Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137178/?format=api
{ "id": 137178, "url": "http://patchwork.dpdk.org/api/patches/137178/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240226014500.3537561-2-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240226014500.3537561-2-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240226014500.3537561-2-chaoyong.he@corigine.com", "date": "2024-02-26T01:44:57", "name": "[v3,1/4] ethdev: add function to check representor port", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "241f350119fd7362cd3bee670f4a12e75969652c", "submitter": { "id": 2554, "url": "http://patchwork.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240226014500.3537561-2-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31211, "url": "http://patchwork.dpdk.org/api/series/31211/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31211", "date": "2024-02-26T01:44:56", "name": "add support of MARK and RSS flow action", "version": 3, "mbox": "http://patchwork.dpdk.org/series/31211/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137178/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/137178/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49B5843BDB;\n\tMon, 26 Feb 2024 02:45:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 148BF42D7D;\n\tMon, 26 Feb 2024 02:45:27 +0100 (CET)", "from NAM04-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam04on2090.outbound.protection.outlook.com [40.107.101.90])\n by mails.dpdk.org (Postfix) with ESMTP id C0BB8402B2\n for <dev@dpdk.org>; Mon, 26 Feb 2024 02:45:24 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH0PR13MB5794.namprd13.prod.outlook.com (2603:10b6:510:11d::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.34; Mon, 26 Feb\n 2024 01:45:22 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::8e02:f738:570a:f8aa]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::8e02:f738:570a:f8aa%7]) with mapi id 15.20.7316.032; Mon, 26 Feb 2024\n 01:45:22 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=caWUgt4b7Hgtu/On5Q5sJ/KeeykDJTVhwna02IUvGD51dsfjJuknxvkYx200kCiOC4uoslCW6kzAXRG+yxc7zOLveWpBVVIXqyyqLLJCuNb8XMRJCWPEvq7vlU59UcSamGQq9VQpm6uZ4TEb0hK5bfuWcKxvpgEbgKicUxd2VF9ADaiW3flifOp3IvHxTyXdBS7TM1Mq54lFmwnNobxiU67UN0jplKBKTAGFBLXl7EhbvdwEG6Rg6HUmk1zz+D9M0IjzGDVKoiH0ECm8FEbuHsnndeNSo8UM1iTPfnpFVgsgzgqiHg0weyG5D3ngXL/uUhP9pXtRc9jkWQdLbMdfqA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=1WfgTdnRvZwws94dIWHt3M2GAtggp1bQTmrhdkmwUsM=;\n b=FkY6n3O5kt53OgtVTS9gGWtkEaRllfEVEWLnL8AY2CNfZK3Z23/X8X+6cHCFohYj48PuZCXN40WL5hZXcgy3bcKsKnydc0NE8E6NRsNNGdrw03UDLMoFziWiGo8brRpbTI0wR1K9D9mlMzYsnFc1pKeerAEkqD0z2IoHRB8ylPFLIK74C07pQjE8Wir0TXNny6QMHinLZJGLr8DdyMSNKbR0NOJZno/RWsMtW5MyRzojUa82YYQqAV7MpOQs35zpd/PKN23yV5i94Ul38WHkVdDsQ3x14R0hvnK+LqOktWtIgS0WbaczLlHjO0vJLtNkKuKws1uoluqofohXGkdmcw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=1WfgTdnRvZwws94dIWHt3M2GAtggp1bQTmrhdkmwUsM=;\n b=eKIcRTXVVbo/5Og9kvqq9LbmM2/QA4pYKrZv9zZzO8MhqDQFUymvkCHgvzu3PAqKsHrX3nSjjZNBc+Lf2AJUNf4AL7g4TH0+7pZcARWp2Sar4rUUNOBq66SjESAj4bRFPFW6U7XxVieIahv2N251vwmua745rqqcvUryM2UvDWE=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,\n Chaoyong He <chaoyong.he@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH v3 1/4] ethdev: add function to check representor port", "Date": "Mon, 26 Feb 2024 09:44:57 +0800", "Message-Id": "<20240226014500.3537561-2-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240226014500.3537561-1-chaoyong.he@corigine.com>", "References": "<20240223024217.3052031-1-chaoyong.he@corigine.com>\n <20240226014500.3537561-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "PH8PR05CA0005.namprd05.prod.outlook.com\n (2603:10b6:510:2cc::14) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH0PR13MB5794:EE_", "X-MS-Office365-Filtering-Correlation-Id": "15f81eb3-7793-4d59-ba59-08dc366c9889", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n YKdNM21gVBBXQm72H0+Nn7bniXabDy6RG9nIoS44hgA2OH06DEGYNGes3ODuuEMfDbnO19ytz6RzZGb0PsDzNNPLofrt1AtIO86yBIn4Jv9GYHUzEctl6mFD9N6pDnFm94uicu0pmINnXSyK4P4iNrA5BnbDVHPndR3TIByDinCgIQwqNPQSjmm4iAYPwfzHUkHMMB64GuRGOtLpOZnSsGbl6zLSW80R4otZw+OCNLE/k4dwaREomwSR8a6on62iKzRft7clfJJp+5rbAYMnvGX2GuD6tQrA2iy8vZtqUVsVgEq39BFnW9DhLgGX8jOWflGSjbjiem7w1iP70ohlICWJi5hcR1Oi+VjNZO/BpnLZbs+kuZ97ftvzjoNtDclnG64MaB6alTBBqBtywxMJng45HqNjvfae9LQfJ/uY280OnMKL3ICik9MEhi4zCGzpgdoSt9jUV3t9df5PJJgdif5wZGvz0QRrqChxdYxTkaiuaiU2ML1JCBshHLVAfAq2dygKX5Dckl9mPNG7ITFyvnaP1J/AO7Bu57blQvwF503SkHZclxG4i0s6wK+4XhlcpopzP9ykAUm22qgC4sqRsxmJHQ9LdS1C85aXhTLeZuBlUH2MGPLgd+FNPHte4+GO1Xk6OxAEIYx/04h7WnbGtIOWBG197i6ATS5KqrlTemTBgn2q6EjTyepYCcY0WKVJsh1926vP18nLSWfFVlQJLqozOCccrNwy4Ae3Q+04tok=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(38350700005); DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n yZ2Qe3RazOB1SgIQYRKPLAW35MWNGUh6Zd6ma7RDY1alvgV9LMZdTDTqhv2NvkSEy7xFjnlwe2TbxIa7aXGFwgnXKtlvrYTU64YwDEpDfDOXfZo7sJ4u/SCIP1DdADewyArKb5izkdp1dpLEY9bebpik0J+SpLm+fH0FV4M0CseC7ETtXtRWYMhgCNiG/OASZS6J/sPY/tUMuyb/gW7HrYZ5lDhG9yLJc0jJbEQSNwEGBAl7ThjPLlu7EqsNCucQcKS9wppEbmwg6KZZUaMFc+jUcDLNiyc+IaswwCHXpO+psSrObaNNaBAwWRRwA53HLG9j5N06hfh5Y12s3xrSSShyavQ3VTC8rhvYHGGkZ9r4ojyQ/kGtecesXdBxLKQb+vNpZsQJeIINn9FSunf7PlVVnT29g+WOoXKh8S7VDeUqpfBgBJsVlpvpKNrvh1NgnxcUbCF8HsBDk2xK69soleffJQOFHUMacycJy8YBvP34BBx00MuJ9NpF3CMbQW8mL8QKmK/oZP+8UUiR70+MEv4l4+C9a0HTdN5ZXZ0Ta0MmUStfnZBC7KhEKHsxLStsMEN/PAkuSyloQgkv8V16Up8k2VEDNYgtMYyHVwYt9d4+u7N2ySafqlDo7s63eln5/gVfXGYHppD7RNih7nfyEDQ5tYRcv1Ttip+gWsGejmbxQDGqMy0rZJrtVahnX7nAJQInF/UZC1bVJCTjaPIpcLNJ6jbtyYFc0VXyw3nVJhTClKrFqdXklb3V4+sL5DdmDSwZP6No1+k+T1huC2r4IbarROdV0hyIpMJaMPbml5t8RR1BNPgfRHcxRIP1HNiekG5yZbTXhdHCBfyFXsG/Hez8b0VN7vxtwN7IOw3rN603Un5k/FRF5xuLtW0NDz1ZrAXZt7hPFRp2xiAUwnGWlssPu7nmHDHXYRKXceuIg0c161BrGSOTPNan6KSqte7GQLwJAohGUOhE2Xzox1g1P75ymJmiIsrejcqTKvXhEcXyBHn/0iAFWDGU9/wqis3L0R3wZiISGAmQhbRuSJSf62HLgX2c/zGOGZNuClnqMpWVst8I+Hjb5mXDe62UozQYhmdnAydatVaDP4/iiCX1yz+e5/uK439Mk6l9Ma3CfuKry+uTTSvoYCumKz0vk29Fhwh7E6uN/KEPKTzv94RqrWsC+3F8m30ey8Ia+joMZx8vfoJPw2HKVr8tA1tlMi00QUN3t7WdJj6wCz8tumb2gHo/Mr7O/dQkrxAMRiIyPtWf1icgMhv3vHamFa2ZivvdKPgFk9aryiLh2qmk8667WU6r/XiD3BGNQg5Z5TToJ/1yO81Qh3uK6exy8NtxWUl+Ykdsvo2eBBQ70hNQGZ9jPto3YLoVbC9eOQLa4BD3HCg1++yk/iMr7wUOUTa3Kt2YGnp0ZvzkZdlgLG49fPZxPTql0jl/jXPQj8ySU52kc88zmS5oFNwSf+9BIUe6gkYD97ZUI7/Mu2vgDxk/erMDmEhdp942POJVV3Ssh5SyuNIpu5uiwypL2cDaHnWhYFZ5GMljaxy8EfecAkz5FkG7HFX0iBRJs4Hv1xvPYqEqzC9szX+Oj5uk/+5uyTtIsqZ0TrYm+OL0dlxgSXtmXT3srw==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 15f81eb3-7793-4d59-ba59-08dc366c9889", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Feb 2024 01:45:22.6655 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n fgsUBC4JrdAOi0P2xSV4pKF5DFzFhSqBgoWLxw01Q8nfLBGFMWlk0md6zbMeBs4P46giB33oaIgIGGtYDC2wgwsn3mmF5M+OY+uWjWMMDww=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH0PR13MB5794", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Wu <long.wu@corigine.com>\n\nAdd a function to check if a device is representor port, also\nmodified the related codes for PMDs.\n\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/bnxt/bnxt.h | 3 ---\n drivers/net/bnxt/bnxt_ethdev.c | 4 ++--\n drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c | 12 ++++++------\n drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 4 ++--\n drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 4 ++--\n drivers/net/cpfl/cpfl_representor.c | 2 +-\n drivers/net/enic/enic.h | 5 -----\n drivers/net/enic/enic_ethdev.c | 2 +-\n drivers/net/enic/enic_fm_flow.c | 20 ++++++++++----------\n drivers/net/enic/enic_main.c | 4 ++--\n drivers/net/i40e/i40e_ethdev.c | 2 +-\n drivers/net/ice/ice_dcf_ethdev.c | 2 +-\n drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-\n drivers/net/nfp/flower/nfp_flower_flow.c | 2 +-\n drivers/net/nfp/nfp_mtr.c | 2 +-\n drivers/net/nfp/nfp_net_common.c | 4 ++--\n drivers/net/nfp/nfp_net_flow.c | 2 +-\n lib/ethdev/ethdev_driver.h | 17 +++++++++++++++++\n lib/ethdev/rte_class_eth.c | 4 ++--\n 19 files changed, 53 insertions(+), 44 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex fcf2b8be97..82036a16a1 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -1204,9 +1204,6 @@ extern const struct rte_flow_ops bnxt_flow_meter_ops;\n \t} \\\n } while (0)\n \n-#define\tBNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)\t\\\n-\t\t((eth_dev)->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n-\n extern int bnxt_logtype_driver;\n #define RTE_LOGTYPE_BNXT bnxt_logtype_driver\n #define PMD_DRV_LOG_RAW(level, fmt, args...) \\\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex f8d83662f4..825e9c1941 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3525,7 +3525,7 @@ bnxt_flow_ops_get_op(struct rte_eth_dev *dev,\n \tif (!bp)\n \t\treturn -EIO;\n \n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(dev)) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\tstruct bnxt_representor *vfr = dev->data->dev_private;\n \t\tbp = vfr->parent_dev->data->dev_private;\n \t\t/* parent is deleted while children are still valid */\n@@ -6781,7 +6781,7 @@ static int bnxt_pci_remove(struct rte_pci_device *pci_dev)\n \n \tPMD_DRV_LOG(DEBUG, \"BNXT Port:%d pci remove\\n\", eth_dev->data->port_id);\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n-\t\tif (eth_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\t\tif (rte_eth_dev_is_repr(eth_dev))\n \t\t\treturn rte_eth_dev_destroy(eth_dev,\n \t\t\t\t\t\t bnxt_representor_uninit);\n \t\telse\ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c b/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c\nindex 239191e14e..96d61c3ed2 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c\n@@ -202,7 +202,7 @@ bnxt_pmd_get_svif(uint16_t port_id, bool func_svif,\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port_id];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\n@@ -260,7 +260,7 @@ bnxt_pmd_get_vnic_id(uint16_t port, enum bnxt_ulp_intf_type type)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\n@@ -285,7 +285,7 @@ bnxt_pmd_get_fw_func_id(uint16_t port, enum bnxt_ulp_intf_type type)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\n@@ -308,7 +308,7 @@ bnxt_pmd_get_interface_type(uint16_t port)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev))\n+\tif (rte_eth_dev_is_repr(eth_dev))\n \t\treturn BNXT_ULP_INTF_TYPE_VF_REP;\n \n \tbp = eth_dev->data->dev_private;\n@@ -330,7 +330,7 @@ bnxt_pmd_get_phy_port_id(uint16_t port_id)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port_id];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tvfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\n@@ -350,7 +350,7 @@ bnxt_pmd_get_parif(uint16_t port_id, enum bnxt_ulp_intf_type type)\n \tstruct bnxt *bp;\n \n \teth_dev = &rte_eth_devices[port_id];\n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {\n+\tif (rte_eth_dev_is_repr(eth_dev)) {\n \t\tstruct bnxt_representor *vfr = eth_dev->data->dev_private;\n \t\tif (!vfr)\n \t\t\treturn 0;\ndiff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\nindex 274e935a1f..33028c470f 100644\n--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c\n@@ -1559,7 +1559,7 @@ bnxt_ulp_destroy_vfr_default_rules(struct bnxt *bp, bool global)\n \tstruct rte_eth_dev *vfr_eth_dev;\n \tstruct bnxt_representor *vfr_bp;\n \n-\tif (!BNXT_TRUFLOW_EN(bp) || BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))\n+\tif (!BNXT_TRUFLOW_EN(bp) || rte_eth_dev_is_repr(bp->eth_dev))\n \t\treturn;\n \n \tif (!bp->ulp_ctx || !bp->ulp_ctx->cfg_data)\n@@ -2316,7 +2316,7 @@ bnxt_ulp_eth_dev_ptr2_cntxt_get(struct rte_eth_dev\t*dev)\n {\n \tstruct bnxt *bp = (struct bnxt *)dev->data->dev_private;\n \n-\tif (BNXT_ETH_DEV_IS_REPRESENTOR(dev)) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\tstruct bnxt_representor *vfr = dev->data->dev_private;\n \n \t\tbp = vfr->parent_dev->data->dev_private;\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\nindex fe1f65deb9..8237dbd294 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c\n@@ -449,7 +449,7 @@ bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)\n \tuint16_t port_id;\n \n \tif (!BNXT_TRUFLOW_EN(bp) ||\n-\t BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))\n+\t rte_eth_dev_is_repr(bp->eth_dev))\n \t\treturn;\n \n \tif (!bp->ulp_ctx || !bp->ulp_ctx->cfg_data)\n@@ -514,7 +514,7 @@ bnxt_ulp_create_df_rules(struct bnxt *bp)\n \tint rc = 0;\n \n \tif (!BNXT_TRUFLOW_EN(bp) ||\n-\t BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev) || !bp->ulp_ctx)\n+\t rte_eth_dev_is_repr(bp->eth_dev) || !bp->ulp_ctx)\n \t\treturn 0;\n \n \tport_id = bp->eth_dev->data->port_id;\ndiff --git a/drivers/net/cpfl/cpfl_representor.c b/drivers/net/cpfl/cpfl_representor.c\nindex e2ed9eda04..60b72b5ec1 100644\n--- a/drivers/net/cpfl/cpfl_representor.c\n+++ b/drivers/net/cpfl/cpfl_representor.c\n@@ -339,7 +339,7 @@ cpfl_repr_link_update(struct rte_eth_dev *ethdev,\n \tstruct cpfl_vport_id vi;\n \tint ret;\n \n-\tif (!(ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)) {\n+\tif (!rte_eth_dev_is_repr(ethdev)) {\n \t\tPMD_INIT_LOG(ERR, \"This ethdev is not representor.\");\n \t\treturn -EINVAL;\n \t}\ndiff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h\nindex 78778704f2..f46903ea9e 100644\n--- a/drivers/net/enic/enic.h\n+++ b/drivers/net/enic/enic.h\n@@ -233,11 +233,6 @@ struct enic_vf_representor {\n #define VF_ENIC_TO_VF_REP(vf_enic) \\\n \tcontainer_of(vf_enic, struct enic_vf_representor, enic)\n \n-static inline int enic_is_vf_rep(struct enic *enic)\n-{\n-\treturn !!(enic->rte_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR);\n-}\n-\n /* Compute ethdev's max packet size from MTU */\n static inline uint32_t enic_mtu_to_max_rx_pktlen(uint32_t mtu)\n {\ndiff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c\nindex 7e040c36c4..cad8db2f6f 100644\n--- a/drivers/net/enic/enic_ethdev.c\n+++ b/drivers/net/enic/enic_ethdev.c\n@@ -1386,7 +1386,7 @@ static int eth_enic_pci_remove(struct rte_pci_device *pci_dev)\n \tethdev = rte_eth_dev_allocated(pci_dev->device.name);\n \tif (!ethdev)\n \t\treturn -ENODEV;\n-\tif (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\tif (rte_eth_dev_is_repr(ethdev))\n \t\treturn rte_eth_dev_destroy(ethdev, enic_vf_representor_uninit);\n \telse\n \t\treturn rte_eth_dev_destroy(ethdev, eth_enic_dev_uninit);\ndiff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c\nindex 90027dc676..8988148454 100644\n--- a/drivers/net/enic/enic_fm_flow.c\n+++ b/drivers/net/enic/enic_fm_flow.c\n@@ -1535,14 +1535,14 @@ vf_egress_port_id_action(struct enic_flowman *fm,\n \tENICPMD_FUNC_TRACE();\n \tsrc_enic = fm->user_enic;\n \tdst_enic = pmd_priv(dst_dev);\n-\tif (!(src_enic->rte_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)) {\n+\tif (!rte_eth_dev_is_repr(src_enic->rte_dev)) {\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\tNULL, \"source port is not VF representor\");\n \t}\n \n \t/* VF -> PF uplink. dst is not VF representor */\n-\tif (!(dst_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)) {\n+\tif (!rte_eth_dev_is_repr(dst_dev)) {\n \t\t/* PF is the VF's PF? Then nothing to do */\n \t\tvf = VF_ENIC_TO_VF_REP(src_enic);\n \t\tif (vf->pf == dst_enic) {\n@@ -1954,7 +1954,7 @@ enic_fm_copy_action(struct enic_flowman *fm,\n \tif (!(overlap & (FATE | PASSTHRU | COUNT | PORT_ID)))\n \t\tgoto unsupported;\n \t/* Egress from VF: need implicit WQ match */\n-\tif (enic_is_vf_rep(enic) && !ingress) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev) && !ingress) {\n \t\tfmt->ftm_data.fk_wq_id = 0;\n \t\tfmt->ftm_mask.fk_wq_id = 0xffff;\n \t\tfmt->ftm_data.fk_wq_vnic = enic->fm_vnic_handle;\n@@ -3226,7 +3226,7 @@ enic_fm_init(struct enic *enic)\n \t\treturn 0;\n \tENICPMD_FUNC_TRACE();\n \t/* Get vnic handle and save for port-id action */\n-\tif (enic_is_vf_rep(enic))\n+\tif (rte_eth_dev_is_repr(enic->rte_dev))\n \t\taddr = &VF_ENIC_TO_VF_REP(enic)->bdf;\n \telse\n \t\taddr = &RTE_ETH_DEV_TO_PCI(enic->rte_dev)->addr;\n@@ -3240,7 +3240,7 @@ enic_fm_init(struct enic *enic)\n \tenic->fm_vnic_uif = vnic_dev_uif(enic->vdev);\n \tENICPMD_LOG(DEBUG, \"uif %u\", enic->fm_vnic_uif);\n \t/* Nothing else to do for representor. It will share the PF flowman */\n-\tif (enic_is_vf_rep(enic))\n+\tif (rte_eth_dev_is_repr(enic->rte_dev))\n \t\treturn 0;\n \tfm = calloc(1, sizeof(*fm));\n \tif (fm == NULL) {\n@@ -3321,7 +3321,7 @@ enic_fm_destroy(struct enic *enic)\n \tstruct enic_fm_fet *fet;\n \n \tENICPMD_FUNC_TRACE();\n-\tif (enic_is_vf_rep(enic)) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev)) {\n \t\tdelete_rep_flows(enic);\n \t\treturn;\n \t}\n@@ -3358,7 +3358,7 @@ enic_fm_allocate_switch_domain(struct enic *pf)\n \tint ret;\n \n \tENICPMD_FUNC_TRACE();\n-\tif (enic_is_vf_rep(pf))\n+\tif (rte_eth_dev_is_repr(pf->rte_dev))\n \t\treturn -EINVAL;\n \tcur = pf;\n \tcur_a = &RTE_ETH_DEV_TO_PCI(cur->rte_dev)->addr;\n@@ -3367,7 +3367,7 @@ enic_fm_allocate_switch_domain(struct enic *pf)\n \t\tdev = &rte_eth_devices[pid];\n \t\tif (!dev_is_enic(dev))\n \t\t\tcontinue;\n-\t\tif (dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\t\tif (rte_eth_dev_is_repr(dev))\n \t\t\tcontinue;\n \t\tif (dev == cur->rte_dev)\n \t\t\tcontinue;\n@@ -3597,7 +3597,7 @@ delete_rep_flows(struct enic *enic)\n \tstruct rte_eth_dev *dev;\n \tuint32_t i;\n \n-\tRTE_ASSERT(enic_is_vf_rep(enic));\n+\tRTE_ASSERT(rte_eth_dev_is_repr(enic->rte_dev));\n \tvf = VF_ENIC_TO_VF_REP(enic);\n \tdev = vf->pf->rte_dev;\n \tfor (i = 0; i < ARRAY_SIZE(vf->vf2rep_flow); i++) {\n@@ -3617,7 +3617,7 @@ begin_fm(struct enic *enic)\n \tstruct enic_flowman *fm;\n \n \t/* Representor uses PF flowman */\n-\tif (enic_is_vf_rep(enic)) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev)) {\n \t\tvf = VF_ENIC_TO_VF_REP(enic);\n \t\tfm = vf->pf->fm;\n \t} else {\ndiff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c\nindex a6aaa760ca..2f681315b6 100644\n--- a/drivers/net/enic/enic_main.c\n+++ b/drivers/net/enic/enic_main.c\n@@ -824,7 +824,7 @@ int enic_alloc_rq(struct enic *enic, uint16_t queue_idx,\n \t * Representor uses a reserved PF queue. Translate representor\n \t * queue number to PF queue number.\n \t */\n-\tif (enic_is_vf_rep(enic)) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev)) {\n \t\tRTE_ASSERT(queue_idx == 0);\n \t\tvf = VF_ENIC_TO_VF_REP(enic);\n \t\tsop_queue_idx = vf->pf_rq_sop_idx;\n@@ -1053,7 +1053,7 @@ int enic_alloc_wq(struct enic *enic, uint16_t queue_idx,\n \t * Representor uses a reserved PF queue. Translate representor\n \t * queue number to PF queue number.\n \t */\n-\tif (enic_is_vf_rep(enic)) {\n+\tif (rte_eth_dev_is_repr(enic->rte_dev)) {\n \t\tRTE_ASSERT(queue_idx == 0);\n \t\tvf = VF_ENIC_TO_VF_REP(enic);\n \t\tqueue_idx = vf->pf_wq_idx;\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 4d21341382..ddbc2962bc 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -706,7 +706,7 @@ static int eth_i40e_pci_remove(struct rte_pci_device *pci_dev)\n \tif (!ethdev)\n \t\treturn 0;\n \n-\tif (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\tif (rte_eth_dev_is_repr(ethdev))\n \t\treturn rte_eth_dev_pci_generic_remove(pci_dev,\n \t\t\t\t\ti40e_vf_representor_uninit);\n \telse\ndiff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c\nindex bebf356f4d..d58ec9d907 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -2131,7 +2131,7 @@ eth_ice_dcf_pci_remove(struct rte_pci_device *pci_dev)\n \tif (!eth_dev)\n \t\treturn 0;\n \n-\tif (eth_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\tif (rte_eth_dev_is_repr(eth_dev))\n \t\treturn rte_eth_dev_pci_generic_remove(pci_dev,\n \t\t\t\t\t\t ice_dcf_vf_repr_uninit);\n \telse\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 0cd3d0b105..c61c52b296 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1842,7 +1842,7 @@ static int eth_ixgbe_pci_remove(struct rte_pci_device *pci_dev)\n \tif (!ethdev)\n \t\treturn 0;\n \n-\tif (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)\n+\tif (rte_eth_dev_is_repr(ethdev))\n \t\treturn rte_eth_dev_pci_generic_remove(pci_dev,\n \t\t\t\t\tixgbe_vf_representor_uninit);\n \telse\ndiff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c\nindex e26be30d18..501a8d87bd 100644\n--- a/drivers/net/nfp/flower/nfp_flower_flow.c\n+++ b/drivers/net/nfp/flower/nfp_flower_flow.c\n@@ -4321,7 +4321,7 @@ int\n nfp_flow_ops_get(struct rte_eth_dev *dev,\n \t\tconst struct rte_flow_ops **ops)\n {\n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) == 0) {\n+\tif (!rte_eth_dev_is_repr(dev)) {\n \t\t*ops = NULL;\n \t\tPMD_DRV_LOG(ERR, \"Port is not a representor.\");\n \t\treturn -EINVAL;\ndiff --git a/drivers/net/nfp/nfp_mtr.c b/drivers/net/nfp/nfp_mtr.c\nindex 255977ec22..6abc6dc9bc 100644\n--- a/drivers/net/nfp/nfp_mtr.c\n+++ b/drivers/net/nfp/nfp_mtr.c\n@@ -1066,7 +1066,7 @@ static const struct rte_mtr_ops nfp_mtr_ops = {\n int\n nfp_net_mtr_ops_get(struct rte_eth_dev *dev, void *arg)\n {\n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) == 0) {\n+\tif (!rte_eth_dev_is_repr(dev)) {\n \t\tPMD_DRV_LOG(ERR, \"Port is not a representor\");\n \t\treturn -EINVAL;\n \t}\ndiff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c\nindex 99c319eb2d..0ee2811926 100644\n--- a/drivers/net/nfp/nfp_net_common.c\n+++ b/drivers/net/nfp/nfp_net_common.c\n@@ -241,7 +241,7 @@ nfp_net_get_hw(const struct rte_eth_dev *dev)\n {\n \tstruct nfp_net_hw *hw;\n \n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\tstruct nfp_flower_representor *repr;\n \t\trepr = dev->data->dev_private;\n \t\thw = repr->app_fw_flower->pf_hw;\n@@ -2143,7 +2143,7 @@ nfp_net_firmware_version_get(struct rte_eth_dev *dev,\n \n \thw = nfp_net_get_hw(dev);\n \n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\tsnprintf(vnic_version, FW_VER_LEN, \"%d.%d.%d.%d\",\n \t\t\thw->ver.extend, hw->ver.class,\n \t\t\thw->ver.major, hw->ver.minor);\ndiff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/nfp/nfp_net_flow.c\nindex 98e8499756..3b33f3b6e9 100644\n--- a/drivers/net/nfp/nfp_net_flow.c\n+++ b/drivers/net/nfp/nfp_net_flow.c\n@@ -932,7 +932,7 @@ nfp_net_flow_ops_get(struct rte_eth_dev *dev,\n {\n \tstruct nfp_net_hw *hw;\n \n-\tif ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0) {\n+\tif (rte_eth_dev_is_repr(dev)) {\n \t\t*ops = NULL;\n \t\tPMD_DRV_LOG(ERR, \"Port is a representor.\");\n \t\treturn -EINVAL;\ndiff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h\nindex 0e4c1f0743..0b088fdab7 100644\n--- a/lib/ethdev/ethdev_driver.h\n+++ b/lib/ethdev/ethdev_driver.h\n@@ -1813,6 +1813,23 @@ rte_eth_representor_id_get(uint16_t port_id,\n \t\t\t int controller, int pf, int representor_port,\n \t\t\t uint16_t *repr_id);\n \n+/**\n+ * @internal\n+ * Check if the ethdev is a representor port.\n+ *\n+ * @param dev\n+ * Pointer to struct rte_eth_dev.\n+ *\n+ * @return\n+ * false the ethdev is not a representor port.\n+ * true the ethdev is a representor port.\n+ */\n+static inline bool\n+rte_eth_dev_is_repr(const struct rte_eth_dev *dev)\n+{\n+\treturn ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0);\n+}\n+\n /**\n * PMD helper function to parse ethdev arguments\n *\ndiff --git a/lib/ethdev/rte_class_eth.c b/lib/ethdev/rte_class_eth.c\nindex bc003db8af..b52f1dd9f2 100644\n--- a/lib/ethdev/rte_class_eth.c\n+++ b/lib/ethdev/rte_class_eth.c\n@@ -69,7 +69,7 @@ eth_representor_cmp(const char *key __rte_unused,\n \tstruct rte_eth_devargs eth_da;\n \tuint16_t id = 0, nc, np, nf, i, c, p, f;\n \n-\tif ((data->dev_flags & RTE_ETH_DEV_REPRESENTOR) == 0)\n+\tif (!rte_eth_dev_is_repr(edev))\n \t\treturn -1; /* not a representor port */\n \n \t/* Parse devargs representor values. */\n@@ -143,7 +143,7 @@ eth_dev_match(const struct rte_eth_dev *edev,\n \t}\n \t/* if no representor key, default is to not match representor ports */\n \tif (ret != 0)\n-\t\tif ((edev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0)\n+\t\tif (rte_eth_dev_is_repr(edev))\n \t\t\treturn -1; /* do not match any representor */\n \n \treturn 0;\n", "prefixes": [ "v3", "1/4" ] }