Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137397/?format=api
{ "id": 137397, "url": "http://patchwork.dpdk.org/api/patches/137397/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1709061720-4843-2-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1709061720-4843-2-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1709061720-4843-2-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-27T19:21:59", "name": "[1/2] build: build eal library with MSVC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "35e6a5120bfada8a7a02379cd1953b87ea159867", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1709061720-4843-2-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31260, "url": "http://patchwork.dpdk.org/api/series/31260/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31260", "date": "2024-02-27T19:21:58", "name": "build eal & ring libraries with MSVC", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31260/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137397/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/137397/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1AA2C43BBE;\n\tTue, 27 Feb 2024 20:22:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8A92F42EE6;\n\tTue, 27 Feb 2024 20:22:06 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 385AB40A81\n for <dev@dpdk.org>; Tue, 27 Feb 2024 20:22:04 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 8ECB420B74C1; Tue, 27 Feb 2024 11:22:03 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 8ECB420B74C1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709061723;\n bh=vRo/iMpbsd/Y4YBaGdoczWg40eyG7WmqFS6YhGS6mS0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ekBk5eXrfhFV3iWNPTStMCQbTrkqKC5S2LzF24NVZdBYRjL9EIHhKWfZgRVZtqty0\n cvqC8Mr5L4yjSIFOcqd1Jxy2C0YwhfbEoqT5FV/r/3wAy6mz5vP2303tIel1HuRfZr\n CERrtO+8Ch5KmEYa9lu2G1xjIerB39MFJtbZGCqM=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 1/2] build: build eal library with MSVC", "Date": "Tue, 27 Feb 2024 11:21:59 -0800", "Message-Id": "<1709061720-4843-2-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1709061720-4843-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1709061720-4843-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "* MSVC now has limited handling of GCC __extension__ keyword when\n compiling C so only expand __extension__ empty on MSVC when\n building with C++.\n\n* When building with MSVC enable the statement expressions compiler\n extension.\n\n* When building with MSVC enable building of eal library.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n config/meson.build | 7 ++++++-\n lib/eal/include/rte_common.h | 2 ++\n lib/meson.build | 1 +\n 3 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex f8f2149..68186e1 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -39,13 +39,18 @@ if is_ms_compiler\n # temporarily disable msvc specific warnings\n # - 4244 compiler detected conversion of integer to smaller type\n # - 4267 compiler detected conversion of size_t to smaller type\n- add_project_arguments('/wd4244', '/wd4267', language: 'c')\n+ # - 4146 unary minus applied to unsigned type\n+ add_project_arguments('/wd4244', '/wd4267', '/wd4146', language: 'c')\n \n # enable non-locking atomic operations\n add_project_arguments('/experimental:c11atomics', language: 'c')\n \n # enable typeof operator\n add_project_arguments('/d1experimental:typeof', language: 'c')\n+\n+ # enable statement expressions extension\n+ add_project_arguments('/experimental:statementExpressions', language: 'c')\n+\n endif\n \n # set the major version, which might be used by drivers and libraries\ndiff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h\nindex 1cc1222..99128d8 100644\n--- a/lib/eal/include/rte_common.h\n+++ b/lib/eal/include/rte_common.h\n@@ -38,8 +38,10 @@\n #endif\n \n #ifdef RTE_TOOLCHAIN_MSVC\n+#ifdef __cplusplus\n #define __extension__\n #endif\n+#endif\n \n /*\n * RTE_TOOLCHAIN_GCC is defined if the target is built with GCC,\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 4fb01f0..d77bfbc 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -73,6 +73,7 @@ if is_ms_compiler\n 'log',\n 'kvargs',\n 'telemetry',\n+ 'eal',\n ]\n endif\n \n", "prefixes": [ "1/2" ] }