Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13740/?format=api
{ "id": 13740, "url": "http://patchwork.dpdk.org/api/patches/13740/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1465948348-10333-1-git-send-email-neescoba@cisco.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1465948348-10333-1-git-send-email-neescoba@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1465948348-10333-1-git-send-email-neescoba@cisco.com", "date": "2016-06-14T23:52:28", "name": "[dpdk-dev] enic: fix name of hash table used for enic classifiers", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ff8942d148806a3a458ba2da7a9f9ff60cf77901", "submitter": { "id": 453, "url": "http://patchwork.dpdk.org/api/people/453/?format=api", "name": "Nelson Escobar", "email": "neescoba@cisco.com" }, "delegate": { "id": 10, "url": "http://patchwork.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1465948348-10333-1-git-send-email-neescoba@cisco.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/13740/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/13740/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D1149AD93;\n\tWed, 15 Jun 2016 01:52:47 +0200 (CEST)", "from alln-iport-1.cisco.com (alln-iport-1.cisco.com\n\t[173.37.142.88]) by dpdk.org (Postfix) with ESMTP id CAB80AD90\n\tfor <dev@dpdk.org>; Wed, 15 Jun 2016 01:52:46 +0200 (CEST)", "from alln-core-7.cisco.com ([173.36.13.140])\n\tby alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t14 Jun 2016 23:52:46 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby alln-core-7.cisco.com (8.14.5/8.14.5) with ESMTP id u5ENqjhJ006518;\n\tTue, 14 Jun 2016 23:52:46 GMT", "by cisco.com (Postfix, from userid 412739)\n\tid DC3563FAADFF; Tue, 14 Jun 2016 16:52:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=1634; q=dns/txt; s=iport;\n\tt=1465948366; x=1467157966;\n\th=from:to:cc:subject:date:message-id;\n\tbh=3XlAVcZ+JEr+ISHXzUVlxhSc/jXiHp4QhHekJILOC4w=;\n\tb=PXjqMfCGekeMylZKdrNxhquRW6CwQbJepeX1CDhCZKf047z3im66xpp4\n\tmdVNwT2XKC52/uzQQjur0R9gRBi0/mFQtHg+bkj5cqVg1g6IKYv5OA+0W\n\tAlkbJlGd/rStPzlw7vFlJcJ7eFXR7Rl024nPIrLdi/HqWkpgv1s9mAClR M=;", "X-IronPort-AV": "E=Sophos;i=\"5.26,473,1459814400\"; d=\"scan'208\";a=\"285758874\"", "From": "Nelson Escobar <neescoba@cisco.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, johndale@cisco.com,\n\tNelson Escobar <neescoba@cisco.com>", "Date": "Tue, 14 Jun 2016 16:52:28 -0700", "Message-Id": "<1465948348-10333-1-git-send-email-neescoba@cisco.com>", "X-Mailer": "git-send-email 2.7.0", "Subject": "[dpdk-dev] [PATCH] enic: fix name of hash table used for enic\n\tclassifiers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The enic_clsf_init() function is called once per enic instance, but it\nused a static name to create the hash table. Consequently when using\nmore than one enic instance, there was a name collision which caused\nerrors:\n\nEAL: memzone_reserve_aligned_thread_unsafe():\n memzone<RG_HT_enicpmd_clsf_hash> already exists\nRING: Cannot reserve memory\nHASH: memory allocation failed\nPMD: rte_enic_pmd: Init of hash table for clsf failed.\n Flow director feature will not work\n\nThis patch changes the name to be unique per enic instance.\n\nFixes: fefed3d1e62c (\"enic: new driver\")\n\nSigned-off-by: Nelson Escobar <neescoba@cisco.com>\nReviewed-by: John Daley <johndale@cisco.com>\n---\n drivers/net/enic/enic_clsf.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c\nindex edb56e1..2ec77f5 100644\n--- a/drivers/net/enic/enic_clsf.c\n+++ b/drivers/net/enic/enic_clsf.c\n@@ -239,15 +239,16 @@ void enic_clsf_destroy(struct enic *enic)\n \n int enic_clsf_init(struct enic *enic)\n {\n+\tchar clsf_name[RTE_HASH_NAMESIZE];\n \tstruct rte_hash_parameters hash_params = {\n-\t\t.name = \"enicpmd_clsf_hash\",\n+\t\t.name = clsf_name,\n \t\t.entries = ENICPMD_CLSF_HASH_ENTRIES,\n \t\t.key_len = sizeof(struct rte_eth_fdir_filter),\n \t\t.hash_func = DEFAULT_HASH_FUNC,\n \t\t.hash_func_init_val = 0,\n \t\t.socket_id = SOCKET_ID_ANY,\n \t};\n-\n+\tsprintf(clsf_name, \"enic_clsf_%s\", enic->bdf_name);\n \tenic->fdir.hash = rte_hash_create(&hash_params);\n \tmemset(&enic->fdir.stats, 0, sizeof(enic->fdir.stats));\n \tenic->fdir.stats.free = ENICPMD_FDIR_MAX;\n", "prefixes": [ "dpdk-dev" ] }