Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137443/?format=api
{ "id": 137443, "url": "http://patchwork.dpdk.org/api/patches/137443/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240228170046.176600-4-dsosnowski@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240228170046.176600-4-dsosnowski@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240228170046.176600-4-dsosnowski@nvidia.com", "date": "2024-02-28T17:00:38", "name": "[03/11] net/mlx5/hws: add check if matcher contains complex rules", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "05086e6f1b19545924f1e88bf0786265aeec0413", "submitter": { "id": 2386, "url": "http://patchwork.dpdk.org/api/people/2386/?format=api", "name": "Dariusz Sosnowski", "email": "dsosnowski@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240228170046.176600-4-dsosnowski@nvidia.com/mbox/", "series": [ { "id": 31278, "url": "http://patchwork.dpdk.org/api/series/31278/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31278", "date": "2024-02-28T17:00:35", "name": "net/mlx5: flow insertion performance improvements", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31278/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137443/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/137443/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE88743C2C;\n\tWed, 28 Feb 2024 18:02:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6DAA042EF4;\n\tWed, 28 Feb 2024 18:01:43 +0100 (CET)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])\n by mails.dpdk.org (Postfix) with ESMTP id BEEE5427DC\n for <dev@dpdk.org>; Wed, 28 Feb 2024 18:01:40 +0100 (CET)", "from SJ0PR03CA0040.namprd03.prod.outlook.com (2603:10b6:a03:33e::15)\n by MN0PR12MB5788.namprd12.prod.outlook.com (2603:10b6:208:377::5)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.34; Wed, 28 Feb\n 2024 17:01:37 +0000", "from SJ1PEPF00001CDD.namprd05.prod.outlook.com\n (2603:10b6:a03:33e:cafe::f6) by SJ0PR03CA0040.outlook.office365.com\n (2603:10b6:a03:33e::15) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.28 via Frontend\n Transport; Wed, 28 Feb 2024 17:01:37 +0000", "from mail.nvidia.com (216.228.117.161) by\n SJ1PEPF00001CDD.mail.protection.outlook.com (10.167.242.5) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7292.25 via Frontend Transport; Wed, 28 Feb 2024 17:01:37 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 28 Feb\n 2024 09:01:11 -0800", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Wed, 28 Feb\n 2024 09:01:09 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=jg1StX0swifUJ1KS2xpHZ2v79YCLJJ8SOOrb7ha65eI4EJKqcI5Fpe4H9jWVmRvefXdkRixzXKmKsORNZII25USy24uV+XJcKv0Hl7etGUvDSA0Coh25ln1zumVIYfESRt1SfkzcXV0HoSNn89aoSiEenPrhgZN2G0LmmLmntVSQgHOWPRNQpF96Pf9msU7WBOifGFbvQwfMAkXkF6ZUwKcb/0RtdWkYpguRbwRNjPxgiKu1nIWanZZpL0gFAOhvc8sSenSyzHybpmTw4wXWrgAKivsx+0FUAzEXLSl0wQAYmwEl6i+lfGRcxHCC0S+aWEBa6cJ6qf+czVtLJB2Yyw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=yxHzW2qoDnTry8i4pn+xN8h4YHih59/XcO0YG8+gNpA=;\n b=IthanX582L3O6U5JMRVTkA7nqSSP7I2lgIzfXOQUxYr4u0CeCS8ctugsA0PSTZifMYlNH+cmuo6ln2e7aaGW6JLipSnvkoLMUgFQeV5IdcM7ruO9c7swwrOnTNfWRzVqy5Uk4RZyuOxuTpZBTZRZw+610ZyZFd0UhyzL7MXJg6yyLNZqc8jXZN/BITJbLh5dRZTtEn7dH6nIZqAhYvzqPArE81rJZ0qhlG+gCwWFxTbAcLQp2bjb2G3yvTrdYkIykJFDsxAQNw41TgYctJ6S2BvcPB2g/YU7n04Ttq0WzfO2gTkXEFAVCWcBxaYNYDODAZjc70o4zlDSZjO6veaJuQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=yxHzW2qoDnTry8i4pn+xN8h4YHih59/XcO0YG8+gNpA=;\n b=YhxnPfpzqo9N+9W8QkylMikBzhxg3wI5ba5n7oHWNfD9Y0Cr6NQ6H+6i5QHeKiIOEW4UX1w/cR53GRIIgfmbpv5E9qE3XeCdUcRk1BZd/ztMrujTp+CjlKcbvxszZSmWi1RSy3QAdJ0HqUc17ySshIEUvsfoiISsb+l4NUusmJKoEqYkplG/b1mGMbxJzd3WqXqyy5kviJQhck3sOVOsvlqmDn4gHfvJ7uFbwyG2+zmxOfYM8wA6qq6udTf5ctILcBqQHQone8tlYqEf9PvJC6r70nXr7jmiMHZJz/RKawX4UMO11KPn3Y7aQi94/oycpNNg19iQ4cyvDRkIyDFUNw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Dariusz Sosnowski <dsosnowski@nvidia.com>", "To": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Suanming Mou <suanmingm@nvidia.com>, Matan Azrad <matan@nvidia.com>", "CC": "<dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>, Bing Zhao\n <bingz@nvidia.com>, Erez Shitrit <erezsh@nvidia.com>", "Subject": "[PATCH 03/11] net/mlx5/hws: add check if matcher contains complex\n rules", "Date": "Wed, 28 Feb 2024 18:00:38 +0100", "Message-ID": "<20240228170046.176600-4-dsosnowski@nvidia.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240228170046.176600-1-dsosnowski@nvidia.com>", "References": "<20240228170046.176600-1-dsosnowski@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ1PEPF00001CDD:EE_|MN0PR12MB5788:EE_", "X-MS-Office365-Filtering-Correlation-Id": "714f060b-58e2-4f58-66bc-08dc387eecf7", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n tayl4te1M17kf4oWl+3a/n1E1KOGFUxVdKUouTPc3fvGy+Oig3C2rDW9X0t/u7Qe9ytoM6dRslcI2PGJxY46o9iqWchw5RIF6AxJHyjwgMa4ucjiWMvck/+tciNlmlMaZRgx7W8mIZjdaoiqQ9UASDSY5kO4l4ecIeO+SrqcigsjGOL/sf/ZZ7R1oYk1EIFS+he1JIlsgegkNzt0RusPzsdciN71ljzq/XOMPvkzk/wkwxdWHV7fgIwcxmUJHPWWkS6yVY6FFFZLiYTGB7K9DkqzRciOPnJHY184xNQ4JlV0laa4WpcY1utyW9OMOcxYa2DX6JzQ2VF6Xbj11+7zjzYxY8QVUUqV7vzYxjZVk0i3jd0wMYTAFp2/3oCibc7zkm02CjSDScayfG3DPj4WJI72e0DOKk184P/h4XAJ9/IA+wgTuMq3cJ9uXXuqphVi5mJdO/E4ckJ55eKVjwjLDxyTNe0ee3OPm5FXVeQd11wmf4udIOJ1m4TR8Yw3L96njGAMqfNW5v09j7ubkksNz4XsM2fzevhSac/wJdO05kmST8iyAmNSbVpBhV+/PLfvPTp4UVxs0tBwAWM5CeUuIhSbOh6Ou8bd/eb+FrHHqhV8XA6maAKB7ohmFGrAfTzJo3VomHLqr4GRLvh2wrfmE9JkmKKXecxpog2wvjPUK+UVIGdiGXUfU0SxgyuNfaYMvmz+FdISZ5S8ut7lJKbZrqtkYSjWMgATgqkXZcBcaMoLa0+X844pAQEMCn95bAo1", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(82310400014)(36860700004); DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Feb 2024 17:01:37.1501 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 714f060b-58e2-4f58-66bc-08dc387eecf7", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SJ1PEPF00001CDD.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN0PR12MB5788", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Erez Shitrit <erezsh@nvidia.com>\n\nThe function returns true if that matcher can contain complicated rule,\nwhich means rule that needs more than one writing to the HW in order to\nhave it.\n\nSigned-off-by: Erez Shitrit <erezsh@nvidia.com>\n---\n drivers/net/mlx5/hws/mlx5dr.h | 8 ++++++++\n drivers/net/mlx5/hws/mlx5dr_action.c | 6 ++++++\n drivers/net/mlx5/hws/mlx5dr_action.h | 2 ++\n drivers/net/mlx5/hws/mlx5dr_matcher.c | 17 +++++++++++++++++\n 4 files changed, 33 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr.h b/drivers/net/mlx5/hws/mlx5dr.h\nindex 781b11e681..d903decc1b 100644\n--- a/drivers/net/mlx5/hws/mlx5dr.h\n+++ b/drivers/net/mlx5/hws/mlx5dr.h\n@@ -499,6 +499,14 @@ int mlx5dr_matcher_resize_rule_move(struct mlx5dr_matcher *src_matcher,\n */\n bool mlx5dr_matcher_is_updatable(struct mlx5dr_matcher *matcher);\n \n+/* Check matcher if might contain rules that need complex structure\n+ *\n+ * @param[in] matcher\n+ *\tthat the rule belongs to.\n+ * @return true when the matcher is contains such rules, false otherwise.\n+ */\n+bool mlx5dr_matcher_is_dependent(struct mlx5dr_matcher *matcher);\n+\n /* Get the size of the rule handle (mlx5dr_rule) to be used on rule creation.\n *\n * @return size in bytes of rule handle struct.\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c\nindex 631763dee0..494642d25c 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_action.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_action.c\n@@ -3265,6 +3265,7 @@ int mlx5dr_action_template_process(struct mlx5dr_action_template *at)\n \t\t\tsetter->flags |= ASF_SINGLE1 | ASF_REMOVE;\n \t\t\tsetter->set_single = &mlx5dr_action_setter_ipv6_route_ext_pop;\n \t\t\tsetter->idx_single = i;\n+\t\t\tat->need_dep_write = true;\n \t\t\tbreak;\n \n \t\tcase MLX5DR_ACTION_TYP_PUSH_IPV6_ROUTE_EXT:\n@@ -3291,6 +3292,7 @@ int mlx5dr_action_template_process(struct mlx5dr_action_template *at)\n \t\t\tsetter->set_double = &mlx5dr_action_setter_ipv6_route_ext_mhdr;\n \t\t\tsetter->idx_double = i;\n \t\t\tsetter->extra_data = 2;\n+\t\t\tat->need_dep_write = true;\n \t\t\tbreak;\n \n \t\tcase MLX5DR_ACTION_TYP_MODIFY_HDR:\n@@ -3299,6 +3301,7 @@ int mlx5dr_action_template_process(struct mlx5dr_action_template *at)\n \t\t\tsetter->flags |= ASF_DOUBLE | ASF_MODIFY;\n \t\t\tsetter->set_double = &mlx5dr_action_setter_modify_header;\n \t\t\tsetter->idx_double = i;\n+\t\t\tat->need_dep_write = true;\n \t\t\tbreak;\n \n \t\tcase MLX5DR_ACTION_TYP_ASO_METER:\n@@ -3326,6 +3329,7 @@ int mlx5dr_action_template_process(struct mlx5dr_action_template *at)\n \t\t\tsetter->flags |= ASF_DOUBLE | ASF_INSERT;\n \t\t\tsetter->set_double = &mlx5dr_action_setter_insert_ptr;\n \t\t\tsetter->idx_double = i;\n+\t\t\tat->need_dep_write = true;\n \t\t\tbreak;\n \n \t\tcase MLX5DR_ACTION_TYP_REFORMAT_L2_TO_TNL_L3:\n@@ -3336,6 +3340,7 @@ int mlx5dr_action_template_process(struct mlx5dr_action_template *at)\n \t\t\tsetter->idx_double = i;\n \t\t\tsetter->set_single = &mlx5dr_action_setter_common_decap;\n \t\t\tsetter->idx_single = i;\n+\t\t\tat->need_dep_write = true;\n \t\t\tbreak;\n \n \t\tcase MLX5DR_ACTION_TYP_REFORMAT_TNL_L3_TO_L2:\n@@ -3344,6 +3349,7 @@ int mlx5dr_action_template_process(struct mlx5dr_action_template *at)\n \t\t\tsetter->flags |= ASF_DOUBLE | ASF_MODIFY | ASF_INSERT;\n \t\t\tsetter->set_double = &mlx5dr_action_setter_tnl_l3_to_l2;\n \t\t\tsetter->idx_double = i;\n+\t\t\tat->need_dep_write = true;\n \t\t\tbreak;\n \n \t\tcase MLX5DR_ACTION_TYP_TAG:\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_action.h b/drivers/net/mlx5/hws/mlx5dr_action.h\nindex 0c8e4bbb5a..68139ca092 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_action.h\n+++ b/drivers/net/mlx5/hws/mlx5dr_action.h\n@@ -119,6 +119,8 @@ struct mlx5dr_action_template {\n \tuint8_t num_of_action_stes;\n \tuint8_t num_actions;\n \tuint8_t only_term;\n+\t/* indicates rule might require dependent wqe */\n+\tbool need_dep_write;\n \tuint32_t flags;\n };\n \ndiff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c\nindex 4e4da8e8f6..1c64abfa57 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_matcher.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c\n@@ -1542,6 +1542,23 @@ bool mlx5dr_matcher_is_updatable(struct mlx5dr_matcher *matcher)\n \treturn true;\n }\n \n+bool mlx5dr_matcher_is_dependent(struct mlx5dr_matcher *matcher)\n+{\n+\tint i;\n+\n+\tif (matcher->action_ste.max_stes || mlx5dr_matcher_req_fw_wqe(matcher))\n+\t\treturn true;\n+\n+\tfor (i = 0; i < matcher->num_of_at; i++) {\n+\t\tstruct mlx5dr_action_template *at = &matcher->at[i];\n+\n+\t\tif (at->need_dep_write)\n+\t\t\treturn true;\n+\t}\n+\n+\treturn false;\n+}\n+\n static int mlx5dr_matcher_resize_precheck(struct mlx5dr_matcher *src_matcher,\n \t\t\t\t\t struct mlx5dr_matcher *dst_matcher)\n {\n", "prefixes": [ "03/11" ] }