Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137589/?format=api
{ "id": 137589, "url": "http://patchwork.dpdk.org/api/patches/137589/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240229225936.483472-16-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240229225936.483472-16-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240229225936.483472-16-stephen@networkplumber.org", "date": "2024-02-29T22:58:02", "name": "[15/71] net/nfp: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "13eeb8136d991f135738f4e3694eee71e16945f8", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240229225936.483472-16-stephen@networkplumber.org/mbox/", "series": [ { "id": 31314, "url": "http://patchwork.dpdk.org/api/series/31314/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31314", "date": "2024-02-29T22:57:48", "name": "replace use of fixed size rte_memcpy", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31314/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137589/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/137589/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B509F43BAE;\n\tFri, 1 Mar 2024 00:01:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1AA7A4330C;\n\tFri, 1 Mar 2024 00:00:52 +0100 (CET)", "from mail-pj1-f49.google.com (mail-pj1-f49.google.com\n [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 266554325B\n for <dev@dpdk.org>; Fri, 1 Mar 2024 00:00:11 +0100 (CET)", "by mail-pj1-f49.google.com with SMTP id\n 98e67ed59e1d1-299a2456948so1154173a91.1\n for <dev@dpdk.org>; Thu, 29 Feb 2024 15:00:11 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Feb 2024 15:00:09 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247610;\n x=1709852410; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZKHXUX+HVRWzIo8lpBJEiNQ1BUP3TApV+QmNZ4YhqYo=;\n b=syL9TY01yLSVt0TfGAEr3ngJr95bmBo/2NVjOH2xyNS/UxFh8ND9CFoakcKFMJW8a9\n ZKGDGjYUl4kswsg9KVQjGx+WG2z6dzLFofB0K/3ZjNSJuEn0SmfoEqBEXnrftHk9rWz8\n JcIntpWbJP31K49qw7TF4dSqn4nhtRVSK6FBf88ycMkcjivsDjTslLwRkV3eruY/jNvH\n 79eqk3QbMM+Y0oH2S1Gkp2FVKMNAWYj4XNALlq3Dw6XdZjmNYZ/loc6jtwy6HTP6sIqh\n 49Ha6LEo43jzeCR1/WcxBGJ5J9l2H9jAPUintAYnUxKbWLJs/ZGyUBG0m6YCOgKMRqWz\n aqIQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709247610; x=1709852410;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=ZKHXUX+HVRWzIo8lpBJEiNQ1BUP3TApV+QmNZ4YhqYo=;\n b=wM6CYsLF9U4BMwxsv1xrxGxaoY6mCvQEho9gj/dD3kZnrj3E9+blnR2x9Gg7EADl3G\n kiQNWzOd6+g2F4D7oc8x7J8p/tHzxyfQqkf+gbijsLgLQtMRImR0xGztVFcO74ylS7ya\n lgUUTPK+bZtRiPWvLUTAT3Oy8DHvlTlb3Kn8/MDYPD9bnIbw2zeqeW6fnh7zDfr5+B0l\n FXbdN8ACXaw2BYWlHIvWDfgcYuPKzYsAdpI067oROuzvNtdPHXEaz+248pvpv8ByJ5Yt\n VVPg4MhP1ZZrvYz0BsuYEH4FuIFkkCiTsPmTgu3hlzCACJRBwzXcuZVzT+RSBzJGLaIj\n W4tQ==", "X-Gm-Message-State": "AOJu0YxXqI6/b/YFQITkZHQqxFJpBzsyxynVQczCIn0RD3IPPLFqS+BT\n qvZz+miX2+kflNpd0N6Fn1Xbtbta4ObqRQsS/Uf5lLqej8upEtZcWxXvMoVrWLmTH05bNgK/42+\n K", "X-Google-Smtp-Source": "\n AGHT+IHRqrCqbV/wMrWBwH+hEXk65UyFtRqv54EBd2gkvFBx5+kv1zlWbtmFfNR5IjM2ERrbVY+uTg==", "X-Received": "by 2002:a17:90a:dd93:b0:29a:7579:88bc with SMTP id\n l19-20020a17090add9300b0029a757988bcmr18225pjv.46.1709247610248;\n Thu, 29 Feb 2024 15:00:10 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH 15/71] net/nfp: replace use of fixed size rte_memcpy", "Date": "Thu, 29 Feb 2024 14:58:02 -0800", "Message-ID": "<20240229225936.483472-16-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240229225936.483472-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/nfp/flower/nfp_conntrack.c | 2 +-\n drivers/net/nfp/flower/nfp_flower_flow.c | 16 ++++++++--------\n drivers/net/nfp/flower/nfp_flower_representor.c | 2 +-\n drivers/net/nfp/nfp_mtr.c | 10 +++++-----\n 4 files changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_conntrack.c b/drivers/net/nfp/flower/nfp_conntrack.c\nindex f89003be8b40..279bf17eb3a5 100644\n--- a/drivers/net/nfp/flower/nfp_conntrack.c\n+++ b/drivers/net/nfp/flower/nfp_conntrack.c\n@@ -1470,7 +1470,7 @@ nfp_ct_do_flow_merge(struct nfp_ct_zone_entry *ze,\n \tmerge_entry->ze = ze;\n \tmerge_entry->pre_ct_parent = pre_ct_entry;\n \tmerge_entry->post_ct_parent = post_ct_entry;\n-\trte_memcpy(merge_entry->cookie, new_cookie, sizeof(new_cookie));\n+\tmemcpy(merge_entry->cookie, new_cookie, sizeof(new_cookie));\n \tmerge_entry->rule.items_cnt = pre_ct_entry->rule.items_cnt +\n \t\t\tpost_ct_entry->rule.items_cnt - cnt_same_item - 1;\n \tmerge_entry->rule.actions_cnt = pre_ct_entry->rule.actions_cnt +\ndiff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c\nindex e26be30d1833..3d07a4429b62 100644\n--- a/drivers/net/nfp/flower/nfp_flower_flow.c\n+++ b/drivers/net/nfp/flower/nfp_flower_flow.c\n@@ -178,10 +178,10 @@ nfp_mask_id_alloc(struct nfp_flow_priv *priv,\n \t\treturn -ENOENT;\n \t}\n \n-\trte_memcpy(&temp_id, &ring->buf[ring->tail], NFP_FLOWER_MASK_ELEMENT_RS);\n+\tmemcpy(&temp_id, &ring->buf[ring->tail], NFP_FLOWER_MASK_ELEMENT_RS);\n \t*mask_id = temp_id;\n \n-\trte_memcpy(&ring->buf[ring->tail], &freed_id, NFP_FLOWER_MASK_ELEMENT_RS);\n+\tmemcpy(&ring->buf[ring->tail], &freed_id, NFP_FLOWER_MASK_ELEMENT_RS);\n \tring->tail = (ring->tail + NFP_FLOWER_MASK_ELEMENT_RS) %\n \t\t\t(NFP_FLOWER_MASK_ENTRY_RS * NFP_FLOWER_MASK_ELEMENT_RS);\n \n@@ -200,7 +200,7 @@ nfp_mask_id_free(struct nfp_flow_priv *priv,\n \tif (CIRC_SPACE(ring->head, ring->tail, NFP_FLOWER_MASK_ENTRY_RS) == 0)\n \t\treturn -ENOBUFS;\n \n-\trte_memcpy(&ring->buf[ring->head], &mask_id, NFP_FLOWER_MASK_ELEMENT_RS);\n+\tmemcpy(&ring->buf[ring->head], &mask_id, NFP_FLOWER_MASK_ELEMENT_RS);\n \tring->head = (ring->head + NFP_FLOWER_MASK_ELEMENT_RS) %\n \t\t\t(NFP_FLOWER_MASK_ENTRY_RS * NFP_FLOWER_MASK_ELEMENT_RS);\n \n@@ -2247,13 +2247,13 @@ nfp_flow_action_set_mac(char *act_data,\n \n \tset_mac = action->conf;\n \tif (mac_src_flag) {\n-\t\trte_memcpy(&set_eth->eth_addr[RTE_ETHER_ADDR_LEN],\n-\t\t\t\tset_mac->mac_addr, RTE_ETHER_ADDR_LEN);\n+\t\tmemcpy(&set_eth->eth_addr[RTE_ETHER_ADDR_LEN],\n+\t\t set_mac->mac_addr, RTE_ETHER_ADDR_LEN);\n \t\tfor (i = 0; i < RTE_ETHER_ADDR_LEN; i++)\n \t\t\tset_eth->eth_addr_mask[RTE_ETHER_ADDR_LEN + i] = 0xff;\n \t} else {\n-\t\trte_memcpy(&set_eth->eth_addr[0],\n-\t\t\t\tset_mac->mac_addr, RTE_ETHER_ADDR_LEN);\n+\t\tmemcpy(&set_eth->eth_addr[0], set_mac->mac_addr,\n+\t\t RTE_ETHER_ADDR_LEN);\n \t\tfor (i = 0; i < RTE_ETHER_ADDR_LEN; i++)\n \t\t\tset_eth->eth_addr_mask[i] = 0xff;\n \t}\n@@ -2329,7 +2329,7 @@ nfp_flow_action_set_ipv6(char *act_data,\n \tset_ip->reserved = 0;\n \n \tfor (i = 0; i < 4; i++) {\n-\t\trte_memcpy(&tmp, &set_ipv6->ipv6_addr[i * 4], 4);\n+\t\tmemcpy(&tmp, &set_ipv6->ipv6_addr[i * 4], 4);\n \t\tset_ip->ipv6[i].exact = tmp;\n \t\tset_ip->ipv6[i].mask = RTE_BE32(0xffffffff);\n \t}\ndiff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c\nindex 4f4df0cd2ee2..ce2b06611802 100644\n--- a/drivers/net/nfp/flower/nfp_flower_representor.c\n+++ b/drivers/net/nfp/flower/nfp_flower_representor.c\n@@ -181,7 +181,7 @@ nfp_flower_repr_stats_get(struct rte_eth_dev *ethdev,\n \tstruct nfp_flower_representor *repr;\n \n \trepr = ethdev->data->dev_private;\n-\trte_memcpy(stats, &repr->repr_stats, sizeof(struct rte_eth_stats));\n+\tmemcpy(stats, &repr->repr_stats, sizeof(struct rte_eth_stats));\n \n \treturn 0;\n }\ndiff --git a/drivers/net/nfp/nfp_mtr.c b/drivers/net/nfp/nfp_mtr.c\nindex 255977ec2236..1f173409b421 100644\n--- a/drivers/net/nfp/nfp_mtr.c\n+++ b/drivers/net/nfp/nfp_mtr.c\n@@ -243,7 +243,7 @@ nfp_mtr_profile_mod(struct nfp_app_fw_flower *app_fw_flower,\n \tstruct nfp_profile_conf old_conf;\n \n \t/* Get the old profile config */\n-\trte_memcpy(&old_conf, &mtr_profile->conf, sizeof(old_conf));\n+\tmemcpy(&old_conf, &mtr_profile->conf, sizeof(old_conf));\n \n \tmemset(&mtr_profile->conf, 0, sizeof(struct nfp_profile_conf));\n \n@@ -267,7 +267,7 @@ nfp_mtr_profile_mod(struct nfp_app_fw_flower *app_fw_flower,\n \treturn 0;\n \n rollback:\n-\trte_memcpy(&mtr_profile->conf, &old_conf, sizeof(old_conf));\n+\tmemcpy(&mtr_profile->conf, &old_conf, sizeof(old_conf));\n \n \treturn ret;\n }\n@@ -492,8 +492,8 @@ nfp_mtr_policy_add(struct rte_eth_dev *dev,\n \t}\n \n \tmtr_policy->policy_id = mtr_policy_id;\n-\trte_memcpy(&mtr_policy->policy, policy,\n-\t\t\tsizeof(struct rte_mtr_meter_policy_params));\n+\tmemcpy(&mtr_policy->policy, policy,\n+\t sizeof(struct rte_mtr_meter_policy_params));\n \n \t/* Insert policy into policy list */\n \tLIST_INSERT_HEAD(&priv->policies, mtr_policy, next);\n@@ -1028,7 +1028,7 @@ nfp_mtr_stats_read(struct rte_eth_dev *dev,\n \t*stats_mask = mtr->stats_mask;\n \n \trte_spinlock_lock(&priv->mtr_stats_lock);\n-\trte_memcpy(&curr, &mtr->mtr_stats.curr, sizeof(curr));\n+\tmemcpy(&curr, &mtr->mtr_stats.curr, sizeof(curr));\n \trte_spinlock_unlock(&priv->mtr_stats_lock);\n \n \tprev = &mtr->mtr_stats.prev;\n", "prefixes": [ "15/71" ] }