Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137635/?format=api
{ "id": 137635, "url": "http://patchwork.dpdk.org/api/patches/137635/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240229225936.483472-62-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240229225936.483472-62-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240229225936.483472-62-stephen@networkplumber.org", "date": "2024-02-29T22:58:48", "name": "[61/71] net/e1000: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "624d9aff5461d6338914323684c0dbd1fd9bde44", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240229225936.483472-62-stephen@networkplumber.org/mbox/", "series": [ { "id": 31314, "url": "http://patchwork.dpdk.org/api/series/31314/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31314", "date": "2024-02-29T22:57:48", "name": "replace use of fixed size rte_memcpy", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31314/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137635/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/137635/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3BADC43BAE;\n\tFri, 1 Mar 2024 00:07:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 71C614343B;\n\tFri, 1 Mar 2024 00:02:03 +0100 (CET)", "from mail-pj1-f46.google.com (mail-pj1-f46.google.com\n [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 1381C432DE\n for <dev@dpdk.org>; Fri, 1 Mar 2024 00:00:53 +0100 (CET)", "by mail-pj1-f46.google.com with SMTP id\n 98e67ed59e1d1-29b10d73630so866864a91.0\n for <dev@dpdk.org>; Thu, 29 Feb 2024 15:00:53 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Feb 2024 15:00:52 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247652;\n x=1709852452; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4KvcmbAp4rw+Hg/wEBF72T3gPI9/7RJ07Bv1mlS/fhs=;\n b=PGICq3QwRIMYHIy9PswUuE3ERvhLPDyu2imV6oZELHBzJxPnaX5W3qCW0IQKoiFIrW\n 5P1LPs/AbxGQESXK9qjcVutT+y4Wko0JyTaa/Umud2xwNaNdMWBQA1Avs6e7b+Dx2rhe\n cya7fvpu59YRzvejzyz2d9MTgN4xU1srWYUdrRZ8TNT1XMQf7DTkO1LeVpsqfyYG0QjE\n dqJ0s8balO/Bt48YR7GxaF4HTlMB5BOTfbpE/yS4/ziSbEAgBSHng/zN6imcMiBA0Xo5\n X7fe3a0rjUv7klwHl8nKskyrHlsR84j50WAJrEm4Cvucdtg87ROBr4ZUQfQfFqETY72T\n Xykg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709247652; x=1709852452;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=4KvcmbAp4rw+Hg/wEBF72T3gPI9/7RJ07Bv1mlS/fhs=;\n b=HKJbtFVT/DTlBcEha5015ZKkEuUBfN4P0tEDvTwbjeufcHZE6DCwCjW1oCZzE/CBz5\n QskEKPY41YU0ZU4+/An06y0TfbnI+VE5kEAjgpLxv/3xtM18Ifl9z74k1MPBTrtpFVx6\n ieP00M9JfPBd+YkotWH6NLTKy1Ph42DdyKmCetcOdyFbf/qhFbRbkU+uSGppcN9hHBD+\n 16JnqpTi1kDZZacYeRV8QgBadr78laTUShiO6GnbFCG0G0WSEIL4NT870FhMfaeR3MEk\n yXxu6NEPih/F2N/KNaUCrAu2kEidfZKLraCg87he7Z2oFkLPf8GjSVqdZ2C87y1uYN2q\n 4wTg==", "X-Gm-Message-State": "AOJu0YxhfpMcX4evvzztfycDkXFr+SLeljzrSdSs0l8gFj5hVI1bP9s/\n nADUC+HiejXgagUfeWlDwiUR2+lbl/WzwpMqibHJ3rAd94XfqgBdltZUgxoEMPv0W8RChDLEimp\n h", "X-Google-Smtp-Source": "\n AGHT+IHAVUS7D6XrQ0doo363XkJDeioImSeezY687ySQb/PAxMdCK0pN7eZuHLn6LbBAZMBtO3ST7Q==", "X-Received": "by 2002:a17:90b:1e51:b0:29b:6a1:4036 with SMTP id\n pi17-20020a17090b1e5100b0029b06a14036mr70979pjb.0.1709247652431;\n Thu, 29 Feb 2024 15:00:52 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH 61/71] net/e1000: replace use of fixed size rte_memcpy", "Date": "Thu, 29 Feb 2024 14:58:48 -0800", "Message-ID": "<20240229225936.483472-62-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240229225936.483472-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/e1000/igb_flow.c | 22 ++++++++++------------\n drivers/net/e1000/igb_pf.c | 6 +++---\n 2 files changed, 13 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c\nindex ea9b290e1cb5..8bca48496035 100644\n--- a/drivers/net/e1000/igb_flow.c\n+++ b/drivers/net/e1000/igb_flow.c\n@@ -1484,9 +1484,9 @@ igb_flow_create(struct rte_eth_dev *dev,\n \t\t\t\tgoto out;\n \t\t\t}\n \n-\t\t\trte_memcpy(&ntuple_filter_ptr->filter_info,\n-\t\t\t\t&ntuple_filter,\n-\t\t\t\tsizeof(struct rte_eth_ntuple_filter));\n+\t\t\tmemcpy(&ntuple_filter_ptr->filter_info,\n+\t\t\t &ntuple_filter,\n+\t\t\t sizeof(struct rte_eth_ntuple_filter));\n \t\t\tTAILQ_INSERT_TAIL(&igb_filter_ntuple_list,\n \t\t\t\tntuple_filter_ptr, entries);\n \t\t\tflow->rule = ntuple_filter_ptr;\n@@ -1511,9 +1511,9 @@ igb_flow_create(struct rte_eth_dev *dev,\n \t\t\t\tgoto out;\n \t\t\t}\n \n-\t\t\trte_memcpy(ðertype_filter_ptr->filter_info,\n-\t\t\t\tðertype_filter,\n-\t\t\t\tsizeof(struct rte_eth_ethertype_filter));\n+\t\t\tmemcpy(ðertype_filter_ptr->filter_info,\n+\t\t\t ðertype_filter,\n+\t\t\t sizeof(struct rte_eth_ethertype_filter));\n \t\t\tTAILQ_INSERT_TAIL(&igb_filter_ethertype_list,\n \t\t\t\tethertype_filter_ptr, entries);\n \t\t\tflow->rule = ethertype_filter_ptr;\n@@ -1536,9 +1536,8 @@ igb_flow_create(struct rte_eth_dev *dev,\n \t\t\t\tgoto out;\n \t\t\t}\n \n-\t\t\trte_memcpy(&syn_filter_ptr->filter_info,\n-\t\t\t\t&syn_filter,\n-\t\t\t\tsizeof(struct rte_eth_syn_filter));\n+\t\t\tmemcpy(&syn_filter_ptr->filter_info, &syn_filter,\n+\t\t\t sizeof(struct rte_eth_syn_filter));\n \t\t\tTAILQ_INSERT_TAIL(&igb_filter_syn_list,\n \t\t\t\tsyn_filter_ptr,\n \t\t\t\tentries);\n@@ -1562,9 +1561,8 @@ igb_flow_create(struct rte_eth_dev *dev,\n \t\t\t\tgoto out;\n \t\t\t}\n \n-\t\t\trte_memcpy(&flex_filter_ptr->filter_info,\n-\t\t\t\t&flex_filter,\n-\t\t\t\tsizeof(struct igb_flex_filter));\n+\t\t\tmemcpy(&flex_filter_ptr->filter_info, &flex_filter,\n+\t\t\t sizeof(struct igb_flex_filter));\n \t\t\tTAILQ_INSERT_TAIL(&igb_filter_flex_list,\n \t\t\t\tflex_filter_ptr, entries);\n \t\t\tflow->rule = flex_filter_ptr;\ndiff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c\nindex c7588ea57eaa..7e2ea3bdbcc1 100644\n--- a/drivers/net/e1000/igb_pf.c\n+++ b/drivers/net/e1000/igb_pf.c\n@@ -290,7 +290,7 @@ igb_vf_reset(struct rte_eth_dev *dev, uint16_t vf, uint32_t *msgbuf)\n \n \t/* reply to reset with ack and vf mac address */\n \tmsgbuf[0] = E1000_VF_RESET | E1000_VT_MSGTYPE_ACK;\n-\trte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN);\n+\tmemcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN);\n \te1000_write_mbx(hw, msgbuf, 3, vf);\n \n \treturn 0;\n@@ -308,8 +308,8 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)\n \n \tif (rte_is_unicast_ether_addr((struct rte_ether_addr *)new_mac)) {\n \t\tif (!rte_is_zero_ether_addr((struct rte_ether_addr *)new_mac))\n-\t\t\trte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac,\n-\t\t\t\tsizeof(vfinfo[vf].vf_mac_addresses));\n+\t\t\tmemcpy(vfinfo[vf].vf_mac_addresses, new_mac,\n+\t\t\t sizeof(vfinfo[vf].vf_mac_addresses));\n \t\thw->mac.ops.rar_set(hw, new_mac, rar_entry);\n \t\trah = E1000_READ_REG(hw, E1000_RAH(rar_entry));\n \t\trah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf));\n", "prefixes": [ "61/71" ] }