Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137751/?format=api
http://patchwork.dpdk.org/api/patches/137751/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240301171707.95242-62-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240301171707.95242-62-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240301171707.95242-62-stephen@networkplumber.org", "date": "2024-03-01T17:15:57", "name": "[v2,61/71] net/e1000: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "085858649ed06b07f0428d1b43f98c38efd185b4", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240301171707.95242-62-stephen@networkplumber.org/mbox/", "series": [ { "id": 31340, "url": "http://patchwork.dpdk.org/api/series/31340/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31340", "date": "2024-03-01T17:14:57", "name": "replace use of fixed size rte_mempcy", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31340/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137751/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/137751/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BB5E943C12;\n\tFri, 1 Mar 2024 18:24:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EC7E0434F0;\n\tFri, 1 Mar 2024 18:18:37 +0100 (CET)", "from mail-pf1-f176.google.com (mail-pf1-f176.google.com\n [209.85.210.176])\n by mails.dpdk.org (Postfix) with ESMTP id E082043443\n for <dev@dpdk.org>; Fri, 1 Mar 2024 18:18:05 +0100 (CET)", "by mail-pf1-f176.google.com with SMTP id\n d2e1a72fcca58-6e56a5b2812so1573852b3a.1\n for <dev@dpdk.org>; Fri, 01 Mar 2024 09:18:05 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 Mar 2024 09:18:04 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313485;\n x=1709918285; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9MG+vFZ0m+Ugqp5xyv+9jw4Ta8YjvNueglpe3DucYSs=;\n b=lvoIeESY4dGZusYnSrpD0ijoKjk6ws2bC7YeLe2mjbDvfRM6808kQ2+k8MMhCSuK1x\n rjQgic98KDwKgC3rXb2QBDiIUUvRQFtPnJveA3y93DXODOOXq+tYnH4UhCr2qa/oOQgq\n Ae1aJ/ajwvwE5G5xrBpkGxbH0nPZyltJ27QVNtLPZz6Td6KISIvpPEIIodeGUvQEn9r2\n 1DzQ4VHkxJSVIpP2/HJGAP448qz1wZBZLDLC5Rl3DzPLGCCMjnyvhIWrDCvkrY0wQLXs\n JvarNorcINQSJhMqc8gFGPhFv1A5nqiETQIpKLiB4vjPN9GqrvNyKMXTCuLmoemxuON4\n uPTg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709313485; x=1709918285;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=9MG+vFZ0m+Ugqp5xyv+9jw4Ta8YjvNueglpe3DucYSs=;\n b=qPewfXlDkHU8CyGXNZcPtR2gliN5kL9xjVl4/JtcCY33/fsraBxGlk9orb9G1x5ua2\n xfgdJ+Cj2sioDEvuFXPr8nVfEtyUl4XrGfvUrEWHFHBQrX2VfGLwmlWoGEWHfFjUXPEP\n uBeprwpiiuXv46o7PzTTjv0CsYFtZWptqOfFzq0JFft62mzhX0zh7E4TLspl81IifNG2\n /hdmqH7MuTL0x8WUDTQQ24YSVluNj5akENAR/vDmGMJ/pQ1fggFpQbL9d+rrOuOehcrY\n 5gOapKByRWGm1xZv9oL0DfZmc+UPObDKCv0vjaQi1/G0xZQUXonQZNJ+z3gY67JTVQZl\n 3Igg==", "X-Gm-Message-State": "AOJu0YxcuDlESTSiCkAv0SB2yEGemeyweAzaK/SSZpg2n9f1Jr6yNOJz\n 0lZjUO+B94ThssiADo21Z47IrGmdQipaD8PmgSjDy90WT2Je7weGfGfbwkbPnFvPjZoj6uHkrQs\n N1O5Rvw==", "X-Google-Smtp-Source": "\n AGHT+IFM40c1+TbD5Hq6Y+pxxrS6hNVKU/QG0fzgqe694/TK7ub80jc6lYC+X3MGeGtSpbSMjE2pMg==", "X-Received": "by 2002:a05:6a20:428e:b0:1a1:43c1:84f8 with SMTP id\n o14-20020a056a20428e00b001a143c184f8mr598453pzj.8.1709313485137;\n Fri, 01 Mar 2024 09:18:05 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v2 61/71] net/e1000: replace use of fixed size rte_memcpy", "Date": "Fri, 1 Mar 2024 09:15:57 -0800", "Message-ID": "<20240301171707.95242-62-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240301171707.95242-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>\n <20240301171707.95242-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/e1000/em_rxtx.c | 1 -\n drivers/net/e1000/igb_flow.c | 22 ++++++++++------------\n drivers/net/e1000/igb_pf.c | 7 +++----\n drivers/net/e1000/igb_rxtx.c | 1 -\n 4 files changed, 13 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c\nindex df5fbb782361..3a069ce33ecd 100644\n--- a/drivers/net/e1000/em_rxtx.c\n+++ b/drivers/net/e1000/em_rxtx.c\n@@ -20,7 +20,6 @@\n #include <rte_pci.h>\n #include <bus_pci_driver.h>\n #include <rte_memory.h>\n-#include <rte_memcpy.h>\n #include <rte_memzone.h>\n #include <rte_launch.h>\n #include <rte_eal.h>\ndiff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c\nindex ea9b290e1cb5..8bca48496035 100644\n--- a/drivers/net/e1000/igb_flow.c\n+++ b/drivers/net/e1000/igb_flow.c\n@@ -1484,9 +1484,9 @@ igb_flow_create(struct rte_eth_dev *dev,\n \t\t\t\tgoto out;\n \t\t\t}\n \n-\t\t\trte_memcpy(&ntuple_filter_ptr->filter_info,\n-\t\t\t\t&ntuple_filter,\n-\t\t\t\tsizeof(struct rte_eth_ntuple_filter));\n+\t\t\tmemcpy(&ntuple_filter_ptr->filter_info,\n+\t\t\t &ntuple_filter,\n+\t\t\t sizeof(struct rte_eth_ntuple_filter));\n \t\t\tTAILQ_INSERT_TAIL(&igb_filter_ntuple_list,\n \t\t\t\tntuple_filter_ptr, entries);\n \t\t\tflow->rule = ntuple_filter_ptr;\n@@ -1511,9 +1511,9 @@ igb_flow_create(struct rte_eth_dev *dev,\n \t\t\t\tgoto out;\n \t\t\t}\n \n-\t\t\trte_memcpy(ðertype_filter_ptr->filter_info,\n-\t\t\t\tðertype_filter,\n-\t\t\t\tsizeof(struct rte_eth_ethertype_filter));\n+\t\t\tmemcpy(ðertype_filter_ptr->filter_info,\n+\t\t\t ðertype_filter,\n+\t\t\t sizeof(struct rte_eth_ethertype_filter));\n \t\t\tTAILQ_INSERT_TAIL(&igb_filter_ethertype_list,\n \t\t\t\tethertype_filter_ptr, entries);\n \t\t\tflow->rule = ethertype_filter_ptr;\n@@ -1536,9 +1536,8 @@ igb_flow_create(struct rte_eth_dev *dev,\n \t\t\t\tgoto out;\n \t\t\t}\n \n-\t\t\trte_memcpy(&syn_filter_ptr->filter_info,\n-\t\t\t\t&syn_filter,\n-\t\t\t\tsizeof(struct rte_eth_syn_filter));\n+\t\t\tmemcpy(&syn_filter_ptr->filter_info, &syn_filter,\n+\t\t\t sizeof(struct rte_eth_syn_filter));\n \t\t\tTAILQ_INSERT_TAIL(&igb_filter_syn_list,\n \t\t\t\tsyn_filter_ptr,\n \t\t\t\tentries);\n@@ -1562,9 +1561,8 @@ igb_flow_create(struct rte_eth_dev *dev,\n \t\t\t\tgoto out;\n \t\t\t}\n \n-\t\t\trte_memcpy(&flex_filter_ptr->filter_info,\n-\t\t\t\t&flex_filter,\n-\t\t\t\tsizeof(struct igb_flex_filter));\n+\t\t\tmemcpy(&flex_filter_ptr->filter_info, &flex_filter,\n+\t\t\t sizeof(struct igb_flex_filter));\n \t\t\tTAILQ_INSERT_TAIL(&igb_filter_flex_list,\n \t\t\t\tflex_filter_ptr, entries);\n \t\t\tflow->rule = flex_filter_ptr;\ndiff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c\nindex c7588ea57eaa..efb806af5692 100644\n--- a/drivers/net/e1000/igb_pf.c\n+++ b/drivers/net/e1000/igb_pf.c\n@@ -17,7 +17,6 @@\n #include <rte_eal.h>\n #include <rte_ether.h>\n #include <ethdev_driver.h>\n-#include <rte_memcpy.h>\n #include <rte_malloc.h>\n #include <rte_random.h>\n \n@@ -290,7 +289,7 @@ igb_vf_reset(struct rte_eth_dev *dev, uint16_t vf, uint32_t *msgbuf)\n \n \t/* reply to reset with ack and vf mac address */\n \tmsgbuf[0] = E1000_VF_RESET | E1000_VT_MSGTYPE_ACK;\n-\trte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN);\n+\tmemcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN);\n \te1000_write_mbx(hw, msgbuf, 3, vf);\n \n \treturn 0;\n@@ -308,8 +307,8 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)\n \n \tif (rte_is_unicast_ether_addr((struct rte_ether_addr *)new_mac)) {\n \t\tif (!rte_is_zero_ether_addr((struct rte_ether_addr *)new_mac))\n-\t\t\trte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac,\n-\t\t\t\tsizeof(vfinfo[vf].vf_mac_addresses));\n+\t\t\tmemcpy(vfinfo[vf].vf_mac_addresses, new_mac,\n+\t\t\t sizeof(vfinfo[vf].vf_mac_addresses));\n \t\thw->mac.ops.rar_set(hw, new_mac, rar_entry);\n \t\trah = E1000_READ_REG(hw, E1000_RAH(rar_entry));\n \t\trah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf));\ndiff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c\nindex 5cafd6f1ce30..4a41a3cea5fc 100644\n--- a/drivers/net/e1000/igb_rxtx.c\n+++ b/drivers/net/e1000/igb_rxtx.c\n@@ -19,7 +19,6 @@\n #include <rte_debug.h>\n #include <rte_pci.h>\n #include <rte_memory.h>\n-#include <rte_memcpy.h>\n #include <rte_memzone.h>\n #include <rte_launch.h>\n #include <rte_eal.h>\n", "prefixes": [ "v2", "61/71" ] }{ "id": 137751, "url": "