Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137755/?format=api
{ "id": 137755, "url": "http://patchwork.dpdk.org/api/patches/137755/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240301171707.95242-66-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240301171707.95242-66-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240301171707.95242-66-stephen@networkplumber.org", "date": "2024-03-01T17:16:01", "name": "[v2,65/71] net/hinic: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3ffaeba8bc73716e7ec32d23ca0273eda377f3e8", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240301171707.95242-66-stephen@networkplumber.org/mbox/", "series": [ { "id": 31340, "url": "http://patchwork.dpdk.org/api/series/31340/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31340", "date": "2024-03-01T17:14:57", "name": "replace use of fixed size rte_mempcy", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31340/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137755/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/137755/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5800B43C12;\n\tFri, 1 Mar 2024 18:24:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 935A3434FC;\n\tFri, 1 Mar 2024 18:18:42 +0100 (CET)", "from mail-pl1-f177.google.com (mail-pl1-f177.google.com\n [209.85.214.177])\n by mails.dpdk.org (Postfix) with ESMTP id 5B31F43476\n for <dev@dpdk.org>; Fri, 1 Mar 2024 18:18:09 +0100 (CET)", "by mail-pl1-f177.google.com with SMTP id\n d9443c01a7336-1d911c2103aso7700615ad.0\n for <dev@dpdk.org>; Fri, 01 Mar 2024 09:18:09 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 Mar 2024 09:18:07 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313488;\n x=1709918288; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2gowFFcWhVDEnjsf9+Qas+Ht+Lb2Py5p1efUePLeUgw=;\n b=svfAZBJuz8285lCjgPMRtOXwqcO7T+Qlyy7j3Q4sg6C9IWxP1zExdesFag/DecN7ez\n 7rjvoQik/S1Wc0/MXSLNqI+aCoP8Y8Ee/lOAxN13JJivrSVLSzNWzmpY5lEIk1CKT+bR\n iAu9TMZ/X4kOovb3tpuveVpvvYqbJ9HvgzgtqN9eRvOzqIC+PnPzAF2c4e8KM7YTe182\n kswNUlPWO7/xO37hpkmKtKaQ26rrFB+J44shJrBA5SaVvveI7uqXJylK+ZCBa3uMn9sF\n 0/5pqBW2aXYDsydte/wwTPxm80OYs8AFDm1hS+DM+W96fxPAK6ONCrfD0TZJLPyTM5mh\n 5wDQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709313488; x=1709918288;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2gowFFcWhVDEnjsf9+Qas+Ht+Lb2Py5p1efUePLeUgw=;\n b=bOMEFSiFHUjdp7FdrlaGQU436E8X26gunZ1P4xk6v8fcEaocJNmOuukB8oO7O4qYLS\n rCOItjgtR0zSWAkxMFcyLZnEoj6hsXsDUdA1xvzoQPa7Ua0s1wzE4QNTqCa4UgYEZsOp\n Z36yGY8iLGFKg2OAFx6XGw4ZHWsM8HZPsTKd+FVaMkORNbKQDju1BMHVwp1OHm00ZfGg\n 5XibzjYhHs/5xBp6yBYtveSuqVB0yTgsgDVOBZrnZrojP4OibSdk6XK8a/9B6GOnOSPW\n l6J+vSRSLhKP7l/wkuTZ9eT+pm7Egx/Rxa5TOrRK60cguS3/EZxMR43rQSNyIm+JhjyL\n TNpQ==", "X-Gm-Message-State": "AOJu0YzbpzFimdR4K0/Oy9ROilIxOlMONk+qfSBhhqabQ1WDcIZu/Xma\n uPqNCc91VsprOcJS/n28vU7lzFNDEtkrxGTtq4tXMSRiSpYUn8LqWYgXMEX1JiiJj9kizw4OBDw\n 4FlbbEQ==", "X-Google-Smtp-Source": "\n AGHT+IGb+llt/sscZ3DRNDkwwJKld1weTFtleB3di7RZiAOmaQmNCnoEWQMcR6GpInjV8tx3Mo0BRg==", "X-Received": "by 2002:a17:902:7846:b0:1dc:db57:d6e2 with SMTP id\n e6-20020a170902784600b001dcdb57d6e2mr2223855pln.69.1709313488579;\n Fri, 01 Mar 2024 09:18:08 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>", "Subject": "[PATCH v2 65/71] net/hinic: replace use of fixed size rte_memcpy", "Date": "Fri, 1 Mar 2024 09:16:01 -0800", "Message-ID": "<20240301171707.95242-66-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240301171707.95242-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>\n <20240301171707.95242-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/hinic/hinic_pmd_flow.c | 40 ++++++++++++++----------------\n 1 file changed, 18 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/hinic/hinic_pmd_flow.c b/drivers/net/hinic/hinic_pmd_flow.c\nindex d1a564a16303..cb61c989fd36 100644\n--- a/drivers/net/hinic/hinic_pmd_flow.c\n+++ b/drivers/net/hinic/hinic_pmd_flow.c\n@@ -983,8 +983,7 @@ static int hinic_normal_item_check_ip(const struct rte_flow_item **in_out_item,\n \t\t}\n \n \t\tipv6_spec = (const struct rte_flow_item_ipv6 *)item->spec;\n-\t\trte_memcpy(rule->hinic_fdir.dst_ipv6,\n-\t\t\t ipv6_spec->hdr.dst_addr, 16);\n+\t\tmemcpy(rule->hinic_fdir.dst_ipv6, ipv6_spec->hdr.dst_addr, 16);\n \n \t\t/*\n \t\t * Check if the next not void item is TCP or UDP or ICMP.\n@@ -2193,8 +2192,8 @@ static int hinic_add_del_ntuple_filter(struct rte_eth_dev *dev,\n \t\t\t\tsizeof(struct hinic_5tuple_filter), 0);\n \t\tif (filter == NULL)\n \t\t\treturn -ENOMEM;\n-\t\trte_memcpy(&filter->filter_info, &filter_5tuple,\n-\t\t\t\tsizeof(struct hinic_5tuple_filter_info));\n+\t\tmemcpy(&filter->filter_info, &filter_5tuple,\n+\t\t sizeof(struct hinic_5tuple_filter_info));\n \t\tfilter->queue = ntuple_filter->queue;\n \n \t\tfilter_info->qid = ntuple_filter->queue;\n@@ -2912,8 +2911,7 @@ static int hinic_add_del_tcam_fdir_filter(struct rte_eth_dev *dev,\n \t\t\t\tsizeof(struct hinic_tcam_filter), 0);\n \t\tif (tcam_filter == NULL)\n \t\t\treturn -ENOMEM;\n-\t\t(void)rte_memcpy(&tcam_filter->tcam_key,\n-\t\t\t\t &tcam_key, sizeof(struct tag_tcam_key));\n+\t\tmemcpy(&tcam_filter->tcam_key, &tcam_key, sizeof(struct tag_tcam_key));\n \t\ttcam_filter->queue = fdir_tcam_rule.data.qid;\n \n \t\tret = hinic_add_tcam_filter(dev, tcam_filter, &fdir_tcam_rule);\n@@ -2990,9 +2988,9 @@ static struct rte_flow *hinic_flow_create(struct rte_eth_dev *dev,\n \t\t\t\t\t\t\t&ntuple_filter, FALSE);\n \t\t\t\tgoto out;\n \t\t\t}\n-\t\t\trte_memcpy(&ntuple_filter_ptr->filter_info,\n-\t\t\t\t &ntuple_filter,\n-\t\t\t\t sizeof(struct rte_eth_ntuple_filter));\n+\t\t\tmemcpy(&ntuple_filter_ptr->filter_info,\n+\t\t\t &ntuple_filter,\n+\t\t\t sizeof(struct rte_eth_ntuple_filter));\n \t\t\tTAILQ_INSERT_TAIL(&nic_dev->filter_ntuple_list,\n \t\t\tntuple_filter_ptr, entries);\n \t\t\tflow->rule = ntuple_filter_ptr;\n@@ -3022,9 +3020,9 @@ static struct rte_flow *hinic_flow_create(struct rte_eth_dev *dev,\n \t\t\t\t\t\tðertype_filter, FALSE);\n \t\t\t\tgoto out;\n \t\t\t}\n-\t\t\trte_memcpy(ðertype_filter_ptr->filter_info,\n-\t\t\t\tðertype_filter,\n-\t\t\t\tsizeof(struct rte_eth_ethertype_filter));\n+\t\t\tmemcpy(ðertype_filter_ptr->filter_info,\n+\t\t\t ðertype_filter,\n+\t\t\t sizeof(struct rte_eth_ethertype_filter));\n \t\t\tTAILQ_INSERT_TAIL(&nic_dev->filter_ethertype_list,\n \t\t\t\tethertype_filter_ptr, entries);\n \t\t\tflow->rule = ethertype_filter_ptr;\n@@ -3065,8 +3063,8 @@ static struct rte_flow *hinic_flow_create(struct rte_eth_dev *dev,\n \n \t\t\t\tgoto out;\n \t\t\t}\n-\t\t\trte_memcpy(&fdir_rule_ptr->filter_info, &fdir_rule,\n-\t\t\t\tsizeof(struct hinic_fdir_rule));\n+\t\t\tmemcpy(&fdir_rule_ptr->filter_info, &fdir_rule,\n+\t\t\t sizeof(struct hinic_fdir_rule));\n \t\t\tTAILQ_INSERT_TAIL(&nic_dev->filter_fdir_rule_list,\n \t\t\t\tfdir_rule_ptr, entries);\n \t\t\tflow->rule = fdir_rule_ptr;\n@@ -3109,8 +3107,8 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,\n \tcase RTE_ETH_FILTER_NTUPLE:\n \t\tntuple_filter_ptr = (struct hinic_ntuple_filter_ele *)\n \t\t\t\t\tpmd_flow->rule;\n-\t\trte_memcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info,\n-\t\t\tsizeof(struct rte_eth_ntuple_filter));\n+\t\tmemcpy(&ntuple_filter, &ntuple_filter_ptr->filter_info,\n+\t\t sizeof(struct rte_eth_ntuple_filter));\n \t\tret = hinic_add_del_ntuple_filter(dev, &ntuple_filter, FALSE);\n \t\tif (!ret) {\n \t\t\tTAILQ_REMOVE(&nic_dev->filter_ntuple_list,\n@@ -3121,9 +3119,8 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,\n \tcase RTE_ETH_FILTER_ETHERTYPE:\n \t\tethertype_filter_ptr = (struct hinic_ethertype_filter_ele *)\n \t\t\t\t\tpmd_flow->rule;\n-\t\trte_memcpy(ðertype_filter,\n-\t\t\tðertype_filter_ptr->filter_info,\n-\t\t\tsizeof(struct rte_eth_ethertype_filter));\n+\t\tmemcpy(ðertype_filter, ðertype_filter_ptr->filter_info,\n+\t\t sizeof(struct rte_eth_ethertype_filter));\n \t\tret = hinic_add_del_ethertype_filter(dev,\n \t\t\t\tðertype_filter, FALSE);\n \t\tif (!ret) {\n@@ -3134,9 +3131,8 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,\n \t\tbreak;\n \tcase RTE_ETH_FILTER_FDIR:\n \t\tfdir_rule_ptr = (struct hinic_fdir_rule_ele *)pmd_flow->rule;\n-\t\trte_memcpy(&fdir_rule,\n-\t\t\t&fdir_rule_ptr->filter_info,\n-\t\t\tsizeof(struct hinic_fdir_rule));\n+\t\tmemcpy(&fdir_rule, &fdir_rule_ptr->filter_info,\n+\t\t sizeof(struct hinic_fdir_rule));\n \t\tif (fdir_rule.mode == HINIC_FDIR_MODE_NORMAL) {\n \t\t\tret = hinic_add_del_fdir_filter(dev, &fdir_rule, FALSE);\n \t\t} else if (fdir_rule.mode == HINIC_FDIR_MODE_TCAM) {\n", "prefixes": [ "v2", "65/71" ] }