Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137761/?format=api
{ "id": 137761, "url": "http://patchwork.dpdk.org/api/patches/137761/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240301171707.95242-72-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240301171707.95242-72-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240301171707.95242-72-stephen@networkplumber.org", "date": "2024-03-01T17:16:07", "name": "[v2,71/71] examples: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a4f2a51f1986922015c7f95ed711202c19fa5163", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240301171707.95242-72-stephen@networkplumber.org/mbox/", "series": [ { "id": 31340, "url": "http://patchwork.dpdk.org/api/series/31340/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31340", "date": "2024-03-01T17:14:57", "name": "replace use of fixed size rte_mempcy", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31340/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137761/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/137761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F0CF943C12;\n\tFri, 1 Mar 2024 18:25:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D6EE94350F;\n\tFri, 1 Mar 2024 18:18:50 +0100 (CET)", "from mail-pl1-f179.google.com (mail-pl1-f179.google.com\n [209.85.214.179])\n by mails.dpdk.org (Postfix) with ESMTP id 2171C43487\n for <dev@dpdk.org>; Fri, 1 Mar 2024 18:18:15 +0100 (CET)", "by mail-pl1-f179.google.com with SMTP id\n d9443c01a7336-1dca160163dso23227495ad.3\n for <dev@dpdk.org>; Fri, 01 Mar 2024 09:18:15 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.18.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 Mar 2024 09:18:13 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313494;\n x=1709918294; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6C2FGPHnRzt39pnm08MPnZG73sDYQhkMrLyqqUoxDfo=;\n b=UTzXQ0xGsqfUo/3tAya5FRwv2CXLdANpxTSKCTUagtB7pUxq3wUCLWh2WzZsY6mxr0\n w3Y6SHf+wovT+0UPEntobbsgHUaV/8WXfhpmMeLpJD55+2rDiszhXZVjVoixz6Tz5B0F\n emvOwOSrqwbntThbg1ovnzMN67XMSvBVdo3wsQVIKDs0eKPXVr11Kydmi6mObXkSHPHe\n JpsC2fgPYTO6YeW+wrGDT0X9W4V4cvV96mmnSZYNpUiF/RBOLOBQe6rvCed24ao1stKu\n vrdHUOzCfALDrJ06RHugeluQNIJhMlMePGeXucbuycBv4ja7FyIRT9yZ6RCCCb/g+H24\n wleQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709313494; x=1709918294;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=6C2FGPHnRzt39pnm08MPnZG73sDYQhkMrLyqqUoxDfo=;\n b=ZkfL94f4d+mgFd+74EfaPVW7XS2TqxooHCvLDdCUZ2Smn88aSNYSsfBdH2W9rhv5+H\n iWMaznThxcYwPBU1n8HUH3lgfYZp1mf6uWE6JRj+LrOUwomeeD6KVf6uJgNxkMdxmf3v\n gpFHTyoXfLZLRmkSaQJ5EqBzahbrGrRw7YVHakUgn+W13jLl+AKorCT/OkaWu+PAdYWq\n sZIwQ+iM49UULzT6+eLvtLphDHaE0GrRsJg/8r4AEbXV+8UB+qEJFreW/7RlBkxa+J+a\n QFgZhCGuTmHKYrku9m0mAKzjV4N2RsvE9pAMo/tIqXMi2lYkhZjDwyxfeb+Dj0a/gx/A\n Vy3A==", "X-Gm-Message-State": "AOJu0YxQgWH9hTfcDCxPatUoitvVUhy4haUThTm6tYyhh3gtM9lVNztg\n /LDOIK2IL/mhfjBDGnMdmMqkPG8hPZe2g63nKlckQh+dYc6ep0ZyEGK5q6Td9/+Ulh1zqfB4UU0\n WN7NmCQ==", "X-Google-Smtp-Source": "\n AGHT+IEEJ/DpTEsRvPyHM7hUQwsMLheNgfsze0FckzOgErnLBKSNwiNQ1s9fyADCwyAAQqy4IGHtpg==", "X-Received": "by 2002:a17:903:32d0:b0:1db:cbff:df15 with SMTP id\n i16-20020a17090332d000b001dbcbffdf15mr2617971plr.9.1709313494197;\n Fri, 01 Mar 2024 09:18:14 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Tomasz Kantecki <tomasz.kantecki@intel.com>,\n Kirill Rybalchenko <kirill.rybalchenko@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbox@nvidia.com>", "Subject": "[PATCH v2 71/71] examples: replace use of fixed size rte_memcpy", "Date": "Fri, 1 Mar 2024 09:16:07 -0800", "Message-ID": "<20240301171707.95242-72-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240301171707.95242-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>\n <20240301171707.95242-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/bbdev_app/main.c | 2 +-\n examples/l2fwd-cat/cat.c | 4 +---\n examples/ptpclient/ptpclient.c | 11 +++++------\n examples/vhost/main.c | 5 ++---\n examples/vmdq/main.c | 6 ++----\n examples/vmdq_dcb/main.c | 15 +++++----------\n 6 files changed, 16 insertions(+), 27 deletions(-)", "diff": "diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c\nindex 16599ae9cee3..52c8eabba778 100644\n--- a/examples/bbdev_app/main.c\n+++ b/examples/bbdev_app/main.c\n@@ -359,7 +359,7 @@ add_ether_hdr(struct rte_mbuf *pkt_src, struct rte_mbuf *pkt_dst)\n \teth_to = rte_pktmbuf_mtod(pkt_dst, struct rte_ether_hdr *);\n \n \t/* copy header */\n-\trte_memcpy(eth_to, eth_from, sizeof(struct rte_ether_hdr));\n+\tmemcpy(eth_to, eth_from, sizeof(struct rte_ether_hdr));\n }\n \n static inline void\ndiff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c\nindex 00e4cde48b48..d1689fca2912 100644\n--- a/examples/l2fwd-cat/cat.c\n+++ b/examples/l2fwd-cat/cat.c\n@@ -12,7 +12,6 @@\n #include <stdio.h>\n \n #include <rte_common.h>\n-#include <rte_memcpy.h>\n \n #include <pqos.h>\n \n@@ -314,8 +313,7 @@ parse_l3ca(const char *l3ca)\n \t\tif (cmask != 0 && is_contiguous(cmask) == 0)\n \t\t\tgoto err;\n \n-\t\trte_memcpy(&m_config[idx].cpumask,\n-\t\t\t&cpuset, sizeof(rte_cpuset_t));\n+\t\tmemcpy(&m_config[idx].cpumask, &cpuset, sizeof(rte_cpuset_t));\n \n \t\tif (cmask != 0) {\n \t\t\tm_config[idx].cdp = 1;\ndiff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c\nindex 2535d848a1e9..e918bc05db34 100644\n--- a/examples/ptpclient/ptpclient.c\n+++ b/examples/ptpclient/ptpclient.c\n@@ -359,9 +359,9 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, uint16_t rx_tstamp_idx)\n \tptp_data->seqID_SYNC = rte_be_to_cpu_16(ptp_hdr->seq_id);\n \n \tif (ptp_data->ptpset == 0) {\n-\t\trte_memcpy(&ptp_data->master_clock_id,\n-\t\t\t\t&ptp_hdr->source_port_id.clock_id,\n-\t\t\t\tsizeof(struct clock_id));\n+\t\tmemcpy(&ptp_data->master_clock_id,\n+\t\t &ptp_hdr->source_port_id.clock_id,\n+\t\t sizeof(struct clock_id));\n \t\tptp_data->ptpset = 1;\n \t}\n \n@@ -466,9 +466,8 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)\n \t\tclient_clkid->id[6] = eth_hdr->src_addr.addr_bytes[4];\n \t\tclient_clkid->id[7] = eth_hdr->src_addr.addr_bytes[5];\n \n-\t\trte_memcpy(&ptp_data->client_clock_id,\n-\t\t\t client_clkid,\n-\t\t\t sizeof(struct clock_id));\n+\t\tmemcpy(&ptp_data->client_clock_id, client_clkid,\n+\t\t sizeof(struct clock_id));\n \n \t\t/* Enable flag for hardware timestamping. */\n \t\tcreated_pkt->ol_flags |= RTE_MBUF_F_TX_IEEE1588_TMST;\ndiff --git a/examples/vhost/main.c b/examples/vhost/main.c\nindex 3fc1b151d182..5691ec110ac8 100644\n--- a/examples/vhost/main.c\n+++ b/examples/vhost/main.c\n@@ -405,9 +405,8 @@ get_eth_conf(struct rte_eth_conf *eth_conf, uint32_t num_devices)\n \t\tconf.pool_map[i].pools = (1UL << i);\n \t}\n \n-\t(void)(rte_memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf)));\n-\t(void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf,\n-\t\t sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf)));\n+\t(void)(memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf)));\n+\t(void)(memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf)));\n \treturn 0;\n }\n \ndiff --git a/examples/vmdq/main.c b/examples/vmdq/main.c\nindex 4a3ce6884c5c..d928f4a45ccf 100644\n--- a/examples/vmdq/main.c\n+++ b/examples/vmdq/main.c\n@@ -17,7 +17,6 @@\n #include <rte_common.h>\n #include <rte_log.h>\n #include <rte_memory.h>\n-#include <rte_memcpy.h>\n #include <rte_eal.h>\n #include <rte_launch.h>\n #include <rte_cycles.h>\n@@ -151,9 +150,8 @@ get_eth_conf(struct rte_eth_conf *eth_conf, uint32_t num_pools)\n \t\tconf.pool_map[i].pools = (1UL << (i % num_pools));\n \t}\n \n-\t(void)(rte_memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf)));\n-\t(void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf,\n-\t\t sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf)));\n+\t(void)(memcpy(eth_conf, &vmdq_conf_default, sizeof(*eth_conf)));\n+\t(void)(memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &conf, sizeof(eth_conf->rx_adv_conf.vmdq_rx_conf)));\n \tif (rss_enable) {\n \t\teth_conf->rxmode.mq_mode = RTE_ETH_MQ_RX_VMDQ_RSS;\n \t\teth_conf->rx_adv_conf.rss_conf.rss_hf = RTE_ETH_RSS_IP |\ndiff --git a/examples/vmdq_dcb/main.c b/examples/vmdq_dcb/main.c\nindex 4ccc2fe4b01c..f93eca59367b 100644\n--- a/examples/vmdq_dcb/main.c\n+++ b/examples/vmdq_dcb/main.c\n@@ -17,7 +17,6 @@\n #include <rte_common.h>\n #include <rte_log.h>\n #include <rte_memory.h>\n-#include <rte_memcpy.h>\n #include <rte_eal.h>\n #include <rte_launch.h>\n #include <rte_cycles.h>\n@@ -161,15 +160,11 @@ get_eth_conf(struct rte_eth_conf *eth_conf)\n \t\ttx_conf.dcb_tc[i] = i % num_tcs;\n \t}\n \tdcb_conf.nb_tcs = (enum rte_eth_nb_tcs)num_tcs;\n-\t(void)(rte_memcpy(eth_conf, &vmdq_dcb_conf_default, sizeof(*eth_conf)));\n-\t(void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_dcb_conf, &conf,\n-\t\t\t sizeof(conf)));\n-\t(void)(rte_memcpy(ð_conf->rx_adv_conf.dcb_rx_conf, &dcb_conf,\n-\t\t\t sizeof(dcb_conf)));\n-\t(void)(rte_memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &vmdq_conf,\n-\t\t\t sizeof(vmdq_conf)));\n-\t(void)(rte_memcpy(ð_conf->tx_adv_conf.vmdq_dcb_tx_conf, &tx_conf,\n-\t\t\t sizeof(tx_conf)));\n+\t(void)(memcpy(eth_conf, &vmdq_dcb_conf_default, sizeof(*eth_conf)));\n+\t(void)(memcpy(ð_conf->rx_adv_conf.vmdq_dcb_conf, &conf, sizeof(conf)));\n+\t(void)(memcpy(ð_conf->rx_adv_conf.dcb_rx_conf, &dcb_conf, sizeof(dcb_conf)));\n+\t(void)(memcpy(ð_conf->rx_adv_conf.vmdq_rx_conf, &vmdq_conf, sizeof(vmdq_conf)));\n+\t(void)(memcpy(ð_conf->tx_adv_conf.vmdq_dcb_tx_conf, &tx_conf, sizeof(tx_conf)));\n \tif (rss_enable) {\n \t\teth_conf->rxmode.mq_mode = RTE_ETH_MQ_RX_VMDQ_DCB_RSS;\n \t\teth_conf->rx_adv_conf.rss_conf.rss_hf = RTE_ETH_RSS_IP |\n", "prefixes": [ "v2", "71/71" ] }