Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137848/?format=api
{ "id": 137848, "url": "http://patchwork.dpdk.org/api/patches/137848/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240304090136.861-6-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240304090136.861-6-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240304090136.861-6-shaibran@amazon.com", "date": "2024-03-04T09:01:08", "name": "[05/33] net/ena: fix fast mbuf free", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d599e0eecaa06cb1d32de7a108a1ad244be635f8", "submitter": { "id": 2930, "url": "http://patchwork.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240304090136.861-6-shaibran@amazon.com/mbox/", "series": [ { "id": 31356, "url": "http://patchwork.dpdk.org/api/series/31356/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31356", "date": "2024-03-04T09:01:07", "name": "net/ena: v2.9.0 driver release", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31356/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/137848/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/137848/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB83E43B9B;\n\tMon, 4 Mar 2024 10:02:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 144CA40DC9;\n\tMon, 4 Mar 2024 10:02:03 +0100 (CET)", "from smtp-fw-80008.amazon.com (smtp-fw-80008.amazon.com\n [99.78.197.219])\n by mails.dpdk.org (Postfix) with ESMTP id B09A74026B;\n Mon, 4 Mar 2024 10:01:56 +0100 (CET)", "from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.25.36.214])\n by smtp-border-fw-80008.pdx80.corp.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 09:01:55 +0000", "from EX19MTAEUB002.ant.amazon.com [10.0.17.79:52732]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.11.111:2525]\n with esmtp (Farcaster)\n id aca711b0-0ce9-454c-8927-84413b6d6435; Mon, 4 Mar 2024 09:01:54 +0000 (UTC)", "from EX19D007EUA001.ant.amazon.com (10.252.50.133) by\n EX19MTAEUB002.ant.amazon.com (10.252.51.79) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 09:01:48 +0000", "from EX19MTAUEC001.ant.amazon.com (10.252.135.222) by\n EX19D007EUA001.ant.amazon.com (10.252.50.133) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 4 Mar 2024 09:01:47 +0000", "from HFA15-CG15235BS.amazon.com (10.1.212.49) by\n mail-relay.amazon.com (10.252.135.200) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Mon, 4 Mar 2024 09:01:46 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709542917; x=1741078917;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=VKWLz4oDznq//Hd+/QwTpu816la+fimxjPhi3Vu/OHA=;\n b=khMtWz75GlySpNIt7zrw6fCTYhyRpNiMEHBJfIxgGwkOEZihDkja9ft4\n nSA/1NXTGUW+1FX6cRrHBAbx5xysvYHnHbykt3z0NOSpbtmwj64gpDhE6\n UenFeR8vwQM1iIE5GITBV39QnA5Z1UkIAvaPgxMc0/tpcJjl0NH4hzm0r 4=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,203,1705363200\"; d=\"scan'208\";a=\"70433912\"", "X-Farcaster-Flow-ID": "aca711b0-0ce9-454c-8927-84413b6d6435", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>, <stable@dpdk.org>", "Subject": "[PATCH 05/33] net/ena: fix fast mbuf free", "Date": "Mon, 4 Mar 2024 11:01:08 +0200", "Message-ID": "<20240304090136.861-6-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240304090136.861-1-shaibran@amazon.com>", "References": "<20240304090136.861-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nIn case the application enables fast mbuf release optimization,\nthe driver releases 256 TX mbufs in bulk upon reaching the\nTX free threshold.\nThe existing implementation utilizes rte_mempool_put_bulk for bulk\nfreeing TXs, which exclusively supports direct mbufs.\nIn case the application transmits indirect bufs, the driver must\nalso decrement the mbuf reference count and unlink the mbuf segment.\nFor such case, the driver should employ rte_pktmbuf_free_bulk.\n\nFixes: c339f53823f3 (\"net/ena: support fast mbuf free\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n doc/guides/rel_notes/release_24_03.rst | 1 +\n drivers/net/ena/ena_ethdev.c | 6 ++----\n 2 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst\nindex f47073c7dc..6b73d4fedf 100644\n--- a/doc/guides/rel_notes/release_24_03.rst\n+++ b/doc/guides/rel_notes/release_24_03.rst\n@@ -105,6 +105,7 @@ New Features\n \n * Removed the reporting of `rx_overruns` errors from xstats and instead updated `imissed` stat with its value.\n * Added support for sub-optimal configuration notifications from the device.\n+ * Restructured fast release of mbufs when RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE optimization is enabled.\n \n * **Updated Atomic Rules' Arkville driver.**\n \ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 3157237c0d..537ee9f8c3 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -3122,8 +3122,7 @@ ena_tx_cleanup_mbuf_fast(struct rte_mbuf **mbufs_to_clean,\n \t\tm_next = mbuf->next;\n \t\tmbufs_to_clean[mbuf_cnt++] = mbuf;\n \t\tif (mbuf_cnt == buf_size) {\n-\t\t\trte_mempool_put_bulk(mbufs_to_clean[0]->pool, (void **)mbufs_to_clean,\n-\t\t\t\t(unsigned int)mbuf_cnt);\n+\t\t\trte_pktmbuf_free_bulk(mbufs_to_clean, mbuf_cnt);\n \t\t\tmbuf_cnt = 0;\n \t\t}\n \t\tmbuf = m_next;\n@@ -3191,8 +3190,7 @@ static int ena_tx_cleanup(void *txp, uint32_t free_pkt_cnt)\n \t}\n \n \tif (mbuf_cnt != 0)\n-\t\trte_mempool_put_bulk(mbufs_to_clean[0]->pool,\n-\t\t\t(void **)mbufs_to_clean, mbuf_cnt);\n+\t\trte_pktmbuf_free_bulk(mbufs_to_clean, mbuf_cnt);\n \n \t/* Notify completion handler that full cleanup was performed */\n \tif (free_pkt_cnt == 0 || total_tx_pkts < cleanup_budget)\n", "prefixes": [ "05/33" ] }