Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138014/?format=api
{ "id": 138014, "url": "http://patchwork.dpdk.org/api/patches/138014/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240306122445.4350-2-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240306122445.4350-2-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240306122445.4350-2-shaibran@amazon.com", "date": "2024-03-06T12:24:13", "name": "[v3,01/33] net/ena: rework the metrics multi-process functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fd0ca011263f96abf48afff072bfe901bb229f1f", "submitter": { "id": 2930, "url": "http://patchwork.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240306122445.4350-2-shaibran@amazon.com/mbox/", "series": [ { "id": 31397, "url": "http://patchwork.dpdk.org/api/series/31397/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31397", "date": "2024-03-06T12:24:13", "name": "net/ena: v2.9.0 driver release", "version": 3, "mbox": "http://patchwork.dpdk.org/series/31397/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138014/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138014/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1E24E43C5B;\n\tWed, 6 Mar 2024 13:24:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D704840A6F;\n\tWed, 6 Mar 2024 13:24:56 +0100 (CET)", "from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com\n [72.21.196.25])\n by mails.dpdk.org (Postfix) with ESMTP id 5BC104027C\n for <dev@dpdk.org>; Wed, 6 Mar 2024 13:24:55 +0100 (CET)", "from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.43.8.6])\n by smtp-border-fw-2101.iad2.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2024 12:24:53 +0000", "from EX19MTAEUC001.ant.amazon.com [10.0.10.100:20519]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.42.5:2525]\n with\n esmtp (Farcaster)\n id 899dc50d-8f71-423f-bbe9-8c465f6da4e1; Wed, 6 Mar 2024 12:24:52 +0000 (UTC)", "from EX19D007EUA001.ant.amazon.com (10.252.50.133) by\n EX19MTAEUC001.ant.amazon.com (10.252.51.155) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:24:51 +0000", "from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by\n EX19D007EUA001.ant.amazon.com (10.252.50.133) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 6 Mar 2024 12:24:51 +0000", "from HFA15-CG15235BS.amazon.com (10.1.213.21) by\n mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Wed, 6 Mar 2024 12:24:49 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1709727896; x=1741263896;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=SOx7LsS6G0ty/ZpiCj/kAL1TgAnWPKqvmUmP5IMtYfk=;\n b=gh/eaUqBofnMXSuwYInMpLpWXWnXi2J2DA52KPIO1t8V8rx445P2QSng\n FKNvQD+KKSn3HzJ3Xc3kY1dLC1eJlvzPQMCwUO2gMyU1AmUfduvPEK1z2\n DshczQlne8z0AMrR5dlfDrctwVyZagpRHnSeY1aSfHqXlOPFIozTqE9wm k=;", "X-IronPort-AV": "E=Sophos;i=\"6.06,208,1705363200\"; d=\"scan'208\";a=\"385860453\"", "X-Farcaster-Flow-ID": "899dc50d-8f71-423f-bbe9-8c465f6da4e1", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v3 01/33] net/ena: rework the metrics multi-process functions", "Date": "Wed, 6 Mar 2024 14:24:13 +0200", "Message-ID": "<20240306122445.4350-2-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240306122445.4350-1-shaibran@amazon.com>", "References": "<20240306122445.4350-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\n1. Changed the rte_memcpy call to use the precomputed buf_size.\n2. Removed redundant address operators (ampersand symbol)\n when providing memcpy source address parameter.\n3. Code style related change.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex beb17c4125..6d500bfa78 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -531,8 +531,8 @@ __extension__ ({\n __extension__ ({\n \tENA_TOUCH(rsp);\n \tENA_TOUCH(ena_dev);\n-\tif (stats != (struct ena_admin_eni_stats *)&adapter->metrics_stats)\n-\t\trte_memcpy(stats, &adapter->metrics_stats, sizeof(*stats));\n+\tif (stats != (struct ena_admin_eni_stats *)adapter->metrics_stats)\n+\t\trte_memcpy(stats, adapter->metrics_stats, sizeof(*stats));\n }),\n \tstruct ena_com_dev *ena_dev, struct ena_admin_eni_stats *stats);\n \n@@ -590,9 +590,8 @@ __extension__ ({\n __extension__ ({\n \tENA_TOUCH(rsp);\n \tENA_TOUCH(ena_dev);\n-\tENA_TOUCH(buf_size);\n-\tif (buf != (char *)&adapter->metrics_stats)\n-\t\trte_memcpy(buf, &adapter->metrics_stats, adapter->metrics_num * sizeof(uint64_t));\n+\tif (buf != (char *)adapter->metrics_stats)\n+\t\trte_memcpy(buf, adapter->metrics_stats, buf_size);\n }),\n \tstruct ena_com_dev *ena_dev, char *buf, size_t buf_size);\n \n@@ -4088,7 +4087,7 @@ ena_mp_primary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n \tcase ENA_MP_CUSTOMER_METRICS_GET:\n \t\tres = ena_com_get_customer_metrics(ena_dev,\n \t\t\t\t(char *)adapter->metrics_stats,\n-\t\t\t\tsizeof(uint64_t) * adapter->metrics_num);\n+\t\t\t\tadapter->metrics_num * sizeof(uint64_t));\n \t\tbreak;\n \tcase ENA_MP_SRD_STATS_GET:\n \t\tres = ena_com_get_ena_srd_info(ena_dev,\n", "prefixes": [ "v3", "01/33" ] }