Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138099/?format=api
{ "id": 138099, "url": "http://patchwork.dpdk.org/api/patches/138099/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240307103624.610080-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240307103624.610080-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240307103624.610080-1-david.marchand@redhat.com", "date": "2024-03-07T10:36:24", "name": "vhost: fix virtqueue access lock check for handlers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ae4e2e23dd731d1de34fbf568115745f8a5c85d9", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240307103624.610080-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 31422, "url": "http://patchwork.dpdk.org/api/series/31422/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31422", "date": "2024-03-07T10:36:24", "name": "vhost: fix virtqueue access lock check for handlers", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31422/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138099/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138099/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD0A343BA7;\n\tThu, 7 Mar 2024 11:36:33 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9284B402C2;\n\tThu, 7 Mar 2024 11:36:33 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 7B0A540272\n for <dev@dpdk.org>; Thu, 7 Mar 2024 11:36:32 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-180-A-jcDzGDPWKXfkPGuVGUhg-1; Thu, 07 Mar 2024 05:36:28 -0500", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9F907185A781;\n Thu, 7 Mar 2024 10:36:28 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.66])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 9FE2A1C05E1C;\n Thu, 7 Mar 2024 10:36:27 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1709807792;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=x3CijOCnxn9+ganVuM95gOvswKS8H9OH7MMRLtcWLFg=;\n b=MSW7hbJyRzTPv8KzxmdQHn4qHXnZYGIC7t9/TJUpQKJKd8uFwyd+uZOxJSLBpX3p+VdEoQ\n PVcMrUVgdAaK0ZBPflSg4PGiyVixjvObABeSq7M6aSBjTBaMVL4hHImr2+8yii6ZHL5FQd\n YBgegTfMI9HEaBpo9xMAPHwf1JvDkFM=", "X-MC-Unique": "A-jcDzGDPWKXfkPGuVGUhg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbox@nvidia.com>", "Subject": "[PATCH] vhost: fix virtqueue access lock check for handlers", "Date": "Thu, 7 Mar 2024 11:36:24 +0100", "Message-ID": "<20240307103624.610080-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "As the vhost library may receive a request for an unsupported request,\nit is necessary to check msg_handler before checking if locking queue\npairs is requested.\n\nCoverity issue: 415049\nFixes: 5e8fcc60b59d (\"vhost: enhance virtqueue access lock asserts\")\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/vhost/vhost_user.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 7fe1687f08..414192500e 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -3171,7 +3171,7 @@ vhost_user_msg_handler(int vid, int fd)\n \t * inactive, so it is safe. Otherwise taking the access_lock\n \t * would cause a dead lock.\n \t */\n-\tif (msg_handler->lock_all_qps) {\n+\tif (msg_handler != NULL && msg_handler->lock_all_qps) {\n \t\tif (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) {\n \t\t\tvhost_user_lock_all_queue_pairs(dev);\n \t\t\tunlock_required = 1;\n", "prefixes": [] }