Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138139/?format=api
{ "id": 138139, "url": "http://patchwork.dpdk.org/api/patches/138139/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240308223446.215726-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240308223446.215726-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240308223446.215726-3-stephen@networkplumber.org", "date": "2024-03-08T22:33:41", "name": "[v4,2/3] examples/vm_power_manager: do not use EAL logtype", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7351ec9fbe1e7b0a8fd1a37cbe2a463f8582d1c6", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240308223446.215726-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 31449, "url": "http://patchwork.dpdk.org/api/series/31449/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31449", "date": "2024-03-08T22:33:39", "name": "replace use of EAL logtype in applications", "version": 4, "mbox": "http://patchwork.dpdk.org/series/31449/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138139/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6E6AC43C4B;\n\tFri, 8 Mar 2024 23:35:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A4F8342F00;\n\tFri, 8 Mar 2024 23:34:54 +0100 (CET)", "from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n by mails.dpdk.org (Postfix) with ESMTP id D9DCD42DCE\n for <dev@dpdk.org>; Fri, 8 Mar 2024 23:34:51 +0100 (CET)", "by mail-pl1-f178.google.com with SMTP id\n d9443c01a7336-1dd5df90170so16051045ad.0\n for <dev@dpdk.org>; Fri, 08 Mar 2024 14:34:51 -0800 (PST)", "from hermes.lan (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n c8-20020a170903234800b001dc3c4e7a12sm145517plh.14.2024.03.08.14.34.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 Mar 2024 14:34:50 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709937291;\n x=1710542091; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EStD9EvR6OoecugU86AyTaCTLdlfFyksP+Y5mTQTQRU=;\n b=GRz5CfsxW1wqYSCdwOimV1uXwr9eMKNXBOlYXpZGHg3QWFu64c6Xu8QWYm7W2icoRk\n nu2mWTyNjzE1N5WC205j6JOKt45TVfJ+drrh/0xa8bU5QkzatJWf8HA7iATNGq0yPpMV\n e1QfWlA1m2ancNP5zJKwj378/U7B4DqtqUcjifunbuabVHWvm4gbegjsZvB18srbbcoo\n RkUE0HStYe9vXlPRDEy4tc8lXqKekAC9nF4f/45BMxZMPJUpPoIreEfD81O4aD/TJCcZ\n fqfYf6+EVASDGrxoLlSvxQut9yCJonq/vBDi5gtrtEolm9XQn9PIUSvvarls4YWs3/Qy\n 5aAA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709937291; x=1710542091;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=EStD9EvR6OoecugU86AyTaCTLdlfFyksP+Y5mTQTQRU=;\n b=jbEuNZAmq7XaY8XA8zXL5jJx/I/S5YIFYcj2fJ7E4u/uhPnskedKiGCDlrsoLacKWg\n BMh1L+7Lw4gl1v/jS1X1hgCIWJiC0fhwrqLa2fdhp4dJaCMbTogRfF2jZHO3PNaoIxcL\n YOugg/9SlBA9dgPkGSruUoMAfBWfW75MLovGbiOp7xbpon4vRFFEHwIq3rf4WkYQ01V0\n OSRLBi9ykzP7y92EO4uPeuYrrQbAxB6DTFsbJM0QZr58CjwE1jRnkuf+ZTRxgwciikBJ\n RS3LuPjtrZm7JfOWqq0s7Su24JUqnAi47VNkh6xEM4GDLI1y9YGiiVDUzV3eO9VION7x\n qeUA==", "X-Gm-Message-State": "AOJu0Yye5tfno09FZ3jdadstSi0133eOiWHnRs2sxtqQKGqyQKI9eslY\n Zs2ydqPnz9+PJn3ua6txuKTmjRqoPxfxCXgdP3G2WLRGuuSZO9XEDinyw4wlzSONZyre3ssOu1b\n DnDU=", "X-Google-Smtp-Source": "\n AGHT+IECGISYvwmv98yi6R+gW6U9068JNzwv+tFJpQBU4DyIDUCXPEcurJPjBqNpZMC57/9xmizwmA==", "X-Received": "by 2002:a17:903:2291:b0:1dc:6071:60ad with SMTP id\n b17-20020a170903229100b001dc607160admr56338plh.24.1709937291042;\n Fri, 08 Mar 2024 14:34:51 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n David Hunt <david.hunt@intel.com>, Huisong Li <lihuisong@huawei.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "Subject": "[PATCH v4 2/3] examples/vm_power_manager: do not use EAL logtype", "Date": "Fri, 8 Mar 2024 14:33:41 -0800", "Message-ID": "<20240308223446.215726-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240308223446.215726-1-stephen@networkplumber.org>", "References": "<20231211172437.61958-1-stephen@networkplumber.org>\n <20240308223446.215726-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Be consistent for all the error printouts and use fprintf().\nThe EAL logtype is reserved for internal use by EAL.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: David Hunt <david.hunt@intel.com>\nAcked-by: Huisong Li <lihuisong@huawei.com>\n---\n examples/vm_power_manager/main.c | 11 ++++-------\n 1 file changed, 4 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c\nindex b159291d77ce..c14138202004 100644\n--- a/examples/vm_power_manager/main.c\n+++ b/examples/vm_power_manager/main.c\n@@ -17,7 +17,6 @@\n #include <rte_common.h>\n #include <rte_eal.h>\n #include <rte_launch.h>\n-#include <rte_log.h>\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n #include <rte_ethdev.h>\n@@ -425,8 +424,7 @@ main(int argc, char **argv)\n \n \tlcore_id = rte_get_next_lcore(-1, 1, 0);\n \tif (lcore_id == RTE_MAX_LCORE) {\n-\t\tRTE_LOG(ERR, EAL, \"A minimum of three cores are required to run \"\n-\t\t\t\t\"application\\n\");\n+\t\tfprintf(stderr, \"A minimum of three cores are required to run application\\n\");\n \t\treturn 0;\n \t}\n \tprintf(\"Running channel monitor on lcore id %d\\n\", lcore_id);\n@@ -434,16 +432,15 @@ main(int argc, char **argv)\n \n \tlcore_id = rte_get_next_lcore(lcore_id, 1, 0);\n \tif (lcore_id == RTE_MAX_LCORE) {\n-\t\tRTE_LOG(ERR, EAL, \"A minimum of three cores are required to run \"\n-\t\t\t\t\"application\\n\");\n+\t\tfprintf(stderr, \"A minimum of three cores are required to run application\\n\");\n \t\treturn 0;\n \t}\n \tif (power_manager_init() < 0) {\n-\t\tprintf(\"Unable to initialize power manager\\n\");\n+\t\tfprintf(stderr, \"Unable to initialize power manager\\n\");\n \t\treturn -1;\n \t}\n \tif (channel_manager_init(CHANNEL_MGR_DEFAULT_HV_PATH) < 0) {\n-\t\tprintf(\"Unable to initialize channel manager\\n\");\n+\t\tfprintf(stderr, \"Unable to initialize channel manager\\n\");\n \t\treturn -1;\n \t}\n \n", "prefixes": [ "v4", "2/3" ] }