Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138199/?format=api
{ "id": 138199, "url": "http://patchwork.dpdk.org/api/patches/138199/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1710229908-31704-4-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1710229908-31704-4-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1710229908-31704-4-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-12T07:51:48", "name": "[3/3] ethdev: import and export data variables for MSVC", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "32d9baa42dddcef36dee86be3893a02525f200c2", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1710229908-31704-4-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31470, "url": "http://patchwork.dpdk.org/api/series/31470/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31470", "date": "2024-03-12T07:51:48", "name": "RFC fix import/export MSVC data variables", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31470/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138199/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/138199/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6AAA443C8E;\n\tTue, 12 Mar 2024 08:51:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 130AE402E6;\n\tTue, 12 Mar 2024 08:51:52 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id C2C2A402E6\n for <dev@dpdk.org>; Tue, 12 Mar 2024 08:51:50 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 174F920B74C4; Tue, 12 Mar 2024 00:51:49 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 174F920B74C4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1710229910;\n bh=2Y8fhp16FKui49ckXxrT6HSlKdL9mBzDBngBD6Y1UxM=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=JCnYVqezyXnnZx1ZlbJ3cKMJcAbecXSeuPY6sph5+J1RonMy3AzLeOiA4R52dashv\n NcrwuIEMuu/gvy96Bbj1SDF+sAb9Cakm1T2y9silvCgNMH/IB7FjexLIP3g+2+XAom\n 0XKzfxqQa7ttHrzDXpyf4asMGzaQzOdUAH6CBGTo=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Bruce Richardson <bruce.richardson@intel.com>,\n David Marchand <david.marchand@redhat.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 3/3] ethdev: import and export data variables for MSVC", "Date": "Tue, 12 Mar 2024 00:51:48 -0700", "Message-Id": "<1710229908-31704-4-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1710229908-31704-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710229908-31704-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC requires that data variables be explicitly declared as either\nimported or exported. Provide macros that allow dpdk to correctly\ndeclare data variables as exported for itself and imported for\napplications.\n\nUse new per-library macro to declare variables exported or imported for\nper-lcore data variables.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/ethdev/meson.build | 1 +\n lib/ethdev/rte_ethdev_core.h | 3 +++\n lib/ethdev/rte_ethdev_export.h | 23 +++++++++++++++++++++++\n lib/ethdev/version.map | 2 +-\n 4 files changed, 28 insertions(+), 1 deletion(-)\n create mode 100644 lib/ethdev/rte_ethdev_export.h", "diff": "diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build\nindex f1d2586..b270e02 100644\n--- a/lib/ethdev/meson.build\n+++ b/lib/ethdev/meson.build\n@@ -23,6 +23,7 @@ sources = files(\n headers = files(\n 'rte_cman.h',\n 'rte_ethdev.h',\n+ 'rte_ethdev_export.h',\n 'rte_ethdev_trace_fp.h',\n 'rte_dev_info.h',\n 'rte_flow.h',\ndiff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h\nindex e55fb42..4e7939f 100644\n--- a/lib/ethdev/rte_ethdev_core.h\n+++ b/lib/ethdev/rte_ethdev_core.h\n@@ -16,6 +16,8 @@\n * Applications should not use these directly.\n */\n \n+#include <rte_ethdev_export.h>\n+\n struct rte_eth_dev_callback;\n /** @internal Structure to keep track of registered callbacks */\n RTE_TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback);\n@@ -126,6 +128,7 @@ struct __rte_cache_aligned rte_eth_fp_ops {\n \n };\n \n+__rte_ethdev_export\n extern struct rte_eth_fp_ops rte_eth_fp_ops[RTE_MAX_ETHPORTS];\n \n #endif /* _RTE_ETHDEV_CORE_H_ */\ndiff --git a/lib/ethdev/rte_ethdev_export.h b/lib/ethdev/rte_ethdev_export.h\nnew file mode 100644\nindex 0000000..7887bee\n--- /dev/null\n+++ b/lib/ethdev/rte_ethdev_export.h\n@@ -0,0 +1,23 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2024 Microsoft Corporation\n+ */\n+\n+#ifndef _RTE_ETHDEV_EXPORT_H_\n+#define _RTE_ETHDEV_EXPORT_H_\n+\n+/**\n+ * @file\n+ *\n+ * Import / Export macros for ethdev data variables.\n+ */\n+\n+#include <rte_common.h>\n+\n+#ifndef __rte_ethdev_export\n+#define __rte_ethdev_export __rte_declare_import\n+#else\n+#undef __rte_ethdev_export\n+#define __rte_ethdev_export __rte_declare_export\n+#endif\n+\n+#endif\ndiff --git a/lib/ethdev/version.map b/lib/ethdev/version.map\nindex 79f6f52..efe426f 100644\n--- a/lib/ethdev/version.map\n+++ b/lib/ethdev/version.map\n@@ -83,7 +83,7 @@ DPDK_24 {\n \trte_eth_find_next_of;\n \trte_eth_find_next_owned_by;\n \trte_eth_find_next_sibling;\n-\trte_eth_fp_ops;\n+\trte_eth_fp_ops; # MSVC_NO_EXPORT\n \trte_eth_iterator_cleanup;\n \trte_eth_iterator_init;\n \trte_eth_iterator_next;\n", "prefixes": [ "3/3" ] }