Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138337/?format=api
{ "id": 138337, "url": "http://patchwork.dpdk.org/api/patches/138337/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240314020052.3107549-1-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314020052.3107549-1-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314020052.3107549-1-chaoyong.he@corigine.com", "date": "2024-03-14T02:00:52", "name": "[v2] examples/ipsec-secgw: fix SA salt endianness problem", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "eb10f2c45b09f4bb32f37cfd1e83deaed4538e4e", "submitter": { "id": 2554, "url": "http://patchwork.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240314020052.3107549-1-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31502, "url": "http://patchwork.dpdk.org/api/series/31502/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31502", "date": "2024-03-14T02:00:52", "name": "[v2] examples/ipsec-secgw: fix SA salt endianness problem", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31502/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138337/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138337/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7DFFF43CB0;\n\tThu, 14 Mar 2024 03:01:42 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1B20040297;\n\tThu, 14 Mar 2024 03:01:42 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2095.outbound.protection.outlook.com [40.107.220.95])\n by mails.dpdk.org (Postfix) with ESMTP id 4EF724025E;\n Thu, 14 Mar 2024 03:01:40 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MW5PR13MB5945.namprd13.prod.outlook.com (2603:10b6:303:1aa::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Thu, 14 Mar\n 2024 02:01:37 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024\n 02:01:37 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=JI3EVA0Qy6BluNr40gHdH/cCahs5iWPClV9A415OzZLGHofMgeIUsr/Wnr8QtynNtyOUX8zEGAZa+Wpo3hSDUZt/UmFoTbAqTRqpZhubWFOHvxYPflyIu20PRwaL2P8t/ShQN4yot8FhMplrlwUNm/YifXANAB4GQJxLI6FFQDAyLj29aoLEvEnMhV0imGHj6lc2CvgTncedo4IXA6wC+/CEGUtqexjhCX9GgyddDoYPXUdxZTTfP10v5Tffz/Ig9th3vKGh/3drRoNsxrgabvULU4HSOLkVZOl/hBemCXZchDV9UitO6D0JIvK2vHoB1OSZ5FRCCAxgQd4HFh2T6g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=YA7qu348NPFYoDkNUpqArJelw6K/lAisjUN3QIe3iHM=;\n b=ldGrIolFQQjsqwA8e45I4Kq39Cq9NJUiQX4ZCGzU8eS+cc9kUQXNE0/Kac8eagGSn3Ff3JC6DA3bjjOW/olXeI3TQeHoZ9Xk2VpX9mkOtkat9kkzdYE5U426QNa46xyIvlCvUQFYCrpxsVy6038GSmLutR6V7jYYfoLpIxHqk+k6dDuoOxHMfsNUbNjoRlZsyfqP6fZ0RZEGZLI98Pc2vx3X8LckQPlSKlyxfI5pgEo7Alcwgs4ON2TEvW+wwa0tY74Po93Yw2G0BmOs18JnDrwB/zOlPDMm13UeprZGpDoYxlnVHBk1c9WxqLSl9Tgdp1eyvrCo41bK7U0XSZcK7Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=YA7qu348NPFYoDkNUpqArJelw6K/lAisjUN3QIe3iHM=;\n b=tS/0xUksyGl/aUEh6O0SUyCUP8ZQwhmsSd9Htf1AJez4KBos6wDuagZW0YpTf0u62VDNloHq8n03nSlL2XmOQ6dmLqj/HQqcRWrKckX7bBQkDcafniCF8JnAljGwaYYzwztRKdpxJDYZePgIGX0psgJXlLdqkTV188uJqGLIyZE=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Shihong Wang <shihong.wang@corigine.com>,\n stable@dpdk.org, Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem", "Date": "Thu, 14 Mar 2024 10:00:52 +0800", "Message-Id": "<20240314020052.3107549-1-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240311024939.2523778-2-chaoyong.he@corigine.com>", "References": "<20240311024939.2523778-2-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "PH8PR22CA0009.namprd22.prod.outlook.com\n (2603:10b6:510:2d1::25) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|MW5PR13MB5945:EE_", "X-MS-Office365-Filtering-Correlation-Id": "7a1e5743-cc75-4c76-239c-08dc43caae6b", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n w9xvQcBH9T+oVoRByBjODwi/ZJkD+o05tSPziO7gy2VMjbw0+I/TUEM6OnR3D2qMG0U1BVctg0g4aMcL3q07Ev43ok/Q+EcREw66G2SHwoVYEHIToka2764GHNSPsttXhQD1X4ab+mkSCMfZrJGy5AHGPJc2pQDbUE9h2v6L0MzW3sNMks7IB5uEZn5qXyM9taiSGPMyRCRX9vO4HQ5/hmKWCu6MQbUBBBcLASLb+/k4cIAuvWp9RptBC8yIM1GDJq1pFThZ7Nq6xNSMS02fUVYMAk5hFwN8ZDOQHnwLowfARKKSkVG0RY7epYrqKCsfF5NvG+pHFChtGb/nqYDNfBidk0D0JddFzkUYZimB/0u5Qx9QyTvk/oKrToz8Ig0w2VslQD9zrzSKqS6GHShuuqaXKdDnaV4LObWoAUfvv0UlAPFl8J9O6Shk+R7Bfp3RmgMu3wwyLcwZHihamVxPTi5yb473sZozn5ZdBA9316nLGbHIhll0Gb5MhOLmRhaanURoGliJUxyInWXLujuF1YjWgnc6rdBZcebL/dx/IIg7XxYFGCqJxfgsR/gK0emndneZIGXXebggFbes3r17VTuftCLdmseMx+bN7TrISSdYETYOvmiT7dWIggu/qHTX/JPEEQHh6B+MQiiab/uePaCX/AzyKvLNAwhErQK2wyN/bNeAYrKci3QgXpExd2qBf8rpZ5474FxDoK6jvMdSmbGccBYXF9O5K8tT77u+Cjk=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(52116005)(1800799015)(376005)(38350700005); DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?GVX3YyG8yAPUaGPxb6nA9OL67GmJ?=\n\t=?utf-8?q?EyYuVYHfMMx1rYICsYPvISfP1MBl1GhOFOctsmxKtCfOqxBASkvpOXsYJujtwz+q2?=\n\t=?utf-8?q?7UCw0tEdp/iNZWkH44/kpt9I6uX4Iq/DhCQaajUr5P5vN1FXibbCZyW0z1ywwbV7s?=\n\t=?utf-8?q?0qnq0+rgVV+hDNHIqmRzZc0A14neM70ClgBdlVvBbGWOU5wUPgJ4GZbHIBz1Na9vH?=\n\t=?utf-8?q?fCrF1VCVz8AzH77G5TJUlk3Cl1F1vD51gnfHpv+tbnLDdWRAlkIbDKMrWP1PYr/cy?=\n\t=?utf-8?q?pVWNzfZDY625ucO5tTdD4qQJYQUBg28ux5/N8U1qf52bJcNL9spu8ck5+uuH+NTO6?=\n\t=?utf-8?q?uICAP4kxnTwtjVRjsHEpNfvDtnpt1hzu2h1uxdDn76Wv8ZaTC4v2BYY+BUVcBvylM?=\n\t=?utf-8?q?lYMtL7MWDLZ5OTk+AK/98ckUxNWEMV/nOLRaCuHEieQMSrbZg63ACvEDfhYHtItuZ?=\n\t=?utf-8?q?iD0q3rPi5DtI5C6V4pYmPjo9Bduz9rA3TyhHU+tIZaVUY4FGER2iegpCGe99UbPkG?=\n\t=?utf-8?q?hOd4eZF7CmrXDhqUg5e0EOaTcRHDkInzS4qWsk7cji2c6eVGMkE7FzKE/Zad4MigB?=\n\t=?utf-8?q?slx4OkfOiZD1dncPFXLeT6dhZbDz08mNFaL7NfDjtmZthEhFnoDOu5Ej5gH/Bq3wH?=\n\t=?utf-8?q?EX/LXV3nz9fh+mlIkm49OqEQSsYHuqKesGp+lx8w8jC5gkz0zHOAWxan8yNa2pVX8?=\n\t=?utf-8?q?H2W7yg40OhRiF1xDsmm5MmboK9/aiu8rtUNjc2ISdRNgvfgdGkeMdSavrfYqXGCzL?=\n\t=?utf-8?q?WJlWpUYoWbEyoPCq+6dDh9tQ3Vinpt5c7R+DO0O9hvvuLQuPlOU67fLIyiQQiFPGK?=\n\t=?utf-8?q?tq/oY1ocmyGq0Z7fTHFXsfO3E/9F+UiUd6JIIz3E+6JB8xbVQ+TxBnIoQSZosVCQf?=\n\t=?utf-8?q?6cayQVX/bBEg4E1Y0miJ6iGvHCK3OwrOs9GnseCRHrYbUaJutvdlWEBHl29RU3G43?=\n\t=?utf-8?q?9aB/Xa1UDWnqD1Q0sWL34Gg4fciLEu69Uso+v36lLHhoA0fQnOIy+VmXw4csdTS7Z?=\n\t=?utf-8?q?uciyoCLFX7OT5E3gyOx5w4NmnNwXwDTH6mdRw02lw79o0G0Ei45QQQZ+hvvJacIuu?=\n\t=?utf-8?q?hfHcHHy2UEzxCXzHmE84x04SJcy/lF7iW07fcKxJ08NjEE7ilu3z5RIwjVq+XfLFy?=\n\t=?utf-8?q?x0ODzPVi82/+7avRGDX/44JvONieADr9JjhCzBuWumLe0GhIEzQ+cgfs/4Qv+zArJ?=\n\t=?utf-8?q?kKi+YcR+Me5ORZm1bQds8u5lZANmm78c5BMSrntzzJ3DAp2DfzHPm3WmErAdhYPYV?=\n\t=?utf-8?q?WoJ0lSQABDz5R2NJbcBSnMwcYYLNOnVcFWEqpXCSaswOwvX4bKOtwWjA0FQCF75Vb?=\n\t=?utf-8?q?ibHS3iGZG64lXSbcekEjnxxBwssacgkOYzbYuBuv66xBV2lGqOnG68ECgf7TtJtxf?=\n\t=?utf-8?q?404umTLca9qbFmsA2bZ0/VgWNM+XvA8jJZ1nAcHJWmVHe5DKcaaTytheEWyR4/fsy?=\n\t=?utf-8?q?qDuhYYWigg/mDZ2Itxg+NxX6AmUS0dbsa+qhJFMnvo8IrE8uSsaYGPEx8WrcltEvC?=\n\t=?utf-8?q?xKbA2bK2wzOMzP6F3Sis9xO4Yba4Q8ce9Q=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7a1e5743-cc75-4c76-239c-08dc43caae6b", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Mar 2024 02:01:37.2157 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n MDgCH4RgKVfMX8j66XePE7yNciG22HQxfvhmIxn1TLXMMgB/+GYlJ+1EcWxTLGFb5SgWVHQRRv/LTDud30W5/BOkXHse71jXPiPL38Wy0FA=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW5PR13MB5945", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shihong Wang <shihong.wang@corigine.com>\n\nThe SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s\nvalue is stored in an array of encryption or authentication keys\naccording to big-endian. So it maybe need to convert the endianness\norder to ensure that the value assigned to the SA salt is CPU-endian.\n\nFixes: 50d75cae2a2c (\"examples/ipsec-secgw: initialize SA salt\")\nFixes: 9413c3901f31 (\"examples/ipsec-secgw: support additional algorithms\")\nFixes: 501e9c226adf (\"examples/ipsec-secgw: add AEAD parameters\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shihong Wang <shihong.wang@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\n\n---\nv2:\n* Put the 'memcpy()' call in a singal line as the review comment.\n---\n examples/ipsec-secgw/sa.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c\nindex c4bac17cd7..8aa9aca739 100644\n--- a/examples/ipsec-secgw/sa.c\n+++ b/examples/ipsec-secgw/sa.c\n@@ -374,6 +374,7 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,\n \tuint32_t ti; /*token index*/\n \tuint32_t *ri /*rule index*/;\n \tstruct ipsec_sa_cnt *sa_cnt;\n+\trte_be32_t salt; /*big-endian salt*/\n \tuint32_t cipher_algo_p = 0;\n \tuint32_t auth_algo_p = 0;\n \tuint32_t aead_algo_p = 0;\n@@ -508,8 +509,8 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,\n \t\t\tif (algo->algo == RTE_CRYPTO_CIPHER_AES_CTR) {\n \t\t\t\tkey_len -= 4;\n \t\t\t\trule->cipher_key_len = key_len;\n-\t\t\t\tmemcpy(&rule->salt,\n-\t\t\t\t\t&rule->cipher_key[key_len], 4);\n+\t\t\t\tmemcpy(&salt, &rule->cipher_key[key_len], 4);\n+\t\t\t\trule->salt = rte_be_to_cpu_32(salt);\n \t\t\t}\n \n \t\t\tcipher_algo_p = 1;\n@@ -573,8 +574,8 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,\n \t\t\t\tkey_len -= 4;\n \t\t\t\trule->auth_key_len = key_len;\n \t\t\t\trule->iv_len = algo->iv_len;\n-\t\t\t\tmemcpy(&rule->salt,\n-\t\t\t\t\t&rule->auth_key[key_len], 4);\n+\t\t\t\tmemcpy(&salt, &rule->auth_key[key_len], 4);\n+\t\t\t\trule->salt = rte_be_to_cpu_32(salt);\n \t\t\t}\n \n \t\t\tauth_algo_p = 1;\n@@ -632,8 +633,8 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,\n \n \t\t\tkey_len -= 4;\n \t\t\trule->cipher_key_len = key_len;\n-\t\t\tmemcpy(&rule->salt,\n-\t\t\t\t&rule->cipher_key[key_len], 4);\n+\t\t\tmemcpy(&salt, &rule->cipher_key[key_len], 4);\n+\t\t\trule->salt = rte_be_to_cpu_32(salt);\n \n \t\t\taead_algo_p = 1;\n \t\t\tcontinue;\n", "prefixes": [ "v2" ] }