Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138339/?format=api
{ "id": 138339, "url": "http://patchwork.dpdk.org/api/patches/138339/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240314070536.3169210-3-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314070536.3169210-3-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314070536.3169210-3-chaoyong.he@corigine.com", "date": "2024-03-14T07:05:30", "name": "[2/8] net/nfp: fix string overflow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dcefac954cdcbe53b59f86495635ed4997bffc0d", "submitter": { "id": 2554, "url": "http://patchwork.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240314070536.3169210-3-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31503, "url": "http://patchwork.dpdk.org/api/series/31503/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31503", "date": "2024-03-14T07:05:28", "name": "fix some coverity issues", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31503/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138339/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138339/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F68243CAB;\n\tThu, 14 Mar 2024 08:06:14 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5CDB242E4C;\n\tThu, 14 Mar 2024 08:06:06 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2093.outbound.protection.outlook.com [40.107.220.93])\n by mails.dpdk.org (Postfix) with ESMTP id 1AAAA42E0E;\n Thu, 14 Mar 2024 08:06:02 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by DS0PR13MB6235.namprd13.prod.outlook.com (2603:10b6:8:115::5) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21; Thu, 14 Mar\n 2024 07:06:01 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024\n 07:06:01 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=K4bRI+MWVhR+URdPCKmFLmiOr4VmqkH8L0GqcbCZY9hKz89YFWYXEQfgPQguIKTu3RFw+AaWcQcNtZ7V9c5YMEpRycjkpUsDkKJIUKXOwPIrhVj9V0IJRalAbhw/k4b4+qnGzhdz8fb3RK0LC6UXm/McrGyES4FVMjYpDoncP2O+FH/TPoCfyEthdqtv9gSwcUaPrRoKiYBfPRMhHJ4MqYD6xO6buCuyYVmQhOK7MUnsOjWkNkeJe4x1z+O6lJfPxBKllECLc+//MAnSgv0VKKNeMORZtmIyinvrlnRGjAHQNUDhBWuVi1ApP68ql5ySrmu542B/ozZfQG787Ns2Ow==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=JaFGoOiIoNM8JGn8TyVkhQw/RM+1oIucUqEJ23jhcSA=;\n b=ROXc5A8D8RJPvGLIphXBV2I0yIutM+T1QQieHc5YvdgufzPq+XTe/O2QePID7r4viErYrkIlQqnXFJsVxpO3HmYwrtSChWH5SnlwRK/2L1ITV5C6/xGJ3sA3B6B7k78du85r8B+1IV+haSWn+YyggxG+w33Br7j2hL6NQdwvwe6pE35+oe1kcKytDlGt9/YGcFdzafjip5bY3CNMLbrq3mV0OQO4+xu12js8a3WCG/QFfAFGm4pDOWcAPpQmZXBThmLgK9bLq/iK5LZls/R2QSpodlvhAg8dVOzubjyatmxendUTyDpzKoABffsjRruk9XW6My2hJWfum6xwUrecZQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=JaFGoOiIoNM8JGn8TyVkhQw/RM+1oIucUqEJ23jhcSA=;\n b=c27EmblkK3Vt91dXQkfT7CcCMbPfQIKlTCf9AJJqP1yuqNOM+YjsQawmTECf+3UudT+QDLitxEpYuWjmB9Yk9djD6hZZn7xDF+yrFlwt60O2trRutjro7vbthdU59zLYYSN6JdRk0WXddph45AmntxqcVjSN1POZ7Qd/pwkd4S0=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n long.wu@corigine.com, stable@dpdk.org, Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 2/8] net/nfp: fix string overflow", "Date": "Thu, 14 Mar 2024 15:05:30 +0800", "Message-Id": "<20240314070536.3169210-3-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240314070536.3169210-1-chaoyong.he@corigine.com>", "References": "<20240314070536.3169210-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR06CA0191.apcprd06.prod.outlook.com (2603:1096:4:1::23)\n To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|DS0PR13MB6235:EE_", "X-MS-Office365-Filtering-Correlation-Id": "b9eca307-873a-49a3-00ff-08dc43f53445", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n M8lpKUUDEZxtTdui8BnZJF84x72Bxt8gQ+pZFh6QEbCBD6meChB8c3uY4cQZynT6Dg397ZHyF3usvYe1c5T9QiW/7JP6fdHeHn+RIP3IxpZKa4fvJGsbb/f9vwJR78prJI0SqJ7h1u+bCgVflBCBslBWybQ599UhrASIiL4ZIcqwhUbWRtYf5V9sTyVtZbCPEU53NP5izuMRGYxt3tVi4OunPvnyHKMW9zOzb63PvBVF29NErKI+SVgU8QpDG66vlHEjr06UDa73RyjCAeE3yQ5D8ICayjX5ACW9EckVwy/7EQu+EplQe+jgLrIneIFYKjTDN8DgmEw6gm9lPnebUPj1ERgJF0gRPCE/d2NrS7xfQNoHFmBuzHWr56DqXCKat6P/3yFu5isA6jFs6aE2dBzg6CVTkBTk8lrHbCsfb90eYYarBVPn16yDgftI5H0lhTU4WebEw6oB2ldDVR+7w+xhY3rb4uAl5g2TlmAgfNv+zbWWfjgi/F8wQ0QEEAMBfIKoN8CFai50mwZ/AMPVmrQRw7qSoN9kB4X6dadDup/TNQY9luSaFXXJ0IbLnHLISC5nV1B5N0x+nwiEU/XzpHAGXq4/dZa2Nn5bVKWvGdBe1UaojGJnkweZxCz1q4I/nx5WYOJM1I7TJVQGWJLwcZRYtpZm70LGLRpicBBNqilLC5+KZSMtprQHMCKR5QzADYE+l1quWnXV3KRIXsUR5g==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(376005)(52116005)(1800799015)(38350700005); DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n BC3OIR09O27L3ek4Dw6HtuazxF2PRR+mP9r5TfUxblcyDu678qf5VXHwDkIg/0O04iGhj5gGmJ3DqdOQlGA87u1jbmLrNsyHf7B6dfcWVj8fbnE983VQDJlp/jZkeM3InCJ4CEJk5stOOqeOXaGiwP8+bF7rMPvvVN7XBXpiMWeSEw/kV6D5tgTSw03rO+bn4BjwnArPPHU2IqIqaY6fj5lhuQTu9Qcg2iqeAKphQA5dwVB1Elnsfm2HLON/8viwcW1cNOhjBYKss7+g/A+RWqh+nKL/8SA8WnQxn7oScvOTcEVWWh8DyS+922R6TD7EZhd/TlrWEDpc7OvqfKwoJtgGfMOrYUUA7Wt9rWJGBO/EgO/XsJIBm+rR/VMiFhr+y5HnWNRAlZvSA7kFle6GPVUVo06My6n5H3B4A/DlJmwIgX6m3ot9WR6jzAuF7QYXcabk0p3sL+iklG9YFcTzmZ2Edj9CXnlMjy4w2Tn+TFrnyGQ6uRvPq9yNVRszwDLhQX1MJjJy9JyUOJ9gwe/PfZtxaoWq/bfSoAWVp3KrFTe41vreXtcbQBaW62tviqgUqevUbtKZRhOG+idRYNTgUxuj5bZN1P4EndUgEcDmExSImrZE9vIytrprmH+NBYoP+0nawaymsUxOmZSSc9SI+ZfgiJs3PiDW1C7JkXf4x0D+RzTWJuJoX7xWgmJaZJsg4cGcg4hm2YhK+rSJfHpvKiCbsAMLXDhqFh77qtYheKeXIJuCQKicdmOK+axEgt0Y8GuOICObXP7vaue/swMt0StXVeSTDN8EZU1OgtTQiq2F93EjL+8auDWHtn+pFylvRMfSb4ymcdg/QTOk6ZFqqBHh57HpPjPX+AN4hPWybvPhnOz33ujFk/Gj+ygcZACYoKkP+BskB12S7N3Vhpd+Q10HZrwlI3hfNrtvnM15sSY6oAzQeGHIf9gdCaXSukb98FTLaQwfR4lQc+A5AmLc1zxf09BXmkJg5pObO5VSEKcvSVOilGAiZNfL5QusywQukR1J+zNQV3HW/65kYPO96OinEC0QN/QHT9uGRm8h3DJaD1AlQ1iygc9AIMWHholForKbkb67Zv62dwXzXnrwSR/kW3nyousy1FNvrWW6HkXzkIVdioTlw/3SH3aJu0Wf/DI2AAPkDISMRmc5ramFL2xMdL4mXL7r2ywZrJPK+ou/Kz1XIX4IjRmTYzaq+kNG6em/I3A0q2lF/4RcqJu4j4v2pZfw8eQ1aGM7yoGJWAg0yBSuYBJEy+uSKlJHx93Df09BbzD6mmln2LQauD5tf3BjvUKzdFDHSQ6wkL22jZ9sI1h7LYni8MVKyXWxUtCGWysCq57AWWlyQUWmEaxpyppLcFwz2zbilPHAxNj/SgmS+00NDfaL21yiKHQxk8nFydMHwYlvTYidSgMTZThN3Xkdu8CIDV8j5ODs/tVnyNuUWVMpJn0NZSaUri5YY2stORKLwAOfEE7ommrdtP3x+j3lDZWUJrXVuI6GmvX010AyDBDskVnRcjwo7k9XHSidRK5JNWsRLRRAKw+bFbR2aGATGFYkvZrWOvaVTS9SxNW6bKCLnNHV3dmadjJH0IXDlHmneNjOEXMsUHr7kjnzCg==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b9eca307-873a-49a3-00ff-08dc43f53445", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Mar 2024 07:06:00.6865 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n BBJUQ16StR4DiFE+eQDB6ziaBNBZAKzSeLcqRLdoQNaXBbBbaBH34S3LRrJ2qrS4VcHBhKMz0WgMF2fL+9tKKa7MTrVJV/R0O4Ph3M5h19A=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DS0PR13MB6235", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "CI found in the logic of 'nfp_sync_pci_inner_handle_alloc()', use\n'strcpy()' may cause string overflow, fix it by use 'rte_strlcpy()'.\n\nCoverity issue: 414937\nFixes: 6b4273a03779 (\"net/nfp: add synchronization module\")\nCc: long.wu@corigine.com\nCc: stable@dpdk.org\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfpcore/nfp_sync.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/nfp/nfpcore/nfp_sync.c b/drivers/net/nfp/nfpcore/nfp_sync.c\nindex 8bc38d6585..686cdf8eb1 100644\n--- a/drivers/net/nfp/nfpcore/nfp_sync.c\n+++ b/drivers/net/nfp/nfpcore/nfp_sync.c\n@@ -9,6 +9,7 @@\n #include <rte_malloc.h>\n #include <rte_memzone.h>\n #include <rte_spinlock.h>\n+#include <rte_string_fns.h>\n \n #include \"nfp_logs.h\"\n \n@@ -266,7 +267,7 @@ nfp_sync_pci_inner_handle_alloc(struct nfp_sync *sync,\n \tfor (i = 0; i < NFP_SYNC_PCI_MAX; i++) {\n \t\tif (strlen(sync->pci[i].pci_name) == 0) {\n \t\t\tpci_avail_id = i;\n-\t\t\tstrcpy(sync->pci[pci_avail_id].pci_name, pci_name);\n+\t\t\trte_strlcpy(sync->pci[pci_avail_id].pci_name, pci_name, PCI_PRI_STR_SIZE);\n \t\t\tgoto common_alloc;\n \t\t}\n \t}\n", "prefixes": [ "2/8" ] }