Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138396/?format=api
{ "id": 138396, "url": "http://patchwork.dpdk.org/api/patches/138396/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240314114220.203241-13-igozlan@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240314114220.203241-13-igozlan@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240314114220.203241-13-igozlan@nvidia.com", "date": "2024-03-14T11:42:20", "name": "[13/13] net/mlx5/hws: fix port ID for root matcher and rule", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e1e4a16399846d60c2d7b6697956cb73e3fc4d90", "submitter": { "id": 3118, "url": "http://patchwork.dpdk.org/api/people/3118/?format=api", "name": "Itamar Gozlan", "email": "igozlan@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240314114220.203241-13-igozlan@nvidia.com/mbox/", "series": [ { "id": 31512, "url": "http://patchwork.dpdk.org/api/series/31512/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31512", "date": "2024-03-14T11:42:08", "name": "[01/13] net/mlx5/hws: move warn into debug level when needed", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31512/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138396/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 96DDC43CA5;\n\tThu, 14 Mar 2024 12:44:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 400C042EEC;\n\tThu, 14 Mar 2024 12:43:52 +0100 (CET)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2044.outbound.protection.outlook.com [40.107.94.44])\n by mails.dpdk.org (Postfix) with ESMTP id A3F6C42EE5\n for <dev@dpdk.org>; Thu, 14 Mar 2024 12:43:50 +0100 (CET)", "from CH0PR03CA0043.namprd03.prod.outlook.com (2603:10b6:610:b3::18)\n by IA0PR12MB9009.namprd12.prod.outlook.com (2603:10b6:208:48f::15)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Thu, 14 Mar\n 2024 11:43:48 +0000", "from CH3PEPF00000009.namprd04.prod.outlook.com\n (2603:10b6:610:b3:cafe::86) by CH0PR03CA0043.outlook.office365.com\n (2603:10b6:610:b3::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.43 via Frontend\n Transport; Thu, 14 Mar 2024 11:43:48 +0000", "from mail.nvidia.com (216.228.117.160) by\n CH3PEPF00000009.mail.protection.outlook.com (10.167.244.36) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:47 +0000", "from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar\n 2024 04:43:33 -0700", "from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com\n (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar\n 2024 04:43:33 -0700", "from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend\n Transport; Thu, 14 Mar 2024 04:43:30 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FWBDt1PMFRN7nPEoUTYdLFf5RvFZOwqHRxHqeDVGLnEw8WpD62fOAuftxmPWgGDNh538oA7jGFcyAFYKujJGEThSOib6fKxA6x/sEVP9TDsuR+cvotzsS5bTokiW3Z4OW2aEe4b1YJZUIVPFdJYwB9M1P+cxZnaNTW730EKCz5oOmVCvZ9oSQDkAIM657RMWgALLG4S3n98kaM6Cj+T1a6V9KKt7Q2sHM6eRpAtvSs9vwN9KZBEb0MiWrD3xEv5EK4wclCXOS9icLv6Ikudl9eN2seIZUIl8G6E46Ucz1e6JuBL/DHtCmhwvM+m/fv4kQZSC5PeiCwvnce9i+r7Z+w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=WkJLkVT6q4mJgLKczljKjzsGGIS5yjWX/UCjXUNht28=;\n b=FmSmS5hst54yXHCGXknLyy9DrNXL4P18dgfE8Jq7+k0mP6rg8Vnz8f9MQLClQcyOUSnko6mgKiJ/KWfyQWQOQUopKRtmUPBKaHGDasabscktR9HEzFgAJmhH0jUYWgpht2V2O+S9nsYJPVI33W64z109X0ngKUISDssyd3jO1JYS2lWraRWp8QdwqK0k1mRl/gpJDtBoIV8x1mf65CB48uhlp+rxHq1/NEGhteevdy3jTXeoM2NRe+MqUY4P5n2X+or2QxwqxSgFVOZiNrmRsVeINYWXaWheuW1gy9IRxED6nFTwuVbhG0/Ny7LiELX0+N1NViaa3ovJX15Fws+PmQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=WkJLkVT6q4mJgLKczljKjzsGGIS5yjWX/UCjXUNht28=;\n b=O+1kXy3yC5whRVapClBTvqYCdZ/5WJgwMMlfRfjf6UJdlWZKrIaV/1PgAYAOO1H20exhx70dB33XNa4ZgCs9aqVFmTxM/Rh7Q6GIm9k75cP6/kivzzNBB6I8q4JVlcuBfUdBP/xmMjCGA0tmvys2/2Tsnka8GWi/cmWdFGowGhS50GsDwICCwKtoFVy4sTvn87O2nQBg4QyXzijTefPDKpa7O/wwC2FAH6prvrcejj1SYuPlWt5GfmwpfeFt0Wr44/RM1BNPKFzGZDzGQZ2LVQk0cFSJbCKr+atnt7/BeuY9bo2xOfpB4xWocIN6YYNx+2tY5QpMOMqXksllhaMzxA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Itamar Gozlan <igozlan@nvidia.com>", "To": "<igozlan@nvidia.com>, <erezsh@nvidia.com>, <hamdani@nvidia.com>,\n <kliteyn@nvidia.com>, <valex@nvidia.com>, <viacheslavo@nvidia.com>,\n <thomas@monjalon.net>, Dariusz Sosnowski <dsosnowski@nvidia.com>, Ori Kam\n <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>, Matan Azrad\n <matan@nvidia.com>", "CC": "<dev@dpdk.org>, <mkashani@nvidia.com>", "Subject": "[PATCH 13/13] net/mlx5/hws: fix port ID for root matcher and rule", "Date": "Thu, 14 Mar 2024 13:42:20 +0200", "Message-ID": "<20240314114220.203241-13-igozlan@nvidia.com>", "X-Mailer": "git-send-email 2.39.3", "In-Reply-To": "<20240314114220.203241-1-igozlan@nvidia.com>", "References": "<20240314114220.203241-1-igozlan@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH3PEPF00000009:EE_|IA0PR12MB9009:EE_", "X-MS-Office365-Filtering-Correlation-Id": "a011d9a4-0e16-4c20-f796-08dc441c0308", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ryyKoR0kTV8m2A8aIhYIo5ExkLyQQs5IgVlsBKpfd7V8rCkCPupDJmxkQXs7jV7bgVcRRUg0hOTC9qTkA2l4yXA7opqaTheZmcDaVSDVL+qi9idlvQ+RpXfPgqDonhXhUO7BxNWw0eGtDIEW+fJRT78MbNKPciG1oRA4hrRPz6/VdTioNeXU18y3oyvGnc+knvpDQ971Py9a2E7n2Wk81X6/OL482bCKV9Tmyt3q3QjHJqL2Xo4+LcmN/gYjTgBz/ALDlfiCsyOJmGDKPvkoOaoBjPwGSy1o4oecAGWUtydrrSkzf0QTxMzvNnP18fN/MVDTTI0rg0jut0Aor2hVVL+kGgw9UordA/6K1hiF1383c9liafP3K8Z6LUXeJ2zQ4GOlaPSmiBMcH2Wzcph3YI39OrXPYBKGzVWlBGQwun1qXqDuizh61g9t+OyKarSLoa2ThU2lWbYdp/TJonHyywLCEiPpV1WptMQwPk4Ams2bJRwvo34CyU6V7NcMQ7DkddZ26sHq+rLk4mMCIuujFxTR3xtF5TMZBtbFOc/jnNtL8GkuwFTGDmsLyKbW8WhdefwiDrHTc/X777EXt9os9FnKjgSD95wVDcA8cGLV5yoQM3TLfh0mrjGjS9r1evvrzzafjTTuC9vkCUnzHtSaL178lzEDUrAgbrrRZECMwca1s1pRirha0vO+oggW8v9Uu9phCFXFjl8Hnjj0OXJIswc72cSze2Qrx6Ib3a+s7arBS/TUg/vZpBCLHPlHWp9w1xMzeJ+mMSLb1/ZoJjNpng==", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004)(921011);\n DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Mar 2024 11:43:47.8897 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a011d9a4-0e16-4c20-f796-08dc441c0308", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CH3PEPF00000009.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "IA0PR12MB9009", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Erez Shitrit <erezsh@nvidia.com>\n\nIn root tables matcher and rule need to have their port-id, otherwise\nthe translate function that done in dpdk layer will not get the right\nattributes.\nFor that whenever the matcher is matching the source-port we need to get\nthe relevant port-id before calling the translate function.\n\nFixes: 405242c52dd5 (\"net/mlx5/hws: add rule object\")\nSigned-off-by: Erez Shitrit <erezsh@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/hws/mlx5dr_matcher.c | 17 +++++++++++++++++\n drivers/net/mlx5/hws/mlx5dr_rule.c | 18 ++++++++++++++++++\n drivers/net/mlx5/mlx5_flow.h | 18 ++++++++++++++++++\n 3 files changed, 53 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c\nindex 78d525e578..394244b55b 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_matcher.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c\n@@ -1227,6 +1227,7 @@ static int mlx5dr_matcher_init_root(struct mlx5dr_matcher *matcher)\n \tstruct mlx5dv_flow_match_parameters *mask;\n \tstruct mlx5_flow_attr flow_attr = {0};\n \tstruct rte_flow_error rte_error;\n+\tstruct rte_flow_item *item;\n \tuint8_t match_criteria;\n \tint ret;\n \n@@ -1255,6 +1256,22 @@ static int mlx5dr_matcher_init_root(struct mlx5dr_matcher *matcher)\n \t\treturn rte_errno;\n \t}\n \n+\t/* We need the port id in case of matching representor */\n+\titem = matcher->mt[0].items;\n+\twhile (item->type != RTE_FLOW_ITEM_TYPE_END) {\n+\t\tif (item->type == RTE_FLOW_ITEM_TYPE_PORT_REPRESENTOR ||\n+\t\t item->type == RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT) {\n+\t\t\tret = flow_hw_get_port_id_from_ctx(ctx, &flow_attr.port_id);\n+\t\t\tif (ret) {\n+\t\t\t\tDR_LOG(ERR, \"Failed to get port id for dev %s\",\n+\t\t\t\t ctx->ibv_ctx->device->name);\n+\t\t\t\trte_errno = EINVAL;\n+\t\t\t\treturn rte_errno;\n+\t\t\t}\n+\t\t}\n+\t\t++item;\n+\t}\n+\n \tmask = simple_calloc(1, MLX5_ST_SZ_BYTES(fte_match_param) +\n \t\t\t offsetof(struct mlx5dv_flow_match_parameters, match_buf));\n \tif (!mask) {\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c\nindex d56677a1a5..5dae4f3442 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_rule.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_rule.c\n@@ -692,10 +692,28 @@ static int mlx5dr_rule_create_root(struct mlx5dr_rule *rule,\n \tstruct mlx5dv_flow_match_parameters *value;\n \tstruct mlx5_flow_attr flow_attr = {0};\n \tstruct mlx5dv_flow_action_attr *attr;\n+\tconst struct rte_flow_item *cur_item;\n \tstruct rte_flow_error error;\n \tuint8_t match_criteria;\n \tint ret;\n \n+\t/* We need the port id in case of matching representor */\n+\tcur_item = items;\n+\twhile (cur_item->type != RTE_FLOW_ITEM_TYPE_END) {\n+\t\tif (cur_item->type == RTE_FLOW_ITEM_TYPE_PORT_REPRESENTOR ||\n+\t\t cur_item->type == RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT) {\n+\t\t\tret = flow_hw_get_port_id_from_ctx(rule->matcher->tbl->ctx,\n+\t\t\t\t\t\t\t &flow_attr.port_id);\n+\t\t\tif (ret) {\n+\t\t\t\tDR_LOG(ERR, \"Failed to get port id for dev %s\",\n+\t\t\t\t rule->matcher->tbl->ctx->ibv_ctx->device->name);\n+\t\t\t\trte_errno = EINVAL;\n+\t\t\t\treturn rte_errno;\n+\t\t\t}\n+\t\t}\n+\t\t++cur_item;\n+\t}\n+\n \tattr = simple_calloc(num_actions, sizeof(*attr));\n \tif (!attr) {\n \t\trte_errno = ENOMEM;\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 34b5e0f45b..e435a686fd 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -2001,6 +2001,24 @@ flow_hw_get_reg_id(struct rte_eth_dev *dev,\n #endif\n }\n \n+static __rte_always_inline int\n+flow_hw_get_port_id_from_ctx(void *dr_ctx, uint32_t *port_val)\n+{\n+\tuint32_t port;\n+\n+\tMLX5_ETH_FOREACH_DEV(port, NULL) {\n+\t\tstruct mlx5_priv *priv;\n+\t\tpriv = rte_eth_devices[port].data->dev_private;\n+\n+\t\tif (priv->dr_ctx == dr_ctx) {\n+\t\t\t*port_val = port;\n+\t\t\treturn 0;\n+\t\t}\n+\t}\n+\n+\treturn -EINVAL;\n+}\n+\n /**\n * Get GENEVE TLV option FW information according type and class.\n *\n", "prefixes": [ "13/13" ] }