Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138442/?format=api
{ "id": 138442, "url": "http://patchwork.dpdk.org/api/patches/138442/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240318091848.14360-3-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240318091848.14360-3-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240318091848.14360-3-fengchengwen@huawei.com", "date": "2024-03-18T09:18:44", "name": "[v3,2/6] argparse: remove dead code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "91c68a052491f45004629993c0b5d57594588d22", "submitter": { "id": 2146, "url": "http://patchwork.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240318091848.14360-3-fengchengwen@huawei.com/mbox/", "series": [ { "id": 31542, "url": "http://patchwork.dpdk.org/api/series/31542/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31542", "date": "2024-03-18T09:18:44", "name": "refine argparse library", "version": 3, "mbox": "http://patchwork.dpdk.org/series/31542/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138442/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138442/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D4A143CE2;\n\tMon, 18 Mar 2024 10:20:43 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8A20F4027F;\n\tMon, 18 Mar 2024 10:20:43 +0100 (CET)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id A63C34027F\n for <dev@dpdk.org>; Mon, 18 Mar 2024 10:20:41 +0100 (CET)", "from mail.maildlp.com (unknown [172.19.88.105])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Tyq6J3ZJgzNmBx;\n Mon, 18 Mar 2024 17:18:48 +0800 (CST)", "from dggpeml500024.china.huawei.com (unknown [7.185.36.10])\n by mail.maildlp.com (Postfix) with ESMTPS id 9104014011F;\n Mon, 18 Mar 2024 17:20:39 +0800 (CST)", "from localhost.localdomain (10.50.165.33) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.1.2507.35; Mon, 18 Mar 2024 17:20:39 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <david.marchand@redhat.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH v3 2/6] argparse: remove dead code", "Date": "Mon, 18 Mar 2024 09:18:44 +0000", "Message-ID": "<20240318091848.14360-3-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240318091848.14360-1-fengchengwen@huawei.com>", "References": "<20240220131502.47510-1-fengchengwen@huawei.com>\n <20240318091848.14360-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The judgement \"obj->callback == NULL\" is dead code which can't be\nreached, because verify_arg_saver() already make sure obj->callback\nmust not be NULL when arg->val_saver is NULL.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n app/test/test_argparse.c | 7 -------\n lib/argparse/rte_argparse.c | 6 ------\n 2 files changed, 13 deletions(-)", "diff": "diff --git a/app/test/test_argparse.c b/app/test/test_argparse.c\nindex df11a129ba..c98bcee56d 100644\n--- a/app/test/test_argparse.c\n+++ b/app/test/test_argparse.c\n@@ -288,13 +288,6 @@ test_argparse_invalid_arg_flags(void)\n \tret = rte_argparse_parse(obj, default_argc, default_argv);\n \tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n \n-\tobj = test_argparse_init_obj();\n-\tobj->args[0].val_saver = NULL;\n-\tobj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_SUPPORT_MULTI;\n-\tobj->callback = NULL;\n-\tret = rte_argparse_parse(obj, default_argc, default_argv);\n-\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n-\n \treturn 0;\n }\n \ndiff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c\nindex 48738cd07b..6e890cdc0d 100644\n--- a/lib/argparse/rte_argparse.c\n+++ b/lib/argparse/rte_argparse.c\n@@ -195,12 +195,6 @@ verify_arg_flags(const struct rte_argparse *obj, uint32_t index)\n \t\treturn -EINVAL;\n \t}\n \n-\tif (obj->callback == NULL) {\n-\t\tARGPARSE_LOG(ERR, \"argument %s should use callback to parse, but callback is NULL!\",\n-\t\t\t arg->name_long);\n-\t\treturn -EINVAL;\n-\t}\n-\n \treturn 0;\n }\n \n", "prefixes": [ "v3", "2/6" ] }