Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138448/?format=api
{ "id": 138448, "url": "http://patchwork.dpdk.org/api/patches/138448/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240318092109.87656-1-shperetz@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240318092109.87656-1-shperetz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240318092109.87656-1-shperetz@nvidia.com", "date": "2024-03-18T09:21:09", "name": "app/testpmd: fix auto completion for indirect list action", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f7dbc5664a217d97e034d1e062f8b568f1df77f4", "submitter": { "id": 3290, "url": "http://patchwork.dpdk.org/api/people/3290/?format=api", "name": "Shani Peretz", "email": "shperetz@nvidia.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240318092109.87656-1-shperetz@nvidia.com/mbox/", "series": [ { "id": 31543, "url": "http://patchwork.dpdk.org/api/series/31543/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31543", "date": "2024-03-18T09:21:09", "name": "app/testpmd: fix auto completion for indirect list action", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31543/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138448/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138448/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4403A43CE2;\n\tMon, 18 Mar 2024 11:49:36 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0EC3E4027F;\n\tMon, 18 Mar 2024 11:49:36 +0100 (CET)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])\n by mails.dpdk.org (Postfix) with ESMTP id A0EE64027F\n for <dev@dpdk.org>; Mon, 18 Mar 2024 10:21:38 +0100 (CET)", "from CH0P220CA0007.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:ef::15)\n by SA3PR12MB8762.namprd12.prod.outlook.com (2603:10b6:806:31f::9) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.25; Mon, 18 Mar\n 2024 09:21:36 +0000", "from CH2PEPF00000149.namprd02.prod.outlook.com\n (2603:10b6:610:ef:cafe::6e) by CH0P220CA0007.outlook.office365.com\n (2603:10b6:610:ef::15) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36 via Frontend\n Transport; Mon, 18 Mar 2024 09:21:35 +0000", "from mail.nvidia.com (216.228.118.232) by\n CH2PEPF00000149.mail.protection.outlook.com (10.167.244.106) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7409.10 via Frontend Transport; Mon, 18 Mar 2024 09:21:35 +0000", "from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com\n (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 18 Mar\n 2024 02:21:30 -0700", "from drhqmail202.nvidia.com (10.126.190.181) by\n drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Mon, 18 Mar 2024 02:21:29 -0700", "from nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.181)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend\n Transport; Mon, 18 Mar 2024 02:21:27 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=B5xf6X9QbJIQNM94nJi4x8SFqD1dR5M9d3QLScSSYWt0IjLc5P/1a4cPgye/p3JbgYwpPhNsB6G3VZTkbNSkhe5gn/KuG953Uy3NiD7jOGzYKYlLnEQT6t0xNhieAqyRKNgO7CUyTYmeiCHuG2KUyDgb6TGW+Xf/2xWbJZFE5C6GPAGxI+oq8/bp6altOeeFF29v/9XewvngLg9uVBSr8U+i1USyz65khV7tIfRFIjD2uQf50xPpQKk0aE9OQrFETECeWzoB9feqAuzD4MSYC01oeqlsnRwy3v4C1fWiA6MhFeLjKwuBmFSbGk3yQtdSr4xfVY/jm4k2HmFZOWVFGQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=wlO4CL+Uh8kfUjVqBGzbs8ElbpTHRZSaYn+PyX6tg+Y=;\n b=i1xiHxHVsrMlhL9PByt78hHAINPBXFepPEOrAMOH077hDGFE9d6MB8vOH8e5O/+DXOdlVC/8Oy1pk7OwxpNp8birJG62eiASN5DWiOzHQ4zxqLe9w4EPkM8AmgCajKGmWC3maObC39dtTIGokrXJV5NDinTHAyUtZJFZ/qExvuNaXYVRZ1bgbxcnHASnziZBP35NJYlNAsu6bDaNh9C5hNeda3/J/55VU/8c3MmubfTc6TY8Gd/YK3tSKyb7XSfs+9a44SnLezfBfCIiOngiUo/Ph7M0tqqjg35gIQjEoCVfdA3UQP73nXhBFSeBdvlMjw6eVAndS++CRUMsysSrmQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.118.232) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=wlO4CL+Uh8kfUjVqBGzbs8ElbpTHRZSaYn+PyX6tg+Y=;\n b=Xi68o1AMZwuULIxdb/nz6zcu8yZ1sdxB1yjpgx78NlOGwzzPm2Qck2qZl6Oq5ALqEIWvOPLgbpQmUhSXzMk0Nyp+BEooIxruwaU3RDZJxKoXLi4fOA2ZJsKYz4Dp9+5iew2f9IsIRLYpjdDxd/Cq0CDrWUQwVVLYCEMYXGVv/FWc4QTuu9gebhvm/TuvslbQ1CWilHsX2Kh7c714hUVGbHLnSI+qq+IMQrktR3YgusXUbwo864gB2zKLVw1ENWcuwdueOspNGU12+DaELHI/QyYnIx2hkM2sdXodnwUHl8BD+QsKQAEDU8tRO35tGbd408Ya7k12TSKfSuFSEqnd4w==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.118.232)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.118.232 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C", "From": "Shani Peretz <shperetz@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<shperetz@nvidia.com>, <mkashani@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang\n <yuying.zhang@intel.com>, Gregory Etelson <getelson@nvidia.com>", "Subject": "[PATCH] app/testpmd: fix auto completion for indirect list action", "Date": "Mon, 18 Mar 2024 11:21:09 +0200", "Message-ID": "<20240318092109.87656-1-shperetz@nvidia.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH2PEPF00000149:EE_|SA3PR12MB8762:EE_", "X-MS-Office365-Filtering-Correlation-Id": "2ab9a687-5587-4deb-75b0-08dc472ccf28", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n h1pUIGji2mDS6y6p5tUv6l26OafSRylnc+2m06Xg6+oBTnXCqkAPVdYrImGxp2BEB23zAQg2JKapDLejW9zIfOC7Tv8ZbqQBKOC6NjRhAiCVs9vipCajYHDSUbU2XQtliKQxceKYHh37ctCt76V4XLgzq3D9S+yfvH3PGgMUwUa3//ssAns6LGQ/Fb7Kwep2y1MdNvrC5oRiUwGKlUfqio1UZA+llYqFStymv3nvEaB/BCdFHJ1Ansim+0oVIZHgvb0d6S1BZqEDqxMlm0aOuTHnOxyfVQWnm6Q5aV0cojluwjMLgmEX5WtVIHIcxBlA4u2xM/sHFG2IrIQDCLLKkEvRNCsqztDC318r8Z63LTELaH0i/9A7UK8JDAk7/3PyJKWEYoZORsIm9rtInROK3VnubnhekP0T5oU5FTcr6D/y6h+l8Ck4HJntDzTi7ct1apNgKEfiQG4RFcasseZL71hi5fxItUiB3j1Gr4miuDCzW1zNX8QpUBYXr0rsUt6INl4+XTacY2T9RglgkSL03ta4gw3xdLCArY+QAEAT7sZYNysv1clro0ljZQq+wXXiYHSb7VUo1P1TCBy2V268sxVbNx3c99vmboAZ2+9Lp9ttWh0GAXVXAcv8gjOk+Q43+vU+tY8zJk+ECBa+GsLA22jDWNGh+laNUP4G3ryiTxhUMR+loBGiYLXIT+j+6wjxWVw5NSk8pzT0c+RE7H0uEafxmjYuAthtpAZKeKVz5sXsrwyvK6KEi/sopZi020kR", "X-Forefront-Antispam-Report": "CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(376005)(36860700004)(82310400014)(1800799015); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Mar 2024 09:21:35.7873 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 2ab9a687-5587-4deb-75b0-08dc472ccf28", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CH2PEPF00000149.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA3PR12MB8762", "X-Mailman-Approved-At": "Mon, 18 Mar 2024 11:49:35 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In the process of auto completion of a command in testpmd,\nthe parser splits the command into tokens, where each token\nrepresents an argument and defines a parsing function.\nThe parsing function of the indirect_list action argument was returning\nbefore having the opportunity to handle the argument.\n\nThe fix ensures that the function appropriately handles\nthe argument before finishing.\n\nFixes: 72a3dec7126f (\"ethdev: add indirect flow list action\")\n\nSigned-off-by: Shani Peretz <shperetz@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 46 ++++++++++++++++++++-----------------\n 1 file changed, 25 insertions(+), 21 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex fd6c51f72d..60ee9337cf 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -7839,11 +7839,13 @@ static const struct token token_list[] = {\n \t\t.type = \"UNSIGNED\",\n \t\t.help = \"unsigned integer value\",\n \t\t.call = parse_indlst_id2ptr,\n+\t\t.comp = comp_none,\n \t},\n \t[INDIRECT_LIST_ACTION_ID2PTR_CONF] = {\n \t\t.type = \"UNSIGNED\",\n \t\t.help = \"unsigned integer value\",\n \t\t.call = parse_indlst_id2ptr,\n+\t\t.comp = comp_none,\n \t},\n \t[ACTION_SHARED_INDIRECT] = {\n \t\t.name = \"shared_indirect\",\n@@ -11912,34 +11914,36 @@ parse_indlst_id2ptr(struct context *ctx, const struct token *token,\n \tuint32_t id;\n \tint ret;\n \n-\tif (!action)\n-\t\treturn -1;\n \tctx->objdata = 0;\n \tctx->object = &id;\n \tctx->objmask = NULL;\n \tret = parse_int(ctx, token, str, len, ctx->object, sizeof(id));\n+\tctx->object = action;\n \tif (ret != (int)len)\n \t\treturn ret;\n-\tctx->object = action;\n-\taction_conf = (void *)(uintptr_t)action->conf;\n-\taction_conf->conf = NULL;\n-\tswitch (ctx->curr) {\n-\tcase INDIRECT_LIST_ACTION_ID2PTR_HANDLE:\n-\taction_conf->handle = (typeof(action_conf->handle))\n-\t\t\t\tport_action_handle_get_by_id(ctx->port, id);\n-\t\tif (!action_conf->handle) {\n-\t\t\tprintf(\"no indirect list handle for id %u\\n\", id);\n-\t\t\treturn -1;\n+\n+\t/* set handle and conf */\n+\tif (action) {\n+\t\taction_conf = (void *)(uintptr_t)action->conf;\n+\t\taction_conf->conf = NULL;\n+\t\tswitch (ctx->curr) {\n+\t\tcase INDIRECT_LIST_ACTION_ID2PTR_HANDLE:\n+\t\taction_conf->handle = (typeof(action_conf->handle))\n+\t\t\t\t\tport_action_handle_get_by_id(ctx->port, id);\n+\t\t\tif (!action_conf->handle) {\n+\t\t\t\tprintf(\"no indirect list handle for id %u\\n\", id);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\tbreak;\n+\t\tcase INDIRECT_LIST_ACTION_ID2PTR_CONF:\n+\t\t\tindlst_conf = indirect_action_list_conf_get(id);\n+\t\t\tif (!indlst_conf)\n+\t\t\t\treturn -1;\n+\t\t\taction_conf->conf = (const void **)indlst_conf->conf;\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tbreak;\n \t\t}\n-\t\tbreak;\n-\tcase INDIRECT_LIST_ACTION_ID2PTR_CONF:\n-\t\tindlst_conf = indirect_action_list_conf_get(id);\n-\t\tif (!indlst_conf)\n-\t\t\treturn -1;\n-\t\taction_conf->conf = (const void **)indlst_conf->conf;\n-\t\tbreak;\n-\tdefault:\n-\t\tbreak;\n \t}\n \treturn ret;\n }\n", "prefixes": [] }