Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138470/?format=api
{ "id": 138470, "url": "http://patchwork.dpdk.org/api/patches/138470/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240318183233.142330-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240318183233.142330-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240318183233.142330-6-stephen@networkplumber.org", "date": "2024-03-18T18:30:06", "name": "[v8,5/5] eal: initialize logging before plugins", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e94f9ea10e7cd8b4d5ecb24a0b81aa32612bb185", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240318183233.142330-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 31549, "url": "http://patchwork.dpdk.org/api/series/31549/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31549", "date": "2024-03-18T18:30:01", "name": "Logging timestamp and related patches", "version": 8, "mbox": "http://patchwork.dpdk.org/series/31549/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138470/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/138470/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E39D443CE8;\n\tMon, 18 Mar 2024 19:33:20 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7A7B540DCD;\n\tMon, 18 Mar 2024 19:32:54 +0100 (CET)", "from mail-oi1-f179.google.com (mail-oi1-f179.google.com\n [209.85.167.179])\n by mails.dpdk.org (Postfix) with ESMTP id E66F0406B4\n for <dev@dpdk.org>; Mon, 18 Mar 2024 19:32:48 +0100 (CET)", "by mail-oi1-f179.google.com with SMTP id\n 5614622812f47-3c19aaedfdaso2635673b6e.2\n for <dev@dpdk.org>; Mon, 18 Mar 2024 11:32:48 -0700 (PDT)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n x6-20020aa784c6000000b006e4e93f4f17sm8186593pfn.117.2024.03.18.11.32.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Mar 2024 11:32:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1710786768;\n x=1711391568; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3FYikwK1xwpaJxKVUawI2osEKSAMSAZcBjVrL37SoHo=;\n b=YdVGC2BItv4sF20G0l+ULP7m1CTnU+STnP8h1cDjCSrRgXgTocukzcRE2ZRPk+iqwI\n AnUvw+QQya0lOA4XNTrVPCl29WIf4UkwbkEE8c4ZKg1itUziVduP5Fb91A1C6UOMRkhW\n KrWL1nVaxOvEq3IbI9Hbb1V58OiZLiH7iJQsCqzxZvwpZ1ZIiwuv8bPGfZoxL2ere4YA\n elsa22Q4phW14Zf+lCtvaUVR4hNvP053FNrHErx1QEZIgBVFHUjGzS7CtGIJei5zx0fd\n xhGMi4Pc3gYSBaG52aHztIRsgJwDm3VBdamVT0ZE5F6NPrUs1IeDmbQv/j33rDbPQwbJ\n EIcA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1710786768; x=1711391568;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=3FYikwK1xwpaJxKVUawI2osEKSAMSAZcBjVrL37SoHo=;\n b=tJ5G3WbbDiEVBlI4NkUW5I/fzuWIOQ4dlxDQHVLjw38+OQpfrJY0jSIItpsCI8YEG7\n rUAJJsqtEgzPrlW0HW5jEuvWXze7uohrpVkQFYIeIAi9c98qIbaZK3O5Ro8+JVxElSGt\n C8v69sxiAa4Xs6WKeBXFhTSan9dMD9vwfTjRNdNt/7P+ayXtYRi/w1QioQWYS+gqpAzh\n 1X+vwcRwrV/z3CgK6uJE9wr/PMJc4Ro3A8xsIgXUwwsKm9TBVUTLOMwuWfcIp3gngDD6\n zcC1PTyNWrJ4UG4f65O+I4B0WEb6aojh18TTpZF1YjpyIQarToBqk/STjknwM1hZh1LR\n oZnw==", "X-Gm-Message-State": "AOJu0YyKEz0ByOiuWGs3S/4W1st8tdQKXr/9bLznJ4/S0xLZPChAXrHX\n 8j2GyV8gfmLcA68qCzBYtfT4dedvVUx/yBErUWEsvHtacWRe1a4V7yyZOV9YukmFTSj89SiCQVT\n R", "X-Google-Smtp-Source": "\n AGHT+IHtOpaiFIkpZenvb0Qz2zevPnfqU1vGqH9xpYhDG7gQzP2VgUSf+ULAWdwf71NW8YtFBKOWHQ==", "X-Received": "by 2002:a05:6870:8304:b0:220:65ba:ca3a with SMTP id\n p4-20020a056870830400b0022065baca3amr15519303oae.14.1710786768325;\n Mon, 18 Mar 2024 11:32:48 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v8 5/5] eal: initialize logging before plugins", "Date": "Mon, 18 Mar 2024 11:30:06 -0700", "Message-ID": "<20240318183233.142330-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240318183233.142330-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240318183233.142330-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Want to make sure that as many log messages as possible\nget added with the real log stream.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/freebsd/eal.c | 16 ++++++++--------\n lib/eal/linux/eal.c | 16 ++++++++--------\n lib/eal/unix/eal_unix_log.c | 0\n 3 files changed, 16 insertions(+), 16 deletions(-)\n create mode 100644 lib/eal/unix/eal_unix_log.c", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex b4f8d68b0a65..e4f00f31fbdd 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -592,6 +592,14 @@ rte_eal_init(int argc, char **argv)\n \t\tinternal_conf->in_memory = false;\n \t}\n \n+\tif (eal_log_init(program_invocation_short_name,\n+\t\t\t internal_conf->syslog_facility) < 0) {\n+\t\trte_eal_init_alert(\"Cannot init logging.\");\n+\t\trte_errno = ENOMEM;\n+\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n+\t\treturn -1;\n+\t}\n+\n \tif (eal_plugins_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot init plugins\");\n \t\trte_errno = EINVAL;\n@@ -718,14 +726,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\tif (eal_log_init(program_invocation_short_name,\n-\t\t\t internal_conf->syslog_facility) < 0) {\n-\t\trte_eal_init_alert(\"Cannot init logging.\");\n-\t\trte_errno = ENOMEM;\n-\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n-\t\treturn -1;\n-\t}\n-\n \t/* in secondary processes, memory init may allocate additional fbarrays\n \t * not present in primary processes, so to avoid any potential issues,\n \t * initialize memzones first.\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex bffeb1f34eb9..e24f24b1b0ce 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -973,6 +973,14 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n+\tif (eal_log_init(program_invocation_short_name,\n+\t\t\t internal_conf->syslog_facility) < 0) {\n+\t\trte_eal_init_alert(\"Cannot init logging.\");\n+\t\trte_errno = ENOMEM;\n+\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n+\t\treturn -1;\n+\t}\n+\n \tif (eal_plugins_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot init plugins\");\n \t\trte_errno = EINVAL;\n@@ -1107,14 +1115,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\tif (eal_log_init(program_invocation_short_name,\n-\t\t\t internal_conf->syslog_facility) < 0) {\n-\t\trte_eal_init_alert(\"Cannot init logging.\");\n-\t\trte_errno = ENOMEM;\n-\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n-\t\treturn -1;\n-\t}\n-\n #ifdef VFIO_PRESENT\n \tif (rte_eal_vfio_setup() < 0) {\n \t\trte_eal_init_alert(\"Cannot init VFIO\");\ndiff --git a/lib/eal/unix/eal_unix_log.c b/lib/eal/unix/eal_unix_log.c\nnew file mode 100644\nindex 000000000000..e69de29bb2d1\n", "prefixes": [ "v8", "5/5" ] }