Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138474/?format=api
{ "id": 138474, "url": "http://patchwork.dpdk.org/api/patches/138474/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240318220432.7486-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240318220432.7486-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240318220432.7486-4-stephen@networkplumber.org", "date": "2024-03-18T22:02:59", "name": "[v9,3/5] eal: initialize logging before plugins", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bff80b5a8e4894cc6a37d8cd5bbae6a808cb0a42", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240318220432.7486-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 31551, "url": "http://patchwork.dpdk.org/api/series/31551/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31551", "date": "2024-03-18T22:02:56", "name": "Logging unification and timestamp", "version": 9, "mbox": "http://patchwork.dpdk.org/series/31551/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138474/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138474/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 616FE43CEE;\n\tMon, 18 Mar 2024 23:05:04 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3FD1640A79;\n\tMon, 18 Mar 2024 23:04:50 +0100 (CET)", "from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180])\n by mails.dpdk.org (Postfix) with ESMTP id E303640A6E\n for <dev@dpdk.org>; Mon, 18 Mar 2024 23:04:47 +0100 (CET)", "by mail-pf1-f180.google.com with SMTP id\n d2e1a72fcca58-6e7224cb3f2so1116993b3a.1\n for <dev@dpdk.org>; Mon, 18 Mar 2024 15:04:47 -0700 (PDT)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n y6-20020a637d06000000b005dc88b232a5sm7747140pgc.26.2024.03.18.15.04.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Mar 2024 15:04:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1710799487;\n x=1711404287; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=h26vCz6XxR4JOVNqKDtIA/aTK4iPIJYOD/gXXJVesxQ=;\n b=rB0bjqdo14vmEsGmQZkiZyzF82a4e4KkjPFJWZkyFk2CrpeVXVAxjPmJ2jhvEs9YKM\n 4HDJYdrbcsXzwAN6V8KyJKq1nyG9zGgm7xQcpcyuPY0Po7OIKY6V3OJ4s/NhYGUleYgi\n bnEdbUamkkXQpOockx5YJfiMvxNmRn4VZba6p7KrmADwBwG4CmSf433lgobl6R78MfaW\n 1UALFG9KByzwq10BEc0AEd1S8kINUs6c/ja9xbhdUm/Sv5UE1BfLA/0LUBjq8jzqqxpd\n ucaFtQO5h3SpFijc2uoAWH4WkQDVHiF7mxQTZcos7Bv45VOfZUl2tLHb0tCVQvahUuWF\n oB4A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1710799487; x=1711404287;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=h26vCz6XxR4JOVNqKDtIA/aTK4iPIJYOD/gXXJVesxQ=;\n b=I76z6JEjvWlmHjK/MZyzs+cYNSCPHgVdLUrDoIIOK/FYCxbeSSDyswI/FqjinTCWLU\n 7kAhb4CM4bCwrzI3HErf/vH2Ql0QkK94fvH+fjEZAnMUSi/284jTgZqUZRXXP9axCmOO\n 7E/InwfVlk2W7GXU2aV2O5yXolmdUsHqeRlIT1aT4pIN/Fx+Nr7atUwr5cYer7jP8dc3\n LMmAAjMI7wO1hVTZxzZzbst+SnJWb4onJ6L9oNlDhpKX1X6cF1OaU/0ahGxRCpiEhCAV\n xvANz1olzJdZ+WcNCNX6O4Uqc+uqZcV/EnInlSw5f9cH3HfZc89UxCMMBCMtPylfGTr4\n Fn4w==", "X-Gm-Message-State": "AOJu0Yz4Ex1HRMYnDWKKDwJS/meCxr2MgDEHp5+Eoc1vtyTWISu0WlVs\n c2FVFG2oWwDIBg1SROTWTny8UmuE2k2hJRQgttaodWLCA7D6Ce4aybi/oqXQw+jyQ0h0+9cB9l7\n O", "X-Google-Smtp-Source": "\n AGHT+IGG7Mhk7kuaVzqv+0GJ6n5abA1/SkcPzn1eVlUEutzuhD1Nw/3IJIIj2coCrEpjZD6Auv7ITw==", "X-Received": "by 2002:a05:6a20:ce47:b0:1a3:4b24:149a with SMTP id\n id7-20020a056a20ce4700b001a34b24149amr1256954pzb.29.1710799487098;\n Mon, 18 Mar 2024 15:04:47 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v9 3/5] eal: initialize logging before plugins", "Date": "Mon, 18 Mar 2024 15:02:59 -0700", "Message-ID": "<20240318220432.7486-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240318220432.7486-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240318220432.7486-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Want to make sure that as many log messages as possible\nget added with the real log stream.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/freebsd/eal.c | 14 +++++++-------\n lib/eal/linux/eal.c | 16 ++++++++--------\n lib/eal/unix/eal_unix_log.c | 0\n 3 files changed, 15 insertions(+), 15 deletions(-)\n create mode 100644 lib/eal/unix/eal_unix_log.c", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 94927472edfe..6f0080c4d8c6 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -593,6 +593,13 @@ rte_eal_init(int argc, char **argv)\n \t\tinternal_conf->in_memory = false;\n \t}\n \n+\tif (eal_log_init(getprogname(), internal_conf->syslog_facility) < 0) {\n+\t\trte_eal_init_alert(\"Cannot init logging.\");\n+\t\trte_errno = ENOMEM;\n+\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n+\t\treturn -1;\n+\t}\n+\n \tif (eal_plugins_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot init plugins\");\n \t\trte_errno = EINVAL;\n@@ -719,13 +726,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\tif (eal_log_init(getprogname(), internal_conf->syslog_facility) < 0) {\n-\t\trte_eal_init_alert(\"Cannot init logging.\");\n-\t\trte_errno = ENOMEM;\n-\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n-\t\treturn -1;\n-\t}\n-\n \t/* in secondary processes, memory init may allocate additional fbarrays\n \t * not present in primary processes, so to avoid any potential issues,\n \t * initialize memzones first.\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex bffeb1f34eb9..e24f24b1b0ce 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -973,6 +973,14 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n+\tif (eal_log_init(program_invocation_short_name,\n+\t\t\t internal_conf->syslog_facility) < 0) {\n+\t\trte_eal_init_alert(\"Cannot init logging.\");\n+\t\trte_errno = ENOMEM;\n+\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n+\t\treturn -1;\n+\t}\n+\n \tif (eal_plugins_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot init plugins\");\n \t\trte_errno = EINVAL;\n@@ -1107,14 +1115,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\tif (eal_log_init(program_invocation_short_name,\n-\t\t\t internal_conf->syslog_facility) < 0) {\n-\t\trte_eal_init_alert(\"Cannot init logging.\");\n-\t\trte_errno = ENOMEM;\n-\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n-\t\treturn -1;\n-\t}\n-\n #ifdef VFIO_PRESENT\n \tif (rte_eal_vfio_setup() < 0) {\n \t\trte_eal_init_alert(\"Cannot init VFIO\");\ndiff --git a/lib/eal/unix/eal_unix_log.c b/lib/eal/unix/eal_unix_log.c\nnew file mode 100644\nindex 000000000000..e69de29bb2d1\n", "prefixes": [ "v9", "3/5" ] }