Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138475/?format=api
http://patchwork.dpdk.org/api/patches/138475/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240318220432.7486-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240318220432.7486-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240318220432.7486-5-stephen@networkplumber.org", "date": "2024-03-18T22:03:00", "name": "[v9,4/5] eal: allow user to set default log stream before init", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e5030f04afdf313c73a91ab6fefa3155434a1483", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240318220432.7486-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 31551, "url": "http://patchwork.dpdk.org/api/series/31551/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31551", "date": "2024-03-18T22:02:56", "name": "Logging unification and timestamp", "version": 9, "mbox": "http://patchwork.dpdk.org/series/31551/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138475/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138475/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E94B843CEE;\n\tMon, 18 Mar 2024 23:05:10 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8F56540DCA;\n\tMon, 18 Mar 2024 23:04:52 +0100 (CET)", "from mail-pf1-f171.google.com (mail-pf1-f171.google.com\n [209.85.210.171])\n by mails.dpdk.org (Postfix) with ESMTP id 2CE1E40A71\n for <dev@dpdk.org>; Mon, 18 Mar 2024 23:04:49 +0100 (CET)", "by mail-pf1-f171.google.com with SMTP id\n d2e1a72fcca58-6e6f69e850bso3763932b3a.0\n for <dev@dpdk.org>; Mon, 18 Mar 2024 15:04:49 -0700 (PDT)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n y6-20020a637d06000000b005dc88b232a5sm7747140pgc.26.2024.03.18.15.04.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Mar 2024 15:04:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1710799488;\n x=1711404288; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=T8d4wbz8UaPAWAX98FuZk1eIKsZOb9m1Xynp/hHjNCo=;\n b=1x/DuWghv5zagI5s20Zm6IN6OtnuyeygY7vN68iVRoMd1GlHiSUWchg76hndVJnRLE\n zHS8IrgdM+DiILK4OzMj9lW8Vmp7pN10KDYWV1xRLE07kdA24u7aXPsf7TsAAvuOc8Ni\n FwVBKhPhzX5Qft0wyhWTQMVfPP8egM0rHJk/C1/dqMLdiY8xOOkTkH47UQfeyJbsy9Q6\n fDe0AUav31NWYt6qh7pH9L6D+5dAE2DdyTDgozQtq5b4zO1xi3cC2aCOz4fUWmxA85ay\n dycpWT0K4XSSmKlAymgjSx1gMEX2G7roW1M1NK5nUF0zFnRs2K9z6+fAoaUxlE3xMEfx\n vSLA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1710799488; x=1711404288;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=T8d4wbz8UaPAWAX98FuZk1eIKsZOb9m1Xynp/hHjNCo=;\n b=dpHqdEt0UjwMCo9wT1/F+LRs39Z/RRiw4owtSh5n4rvKVoWzhl7a/lh+PGkOb5n2A1\n As1dq3niUk83uDUKC8xevTcgylMqwLHQfbshGROjcSQoy8Y4wyrGd/EmeQPVf87Tnlyi\n zYUn91a/VbolXQbSrMpQgO48RuFY5bQ36ZdxXKpj5xp9M1F5hUfFCiNna11cWjpvsmjS\n PWUEYnsuJar2Ehmo3L39h/HrLChHkqZlpqg9o4W90jmWoo4ytLLyrJMOFaABJZ5romoP\n l9k9ezTpZNCq/trj82TGXMRiA2RzhfEj/cUMck+s3s2y8xD2UntYRbxClhY+L86WWQvn\n zVlg==", "X-Gm-Message-State": "AOJu0YyrdkAyGDuZCA51ZsOYCuHjWjHkFqfHo0EYEZku0Z8sQwBViHoO\n sY8ll4GizrVQLNEzArrczec6iTUZkb89v3F1Y5q1DNdEy20JW6/nJtpU2Bh1S9l3RMoJOj8o9uh\n I", "X-Google-Smtp-Source": "\n AGHT+IHG4Sg5ew3IOWoFgdgPzXGv/CoxE8pRwzr8RcTilVYewTptGB7DjmnK7bOf+9N5xWX5QgS75Q==", "X-Received": "by 2002:a05:6a20:a111:b0:1a3:677c:23c1 with SMTP id\n q17-20020a056a20a11100b001a3677c23c1mr4583748pzk.12.1710799488349;\n Mon, 18 Mar 2024 15:04:48 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v9 4/5] eal: allow user to set default log stream before init", "Date": "Mon, 18 Mar 2024 15:03:00 -0700", "Message-ID": "<20240318220432.7486-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240318220432.7486-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240318220432.7486-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "It is useful for application to be able to set the default log\nstream before call rte_eal_init(). This makes all messages go\nto the new default.\n\nFor example, to skip using syslog; just doing\n\trte_openlog_stream(stderr);\n\nThere is no reason for helper command line applications to clutter\nsyslog with messages.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/dumpcap/main.c | 3 +++\n app/pdump/main.c | 3 +++\n app/proc-info/main.c | 3 +++\n lib/log/log.c | 6 ++++++\n lib/log/log_internal.h | 2 ++\n lib/log/log_unix.c | 4 ++++\n lib/log/version.map | 1 +\n 7 files changed, 22 insertions(+)", "diff": "diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c\nindex cc0f66b2bc61..27934ca7e688 100644\n--- a/app/dumpcap/main.c\n+++ b/app/dumpcap/main.c\n@@ -633,6 +633,9 @@ static void dpdk_init(void)\n \t\t\trte_panic(\"No memory\\n\");\n \t}\n \n+\t/* keep any logging away from syslog. */\n+\trte_openlog_stream(stderr);\n+\n \tif (rte_eal_init(eal_argc, eal_argv) < 0)\n \t\trte_exit(EXIT_FAILURE, \"EAL init failed: is primary process running?\\n\");\n }\ndiff --git a/app/pdump/main.c b/app/pdump/main.c\nindex a9205e130bb1..7b9ba68b1a14 100644\n--- a/app/pdump/main.c\n+++ b/app/pdump/main.c\n@@ -995,6 +995,9 @@ main(int argc, char **argv)\n \n \targc += 2;\n \n+\t/* keep any logging away from syslog. */\n+\trte_openlog_stream(stderr);\n+\n \tdiag = rte_eal_init(argc, argp);\n \tif (diag < 0)\n \t\trte_panic(\"Cannot init EAL\\n\");\ndiff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex b672aaefbe99..24ee52c4ac7a 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -2149,6 +2149,9 @@ main(int argc, char **argv)\n \n \targc += 4;\n \n+\t/* keep any logging away from syslog. */\n+\trte_openlog_stream(stderr);\n+\n \tret = rte_eal_init(argc, argp);\n \tif (ret < 0)\n \t\trte_panic(\"Cannot init EAL\\n\");\ndiff --git a/lib/log/log.c b/lib/log/log.c\nindex 255f757d94cc..4cc944305057 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -519,6 +519,12 @@ eal_log_set_default(FILE *default_log)\n #endif\n }\n \n+FILE *\n+eal_log_get_default(void)\n+{\n+\treturn default_log_stream;\n+}\n+\n /*\n * Called by eal_cleanup\n */\ndiff --git a/lib/log/log_internal.h b/lib/log/log_internal.h\nindex 451629f1c1ba..c77e687e28bc 100644\n--- a/lib/log/log_internal.h\n+++ b/lib/log/log_internal.h\n@@ -21,6 +21,8 @@ int eal_log_init(const char *id, int facility);\n */\n __rte_internal\n void eal_log_set_default(FILE *default_log);\n+__rte_internal\n+FILE *eal_log_get_default(void);\n \n /*\n * Save a log option for later.\ndiff --git a/lib/log/log_unix.c b/lib/log/log_unix.c\nindex 2dfb0c974b1d..a415bae5774d 100644\n--- a/lib/log/log_unix.c\n+++ b/lib/log/log_unix.c\n@@ -49,6 +49,10 @@ eal_log_init(const char *id, int facility)\n {\n \tFILE *log_stream;\n \n+\t/* skip if user has already setup a log stream */\n+\tif (eal_log_get_default())\n+\t\treturn 0;\n+\n \tlog_stream = fopencookie(NULL, \"w+\", console_log_func);\n \tif (log_stream == NULL)\n \t\treturn -1;\ndiff --git a/lib/log/version.map b/lib/log/version.map\nindex 0648f8831aff..6ecc656d1d65 100644\n--- a/lib/log/version.map\n+++ b/lib/log/version.map\n@@ -25,6 +25,7 @@ DPDK_24 {\n INTERNAL {\n \tglobal:\n \n+\teal_log_get_default;\n \teal_log_init;\n \teal_log_level2str;\n \teal_log_save_pattern;\n", "prefixes": [ "v9", "4/5" ] }{ "id": 138475, "url": "