Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138484/?format=api
{ "id": 138484, "url": "http://patchwork.dpdk.org/api/patches/138484/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1710865092-2796-1-git-send-email-junwang01@cestc.cn/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1710865092-2796-1-git-send-email-junwang01@cestc.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/1710865092-2796-1-git-send-email-junwang01@cestc.cn", "date": "2024-03-19T16:18:12", "name": "net/ixgbe: using dpdk-dumpcap capture packet coredump", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f7b426b596e3c52614025b21d4f402edf6f18831", "submitter": { "id": 3288, "url": "http://patchwork.dpdk.org/api/people/3288/?format=api", "name": "junwang01@cestc.cn", "email": "junwang01@cestc.cn" }, "delegate": { "id": 10, "url": "http://patchwork.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1710865092-2796-1-git-send-email-junwang01@cestc.cn/mbox/", "series": [ { "id": 31559, "url": "http://patchwork.dpdk.org/api/series/31559/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31559", "date": "2024-03-19T16:18:12", "name": "net/ixgbe: using dpdk-dumpcap capture packet coredump", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31559/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138484/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/138484/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1988043CEE;\n\tTue, 19 Mar 2024 17:18:37 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 938BA40EE1;\n\tTue, 19 Mar 2024 17:18:36 +0100 (CET)", "from smtp.cecloud.com (unknown [1.203.97.246])\n by mails.dpdk.org (Postfix) with ESMTP id A376140A79\n for <dev@dpdk.org>; Tue, 19 Mar 2024 17:18:34 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by smtp.cecloud.com (Postfix) with ESMTP id 130547C0113\n for <dev@dpdk.org>; Wed, 20 Mar 2024 00:18:31 +0800 (CST)", "from izgc79c142y6tt9fty3vzrz.localdomain (unknown [47.122.22.90])\n by smtp.cecloud.com (postfix) whith ESMTP id\n P235493T281471604355440S1710865095237294_;\n Wed, 20 Mar 2024 00:18:30 +0800 (CST)" ], "X-MAIL-GRAY": "0", "X-MAIL-DELIVERY": "1", "X-ANTISPAM-LEVEL": "2", "X-ABS-CHECKED": "0", "X-IP-DOMAINF": "1", "X-RL-SENDER": "junwang01@cestc.cn", "X-SENDER": "junwang01@cestc.cn", "X-LOGIN-NAME": "junwang01@cestc.cn", "X-FST-TO": "dev@dpdk.org", "X-RCPT-COUNT": "1", "X-LOCAL-RCPT-COUNT": "0", "X-MUTI-DOMAIN-COUNT": "0", "X-SENDER-IP": "47.122.22.90", "X-ATTACHMENT-NUM": "0", "X-UNIQUE-TAG": "<4038681a301be5cd2635cab2ae8f55d5>", "X-System-Flag": "0", "From": "Jun Wang <junwang01@cestc.cn>", "To": "dev@dpdk.org", "Subject": "[PATCH] net/ixgbe: using dpdk-dumpcap capture packet coredump", "Date": "Wed, 20 Mar 2024 00:18:12 +0800", "Message-Id": "<1710865092-2796-1-git-send-email-junwang01@cestc.cn>", "X-Mailer": "git-send-email 1.8.3.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Signed-off-by: Jun Wang <junwang01@cestc.cn>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 73 ++++++++++++++++++++--------------------\n 1 file changed, 37 insertions(+), 36 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex c61c52b..0e624f5 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -4313,49 +4313,50 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n #ifdef RTE_EXEC_ENV_FREEBSD\n \twait = 1;\n #endif\n+\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n+\t\tif (vf)\n+\t\t\tdiag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);\n+\t\telse\n+\t\t\tdiag = ixgbe_check_link(hw, &link_speed, &link_up, wait);\n \n-\tif (vf)\n-\t\tdiag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);\n-\telse\n-\t\tdiag = ixgbe_check_link(hw, &link_speed, &link_up, wait);\n+\t\tif (diag != 0) {\n+\t\t\tlink.link_speed = RTE_ETH_SPEED_NUM_100M;\n+\t\t\tlink.link_duplex = RTE_ETH_LINK_FULL_DUPLEX;\n+\t\t\treturn rte_eth_linkstatus_set(dev, &link);\n+\t\t}\n \n-\tif (diag != 0) {\n-\t\tlink.link_speed = RTE_ETH_SPEED_NUM_100M;\n-\t\tlink.link_duplex = RTE_ETH_LINK_FULL_DUPLEX;\n-\t\treturn rte_eth_linkstatus_set(dev, &link);\n-\t}\n+\t\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber &&\n+\t \t!ad->sdp3_no_tx_disable) {\n+\t\t\tesdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);\n+\t\t\tif ((esdp_reg & IXGBE_ESDP_SDP3))\n+\t\t\t\tlink_up = 0;\n+\t\t}\n \n-\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber &&\n-\t !ad->sdp3_no_tx_disable) {\n-\t\tesdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);\n-\t\tif ((esdp_reg & IXGBE_ESDP_SDP3))\n-\t\t\tlink_up = 0;\n-\t}\n-\n-\tif (link_up == 0) {\n-\t\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {\n-\t\t\tixgbe_dev_wait_setup_link_complete(dev, 0);\n-\t\t\t/* NOTE: review for potential ordering optimization */\n-\t\t\tif (!__atomic_test_and_set(&ad->link_thread_running, __ATOMIC_SEQ_CST)) {\n-\t\t\t\t/* To avoid race condition between threads, set\n-\t\t\t\t * the IXGBE_FLAG_NEED_LINK_CONFIG flag only\n-\t\t\t\t * when there is no link thread running.\n-\t\t\t\t */\n-\t\t\t\tintr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;\n-\t\t\t\tif (rte_thread_create_internal_control(&ad->link_thread_tid,\n-\t\t\t\t\t\t\"ixgbe-link\",\n-\t\t\t\t\t\tixgbe_dev_setup_link_thread_handler, dev) < 0) {\n+\t\tif (link_up == 0) {\n+\t\t\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {\n+\t\t\t\tixgbe_dev_wait_setup_link_complete(dev, 0);\n+\t\t\t\t/* NOTE: review for potential ordering optimization */\n+\t\t\t\tif (!__atomic_test_and_set(&ad->link_thread_running, __ATOMIC_SEQ_CST)) {\n+\t\t\t\t\t/* To avoid race condition between threads, set\n+\t\t\t\t \t* the IXGBE_FLAG_NEED_LINK_CONFIG flag only\n+\t\t\t\t \t* when there is no link thread running.\n+\t\t\t\t \t*/\n+\t\t\t\t\tintr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;\n+\t\t\t\t\tif (rte_thread_create_internal_control(&ad->link_thread_tid,\n+\t\t\t\t\t\t\t\"ixgbe-link\",\n+\t\t\t\t\t\t\tixgbe_dev_setup_link_thread_handler, dev) < 0) {\n+\t\t\t\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\t\t\t\"Create link thread failed!\");\n+\t\t\t\t\t\t/* NOTE: review for potential ordering optimization */\n+\t\t\t\t\t\t__atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST);\n+\t\t\t\t\t}\n+\t\t\t\t} else {\n \t\t\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t\t\t\"Create link thread failed!\");\n-\t\t\t\t\t/* NOTE: review for potential ordering optimization */\n-\t\t\t\t\t__atomic_clear(&ad->link_thread_running, __ATOMIC_SEQ_CST);\n+\t\t\t\t\t\t\"Other link thread is running now!\");\n \t\t\t\t}\n-\t\t\t} else {\n-\t\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t\t\"Other link thread is running now!\");\n \t\t\t}\n+\t\t\treturn rte_eth_linkstatus_set(dev, &link);\n \t\t}\n-\t\treturn rte_eth_linkstatus_set(dev, &link);\n \t}\n \n \tlink.link_status = RTE_ETH_LINK_UP;\n", "prefixes": [] }