Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138579/?format=api
{ "id": 138579, "url": "http://patchwork.dpdk.org/api/patches/138579/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240320173407.216307-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240320173407.216307-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240320173407.216307-1-stephen@networkplumber.org", "date": "2024-03-20T17:33:04", "name": "net/ixgbe: do not update link status in secondary process", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "037923f4c4ec06949cde57c6f1862fb1eaa58348", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 10, "url": "http://patchwork.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240320173407.216307-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 31571, "url": "http://patchwork.dpdk.org/api/series/31571/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31571", "date": "2024-03-20T17:33:04", "name": "net/ixgbe: do not update link status in secondary process", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31571/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138579/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/138579/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EAE4043D06;\n\tWed, 20 Mar 2024 18:37:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D189140ED3;\n\tWed, 20 Mar 2024 18:37:16 +0100 (CET)", "from mail-pg1-f178.google.com (mail-pg1-f178.google.com\n [209.85.215.178])\n by mails.dpdk.org (Postfix) with ESMTP id A240F40A6F\n for <dev@dpdk.org>; Wed, 20 Mar 2024 18:37:15 +0100 (CET)", "by mail-pg1-f178.google.com with SMTP id\n 41be03b00d2f7-5d8b70b39efso80171a12.0\n for <dev@dpdk.org>; Wed, 20 Mar 2024 10:37:15 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n d1-20020aa78141000000b006e6c0080466sm12221350pfn.176.2024.03.20.10.37.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 20 Mar 2024 10:37:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1710956235;\n x=1711561035; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fT+wPQLAWuMg0f42jW3l9au1pm+NjlKhSuLfaSsFMFQ=;\n b=bHAp4wqcM5V4JJOyRvdxyRer4qc+9jmKW98RtwVMU0uFG72wiyHecUNloZaxT4B4e6\n RKe+HaVCc+raziPh6etSI7tps+jBPru/XHmm/IecGkJN1hMkyY+jrKZnKHcqgS/RqU/5\n O2wF/xqNAeGt1LKvtccEyzFSDRVnpQI15j93Q4OtOh7fo2WnxIUipFu+/2HrZypDYKPi\n wJVtZr1WI79avIL9PnYhwIxSYtEAqKeKWsLOlS/flmINOZ4vOGqfxPKsCfyc/YsdSh/9\n GHVZ0amLMgPhXSZJiKFEcrNRuD8bvRJDMroeS5Sh+uaGvH3nnxluPdCMhF2ApwXntzFT\n aKvw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1710956235; x=1711561035;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=fT+wPQLAWuMg0f42jW3l9au1pm+NjlKhSuLfaSsFMFQ=;\n b=QW334l6/mkJ8i09tUMQHu/K6fw6XlrQQ6ZkyfMiw/hFCV4zPUMinOojonyGJVxHl96\n WdIgxtT4ppJJZ/5Vi+YUKsH6IeQ7UR8WwEEXGiR7DC5Oky2/g1GcgKRV3bdO2XH42qoO\n tWKNc24JXyFgND7X/SstlfGt5sH5DQP1WnV3l5NnbquK8aMBWyorwoXHDaYYgRaT4/2V\n JqfWCdQAOCYu4tAobiCePdrlJaNgwjPeconM6zvLkHeUKQouDW+bjqbviGL1IQWpmm+w\n +iB82FM2C+JnQaTVyLzoFRhk3+d5hCyfnP5WF8CffASbIrNJxyuR30NOLCsNskg/+e0J\n UAQA==", "X-Gm-Message-State": "AOJu0YzFQVngN3bTvBvwYz7hceULHcyyvNTgGDDOD6M0obqVvmsWRaiW\n YGRFGXJ5385OFYjzfkXtre7dsgpFcVcnea0/7miKM0cGEk6TKtBIhgKd6+q+jfXz80+r0FKg9ez\n j", "X-Google-Smtp-Source": "\n AGHT+IFpzggKaLp8Ub6JMD5O32aaJdtI90IQ1cNPKPe0s1vtUQKSlCrUh3PQHeUbb0in+M3boxlNEA==", "X-Received": "by 2002:a05:6a20:8f06:b0:1a3:5440:520 with SMTP id\n b6-20020a056a208f0600b001a354400520mr14422803pzk.1.1710956234759;\n Wed, 20 Mar 2024 10:37:14 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "junwang01@cestc.cn,\n\tStephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH] net/ixgbe: do not update link status in secondary process", "Date": "Wed, 20 Mar 2024 10:33:04 -0700", "Message-ID": "<20240320173407.216307-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<1710865092-2796-1-git-send-email-junwang01@cestc.cn>", "References": "<1710865092-2796-1-git-send-email-junwang01@cestc.cn>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The code to update link status is not safe in secondary process.\nIf called from secondary it will crash, example from dumpcap:\n\tixgbe_dev_link_update_share()\n\tixgbe_dev_link_update()\n\trte_eth_link_get()\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReported-by: Jun Wang <junwang01@cestc.cn>\n---\nSimpler version of earlier patch, and add explanation.\n\n drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex c61c52b2966b..86ccbdd78292 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -4293,6 +4293,9 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \tint wait = 1;\n \tu32 esdp_reg;\n \n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -1;\n+\n \tmemset(&link, 0, sizeof(link));\n \tlink.link_status = RTE_ETH_LINK_DOWN;\n \tlink.link_speed = RTE_ETH_SPEED_NUM_NONE;\n", "prefixes": [] }