Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138654/?format=api
{ "id": 138654, "url": "http://patchwork.dpdk.org/api/patches/138654/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240320130255.1526-1-thj@freebsd.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240320130255.1526-1-thj@freebsd.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240320130255.1526-1-thj@freebsd.org", "date": "2024-03-20T13:02:55", "name": "net/vmxnet3: Don't enable rx queue interrupts on FreeBSD", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cd289b6942d87cf3d0166e009fb3f4c3c92cfbf2", "submitter": { "id": 3293, "url": "http://patchwork.dpdk.org/api/people/3293/?format=api", "name": "Tom Jones", "email": "thj@freebsd.org" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240320130255.1526-1-thj@freebsd.org/mbox/", "series": [ { "id": 31581, "url": "http://patchwork.dpdk.org/api/series/31581/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31581", "date": "2024-03-20T13:02:55", "name": "net/vmxnet3: Don't enable rx queue interrupts on FreeBSD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31581/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138654/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/138654/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6E8B143D11;\n\tThu, 21 Mar 2024 08:43:53 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4D87B4028B;\n\tThu, 21 Mar 2024 08:43:53 +0100 (CET)", "from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81])\n by mails.dpdk.org (Postfix) with ESMTP id F37FC4029F\n for <dev@dpdk.org>; Wed, 20 Mar 2024 14:03:15 +0100 (CET)", "from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits)\n client-signature RSA-PSS (4096 bits))\n (Client CN \"mx1.freebsd.org\", Issuer \"R3\" (verified OK))\n by mx2.freebsd.org (Postfix) with ESMTPS id 4V080L63Gsz3rMZ;\n Wed, 20 Mar 2024 13:03:14 +0000 (UTC) (envelope-from thj@freebsd.org)", "from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256\n client-signature RSA-PSS (4096 bits) client-digest SHA256)\n (Client CN \"smtp.freebsd.org\", Issuer \"R3\" (verified OK))\n by mx1.freebsd.org (Postfix) with ESMTPS id 4V080L51Lhz4qHS;\n Wed, 20 Mar 2024 13:03:14 +0000 (UTC) (envelope-from thj@freebsd.org)", "from vpp.my.domain (unknown [188.74.83.122])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (Client did not present a certificate) (Authenticated sender: thj)\n by smtp.freebsd.org (Postfix) with ESMTPSA id 4V080L1JhJzGn6;\n Wed, 20 Mar 2024 13:03:14 +0000 (UTC) (envelope-from thj@freebsd.org)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;\n t=1710939794;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=AAvq6rrC5JyIADnEAej52HJ4Bp4Y/HH1nzpei6pjNDg=;\n b=JwjF3fHJaNHqc7KzkPWV+UIedWV1/V/8f9pTwwCPG/iLGM/SR/Iewl9Vk0kU+Gu/Y9x6ps\n /Fr342k2h49EN+EwJdGFmE/IbV4FpMiB1pTLdqeQvIr7xdEDJbEh65Iri7CpSa6lLuBPqh\n GN9N8lflL72tdkhl9er221vPm9CqzgrhcspyfcwMniT0/zXTyZL8AuTyVOry2tTnUfWgI4\n ghsaaYvRUISgO7PMpVnbvjDCMQ17TN1epRZBtBVwktWeAhgw69pqsoNchB5KeEdRpMSABN\n EFmh+QiE5ZU5hrnTWb3dDCNW/UuS7lhTYPmWV7b4VkRgm8fBCYwZV+XFiTQzvQ==", "ARC-Seal": "i=1; s=dkim; d=freebsd.org; t=1710939794; a=rsa-sha256; cv=none;\n b=AKH56IiX9dQ9Xmv3rwFxHR6qZXQ1US7PczYaZ17RwoINj2+HaEI2HPTBhSDgoch5MjQN61\n eHWZswxHJMn+X20HTHf5FES06WmBOQFHh1DFM6onF0XdPnmv0CjMNtzV2Y2gHmoH8EjVuk\n TGY/eEbT3lV8N1a0yNbT78HtgsUK6P++/bW2LDe3wIXqEyjneGSOgpoAl7nJvh98Cjsvme\n 3IJm75i+MJZ4NYM0BbkV6/OH3lbp1RToFWYc842IDN965KMmU7I2RZJIwwvRC/eKHDXxUD\n NGKk8PH1ZcdB1gR+kkjzQm8oz83ktvIzQWVHvu1K+iSogxXfCMssnq/TLROJvA==", "ARC-Authentication-Results": "i=1;\n\tmx1.freebsd.org;\n\tnone", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;\n s=dkim; t=1710939794;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=AAvq6rrC5JyIADnEAej52HJ4Bp4Y/HH1nzpei6pjNDg=;\n b=XLuO77/Nz2OEvLwj5BoYqU4dnAN3PJNlB4onVW3mJIwHKnOGBybtJeZH1fanevFdaPAaEu\n Cj557LWy+JUXXV2ZL08ipjO8CCwysZiTPH/VyphSO8bklHjJuEgrpfJmjIHD4ilmmnriin\n Uz+xfHh7Bd2RfFAt7lp4UyGlREJ6rRLmvPsjIrVtHWAoepgLNWzPy0HazdqmCrAoThh6n4\n BJKSZRy5hoCuI35KhsB70YHPyxQV+2U4iu9SldSoIYbwOg9v9N24iWafBUDrc8RSZhxtgT\n +j2GvlVxgdniCmTMHY88tRhD9IfpSAT0XlRbKrujUQEx1qtHZcPXzr3itdUs3g==", "From": "Tom Jones <thj@freebsd.org>", "To": "jbehrens@vmware.com", "Cc": "dev@dpdk.org,\n\tthj@freebsd.org", "Subject": "[PATCH] net/vmxnet3: Don't enable rx queue interrupts on FreeBSD", "Date": "Wed, 20 Mar 2024 13:02:55 +0000", "Message-ID": "<20240320130255.1526-1-thj@freebsd.org>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Thu, 21 Mar 2024 08:43:52 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Commit 29a1c9107bb disabled interrupts on FreeBSD for the vmxnet3 driver\nas they are not supported. Rx queue interrupts were missed by this\nchange, don't attempt to enable them on FreeBSD.\n\nWithout this change applications enabling interrupts encounter an\nimmediate abort on FreeBSD.\n\nSigned-off-by: Tom Jones <thj@freebsd.org>\n---\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 2707b25148..8b12967fa2 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -1938,9 +1938,11 @@ vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)\n {\n \tstruct vmxnet3_hw *hw = dev->data->dev_private;\n \n+#ifndef RTE_EXEC_ENV_FREEBSD\n \tvmxnet3_enable_intr(hw,\n \t\t\t rte_intr_vec_list_index_get(dev->intr_handle,\n \t\t\t\t\t\t\t queue_id));\n+#endif\n \n \treturn 0;\n }\n", "prefixes": [] }