Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138657/?format=api
{ "id": 138657, "url": "http://patchwork.dpdk.org/api/patches/138657/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240321095029.1216-1-thj@freebsd.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240321095029.1216-1-thj@freebsd.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240321095029.1216-1-thj@freebsd.org", "date": "2024-03-21T09:50:29", "name": "net/vmxnet3: Don't enable rx queue interrupts on FreeBSD", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e9b1052924d532e5261984db7ef75e9a1ec7d4e5", "submitter": { "id": 3293, "url": "http://patchwork.dpdk.org/api/people/3293/?format=api", "name": "Tom Jones", "email": "thj@freebsd.org" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240321095029.1216-1-thj@freebsd.org/mbox/", "series": [ { "id": 31584, "url": "http://patchwork.dpdk.org/api/series/31584/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31584", "date": "2024-03-21T09:50:29", "name": "net/vmxnet3: Don't enable rx queue interrupts on FreeBSD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31584/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138657/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138657/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9946243D14;\n\tThu, 21 Mar 2024 10:55:33 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8797542D7F;\n\tThu, 21 Mar 2024 10:55:33 +0100 (CET)", "from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81])\n by mails.dpdk.org (Postfix) with ESMTP id 4ACEA40261\n for <dev@dpdk.org>; Thu, 21 Mar 2024 10:50:41 +0100 (CET)", "from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits)\n client-signature RSA-PSS (4096 bits))\n (Client CN \"mx1.freebsd.org\", Issuer \"R3\" (verified OK))\n by mx2.freebsd.org (Postfix) with ESMTPS id 4V0ggj0x0gz4MYT;\n Thu, 21 Mar 2024 09:50:41 +0000 (UTC) (envelope-from thj@freebsd.org)", "from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256\n client-signature RSA-PSS (4096 bits) client-digest SHA256)\n (Client CN \"smtp.freebsd.org\", Issuer \"R3\" (verified OK))\n by mx1.freebsd.org (Postfix) with ESMTPS id 4V0ggh6tTdz41NK;\n Thu, 21 Mar 2024 09:50:40 +0000 (UTC) (envelope-from thj@freebsd.org)", "from vpp.my.domain (unknown [188.74.83.122])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (Client did not present a certificate) (Authenticated sender: thj)\n by smtp.freebsd.org (Postfix) with ESMTPSA id 4V0ggh3bRpzh1V;\n Thu, 21 Mar 2024 09:50:40 +0000 (UTC) (envelope-from thj@freebsd.org)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;\n t=1711014641;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=lOJaI7IZHaN6uPi0TQuejvhnZHgDce4G52ZJ4iXVFAE=;\n b=ll/h671oBh/hfiI/ihDADYeANrW9XBDSRcaBmLkHfZE6wmJKC3Q0WruIOyCjrK8fIaEd4N\n icWDGHH3lmbKt3GbFqFqXOpV6dW043olT217LFlV4YxzdSa8Lsz69s5JJLNe2DAKyrUClF\n Jol40GIJPghRIV1vEywUeA3tGHpNKM51otuit0AgjGP9rIJeIfUSHV1HgfRBzK0sZRv0dU\n Yv2Lh+/JK9qMMYRGr8yg4yoHh93zYI33QtMhdvwAAcJOsZyRSITdwDHLy0JMXh0zDgpy+k\n TrK5aYFkNAimChHUSU+Sp5b3nkqROEAPLdkhn4XlQnl3JUsQ/lW7Mf7K2iBjyg==", "ARC-Seal": "i=1; s=dkim; d=freebsd.org; t=1711014641; a=rsa-sha256; cv=none;\n b=MrgCZSm6ZIHo8RYp758nazAgPb6RNYVVRD85OCl8IVDrj17RbEUfOMlmmx4kmJDkMTP352\n uf1D2qaqIdHMXg10GZx1uKCZDBa9+WK/ucaFDV/itGoY1nxdBE4xW03GZhbb4DOCn0RSiI\n tW1FQbB0D39RP4ISklDls/PpOENn6EmQNXtr0CPEbjf9vZBAu1hHBZFmyXf34MDoNPike3\n AnWnarjKqkrI7nPJa1bWtfH+FuxJStgdNeZc9+3WBIsH6BusxMWHQ8DmC6CNwHRS5NehtW\n TgNo8l2RX57yJNWR7M3eeJJjLbXZ5dPKgHl923Iy0duBnVqc6XZbRDqAqMA81g==", "ARC-Authentication-Results": "i=1;\n\tmx1.freebsd.org;\n\tnone", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;\n s=dkim; t=1711014641;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=lOJaI7IZHaN6uPi0TQuejvhnZHgDce4G52ZJ4iXVFAE=;\n b=Et7nhMHqBN7ZmvE5qrg/QMt1ySh1ZgY4Rvx2VRn/yWYTNBYyUIkmxcz49u52QwIBY/+pjk\n vMATtKSAemq6iDSPXBbxA/GtQck2dBM9mwu/LRxk+HXD+OiGB9gHRW+NHgiMUEiubPPdUH\n cTSh7927KUkQM3A2ozRnJ5jn/ms42/1OUJ5PTYoyXB8aMxYWP3YVC1VAs7j5fP1f5SaXsx\n /DNwNBsrYk3GEp3kpkmkrngAcO9jsrWXBb0rSpj1RQUpk8yYhaR3YUoULEmnHv2Xx8MRYJ\n G75x4McaB6XRw2GluTKHu4YpJI6+LDqQCqJy4wcglsFJ1d8cdoUtN3DoEbHv8A==", "From": "Tom Jones <thj@freebsd.org>", "To": "dev@dpdk.org", "Cc": "Tom Jones <thj@freebsd.org>", "Subject": "[PATCH] net/vmxnet3: Don't enable rx queue interrupts on FreeBSD", "Date": "Thu, 21 Mar 2024 09:50:29 +0000", "Message-ID": "<20240321095029.1216-1-thj@freebsd.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240320130255.1526-1-thj@freebsd.org>", "References": "<20240320130255.1526-1-thj@freebsd.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Thu, 21 Mar 2024 10:55:31 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Commit 29a1c9107bb disabled interrupts on FreeBSD for the vmxnet3 driver\nas they are not supported. Rx queue interrupts were missed by this\nchange, don't attempt to enable them on FreeBSD.\n\nWithout this change applications enabling interrupts encounter an\nimmediate abort on FreeBSD.\n\nSigned-off-by: Tom Jones <thj@freebsd.org>\n---\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 2707b25148..ce7c347254 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -1936,11 +1936,13 @@ vmxnet3_interrupt_handler(void *param)\n static int\n vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)\n {\n+#ifndef RTE_EXEC_ENV_FREEBSD\n \tstruct vmxnet3_hw *hw = dev->data->dev_private;\n \n \tvmxnet3_enable_intr(hw,\n \t\t\t rte_intr_vec_list_index_get(dev->intr_handle,\n \t\t\t\t\t\t\t queue_id));\n+#endif\n \n \treturn 0;\n }\n", "prefixes": [] }