Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138759/?format=api
{ "id": 138759, "url": "http://patchwork.dpdk.org/api/patches/138759/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240324024109.306614-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240324024109.306614-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240324024109.306614-7-stephen@networkplumber.org", "date": "2024-03-24T02:33:28", "name": "[v11,6/9] log: add hook for printing log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "75266a5fd1c78f034bb7314b356c18b5cae1949a", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240324024109.306614-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 31607, "url": "http://patchwork.dpdk.org/api/series/31607/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31607", "date": "2024-03-24T02:33:22", "name": "Logging unification and enhancements", "version": 11, "mbox": "http://patchwork.dpdk.org/series/31607/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138759/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138759/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 93D1443D36;\n\tSun, 24 Mar 2024 03:42:07 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B7CA740693;\n\tSun, 24 Mar 2024 03:41:31 +0100 (CET)", "from mail-pg1-f169.google.com (mail-pg1-f169.google.com\n [209.85.215.169])\n by mails.dpdk.org (Postfix) with ESMTP id E31EC402EB\n for <dev@dpdk.org>; Sun, 24 Mar 2024 03:41:25 +0100 (CET)", "by mail-pg1-f169.google.com with SMTP id\n 41be03b00d2f7-5d8b887bb0cso2193592a12.2\n for <dev@dpdk.org>; Sat, 23 Mar 2024 19:41:25 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n q17-20020a17090311d100b001dc3c4e7a12sm2244980plh.14.2024.03.23.19.41.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 23 Mar 2024 19:41:24 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711248085;\n x=1711852885; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=VdEvoGGjU84scNBTJhyFTXSp+Lveq7VDyLhJBdzO3yw=;\n b=0ciau0+8uP8waaIAgPRZbMiZFiDkm71Di2SWZisph9qaGVnByRLseMHnfRy7gV/1qq\n Oz856oSVAD+0RFnoRnq6gbkYG5Ry4ff0AW6UiRpKjJLvuOQYiLe9alh/sBHON9zC2fgK\n qCif9lxv/oUrssEOyEaaOpTU/7IK8ikAV2vBexOCSVv7Vbe6S2L8qvx0cYsIh8cJyKRd\n 7EIN78DZEu1IMgQcIqo1OZr2+CZhEEaf9yc6IZj98IulYXx4NhijM485zO76iV6MHQ5p\n gAFZ+ERj6V3bpmMKgNaDvmNdxcLBA2UuKfw/sS28X64bklunZKk9sSHvn7skPp+UJwpa\n 8o8A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711248085; x=1711852885;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=VdEvoGGjU84scNBTJhyFTXSp+Lveq7VDyLhJBdzO3yw=;\n b=IH36M2WG0fxCmsUAzbY61Lv73bJVUwPcwdDgEC4qvh51cFUBla1JezhsyyYEbJqTJH\n u30smXss6yoM1nVwApYIWJO41gOUAh0FEgTzReM0NsvCyv2EmEPa1/bQzMtuq4i9omE+\n Uae275Z/ntOdupp6OW9C6A8uFNdpScAAm5buC+iyJ7c4Md2rPbo5DCvcysLDFYozP00h\n hV0zuFSXf5ffDmBSa+6ZKOvepdVXtjABYTY7QM+rV/7Zr6xv7kA9pSCE6V/BdJcSzcm3\n 053ka4nmSVnWy0V/XKdV3WZ47+OFXeEAf2axBfVpk27i8Qx0UHUmjwu4YkFDz3K1/NRH\n 01KQ==", "X-Gm-Message-State": "AOJu0YzSgKp2ZzG3+H0jWlo8S2iw4puugUIHBuRl4lcdk/hk0Tuq/UNC\n V44nsjAMYwxD+aOPpqf7qre9w1FpYnUqrO/VJ+bvhvzvK+t3lp6DBXWXbfUxLuEv4zb2N6QauSy\n 1", "X-Google-Smtp-Source": "\n AGHT+IG0oFdAT96k4vrSZop5SaKJHVtkLZIwY6iFWpzxW4sIwul8La0GCfx0MkBQ8PNGeMst8keV+Q==", "X-Received": "by 2002:a17:902:d4c3:b0:1e0:1f59:d672 with SMTP id\n o3-20020a170902d4c300b001e01f59d672mr5214967plg.36.1711248085063;\n Sat, 23 Mar 2024 19:41:25 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v11 6/9] log: add hook for printing log messages", "Date": "Sat, 23 Mar 2024 19:33:28 -0700", "Message-ID": "<20240324024109.306614-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240324024109.306614-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240324024109.306614-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This is useful for when decorating log output for console\nor journal. Provide basic version in this patch.\nNo functional changes in this patch, just infrastructure addition.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/log/log.c | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/log/log.c b/lib/log/log.c\nindex 4c8666ac93..4cc871911c 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -26,16 +26,21 @@ struct rte_log_dynamic_type {\n \tuint32_t loglevel;\n };\n \n+typedef int (*log_print_t)(FILE *f, uint32_t level, const char *fmt, va_list ap);\n+static int log_print(FILE *f, uint32_t level, const char *format, va_list ap);\n+\n /** The rte_log structure. */\n static struct rte_logs {\n \tuint32_t type; /**< Bitfield with enabled logs. */\n \tuint32_t level; /**< Log level. */\n \tFILE *file; /**< Output file set by rte_openlog_stream, or NULL. */\n+\tlog_print_t print_func;\n \tsize_t dynamic_types_len;\n \tstruct rte_log_dynamic_type *dynamic_types;\n } rte_logs = {\n \t.type = UINT32_MAX,\n \t.level = RTE_LOG_DEBUG,\n+\t.print_func = log_print,\n };\n \n struct rte_eal_opt_loglevel {\n@@ -67,8 +72,6 @@ struct log_cur_msg {\n /* per core log */\n static RTE_DEFINE_PER_LCORE(struct log_cur_msg, log_cur_msg);\n \n-/* default logs */\n-\n /* Change the stream that will be used by logging system */\n int\n rte_openlog_stream(FILE *f)\n@@ -77,6 +80,7 @@ rte_openlog_stream(FILE *f)\n \t\tfclose(rte_logs.file);\n \n \trte_logs.file = f;\n+\trte_logs.print_func = log_print;\n \treturn 0;\n }\n \n@@ -473,7 +477,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)\n \tRTE_PER_LCORE(log_cur_msg).loglevel = level;\n \tRTE_PER_LCORE(log_cur_msg).logtype = logtype;\n \n-\tret = vfprintf(f, format, ap);\n+\tret = (*rte_logs.print_func)(f, level, format, ap);\n \tfflush(f);\n \treturn ret;\n }\n@@ -509,6 +513,15 @@ rte_eal_log_cleanup(void)\n \t}\n }\n \n+/* default log print function */\n+__rte_format_printf(3, 0)\n+static int\n+log_print(FILE *f, uint32_t level __rte_unused,\n+\t const char *format, va_list ap)\n+{\n+\treturn vfprintf(f, format, ap);\n+}\n+\n /* initialize logging */\n void\n eal_log_init(const char *id __rte_unused)\n", "prefixes": [ "v11", "6/9" ] }