Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138775/?format=api
{ "id": 138775, "url": "http://patchwork.dpdk.org/api/patches/138775/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240325205405.669897-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240325205405.669897-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240325205405.669897-6-stephen@networkplumber.org", "date": "2024-03-25T20:47:02", "name": "[v12,05/14] eal: change rte_exit() output to match rte_log()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f359f3c8f508261a69b4f1da4c61076272b876f3", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240325205405.669897-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 31616, "url": "http://patchwork.dpdk.org/api/series/31616/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31616", "date": "2024-03-25T20:46:57", "name": "Logging unification and enhancements", "version": 12, "mbox": "http://patchwork.dpdk.org/series/31616/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138775/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138775/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B361243D49;\n\tMon, 25 Mar 2024 21:54:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2E84840E01;\n\tMon, 25 Mar 2024 21:54:26 +0100 (CET)", "from mail-pl1-f169.google.com (mail-pl1-f169.google.com\n [209.85.214.169])\n by mails.dpdk.org (Postfix) with ESMTP id 088F940DC9\n for <dev@dpdk.org>; Mon, 25 Mar 2024 21:54:22 +0100 (CET)", "by mail-pl1-f169.google.com with SMTP id\n d9443c01a7336-1de0f92e649so33573235ad.0\n for <dev@dpdk.org>; Mon, 25 Mar 2024 13:54:21 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n b18-20020a170903229200b001e0b5eee802sm3164487plh.123.2024.03.25.13.54.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 25 Mar 2024 13:54:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711400061;\n x=1712004861; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=w0CHwUH99LTRr59BzckESo/nF08qFhhomDRK57rezcs=;\n b=YrntsEdpEVyL47oWwHuqFl6TxCojmU46YHLV/zgnqOCBJT+fvw6cRYnGJ+0pfo60Ir\n FaEqqx8GIV6dPCNqph7c0Rau9iE2W6As06rGK65uR3Vl/0eAvN9tEADs2kHGniVxLSCc\n lAYxk1tz2HBYsDD2XS+MxMg9oBAi7GOj3m2SwA0ltmD0YeLpF9XV0S85NxGS5sP+UNHz\n WbYZyYBTdFcaZSbGG6lljZHoXpShVrxjhIEV4msT4vfFAfUovXnd4Dtji2B70mxxExL8\n PF7l/TWCbBClHuppDR+VOrC+2NNtnxs2oDNzDJ92iZfjGZErXzzg/ga63Rdz85ai860f\n PkIw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711400061; x=1712004861;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=w0CHwUH99LTRr59BzckESo/nF08qFhhomDRK57rezcs=;\n b=lS+KvMxd5fZ+xPMvknVQh4OOf60EGE4vQiHWdVRWp/No48EhmE6Ng+G/iKx4FoSyYc\n omPYpauIckzwUCmilORSx6Ic2BCsqSnK0lO9FcN+Co9J3y+zHdwXw0E6YdzOXk5R6nE8\n ShTi42QVu/DqGAfwoSXFGtYy0PfSyJXl58yJem1MVHPeOQ3TQr1l/UuJGZ25EWmZEmYd\n QxJxss+aNyNXbmLI3y100YdAyqbXbnrWVb1dUi0F8FyHAPN3YBkW8Ayj+vk+91SZtEdD\n bp8+5O0ii0m6b0vvV3fH73i0hbaoCfGY5epDbSOJn6SSodOfxC5UT/KTzqi88i9Aasv5\n NAdA==", "X-Gm-Message-State": "AOJu0YyQQdNuU8un+UE7O34GPh26dtBJa4WCZnW/3LkqV4lXGalcLxo8\n 57Yr5iIW6HxdiWECgNSnhLLSSGigCZhvXN+uMLe//zr2v6LpPR33NDTdUyZx4/aak+9/KZO4QLA\n l", "X-Google-Smtp-Source": "\n AGHT+IEeL9pZhpam8vOao1u0mYWfDq0I9aAiKtGdnXaSVs8ACq0nSZwTblQeh00purQzr4CLzjR15w==", "X-Received": "by 2002:a17:902:7208:b0:1e0:b1a7:473e with SMTP id\n ba8-20020a170902720800b001e0b1a7473emr776969plb.67.1711400061104;\n Mon, 25 Mar 2024 13:54:21 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v12 05/14] eal: change rte_exit() output to match rte_log()", "Date": "Mon, 25 Mar 2024 13:47:02 -0700", "Message-ID": "<20240325205405.669897-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240325205405.669897-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240325205405.669897-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_exit() output format confuses the timestamp and coloring\noptions. Change it to use be a single line with proper prefix.\n\nBefore:\n[ 0.006481] EAL: Error - exiting with code: 1\n Cause: [ 0.006489] Cannot init EAL: Permission denied\n\nAfter:\n[ 0.006238] EAL: Error - exiting with code: 1\n[ 0.006250] EAL: Cause - Cannot init EAL: Permission denied\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_debug.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c\nindex 3e77995896..3f37879144 100644\n--- a/lib/eal/common/eal_common_debug.c\n+++ b/lib/eal/common/eal_common_debug.c\n@@ -34,17 +34,18 @@ void\n rte_exit(int exit_code, const char *format, ...)\n {\n \tva_list ap;\n+\tchar *msg = NULL;\n \n \tif (exit_code != 0)\n-\t\tRTE_LOG(CRIT, EAL, \"Error - exiting with code: %d\\n\"\n-\t\t\t\t\" Cause: \", exit_code);\n+\t\tEAL_LOG(CRIT, \"Error - exiting with code: %d\", exit_code);\n \n \tva_start(ap, format);\n-\trte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);\n+\tvasprintf(&msg, format, ap);\n \tva_end(ap);\n \n+\trte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, \"EAL: Cause - %s\", msg);\n+\n \tif (rte_eal_cleanup() != 0 && rte_errno != EALREADY)\n-\t\tEAL_LOG(CRIT,\n-\t\t\t\"EAL could not release all resources\");\n+\t\tEAL_LOG(CRIT, \"EAL could not release all resources\");\n \texit(exit_code);\n }\n", "prefixes": [ "v12", "05/14" ] }