Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138777/?format=api
{ "id": 138777, "url": "http://patchwork.dpdk.org/api/patches/138777/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240325205405.669897-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240325205405.669897-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240325205405.669897-8-stephen@networkplumber.org", "date": "2024-03-25T20:47:04", "name": "[v12,07/14] eal: initialize log before everything else", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0e0cfdb7f110f873ced5b9b320cf964eda9fb623", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240325205405.669897-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 31616, "url": "http://patchwork.dpdk.org/api/series/31616/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31616", "date": "2024-03-25T20:46:57", "name": "Logging unification and enhancements", "version": 12, "mbox": "http://patchwork.dpdk.org/series/31616/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138777/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4E06543D49;\n\tMon, 25 Mar 2024 21:55:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DE06C40E54;\n\tMon, 25 Mar 2024 21:54:28 +0100 (CET)", "from mail-pf1-f172.google.com (mail-pf1-f172.google.com\n [209.85.210.172])\n by mails.dpdk.org (Postfix) with ESMTP id 6E8EE40DCE\n for <dev@dpdk.org>; Mon, 25 Mar 2024 21:54:24 +0100 (CET)", "by mail-pf1-f172.google.com with SMTP id\n d2e1a72fcca58-6e6b5432439so3671062b3a.1\n for <dev@dpdk.org>; Mon, 25 Mar 2024 13:54:24 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n b18-20020a170903229200b001e0b5eee802sm3164487plh.123.2024.03.25.13.54.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 25 Mar 2024 13:54:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711400063;\n x=1712004863; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yt8sOxcACKjNMF6qKstsLWVdnhI7Desd0hXEpONxCMs=;\n b=p9L7cQ4KHCz/qJX+Y7DHKyrUTFU3tmS9RpV3ii8DrpEFR6MD8Em/v1E/V6klAOx+vr\n s/h27YPkVjOflJzhcxBS3xMO10m98RiawS1iQbDeJEHECv8y3bphKF+Nhj8VsUXF/Xz2\n CfgYl5HVysPGBuw3ea+809OIkZUzae81lD4Pj4/0gkFlddSIAkAUxr6uJhw5dcWPO/tY\n YTJmJKQwckU6Y8Erm2J6DDpwWJYnehpS1bipqXmOFTQZacnUTKKSin1jIWyrg17Spi7e\n cAwn1JpigpWMQvUCVH15s7I0cM2ae7xvXIBs6sKY9XT+jDGGno5nHluJl/UmHJMMn7jZ\n S+5A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711400063; x=1712004863;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=yt8sOxcACKjNMF6qKstsLWVdnhI7Desd0hXEpONxCMs=;\n b=knFSzPoBh9599yUCvq77n6YgsFFygo9N5oYYIdc9Ds18n5bdbIGYj/PHxBTy7gyPRj\n JOG45U4dhgBSTk3I092XVV3ZqxVvNe3n28h7Ym/zAb6N2WJGTLOPD/NI9bQwD0iiO344\n YsMIS8Wmymt3nx041vLYr3EGIE4Jh4NTrSjcDtyftmZP4bSKzo5RcwNmUze52znARjH/\n wh39+hK+g/bPpPNCkP5tkFcQy5wrjSYqNQ0+osBAJcaUZRmSrlGHGUG41nNjuLumuiv/\n f3CFZc99di39z6/Egn7uOAbW3qoF2XfujHmdX/F6eL5Uy9A8e+1KXK1E5psrbRESEW3d\n C3Yw==", "X-Gm-Message-State": "AOJu0YwlquUcZq+pDji3ACXjmtQVwD59DFgo+CtLZgJkdaZHtIhgr8j9\n P/6I91VglSKO75p7fz0XKnn6MMBCqZPFqGLxoyRBlGHhWvh5+CY1bhfOiSb9qixJAUypPgCr0ik\n O", "X-Google-Smtp-Source": "\n AGHT+IEflYCd1XUvMf1BGOFNRROkOB/RJcJzohkUpsrOpVYX2SuTMgPhUq3i8q8cggS1uxI4dGUI2w==", "X-Received": "by 2002:a05:6a20:6399:b0:1a3:5a55:bfd9 with SMTP id\n m25-20020a056a20639900b001a35a55bfd9mr6197218pzg.21.1711400063655;\n Mon, 25 Mar 2024 13:54:23 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH v12 07/14] eal: initialize log before everything else", "Date": "Mon, 25 Mar 2024 13:47:04 -0700", "Message-ID": "<20240325205405.669897-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240325205405.669897-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240325205405.669897-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In order for all log messages (including CPU mismatch) to\ncome out through the logging library, it must be initialized\nas early in rte_eal_init() as possible on all platforms.\n\nWhere it was done before was likely historical based on\nthe support of non-OS isolated CPU's which required a shared\nmemory buffer; that support was dropped before DPDK was\npublicly released.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/freebsd/eal.c | 8 +++++---\n lib/eal/linux/eal.c | 15 +++++----------\n lib/eal/windows/eal.c | 3 +--\n lib/log/log_freebsd.c | 3 +--\n lib/log/log_internal.h | 2 +-\n lib/log/log_linux.c | 14 ++++++--------\n lib/log/log_windows.c | 4 +---\n 7 files changed, 20 insertions(+), 29 deletions(-)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 6552f9c138..ec3a0c3244 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -52,6 +52,7 @@\n #include \"eal_options.h\"\n #include \"eal_memcfg.h\"\n #include \"eal_trace.h\"\n+#include \"log_internal.h\"\n \n #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)\n \n@@ -546,6 +547,10 @@ rte_eal_init(int argc, char **argv)\n \tbool has_phys_addr;\n \tenum rte_iova_mode iova_mode;\n \n+\t/* setup log as early as possible */\n+\teal_log_level_parse(argc, argv);\n+\teal_log_init(getprogname());\n+\n \t/* checks if the machine is adequate */\n \tif (!rte_cpu_is_supported()) {\n \t\trte_eal_init_alert(\"unsupported cpu type.\");\n@@ -565,9 +570,6 @@ rte_eal_init(int argc, char **argv)\n \t/* clone argv to report out later in telemetry */\n \teal_save_args(argc, argv);\n \n-\t/* set log level as early as possible */\n-\teal_log_level_parse(argc, argv);\n-\n \tif (rte_eal_cpu_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot detect lcores.\");\n \t\trte_errno = ENOTSUP;\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 3d0c34063e..0a488ee567 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -936,6 +936,11 @@ rte_eal_init(int argc, char **argv)\n \tstruct internal_config *internal_conf =\n \t\teal_get_internal_configuration();\n \n+\n+\t/* setup log as early as possible */\n+\teal_log_level_parse(argc, argv);\n+\teal_log_init(program_invocation_short_name);\n+\n \t/* checks if the machine is adequate */\n \tif (!rte_cpu_is_supported()) {\n \t\trte_eal_init_alert(\"unsupported cpu type.\");\n@@ -952,9 +957,6 @@ rte_eal_init(int argc, char **argv)\n \n \teal_reset_internal_config(internal_conf);\n \n-\t/* set log level as early as possible */\n-\teal_log_level_parse(argc, argv);\n-\n \t/* clone argv to report out later in telemetry */\n \teal_save_args(argc, argv);\n \n@@ -1106,13 +1108,6 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n-\tif (eal_log_init(program_invocation_short_name) < 0) {\n-\t\trte_eal_init_alert(\"Cannot init logging.\");\n-\t\trte_errno = ENOMEM;\n-\t\trte_atomic_store_explicit(&run_once, 0, rte_memory_order_relaxed);\n-\t\treturn -1;\n-\t}\n-\n #ifdef VFIO_PRESENT\n \tif (rte_eal_vfio_setup() < 0) {\n \t\trte_eal_init_alert(\"Cannot init VFIO\");\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 2519a30017..fb2920e1b8 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -250,9 +250,8 @@ rte_eal_init(int argc, char **argv)\n \tchar cpuset[RTE_CPU_AFFINITY_STR_LEN];\n \tchar thread_name[RTE_THREAD_NAME_SIZE];\n \n-\teal_log_init(NULL);\n-\n \teal_log_level_parse(argc, argv);\n+\teal_log_init(NULL);\n \n \tif (eal_create_cpu_map() < 0) {\n \t\trte_eal_init_alert(\"Cannot discover CPU and NUMA.\");\ndiff --git a/lib/log/log_freebsd.c b/lib/log/log_freebsd.c\nindex 953e371bee..33a0925c43 100644\n--- a/lib/log/log_freebsd.c\n+++ b/lib/log/log_freebsd.c\n@@ -5,8 +5,7 @@\n #include <rte_common.h>\n #include \"log_internal.h\"\n \n-int\n+void\n eal_log_init(__rte_unused const char *id)\n {\n-\treturn 0;\n }\ndiff --git a/lib/log/log_internal.h b/lib/log/log_internal.h\nindex cb15cdff08..d5fabd7ef7 100644\n--- a/lib/log/log_internal.h\n+++ b/lib/log/log_internal.h\n@@ -14,7 +14,7 @@\n * Initialize the default log stream.\n */\n __rte_internal\n-int eal_log_init(const char *id);\n+void eal_log_init(const char *id);\n \n /*\n * Determine where log data is written when no call to rte_openlog_stream.\ndiff --git a/lib/log/log_linux.c b/lib/log/log_linux.c\nindex 47aa074da2..6d7dc8f3ab 100644\n--- a/lib/log/log_linux.c\n+++ b/lib/log/log_linux.c\n@@ -87,18 +87,16 @@ static cookie_io_functions_t console_log_func = {\n * set the log to default function, called during eal init process,\n * once memzones are available.\n */\n-int\n+void\n eal_log_init(const char *id)\n {\n \tFILE *log_stream;\n \n-\tlog_stream = fopencookie(NULL, \"w+\", console_log_func);\n-\tif (log_stream == NULL)\n-\t\treturn -1;\n-\n \topenlog(id, LOG_NDELAY | LOG_PID, log_facility);\n \n-\teal_log_set_default(log_stream);\n-\n-\treturn 0;\n+\tlog_stream = fopencookie(NULL, \"w+\", console_log_func);\n+\tif (log_stream != NULL)\n+\t\teal_log_set_default(log_stream);\n+\telse\n+\t\teal_log_set_default(stderr);\n }\ndiff --git a/lib/log/log_windows.c b/lib/log/log_windows.c\nindex a3a756351d..d7c30e4cfa 100644\n--- a/lib/log/log_windows.c\n+++ b/lib/log/log_windows.c\n@@ -13,12 +13,10 @@ eal_log_syslog(const char *name __rte_unused)\n }\n \n /* set the log to default function, called during eal init process. */\n-int\n+void\n eal_log_init(__rte_unused const char *id)\n {\n \trte_openlog_stream(stderr);\n \n \teal_log_set_default(stderr);\n-\n-\treturn 0;\n }\n", "prefixes": [ "v12", "07/14" ] }