Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138779/?format=api
http://patchwork.dpdk.org/api/patches/138779/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240325205405.669897-10-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240325205405.669897-10-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240325205405.669897-10-stephen@networkplumber.org", "date": "2024-03-25T20:47:06", "name": "[v12,09/14] log: add hook for printing log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0dac51056037de6cb9b6c1c1e99531e4abef1e9", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240325205405.669897-10-stephen@networkplumber.org/mbox/", "series": [ { "id": 31616, "url": "http://patchwork.dpdk.org/api/series/31616/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31616", "date": "2024-03-25T20:46:57", "name": "Logging unification and enhancements", "version": 12, "mbox": "http://patchwork.dpdk.org/series/31616/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138779/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138779/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 43F3043D49;\n\tMon, 25 Mar 2024 21:55:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E756B40EAB;\n\tMon, 25 Mar 2024 21:54:31 +0100 (CET)", "from mail-pl1-f182.google.com (mail-pl1-f182.google.com\n [209.85.214.182])\n by mails.dpdk.org (Postfix) with ESMTP id 90E8540E0F\n for <dev@dpdk.org>; Mon, 25 Mar 2024 21:54:26 +0100 (CET)", "by mail-pl1-f182.google.com with SMTP id\n d9443c01a7336-1e0d6356ce9so6469865ad.3\n for <dev@dpdk.org>; Mon, 25 Mar 2024 13:54:26 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n b18-20020a170903229200b001e0b5eee802sm3164487plh.123.2024.03.25.13.54.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 25 Mar 2024 13:54:25 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711400066;\n x=1712004866; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=U3Pm2jWPA8CvWVzSCbpUHJ5X5gWKk93CeDmKEZa2qf2WGzpLw9U2C+aKdtH4As9pQ0\n NnlRROzopdzrat3lSGt8RRHozRgv8e8eoB1rNb5p/a+qB7If3JIqr81rz0zXX8iKQO1a\n Vz5N9We6iQDCGiFS7007RFGcQc/ascpI+CfbIcmplXj9XIEmsxd3YVwtC+yxeW2qFimw\n U9u5/H/b/qdFBGIG+V9ErbRWU4kSYbKgPfWlCz3QFlm82tZqhDbPhS//sJP2+Pa7fG2P\n RIT9E9APSiE0qtVQG7Pb/xv7wy20rqHdlRY86QZYGFAmcbL+cRAVOdYgF8qk1eZHKVPd\n anSQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711400066; x=1712004866;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=Ql56zAVTEj4nPrcpFm+8Pjl3fJk8Ujt8VocUmkLiQaPoJlQD75KB6cG4h0+R0/L3yg\n m/K3rfUoM9tox7pxxnuAITgaw1/TRTgEHKuFVR6GyhzY7HFbPxVct5OUKhEkVZS6S2N8\n NZ9y2GfFT4MZovkxh0/8wk3TQ8vepYP7jeDCuZDDLECSePRlpdY1sWdTLPREMUZX5bBI\n Oa3hYaQC51zlZckAyNDJqwn1RpmmXsSJHyy9GICxPjj5gsQ/nAYCnengL3v3Cyy5q4jg\n r36U2tnJkBKjuEnd9fieTwks9jr614elVcJPT5klzvDdaPzMvI4MtapQ1OUF4ffdLKD4\n whRg==", "X-Gm-Message-State": "AOJu0YzH9P2HyxYENR1nX2G7Zf9AQFJrsuTulidgQio2Jsp5sRH9voEG\n wXSmFeGosA9B+A7yhpag2GY/dCg6RyDH3PXndAYCGxvCEKtJ4H5hQ6zWLAN7OnU59XgmsjCw9Sv\n U", "X-Google-Smtp-Source": "\n AGHT+IEzhQllpPHYQWlKQvYb+SaxR9fB1T0nyUgfj4k3GAzY9wjEDIGU8/Qo9R76RUoJ01l8pc5HJw==", "X-Received": "by 2002:a17:903:41c8:b0:1e0:c88f:654b with SMTP id\n u8-20020a17090341c800b001e0c88f654bmr3149091ple.25.1711400065835;\n Mon, 25 Mar 2024 13:54:25 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v12 09/14] log: add hook for printing log messages", "Date": "Mon, 25 Mar 2024 13:47:06 -0700", "Message-ID": "<20240325205405.669897-10-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240325205405.669897-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240325205405.669897-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This is useful for when decorating log output for console\nor journal. Provide basic version in this patch.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/log/log.c | 17 ++++++++++++++++-\n 1 file changed, 16 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/log/log.c b/lib/log/log.c\nindex f597da2e39..acd4c320b6 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -26,16 +26,21 @@ struct rte_log_dynamic_type {\n \tuint32_t loglevel;\n };\n \n+typedef int (*log_print_t)(FILE *f, uint32_t level, const char *fmt, va_list ap);\n+static int log_print(FILE *f, uint32_t level, const char *format, va_list ap);\n+\n /** The rte_log structure. */\n static struct rte_logs {\n \tuint32_t type; /**< Bitfield with enabled logs. */\n \tuint32_t level; /**< Log level. */\n \tFILE *file; /**< Output file set by rte_openlog_stream, or NULL. */\n+\tlog_print_t print_func;\n \tsize_t dynamic_types_len;\n \tstruct rte_log_dynamic_type *dynamic_types;\n } rte_logs = {\n \t.type = UINT32_MAX,\n \t.level = RTE_LOG_DEBUG,\n+\t.print_func = log_print,\n };\n \n struct rte_eal_opt_loglevel {\n@@ -78,6 +83,7 @@ rte_openlog_stream(FILE *f)\n \t\tfclose(rte_logs.file);\n \n \trte_logs.file = f;\n+\trte_logs.print_func = log_print;\n \treturn 0;\n }\n \n@@ -484,7 +490,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)\n \tRTE_PER_LCORE(log_cur_msg).loglevel = level;\n \tRTE_PER_LCORE(log_cur_msg).logtype = logtype;\n \n-\tret = vfprintf(f, format, ap);\n+\tret = (*rte_logs.print_func)(f, level, format, ap);\n \tfflush(f);\n \treturn ret;\n }\n@@ -513,6 +519,15 @@ eal_log_syslog(const char *mode __rte_unused)\n \treturn -1;\n }\n \n+/* default log print function */\n+__rte_format_printf(3, 0)\n+static int\n+log_print(FILE *f, uint32_t level __rte_unused,\n+\t const char *format, va_list ap)\n+{\n+\treturn vfprintf(f, format, ap);\n+}\n+\n /*\n * Called by rte_eal_init\n */\n", "prefixes": [ "v12", "09/14" ] }{ "id": 138779, "url": "