Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138789/?format=api
{ "id": 138789, "url": "http://patchwork.dpdk.org/api/patches/138789/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240326015827.825648-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240326015827.825648-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240326015827.825648-6-stephen@networkplumber.org", "date": "2024-03-26T01:57:00", "name": "[v13,05/11] eal: change rte_exit() output to match rte_log()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6438c0a4dd44d2cb3f4349a2c0986288e5616a2f", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240326015827.825648-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 31617, "url": "http://patchwork.dpdk.org/api/series/31617/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31617", "date": "2024-03-26T01:56:55", "name": "Logging unification and improvements", "version": 13, "mbox": "http://patchwork.dpdk.org/series/31617/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138789/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138789/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 33A1143D4E;\n\tTue, 26 Mar 2024 02:59:11 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BE5FB40E03;\n\tTue, 26 Mar 2024 02:58:48 +0100 (CET)", "from mail-oo1-f52.google.com (mail-oo1-f52.google.com\n [209.85.161.52]) by mails.dpdk.org (Postfix) with ESMTP id 9F69F40A7F\n for <dev@dpdk.org>; Tue, 26 Mar 2024 02:58:43 +0100 (CET)", "by mail-oo1-f52.google.com with SMTP id\n 006d021491bc7-5a470320194so2656994eaf.3\n for <dev@dpdk.org>; Mon, 25 Mar 2024 18:58:43 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n u19-20020a63d353000000b005dc88b232a5sm6571541pgi.26.2024.03.25.18.58.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 25 Mar 2024 18:58:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711418323;\n x=1712023123; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zmgn2TMY0pSmt2vzjAmFWex3Ac/CzGg0VZQ9Pce9n7s=;\n b=to3eoP4HY8GfHipxOPYzJb8A95ZvbN8/9BygwujkCG+2ipf7Km5jc1Q3tovZ+iBjiI\n kN/nEGqS8lf8j2PLT/GogZ4Mz0oi1QI0pax/yGDXkBFbJ/yW8ECvS60xw6F9isW0Dt9y\n +L5q8m+/lccDbLRUjdvGYn7ijFI2c5h20EsHENPyeujXoqeAKH7dw0DuOmumEkApadeT\n H+bO2kOoNwcYogQZiamIBKH+zCJENYJ5l9OLS/l7c3QCe+Gn2mQB0t4rSQmYkVoKp/MS\n AZSFKvw+NwzEECpkjNG6sgSN/fhSlzi+zyzhY+eBksc2B/WGXQdUHfqTGmVN4KUqERDG\n xbRQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711418323; x=1712023123;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zmgn2TMY0pSmt2vzjAmFWex3Ac/CzGg0VZQ9Pce9n7s=;\n b=M0bDMQsmvMN9nkNUYZZJ5csIYblTUFtKnJeXNR/Q+iRS9SzIyrl5FA7y7l4+9slwCm\n bFJxhJhutf4sitTe1yquw2AqS/V0p/mufTCn1SG1icStMCv8fPQDvRYtCca+s2K9UVMI\n zt9lkKCGYN2/86+HcYZK+Zk7DwLpe7peTEKIqea0myvq5zHJjs851UPn7qHx0DMqBbLS\n ojPQJii7+WKIR4gZBRx6N8ymvPr0q7bMX1HQ/ULP8VOqRwdtxKnpRAw5jlBREIiQaENz\n ddaoRvYSpU88+tsjCeGY8CBr4UacWRwCGy7g8SDAsp+VfimuKgFPJ5CyhcsYRXIPnLry\n JEpw==", "X-Gm-Message-State": "AOJu0YyI/1aTPSlfckDK8Yh4nmBFvpzE4WAmT+tf9MY2zSlrR1lQZRfl\n LaoNUH7HrswfQ2s1Ugz0knk5cM5y50FNmxBNzNjRyxJJ8fnLdRqTDgW1ClWUpXBqCmeL/HYcWaL\n e", "X-Google-Smtp-Source": "\n AGHT+IHQ/8iRVuQk0enP1qzdMJ80bTg5Kvb7fcTVI74IfhFvwuytvX2JEsx+djWw4YnP+R8y1Iu2bw==", "X-Received": "by 2002:a05:6358:2621:b0:17e:7c4b:bb56 with SMTP id\n l33-20020a056358262100b0017e7c4bbb56mr10158195rwc.15.1711418322902;\n Mon, 25 Mar 2024 18:58:42 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v13 05/11] eal: change rte_exit() output to match rte_log()", "Date": "Mon, 25 Mar 2024 18:57:00 -0700", "Message-ID": "<20240326015827.825648-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240326015827.825648-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240326015827.825648-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_exit() output format confuses the timestamp and coloring\noptions. Change it to use be a single line with proper prefix.\n\nBefore:\n[ 0.006481] EAL: Error - exiting with code: 1\n Cause: [ 0.006489] Cannot init EAL: Permission denied\n\nAfter:\n[ 0.006238] EAL: Error - exiting with code: 1\n[ 0.006250] EAL: Cause - Cannot init EAL: Permission denied\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_debug.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c\nindex 3e77995896..71bb5a7d34 100644\n--- a/lib/eal/common/eal_common_debug.c\n+++ b/lib/eal/common/eal_common_debug.c\n@@ -34,17 +34,17 @@ void\n rte_exit(int exit_code, const char *format, ...)\n {\n \tva_list ap;\n+\tchar *msg = NULL;\n \n \tif (exit_code != 0)\n-\t\tRTE_LOG(CRIT, EAL, \"Error - exiting with code: %d\\n\"\n-\t\t\t\t\" Cause: \", exit_code);\n+\t\tEAL_LOG(CRIT, \"Error - exiting with code: %d\", exit_code);\n \n \tva_start(ap, format);\n-\trte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);\n+\tif (vasprintf(&msg, format, ap) > 0)\n+\t\trte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, \"EAL: Cause - %s\", msg);\n \tva_end(ap);\n \n \tif (rte_eal_cleanup() != 0 && rte_errno != EALREADY)\n-\t\tEAL_LOG(CRIT,\n-\t\t\t\"EAL could not release all resources\");\n+\t\tEAL_LOG(CRIT, \"EAL could not release all resources\");\n \texit(exit_code);\n }\n", "prefixes": [ "v13", "05/11" ] }