Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138818/?format=api
{ "id": 138818, "url": "http://patchwork.dpdk.org/api/patches/138818/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240326173552.97249-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240326173552.97249-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240326173552.97249-8-stephen@networkplumber.org", "date": "2024-03-26T17:34:27", "name": "[v14,07/15] eal: change rte_exit() output to match rte_log()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6438c0a4dd44d2cb3f4349a2c0986288e5616a2f", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240326173552.97249-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 31621, "url": "http://patchwork.dpdk.org/api/series/31621/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31621", "date": "2024-03-26T17:34:20", "name": "Logging unification and improvments", "version": 14, "mbox": "http://patchwork.dpdk.org/series/31621/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138818/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138818/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 80C2443D5A;\n\tTue, 26 Mar 2024 18:36:54 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 153864113D;\n\tTue, 26 Mar 2024 18:36:16 +0100 (CET)", "from mail-pf1-f169.google.com (mail-pf1-f169.google.com\n [209.85.210.169])\n by mails.dpdk.org (Postfix) with ESMTP id 77122410D3\n for <dev@dpdk.org>; Tue, 26 Mar 2024 18:36:10 +0100 (CET)", "by mail-pf1-f169.google.com with SMTP id\n d2e1a72fcca58-6e6b6f86975so3729568b3a.1\n for <dev@dpdk.org>; Tue, 26 Mar 2024 10:36:10 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n u6-20020aa78386000000b006e58da8bb6asm6205546pfm.132.2024.03.26.10.36.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 26 Mar 2024 10:36:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711474569;\n x=1712079369; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zmgn2TMY0pSmt2vzjAmFWex3Ac/CzGg0VZQ9Pce9n7s=;\n b=gy41fnNZEOidULJp4fmzQB/si1whEexsTvFTwG4Y4kZswmbItnbfsj8CyVK+pd1I7/\n WWHpVubRCZMrGzCta69x0gTNteQf5vcpbMcuOJ1QGuviWQ1y2+UAB9Pqup2Gs710bhOH\n /E/GxZeqsKqe1216y+8qUOsw4GEMCkDd0CeA0vWyt3f/+Xotcuj2OSOORYzGJpAwy9/b\n L+KGHymYG/9/Gh8slcuCnNDLONlEft0QPiRZxOfMRO4WGRIJXr2ry6cQ+UMy7yNq7MkR\n Xi7CbqpCQGyF7BsurbsEUU1il5zbqg9YxPDmLDASZ28k0yHkObivNFbSgWbYacXmPLTr\n M08w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711474569; x=1712079369;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zmgn2TMY0pSmt2vzjAmFWex3Ac/CzGg0VZQ9Pce9n7s=;\n b=lOVA/712E4sbJlJKhAGZFgskJyOyhcaO/J46XAhaI5dq2Sg6HttXox9LykpnSu2GBA\n 80DYpcQea/4OQ5jsKj+J8QTrmkwgr4Qbv2q99Ro2lJZa0aRmIU/cFgrOqsO6PBvcMxOl\n Knp1ybhiTDJWXxC9svvgu9c9K0vgB5yjEMke2cu8C//9Bd77V9UtIfLfghA6bmRhbFp7\n EgTtw3eIn9wven6QvspQ825OFHd3fzTIpmJJVBFy0RXjiwx0WlH8IY6EU7c/ipQxG2AE\n aLeNS0FpxrUDE5+oIDX0HeLz6vx82/qlHigo4y7xa2Qt3gf7mwUoy6NNtcyAN5ze+70B\n zgNA==", "X-Gm-Message-State": "AOJu0Yx6i9prm7PO+kXC4DMpFgeVnttjNcpoON5Lea/SKP+oVwr1cYR5\n e7CU7G9FT3WXKIBI4Xh+D0bZ9NUrrNa3Q2VQA+pCNrUE/zUFuLxe686zdSna16NN2Jq2sNzBBfI\n 5", "X-Google-Smtp-Source": "\n AGHT+IG7R2De2rQenbHh+knaBLL6WaEtIWt6kFH1GAvxqamWZobxNQwuMZ4RZAg0QXUYHD1kO0xm5w==", "X-Received": "by 2002:a05:6a00:701e:b0:6ea:c04c:71cb with SMTP id\n lf30-20020a056a00701e00b006eac04c71cbmr1200172pfb.3.1711474569671;\n Tue, 26 Mar 2024 10:36:09 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v14 07/15] eal: change rte_exit() output to match rte_log()", "Date": "Tue, 26 Mar 2024 10:34:27 -0700", "Message-ID": "<20240326173552.97249-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240326173552.97249-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240326173552.97249-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_exit() output format confuses the timestamp and coloring\noptions. Change it to use be a single line with proper prefix.\n\nBefore:\n[ 0.006481] EAL: Error - exiting with code: 1\n Cause: [ 0.006489] Cannot init EAL: Permission denied\n\nAfter:\n[ 0.006238] EAL: Error - exiting with code: 1\n[ 0.006250] EAL: Cause - Cannot init EAL: Permission denied\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_debug.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c\nindex 3e77995896..71bb5a7d34 100644\n--- a/lib/eal/common/eal_common_debug.c\n+++ b/lib/eal/common/eal_common_debug.c\n@@ -34,17 +34,17 @@ void\n rte_exit(int exit_code, const char *format, ...)\n {\n \tva_list ap;\n+\tchar *msg = NULL;\n \n \tif (exit_code != 0)\n-\t\tRTE_LOG(CRIT, EAL, \"Error - exiting with code: %d\\n\"\n-\t\t\t\t\" Cause: \", exit_code);\n+\t\tEAL_LOG(CRIT, \"Error - exiting with code: %d\", exit_code);\n \n \tva_start(ap, format);\n-\trte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);\n+\tif (vasprintf(&msg, format, ap) > 0)\n+\t\trte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, \"EAL: Cause - %s\", msg);\n \tva_end(ap);\n \n \tif (rte_eal_cleanup() != 0 && rte_errno != EALREADY)\n-\t\tEAL_LOG(CRIT,\n-\t\t\t\"EAL could not release all resources\");\n+\t\tEAL_LOG(CRIT, \"EAL could not release all resources\");\n \texit(exit_code);\n }\n", "prefixes": [ "v14", "07/15" ] }