Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138839/?format=api
http://patchwork.dpdk.org/api/patches/138839/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240327002859.203006-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240327002859.203006-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240327002859.203006-8-stephen@networkplumber.org", "date": "2024-03-27T00:27:06", "name": "[v15,07/15] eal: change rte_exit() output to match rte_log()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6438c0a4dd44d2cb3f4349a2c0986288e5616a2f", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240327002859.203006-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 31623, "url": "http://patchwork.dpdk.org/api/series/31623/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31623", "date": "2024-03-27T00:26:59", "name": "Logging unification and improvements", "version": 15, "mbox": "http://patchwork.dpdk.org/series/31623/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138839/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138839/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E29F543D5B;\n\tWed, 27 Mar 2024 01:30:01 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 06E7242D26;\n\tWed, 27 Mar 2024 01:29:22 +0100 (CET)", "from mail-pf1-f176.google.com (mail-pf1-f176.google.com\n [209.85.210.176])\n by mails.dpdk.org (Postfix) with ESMTP id A08894113D\n for <dev@dpdk.org>; Wed, 27 Mar 2024 01:29:15 +0100 (CET)", "by mail-pf1-f176.google.com with SMTP id\n d2e1a72fcca58-6e703e0e5deso4471092b3a.3\n for <dev@dpdk.org>; Tue, 26 Mar 2024 17:29:15 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n w15-20020a17090ad60f00b002a04eef22c5sm225383pju.44.2024.03.26.17.29.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 26 Mar 2024 17:29:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711499355;\n x=1712104155; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zmgn2TMY0pSmt2vzjAmFWex3Ac/CzGg0VZQ9Pce9n7s=;\n b=WymigXrHVEZzpyQ6kflD7zIAR9R4mf4VkX2hJ63oYwLRBBJhCme0xdcMa+O98FAGhX\n Tfq+uuRsDxrBrp6bGDDAZLghOafgJ+ORIlvyrRyj980pmW7NmjlJPp0+0symDmaOQWwe\n PHodtGBS1fWTT3ei+/sCwYhbkVYoMTxskaVTVi1W+j0aEPsHjmjNsZ17GOjx/PhWZqvZ\n +bulMJTrTCKOoCbQocWHw68RSkR2DvjZvhDTkxvUtkqfY67JayrCYr6/v4JUHvKxGO6e\n K32XEdE5Qi2mwfIrBX/5KQrMineJ+jm7v4PAsZHM6FI/KqgKKzGzAox+7NwaLAVEyJ49\n LrnA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711499355; x=1712104155;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zmgn2TMY0pSmt2vzjAmFWex3Ac/CzGg0VZQ9Pce9n7s=;\n b=dW3MTJkwC2qsPHhUTeytAk+IkBN0qFZKHkYwqihsWzee9DiwMm0TSS3FGq8tudBGek\n L4UT8d9IzxQhMHcPn50xbbCFXnbwUzs4EHq41OM+3/KLbFKVFz7aB2W5ADK4Vf4XpAkO\n 8u/+YWjJXmM2ZpgadwrnuE06/RSYRDzG/4wp6gCuWyPKDeYRY+ZyZLUmh2/pSv5qVLYn\n mPdiPYx6r6dXoxbis0XsElMeVCpSyZmkZ9Fhw6or3lpETrdFwA13J9KQKIEF628SEcaR\n 4UvcvFTednKXk66vOrgrrAllz0QFpAvJ73EiDkrrqVFxeQTK/YqQQP+hDreHr9LLMrMD\n m0gQ==", "X-Gm-Message-State": "AOJu0YxsGOvpMM0wyIY7Eq8xt1gu1ch8SIRxp/Fa9cPU9yOTPXJIlgd7\n Fbxyw7KhnzITkWTG/CLHnX1eKO3tMoC+xKfeC6db8GLZlyq3BFfN/Lkjx5WVc80/AW+Fi5jEMrh\n /", "X-Google-Smtp-Source": "\n AGHT+IHnItVOiGjZeYVK/k+28YX0bSioWztqUwNFJyP35iJ5qeW7KoY94PtAXngonXAHeTpj17FPrg==", "X-Received": "by 2002:a05:6a21:788e:b0:1a3:a639:ef7c with SMTP id\n bf14-20020a056a21788e00b001a3a639ef7cmr1640584pzc.1.1711499354848;\n Tue, 26 Mar 2024 17:29:14 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v15 07/15] eal: change rte_exit() output to match rte_log()", "Date": "Tue, 26 Mar 2024 17:27:06 -0700", "Message-ID": "<20240327002859.203006-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240327002859.203006-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240327002859.203006-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_exit() output format confuses the timestamp and coloring\noptions. Change it to use be a single line with proper prefix.\n\nBefore:\n[ 0.006481] EAL: Error - exiting with code: 1\n Cause: [ 0.006489] Cannot init EAL: Permission denied\n\nAfter:\n[ 0.006238] EAL: Error - exiting with code: 1\n[ 0.006250] EAL: Cause - Cannot init EAL: Permission denied\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_debug.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c\nindex 3e77995896..71bb5a7d34 100644\n--- a/lib/eal/common/eal_common_debug.c\n+++ b/lib/eal/common/eal_common_debug.c\n@@ -34,17 +34,17 @@ void\n rte_exit(int exit_code, const char *format, ...)\n {\n \tva_list ap;\n+\tchar *msg = NULL;\n \n \tif (exit_code != 0)\n-\t\tRTE_LOG(CRIT, EAL, \"Error - exiting with code: %d\\n\"\n-\t\t\t\t\" Cause: \", exit_code);\n+\t\tEAL_LOG(CRIT, \"Error - exiting with code: %d\", exit_code);\n \n \tva_start(ap, format);\n-\trte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);\n+\tif (vasprintf(&msg, format, ap) > 0)\n+\t\trte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, \"EAL: Cause - %s\", msg);\n \tva_end(ap);\n \n \tif (rte_eal_cleanup() != 0 && rte_errno != EALREADY)\n-\t\tEAL_LOG(CRIT,\n-\t\t\t\"EAL could not release all resources\");\n+\t\tEAL_LOG(CRIT, \"EAL could not release all resources\");\n \texit(exit_code);\n }\n", "prefixes": [ "v15", "07/15" ] }{ "id": 138839, "url": "