Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138843/?format=api
{ "id": 138843, "url": "http://patchwork.dpdk.org/api/patches/138843/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240327002859.203006-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240327002859.203006-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240327002859.203006-12-stephen@networkplumber.org", "date": "2024-03-27T00:27:10", "name": "[v15,11/15] log: add hook for printing log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0dac51056037de6cb9b6c1c1e99531e4abef1e9", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240327002859.203006-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 31623, "url": "http://patchwork.dpdk.org/api/series/31623/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31623", "date": "2024-03-27T00:26:59", "name": "Logging unification and improvements", "version": 15, "mbox": "http://patchwork.dpdk.org/series/31623/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138843/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A82C43D5B;\n\tWed, 27 Mar 2024 01:30:36 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 28CDB42DB2;\n\tWed, 27 Mar 2024 01:29:30 +0100 (CET)", "from mail-pg1-f179.google.com (mail-pg1-f179.google.com\n [209.85.215.179])\n by mails.dpdk.org (Postfix) with ESMTP id 0974A427DD\n for <dev@dpdk.org>; Wed, 27 Mar 2024 01:29:19 +0100 (CET)", "by mail-pg1-f179.google.com with SMTP id\n 41be03b00d2f7-5e4f79007ffso3981630a12.2\n for <dev@dpdk.org>; Tue, 26 Mar 2024 17:29:18 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n w15-20020a17090ad60f00b002a04eef22c5sm225383pju.44.2024.03.26.17.29.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 26 Mar 2024 17:29:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711499358;\n x=1712104158; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=TMG1/ygWZ3Pt3CptFdbW8cFI4ImJqDhmvYP5qdG2wC4fKVK4cBC6RK/rxDfd6tO/SA\n MRRZTOnrI+fUcgDiPzsJi7DWl/R+DY2jbWABNeVetUrQYcKn77YdSrtuSJXv4RIjown9\n p7MYYPua2vJVlKMxSZd3qDzY3LHIdpHRdgI7fmO0u3HxYeL4B9WBfDyox+Z6eeXvry3e\n ST6EIPe2SfP27wF4a9tWZyX94/TpJ+nFGq92oG/vpBD33CRi5VxyszLceS1n0tmGdnBq\n U4dBHtqADHgKyTLAI21KcVvZwGd8G9uTmLKTDQ7tub7+ORULWpsex7fcYLHI/kGZKwTN\n 2rrQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711499358; x=1712104158;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zu4Y35qfKTRMkWDem+dq2ZFz0NT/aAm4UNjlX7qaan4=;\n b=iQ4cI+mvkbVWYBbONyvGmpj9GBv7/3WlfLTw/gFh8m/tE2xV90EqJ13OOf/+1hYoHC\n p5y4OUbPwbnrCRP/XKu0LbdlOERY2yE3LFZLRVqvgRXQ2Zav348qT39945GeAAd0lFEy\n adQbxvRVgbKEwanTb0+9i8ArIVPqfQeEJr6b4+XhxqKXZYX2DLSjGY49wxniNhXpVJDI\n qpHYMH7V+d/fcGokQvjac4obp9tYcN7RYnklOhkVrNFT3XM82bWQx/Srpnh8zfDUJIOO\n YN+FpIzwrXmYNjOZ13g9YAWbdO+QFPViQQoMnkDxOiifuiJnUybBSSNRVZIbbRsa0qZn\n SFsQ==", "X-Gm-Message-State": "AOJu0Yxot+M4ujWAzeVKVqxfePErq557AcaycfNhvIJJCyc8YbXYay7+\n E3YCmCektdIyHyFtsWF56whsR5pgcjMkoSLCElldofFSI1JnhT/LqFtBD+9HejS9vkUNo8uQXY+\n Q", "X-Google-Smtp-Source": "\n AGHT+IEbEvny1BBv5NyxYIp/I+EYxyFGoqOp4Giovaqmd+6zS6Clkr9cVR931NPaFKHTDUcPwaVn2Q==", "X-Received": "by 2002:a17:90a:da05:b0:29d:e004:f8ce with SMTP id\n e5-20020a17090ada0500b0029de004f8cemr2912340pjv.6.1711499358236;\n Tue, 26 Mar 2024 17:29:18 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v15 11/15] log: add hook for printing log messages", "Date": "Tue, 26 Mar 2024 17:27:10 -0700", "Message-ID": "<20240327002859.203006-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240327002859.203006-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240327002859.203006-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This is useful for when decorating log output for console\nor journal. Provide basic version in this patch.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/log/log.c | 17 ++++++++++++++++-\n 1 file changed, 16 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/log/log.c b/lib/log/log.c\nindex f597da2e39..acd4c320b6 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -26,16 +26,21 @@ struct rte_log_dynamic_type {\n \tuint32_t loglevel;\n };\n \n+typedef int (*log_print_t)(FILE *f, uint32_t level, const char *fmt, va_list ap);\n+static int log_print(FILE *f, uint32_t level, const char *format, va_list ap);\n+\n /** The rte_log structure. */\n static struct rte_logs {\n \tuint32_t type; /**< Bitfield with enabled logs. */\n \tuint32_t level; /**< Log level. */\n \tFILE *file; /**< Output file set by rte_openlog_stream, or NULL. */\n+\tlog_print_t print_func;\n \tsize_t dynamic_types_len;\n \tstruct rte_log_dynamic_type *dynamic_types;\n } rte_logs = {\n \t.type = UINT32_MAX,\n \t.level = RTE_LOG_DEBUG,\n+\t.print_func = log_print,\n };\n \n struct rte_eal_opt_loglevel {\n@@ -78,6 +83,7 @@ rte_openlog_stream(FILE *f)\n \t\tfclose(rte_logs.file);\n \n \trte_logs.file = f;\n+\trte_logs.print_func = log_print;\n \treturn 0;\n }\n \n@@ -484,7 +490,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)\n \tRTE_PER_LCORE(log_cur_msg).loglevel = level;\n \tRTE_PER_LCORE(log_cur_msg).logtype = logtype;\n \n-\tret = vfprintf(f, format, ap);\n+\tret = (*rte_logs.print_func)(f, level, format, ap);\n \tfflush(f);\n \treturn ret;\n }\n@@ -513,6 +519,15 @@ eal_log_syslog(const char *mode __rte_unused)\n \treturn -1;\n }\n \n+/* default log print function */\n+__rte_format_printf(3, 0)\n+static int\n+log_print(FILE *f, uint32_t level __rte_unused,\n+\t const char *format, va_list ap)\n+{\n+\treturn vfprintf(f, format, ap);\n+}\n+\n /*\n * Called by rte_eal_init\n */\n", "prefixes": [ "v15", "11/15" ] }