Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138863/?format=api
http://patchwork.dpdk.org/api/patches/138863/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240327164726.68732-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240327164726.68732-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240327164726.68732-8-stephen@networkplumber.org", "date": "2024-03-27T16:45:25", "name": "[v16,07/15] eal: change rte_exit() output to match rte_log()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fbc4ae53bc33cc48298d44fab2e03865203ac018", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240327164726.68732-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 31630, "url": "http://patchwork.dpdk.org/api/series/31630/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31630", "date": "2024-03-27T16:45:18", "name": "Logging unification and improvements", "version": 16, "mbox": "http://patchwork.dpdk.org/series/31630/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138863/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/138863/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 255D843D55;\n\tWed, 27 Mar 2024 17:48:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 93ABC42830;\n\tWed, 27 Mar 2024 17:47:47 +0100 (CET)", "from mail-pf1-f178.google.com (mail-pf1-f178.google.com\n [209.85.210.178])\n by mails.dpdk.org (Postfix) with ESMTP id 4E561410E3\n for <dev@dpdk.org>; Wed, 27 Mar 2024 17:47:42 +0100 (CET)", "by mail-pf1-f178.google.com with SMTP id\n d2e1a72fcca58-6e6fb9a494aso94601b3a.0\n for <dev@dpdk.org>; Wed, 27 Mar 2024 09:47:42 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n a33-20020a056a0011e100b006e580678dfbsm5160873pfu.193.2024.03.27.09.47.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 27 Mar 2024 09:47:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711558061;\n x=1712162861; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=z1Ss/Jo5pzxKGB7DFQyYr6zCqpXokQnGKUO4mVGS4XE=;\n b=oLG7VPi14UvWYVk3aGh7lj8Ghj5O66kgZqk3Rk0fLAD/1Zirwr0MzrjyF1R7U8BUjR\n FMTqooTFyVqKZ1vPuaWXIjKaS1yX+Pk3mov8IHAibncUwfPRVOun385Fshr3gZTx8e/f\n UWWa3KdrN8tClHtFYERK9JsPQWVhoRotsE4ee0VLjRPfATT6smHwwtoF7pXyJHiNt7cb\n qOmOHlCm4rpNkP1r8F+Fh9rT/9ZbjcCWXL2G6M8cizV4FIDI+E7rlAYTGLiUgGsnf8xb\n FA5AWpiErlTV6oJ+rL16ZcSMoC0wj3iFTWOefLn8r3sQSWPnyo2wsZbz5oFKCoyO/6ka\n /p8g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711558061; x=1712162861;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=z1Ss/Jo5pzxKGB7DFQyYr6zCqpXokQnGKUO4mVGS4XE=;\n b=Z61FIaDXwj3qfEp1HnAyu92cwSqHmEIR6bRZvRz71UYMGE4NQjQKozRnXwx9DCK3ro\n bO30oGFGSvOJjHURHe6wzgkmjIMqqeNM8g5kHaqXgK9inTIKqq/o+WpxjfUNnSfo0M7r\n Vlni8qecm7At+TR2mZtk099Ukey/yMJ4BO6I1pK4nsgbBS9Xh8Jett4FCzJhITCPIBN4\n BRI14+60Mv/QwB3y3HX1Qt7PE06Xwl151Bq3m1wOT1JukAN+3sYNk5NHPvBHjyxau27T\n 8TMemL4OLTBAXMYcFydp3IBwJ3VaagdOmXlZ8QagRwR7GYqld7eJPARju1e/utAxuwIL\n 1nXQ==", "X-Gm-Message-State": "AOJu0Ywyu2Hiti/suPSs0EMZZnKUjwTSW/H7GuSBoIHqjH4LYXB737CX\n x5MzTKzmU0oHsgsOUhbb1Du8rQZ6RJQXTPD7t/KqpaEsE5fO+fS88rChL4qZQI21hhuUjUoQAIc\n m", "X-Google-Smtp-Source": "\n AGHT+IFtK117H8tpJZOlFu6czXRngkLIhYRlgUHgVZ3lGYK15BgHWxOrNh0zsScSOQQlZWjFL9D7Tw==", "X-Received": "by 2002:a05:6a20:bca9:b0:1a3:df1a:271e with SMTP id\n fx41-20020a056a20bca900b001a3df1a271emr481164pzb.19.1711558061535;\n Wed, 27 Mar 2024 09:47:41 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v16 07/15] eal: change rte_exit() output to match rte_log()", "Date": "Wed, 27 Mar 2024 09:45:25 -0700", "Message-ID": "<20240327164726.68732-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240327164726.68732-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240327164726.68732-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_exit() output format confuses the timestamp and coloring\noptions. Change it to use be a single line with proper prefix.\n\nBefore:\n[ 0.006481] EAL: Error - exiting with code: 1\n Cause: [ 0.006489] Cannot init EAL: Permission denied\n\nAfter:\n[ 0.006238] EAL: Error - exiting with code: 1\n[ 0.006250] EAL: Cause - Cannot init EAL: Permission denied\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_debug.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c\nindex 3e77995896..ad2be63cbb 100644\n--- a/lib/eal/common/eal_common_debug.c\n+++ b/lib/eal/common/eal_common_debug.c\n@@ -34,17 +34,18 @@ void\n rte_exit(int exit_code, const char *format, ...)\n {\n \tva_list ap;\n+\tchar msg[256];\n \n \tif (exit_code != 0)\n-\t\tRTE_LOG(CRIT, EAL, \"Error - exiting with code: %d\\n\"\n-\t\t\t\t\" Cause: \", exit_code);\n+\t\tEAL_LOG(CRIT, \"Error - exiting with code: %d\", exit_code);\n \n \tva_start(ap, format);\n-\trte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);\n+\tvsnprintf(msg, sizeof(msg), format, ap);\n \tva_end(ap);\n \n+\trte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, \"EAL: Cause - %s\", msg);\n+\n \tif (rte_eal_cleanup() != 0 && rte_errno != EALREADY)\n-\t\tEAL_LOG(CRIT,\n-\t\t\t\"EAL could not release all resources\");\n+\t\tEAL_LOG(CRIT, \"EAL could not release all resources\");\n \texit(exit_code);\n }\n", "prefixes": [ "v16", "07/15" ] }{ "id": 138863, "url": "