Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138875/?format=api
http://patchwork.dpdk.org/api/patches/138875/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1711569406-7750-5-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1711569406-7750-5-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1711569406-7750-5-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-27T19:56:46", "name": "[v8,4/4] cryptodev: remove rte marker fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6081738872b51dfe5f40172009614dcda535e16f", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1711569406-7750-5-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31632, "url": "http://patchwork.dpdk.org/api/series/31632/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31632", "date": "2024-03-27T19:56:43", "name": "remove use of RTE_MARKER fields in libraries", "version": 8, "mbox": "http://patchwork.dpdk.org/series/31632/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/138875/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/138875/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49D6243D0E;\n\tWed, 27 Mar 2024 20:57:06 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C78A94114B;\n\tWed, 27 Mar 2024 20:56:53 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 3D24740ED6\n for <dev@dpdk.org>; Wed, 27 Mar 2024 20:56:49 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 590DB20E65C9; Wed, 27 Mar 2024 12:56:48 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 590DB20E65C9", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1711569408;\n bh=xXPBSTBYR89fi6Efp1CFWXU0jLlM7T2XYANjF/S3koo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=DtJ7hxSB6bQXhwzvZq4037rrEm1WLzyLfLcHGOKAn1JGGqvGpQqx4FguAQRRtlflc\n V9SkFQr7+/DAKtKv3Bg5ui43FEqP4RZvCllRYGXXNfX+9zC/8dnXXCveGruXWczElP\n YESMcUI+rZei/wcXUCxmi8lXXZbLTpUsLFO6DJcQ=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v8 4/4] cryptodev: remove rte marker fields", "Date": "Wed, 27 Mar 2024 12:56:46 -0700", "Message-Id": "<1711569406-7750-5-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1711569406-7750-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1711569406-7750-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove\nRTE_MARKER fields from rte_mbuf struct.\n\nMaintain alignment of fields after removed cacheline1 marker by placing\nC11 alignas(RTE_CACHE_LINE_MIN_SIZE).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nReviewed-by: Morten Brørup <mb@smartsharesystems.com>\n---\n doc/guides/rel_notes/release_24_03.rst | 3 +++\n lib/cryptodev/cryptodev_pmd.h | 5 +++--\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst\nindex 83ceea7..98ab3cd 100644\n--- a/doc/guides/rel_notes/release_24_03.rst\n+++ b/doc/guides/rel_notes/release_24_03.rst\n@@ -222,6 +222,9 @@ Removed Items\n * security: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``\n have been removed from ``struct rte_security_session``.\n \n+* cryptodev: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``\n+ have been removed from ``struct cryptodev_driver``.\n+\n API Changes\n -----------\n \ndiff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h\nindex d195b81..9daf129 100644\n--- a/lib/cryptodev/cryptodev_pmd.h\n+++ b/lib/cryptodev/cryptodev_pmd.h\n@@ -5,6 +5,8 @@\n #ifndef _CRYPTODEV_PMD_H_\n #define _CRYPTODEV_PMD_H_\n \n+#include <stdalign.h>\n+\n #ifdef __cplusplus\n extern \"C\" {\n #endif\n@@ -139,7 +141,6 @@ struct cryptodev_driver {\n * has a fixed algo, key, op-type, digest_len etc.\n */\n struct rte_cryptodev_sym_session {\n-\tRTE_MARKER cacheline0;\n \tuint64_t opaque_data;\n \t/**< Can be used for external metadata */\n \tuint32_t sess_data_sz;\n@@ -151,7 +152,7 @@ struct rte_cryptodev_sym_session {\n \trte_iova_t driver_priv_data_iova;\n \t/**< Session driver data IOVA address */\n \n-\talignas(RTE_CACHE_LINE_MIN_SIZE) RTE_MARKER cacheline1;\n+\talignas(RTE_CACHE_LINE_MIN_SIZE)\n \t/**< Second cache line - start of the driver session data */\n \tuint8_t driver_priv_data[];\n \t/**< Driver specific session data, variable size */\n", "prefixes": [ "v8", "4/4" ] }{ "id": 138875, "url": "