Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139006/?format=api
{ "id": 139006, "url": "http://patchwork.dpdk.org/api/patches/139006/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240330164433.50144-11-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240330164433.50144-11-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240330164433.50144-11-stephen@networkplumber.org", "date": "2024-03-30T16:42:21", "name": "[v20,10/14] log: add hook for printing log messages", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ab13e106776505aad68f02a9aa3dcb3fa1c4eb04", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240330164433.50144-11-stephen@networkplumber.org/mbox/", "series": [ { "id": 31649, "url": "http://patchwork.dpdk.org/api/series/31649/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31649", "date": "2024-03-30T16:42:11", "name": "Logging unification and improvements", "version": 20, "mbox": "http://patchwork.dpdk.org/series/31649/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139006/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139006/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3498D43D85;\n\tSat, 30 Mar 2024 17:46:00 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CD7D740A75;\n\tSat, 30 Mar 2024 17:45:02 +0100 (CET)", "from mail-oa1-f44.google.com (mail-oa1-f44.google.com\n [209.85.160.44]) by mails.dpdk.org (Postfix) with ESMTP id 75F7B402EE\n for <dev@dpdk.org>; Sat, 30 Mar 2024 17:44:52 +0100 (CET)", "by mail-oa1-f44.google.com with SMTP id\n 586e51a60fabf-22a96054726so2131120fac.0\n for <dev@dpdk.org>; Sat, 30 Mar 2024 09:44:52 -0700 (PDT)", "from hermes.local (204-195-123-203.wavecable.com. [204.195.123.203])\n by smtp.gmail.com with ESMTPSA id\n by1-20020a056a02058100b005dc26144d96sm4192417pgb.75.2024.03.30.09.44.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 30 Mar 2024 09:44:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1711817092;\n x=1712421892; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=PJaBt95mJGUWxHM6IfnmZOombz4LVzOya7YPQnoawfY=;\n b=fRTRzeLf4wTFUC+Wg+cVLMIZBI4n9evsB9k3McvrbZ42pWFJ5j6U5IZbK8W8xZGy47\n dwJtuLx14grJoSi0xHW/i9LuaxwYF7iTssXg3R+Qbxm/LZ0s+iw7dLdhFCkQvX4sKQjF\n ehqGNUpNoEoEmNjv2oEdOOKGhI73MXMcTdNe+ByV/OBVL2npVNctAmSsIAYPybi0cItG\n rDEmMumDt2ofsaOdrdcfIrghRoslToP6fzebYVQd50c9aw4R7eFaoer4hJchqb2EXT+t\n z7O/eYGWBj0A1Y55WGqCdewBUHaCZGqyUskQ23wU9LLLbE5eI4jQm6YaqpYN4cm+Ea49\n HnNQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1711817092; x=1712421892;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=PJaBt95mJGUWxHM6IfnmZOombz4LVzOya7YPQnoawfY=;\n b=DqQx9nP1DamwV4AY7IYdfTDnAfuHI56cbwSfGg4dNnkQnRoBe1ZADm0ADl0CehraIM\n vzSdMklY4iuZkPLGPSyR8OzS7vpCOGXdmy0rtG2L7odpmy/SlQh1FnOi9hXeuoCYUyxG\n 5hKMw2fy7SrjXroVfN9OmrmPjpYsxb6VFivWfz4JFgE+t+TVJIzy9X4SmWuhNULLfXcu\n TLvF/Tt8jlKAKjBPVZBHcCvr11yQDyKLGyzrIMRPfFbQB/byxM7WtSJm7I8oCrgxTx0x\n 4/ypR1+qB2Ji4FJ9rWG6GaAUecMhfH61npnsdlc8sNGSKnrwX+MmY2++ht9sUzn6FpjC\n 4Qnw==", "X-Gm-Message-State": "AOJu0YwL4quYqIaJxbqS7wuM6M0ohQ6IzWNl5fOEAX6pEvFy7KOEpOFg\n nUo587BExxga0Q4K6ZlrugTfMUiQYf+Cq6CsglGZighFdCWNHc///2bnSUNj9+WyDZqmDih35Kx\n a", "X-Google-Smtp-Source": "\n AGHT+IE1adO28ODmnxVCQKhRFYqS7+Slmxdlk0TJE4keDnHmx+e+qfOWSW+WBKRx9W4ZhvuBlT4cZQ==", "X-Received": "by 2002:a05:6870:2199:b0:22e:dce:39b6 with SMTP id\n l25-20020a056870219900b0022e0dce39b6mr3642298oae.48.1711817091844;\n Sat, 30 Mar 2024 09:44:51 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v20 10/14] log: add hook for printing log messages", "Date": "Sat, 30 Mar 2024 09:42:21 -0700", "Message-ID": "<20240330164433.50144-11-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240330164433.50144-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20240330164433.50144-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This is useful for when decorating log output for console\nor journal. Provide basic version in this patch.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/log/log.c | 7 ++++++-\n lib/log/log_private.h | 9 +++++++++\n 2 files changed, 15 insertions(+), 1 deletion(-)\n create mode 100644 lib/log/log_private.h", "diff": "diff --git a/lib/log/log.c b/lib/log/log.c\nindex 3fe86ddcd7..979b20c3ef 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -18,6 +18,7 @@\n #include <rte_per_lcore.h>\n \n #include \"log_internal.h\"\n+#include \"log_private.h\"\n \n #ifdef RTE_EXEC_ENV_WINDOWS\n #define strdup _strdup\n@@ -28,16 +29,19 @@ struct rte_log_dynamic_type {\n \tuint32_t loglevel;\n };\n \n+\n /** The rte_log structure. */\n static struct rte_logs {\n \tuint32_t type; /**< Bitfield with enabled logs. */\n \tuint32_t level; /**< Log level. */\n \tFILE *file; /**< Output file set by rte_openlog_stream, or NULL. */\n+\tlog_print_t print_func;\n \tsize_t dynamic_types_len;\n \tstruct rte_log_dynamic_type *dynamic_types;\n } rte_logs = {\n \t.type = UINT32_MAX,\n \t.level = RTE_LOG_DEBUG,\n+\t.print_func = vfprintf,\n };\n \n struct rte_eal_opt_loglevel {\n@@ -74,6 +78,7 @@ int\n rte_openlog_stream(FILE *f)\n {\n \trte_logs.file = f;\n+\trte_logs.print_func = vfprintf;\n \treturn 0;\n }\n \n@@ -470,7 +475,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)\n \tRTE_PER_LCORE(log_cur_msg).loglevel = level;\n \tRTE_PER_LCORE(log_cur_msg).logtype = logtype;\n \n-\tret = vfprintf(f, format, ap);\n+\tret = (*rte_logs.print_func)(f, format, ap);\n \tfflush(f);\n \treturn ret;\n }\ndiff --git a/lib/log/log_private.h b/lib/log/log_private.h\nnew file mode 100644\nindex 0000000000..67d2463b2f\n--- /dev/null\n+++ b/lib/log/log_private.h\n@@ -0,0 +1,9 @@\n+/* SPDX-License-Identifier: BSD-3-Clause */\n+\n+#ifndef LOG_PRIVATE_H\n+#define LOG_PRIVATE_H\n+\n+/* Note: same as vfprintf() */\n+typedef int (*log_print_t)(FILE *f, const char *fmt, va_list ap);\n+\n+#endif /* LOG_PRIVATE_H */\n", "prefixes": [ "v20", "10/14" ] }