Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139049/?format=api
{ "id": 139049, "url": "http://patchwork.dpdk.org/api/patches/139049/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240402215502.278838-17-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240402215502.278838-17-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240402215502.278838-17-stephen@networkplumber.org", "date": "2024-04-02T21:50:32", "name": "[v3,16/30] raw: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "10b690338db70eef5fa974b923ded5aad914b1c4", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240402215502.278838-17-stephen@networkplumber.org/mbox/", "series": [ { "id": 31659, "url": "http://patchwork.dpdk.org/api/series/31659/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31659", "date": "2024-04-02T21:50:16", "name": "replace rte_memcpy of fixed size with memcpy", "version": 3, "mbox": "http://patchwork.dpdk.org/series/31659/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139049/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139049/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5775B43DC8;\n\tTue, 2 Apr 2024 23:57:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 45BD740DF8;\n\tTue, 2 Apr 2024 23:56:04 +0200 (CEST)", "from mail-pl1-f174.google.com (mail-pl1-f174.google.com\n [209.85.214.174])\n by mails.dpdk.org (Postfix) with ESMTP id 277C140A67\n for <dev@dpdk.org>; Tue, 2 Apr 2024 23:55:56 +0200 (CEST)", "by mail-pl1-f174.google.com with SMTP id\n d9443c01a7336-1e0f0398553so50932235ad.3\n for <dev@dpdk.org>; Tue, 02 Apr 2024 14:55:56 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n x15-20020a170902820f00b001dddf29b6e8sm11609381pln.299.2024.04.02.14.55.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 02 Apr 2024 14:55:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712094955;\n x=1712699755; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Grk2cJIzxC80uwuX8qnelePHUG7TGKeD7z+sdRwYR2M=;\n b=fn+buJspGgVtPky6/IkoWkdC9tv2y0GkVq1mFPmhu9A+gWENy20376sB7P3vct1ufj\n WEsvOfy0K91+o9ZTj4E8STolIl1fuFX02Slv+toz0g+B9m8Zvmu5GHFg7fXEwsfcHB+f\n hKSX7+bAZao5A/+oPiyku8/SS0icZIiEFCkh7zMoQrh6m+DrcfkmBtaCQtXEJwnvsq1u\n f8+cGArglXy+rZHK0ZEHMZxmx3hUOJjOJYZ+BZOXAQW039/Ri1Zy5Kq01RZA7KSbX4+p\n oms//g1xLHfHrDg8Bq+lx1puzV4fJCbpSp6i79J70csGgsLijCIrUhFrAzXFDu7GbCRA\n nGzQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1712094955; x=1712699755;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Grk2cJIzxC80uwuX8qnelePHUG7TGKeD7z+sdRwYR2M=;\n b=ulK30LaNwLH7wjLNAaBdg4b2ZEQkYA29pHDrmgzdrvTkHjhY7YCW2idb/NBB5PUhi+\n E/yb0erasUp+WpeuAMy3gCPDGccWPrqnqkUlXovZpmN2AbmR4pMYqjsfLztpyebWEN01\n XVi0Ml/mCdF7TDzH1m5bXRqnZfsodsseJdy0q6ZP1Y0Mh7VQqEive4vOh2X6uzSQN9xZ\n ebtOryaAA91i7Ir5LUPl1mDz49DcKKNIEAOXg3AhnnnoZDhEZJkZ6dJhdCiay11Sp5yL\n pLLcaQsGMe3lqbVIsBMFJ+1DUpXp91hmzsBXjjUlhkD9iJda90McFkhQYegq+5Elfshr\n /7OQ==", "X-Gm-Message-State": "AOJu0Yyul2LqK+/4QBKFSAYKM3+TRTKDCHE9MbEFpnMpgXIwK3lk7CAk\n 2oLz1RDZD0KPkUZRVtxMOlLGeuY2BUgYd9BJbXM7fZVgy09epJ8MO4y6g7XJAxBmgrprzB1FxgP\n lpc4=", "X-Google-Smtp-Source": "\n AGHT+IFvl9u2f1jMWFUeEJppkICwtkBVj8QxM75h2b0CGHRyX7wIemXL7TctgdjO67CtppJdJrE6Hw==", "X-Received": "by 2002:a17:902:9342:b0:1e0:96c3:2fe7 with SMTP id\n g2-20020a170902934200b001e096c32fe7mr12703689plp.50.1712094955369;\n Tue, 02 Apr 2024 14:55:55 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Rosen Xu <rosen.xu@intel.com>, Sachin Saxena <sachin.saxena@nxp.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>", "Subject": "[PATCH v3 16/30] raw: replace use of fixed size rte_memcpy", "Date": "Tue, 2 Apr 2024 14:50:32 -0700", "Message-ID": "<20240402215502.278838-17-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240402215502.278838-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>\n <20240402215502.278838-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/raw/ifpga/afu_pmd_he_hssi.c | 3 +--\n drivers/raw/ifpga/afu_pmd_he_lpbk.c | 3 +--\n drivers/raw/ifpga/afu_pmd_he_mem.c | 3 +--\n drivers/raw/ifpga/afu_pmd_n3000.c | 8 ++++----\n drivers/raw/ifpga/ifpga_rawdev.c | 11 +++++------\n drivers/raw/skeleton/skeleton_rawdev.c | 8 +++-----\n drivers/raw/skeleton/skeleton_rawdev_test.c | 1 -\n 7 files changed, 15 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/raw/ifpga/afu_pmd_he_hssi.c b/drivers/raw/ifpga/afu_pmd_he_hssi.c\nindex 859f28dcc1..c2aaed9203 100644\n--- a/drivers/raw/ifpga/afu_pmd_he_hssi.c\n+++ b/drivers/raw/ifpga/afu_pmd_he_hssi.c\n@@ -15,7 +15,6 @@\n \n #include <rte_eal.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <rte_io.h>\n #include <rte_vfio.h>\n #include <bus_pci_driver.h>\n@@ -314,7 +313,7 @@ static int he_hssi_config(struct afu_rawdev *dev, void *config,\n \tif (cfg->port >= NUM_HE_HSSI_PORTS)\n \t\treturn -EINVAL;\n \n-\trte_memcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg));\n+\tmemcpy(&priv->he_hssi_cfg, cfg, sizeof(priv->he_hssi_cfg));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/afu_pmd_he_lpbk.c b/drivers/raw/ifpga/afu_pmd_he_lpbk.c\nindex c7c5cda48c..ffb7075c84 100644\n--- a/drivers/raw/ifpga/afu_pmd_he_lpbk.c\n+++ b/drivers/raw/ifpga/afu_pmd_he_lpbk.c\n@@ -15,7 +15,6 @@\n \n #include <rte_eal.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <rte_io.h>\n #include <rte_vfio.h>\n #include <bus_pci_driver.h>\n@@ -363,7 +362,7 @@ static int he_lpbk_config(struct afu_rawdev *dev, void *config,\n \tif ((cfg->end < cfg->begin) || (cfg->end > MAX_CACHE_LINES))\n \t\treturn -EINVAL;\n \n-\trte_memcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg));\n+\tmemcpy(&priv->he_lpbk_cfg, cfg, sizeof(priv->he_lpbk_cfg));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/afu_pmd_he_mem.c b/drivers/raw/ifpga/afu_pmd_he_mem.c\nindex a1db533eeb..b799e40d2d 100644\n--- a/drivers/raw/ifpga/afu_pmd_he_mem.c\n+++ b/drivers/raw/ifpga/afu_pmd_he_mem.c\n@@ -14,7 +14,6 @@\n \n #include <rte_eal.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <rte_io.h>\n #include <rte_vfio.h>\n #include <bus_pci_driver.h>\n@@ -126,7 +125,7 @@ static int he_mem_tg_config(struct afu_rawdev *dev, void *config,\n \tif (config_size != sizeof(struct rte_pmd_afu_he_mem_tg_cfg))\n \t\treturn -EINVAL;\n \n-\trte_memcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg));\n+\tmemcpy(&priv->he_mem_tg_cfg, config, sizeof(priv->he_mem_tg_cfg));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga/afu_pmd_n3000.c b/drivers/raw/ifpga/afu_pmd_n3000.c\nindex 67b3941265..9236c0b153 100644\n--- a/drivers/raw/ifpga/afu_pmd_n3000.c\n+++ b/drivers/raw/ifpga/afu_pmd_n3000.c\n@@ -1867,8 +1867,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config,\n \t\tif ((cfg->nlb_cfg.end < cfg->nlb_cfg.begin) ||\n \t\t\t(cfg->nlb_cfg.end > MAX_CACHE_LINES))\n \t\t\treturn -EINVAL;\n-\t\trte_memcpy(&priv->nlb_cfg, &cfg->nlb_cfg,\n-\t\t\tsizeof(struct rte_pmd_afu_nlb_cfg));\n+\t\tmemcpy(&priv->nlb_cfg, &cfg->nlb_cfg,\n+\t\t sizeof(struct rte_pmd_afu_nlb_cfg));\n \t} else if (cfg->type == RTE_PMD_AFU_N3000_DMA) {\n \t\tif (cfg->dma_cfg.index >= NUM_N3000_DMA)\n \t\t\treturn -EINVAL;\n@@ -1887,8 +1887,8 @@ static int n3000_afu_config(struct afu_rawdev *dev, void *config,\n \t\t\t\t\tcfg->dma_cfg.length);\n \t\t\t}\n \t\t}\n-\t\trte_memcpy(&priv->dma_cfg, &cfg->dma_cfg,\n-\t\t\tsizeof(struct rte_pmd_afu_dma_cfg));\n+\t\tmemcpy(&priv->dma_cfg, &cfg->dma_cfg,\n+\t\t sizeof(struct rte_pmd_afu_dma_cfg));\n \t} else {\n \t\tIFPGA_RAWDEV_PMD_ERR(\"Invalid type of N3000 AFU\");\n \t\treturn -EINVAL;\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex f89bd3f9e2..d5d47e14dd 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -14,7 +14,6 @@\n #include <rte_log.h>\n #include <rte_malloc.h>\n #include <rte_devargs.h>\n-#include <rte_memcpy.h>\n #include <rte_pci.h>\n #include <bus_pci_driver.h>\n #include <rte_kvargs.h>\n@@ -258,7 +257,7 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev *ifpga_dev)\n \tif (point < 12)\n \t\treturn -1;\n \tpoint -= 12;\n-\trte_memcpy(ifpga_dev->parent_bdf, &link[point], 12);\n+\tmemcpy(ifpga_dev->parent_bdf, &link[point], 12);\n \n \tpoint = strlen(link1);\n \tif (point < 26)\n@@ -948,10 +947,10 @@ ifpga_rawdev_pr(struct rte_rawdev *dev,\n \t\tif (ret)\n \t\t\treturn ret;\n \n-\t\trte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b,\n-\t\t\tsizeof(u64));\n-\t\trte_memcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8,\n-\t\t\tsizeof(u64));\n+\t\tmemcpy(&afu_pr_conf->afu_id.uuid.uuid_low, uuid.b,\n+\t\t sizeof(u64));\n+\t\tmemcpy(&afu_pr_conf->afu_id.uuid.uuid_high, uuid.b + 8,\n+\t\t sizeof(u64));\n \n \t\tIFPGA_RAWDEV_PMD_INFO(\"%s: uuid_l=0x%lx, uuid_h=0x%lx\\n\",\n \t\t\t__func__,\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c\nindex 6e99d35536..256f45cb5d 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev.c\n@@ -20,7 +20,6 @@\n #include <rte_log.h>\n #include <rte_malloc.h>\n #include <rte_memory.h>\n-#include <rte_memcpy.h>\n #include <rte_lcore.h>\n #include <bus_vdev_driver.h>\n \n@@ -245,8 +244,8 @@ static int skeleton_rawdev_queue_def_conf(struct rte_rawdev *dev,\n \tskelq = &skeldev->queues[queue_id];\n \n \tif (queue_id < SKELETON_MAX_QUEUES)\n-\t\trte_memcpy(queue_conf, skelq,\n-\t\t\tsizeof(struct skeleton_rawdev_queue));\n+\t\tmemcpy(queue_conf, skelq,\n+\t\t sizeof(struct skeleton_rawdev_queue));\n \n \treturn 0;\n }\n@@ -281,8 +280,7 @@ static int skeleton_rawdev_queue_setup(struct rte_rawdev *dev,\n \n \tif (skeldev->num_queues > queue_id &&\n \t q->depth < SKELETON_QUEUE_MAX_DEPTH) {\n-\t\trte_memcpy(q, queue_conf,\n-\t\t\t sizeof(struct skeleton_rawdev_queue));\n+\t\tmemcpy(q, queue_conf, sizeof(struct skeleton_rawdev_queue));\n \t\tclear_queue_bufs(queue_id);\n \t} else {\n \t\tSKELETON_PMD_ERR(\"Invalid queue configuration\");\ndiff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c\nindex b7a7f623aa..dc32c4e29b 100644\n--- a/drivers/raw/skeleton/skeleton_rawdev_test.c\n+++ b/drivers/raw/skeleton/skeleton_rawdev_test.c\n@@ -7,7 +7,6 @@\n #include <rte_common.h>\n #include <rte_mbuf.h>\n #include <rte_malloc.h>\n-#include <rte_memcpy.h>\n #include <dev_driver.h>\n #include <rte_rawdev.h>\n #include <bus_vdev_driver.h>\n", "prefixes": [ "v3", "16/30" ] }