Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139051/?format=api
{ "id": 139051, "url": "http://patchwork.dpdk.org/api/patches/139051/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240402215502.278838-18-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240402215502.278838-18-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240402215502.278838-18-stephen@networkplumber.org", "date": "2024-04-02T21:50:33", "name": "[v3,17/30] baseband: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c729e5ef868d3320d83e31c72bccf9b7977c5dd0", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240402215502.278838-18-stephen@networkplumber.org/mbox/", "series": [ { "id": 31659, "url": "http://patchwork.dpdk.org/api/series/31659/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31659", "date": "2024-04-02T21:50:16", "name": "replace rte_memcpy of fixed size with memcpy", "version": 3, "mbox": "http://patchwork.dpdk.org/series/31659/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139051/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139051/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F62A43DC8;\n\tTue, 2 Apr 2024 23:57:59 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6CA4F40E54;\n\tTue, 2 Apr 2024 23:56:07 +0200 (CEST)", "from mail-pl1-f172.google.com (mail-pl1-f172.google.com\n [209.85.214.172])\n by mails.dpdk.org (Postfix) with ESMTP id 24A8240A6C\n for <dev@dpdk.org>; Tue, 2 Apr 2024 23:55:57 +0200 (CEST)", "by mail-pl1-f172.google.com with SMTP id\n d9443c01a7336-1e0189323b4so40386305ad.1\n for <dev@dpdk.org>; Tue, 02 Apr 2024 14:55:57 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n x15-20020a170902820f00b001dddf29b6e8sm11609381pln.299.2024.04.02.14.55.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 02 Apr 2024 14:55:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712094956;\n x=1712699756; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NNbnMxV+iy5OYoiFSPUNvlUHcKvQm6Nd4ja4OwD1PGk=;\n b=jskoE5A19QxfhY92+Tz4xDE9q+EOXWvlONMbgsMoC+6/3CZTer02Qbsfw2hIXzBIXt\n KtVjCOI5qvtxjFCieJ4wrR89PUGC6fF1Z+bCOS7rSEXQW9XwwrPlNmVohjEDDjI3mzwv\n JvNeGGHV0u0hHw7JA3hp+edwusxH/KB6AqtrseCH5Zw0toA0eDhXuO498FFnnf3gImUH\n od8eWf8HTCxsxu30Ymo+XnQwolKVC7geKh6/gPFe3twfYfq9SmAfxoHWEAhhXx+rywOx\n sgxM50znMEqF9YvbvG6FH9OpQ7NwB4wwNPW56dxn/ElRM1zA6y7rV7Sq2jEJdzEd1aQb\n c5/Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1712094956; x=1712699756;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=NNbnMxV+iy5OYoiFSPUNvlUHcKvQm6Nd4ja4OwD1PGk=;\n b=dq6+q3GwXF6jPrM3PwkmAsmcCFWT4K/PuY0gh89i0gWHHN9NcQKvradnnQogms8CZe\n 9JRbtA394nngB//qMgcEncu4hK7CaGENtZ/IVu2oYbjQ+tpQJq+EvR0u3M7R0acmZuci\n CBes2eNwsOEtf400aonvjX0sYuBquNZk5P7pzE2QUR6KMOLvZekKqgEauF/O0luEBWNr\n 5EeDoaCfJYOVIdQPENKUwrzV0ovRSBv2PnZ2Yu84YF+1Gk2Z45r1dHDmkxtqqWXs6plH\n RmMPzmAEJWlw0NUxJ9XcxB2wiQJ0F9O/PMg/ZdwO2xao32j6m+p4mxIDQdKbh73q18jZ\n XX2Q==", "X-Gm-Message-State": "AOJu0Yzm2XtgVfaqiULUEMDh2uu/VUR1iIuJHePPC7T0qR48UL+V1tWo\n gfNQLf5FXO7AtfOJlMGCR9CuXQDTBB7nAx9mlDnCPS/V36u072pxv/ISnkXQctM5CKsuQb35hMV\n Xv7c=", "X-Google-Smtp-Source": "\n AGHT+IHrACDESlSpWhcWSn+lj+0aC9sOkOQuwlV01T9tkqWU9++9soMkLC0Uw++2k7fTKRjoPbDagg==", "X-Received": "by 2002:a17:902:eb89:b0:1e2:75a3:685a with SMTP id\n q9-20020a170902eb8900b001e275a3685amr3031401plg.12.1712094956293;\n Tue, 02 Apr 2024 14:55:56 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Gagandeep Singh <g.singh@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>", "Subject": "[PATCH v3 17/30] baseband: replace use of fixed size rte_memcpy", "Date": "Tue, 2 Apr 2024 14:50:33 -0700", "Message-ID": "<20240402215502.278838-18-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240402215502.278838-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>\n <20240402215502.278838-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/baseband/acc/rte_acc100_pmd.c | 17 ++++++++---------\n drivers/baseband/acc/rte_vrb_pmd.c | 21 ++++++++++-----------\n drivers/baseband/la12xx/bbdev_la12xx.c | 4 ++--\n 3 files changed, 20 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c\nindex 4f666e514b..6a6212f3de 100644\n--- a/drivers/baseband/acc/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc/rte_acc100_pmd.c\n@@ -2975,15 +2975,13 @@ enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,\n \t\tuint8_t *prev_ptr = (uint8_t *) prev_desc;\n \t\tuint8_t *new_ptr = (uint8_t *) desc;\n \t\t/* Copy first 4 words and BDESCs */\n-\t\trte_memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0);\n-\t\trte_memcpy(new_ptr + ACC_5GUL_OFFSET_0,\n-\t\t\t\tprev_ptr + ACC_5GUL_OFFSET_0,\n-\t\t\t\tACC_5GUL_SIZE_1);\n+\t\tmemcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0);\n+\t\tmemcpy(new_ptr + ACC_5GUL_OFFSET_0,\n+\t\t prev_ptr + ACC_5GUL_OFFSET_0, ACC_5GUL_SIZE_1);\n \t\tdesc->req.op_addr = prev_desc->req.op_addr;\n \t\t/* Copy FCW */\n-\t\trte_memcpy(new_ptr + ACC_DESC_FCW_OFFSET,\n-\t\t\t\tprev_ptr + ACC_DESC_FCW_OFFSET,\n-\t\t\t\tACC_FCW_LD_BLEN);\n+\t\tmemcpy(new_ptr + ACC_DESC_FCW_OFFSET,\n+\t\t prev_ptr + ACC_DESC_FCW_OFFSET, ACC_FCW_LD_BLEN);\n \t\tacc100_dma_desc_ld_update(op, &desc->req, input, h_output,\n \t\t\t\t&in_offset, &h_out_offset,\n \t\t\t\t&h_out_length, harq_layout);\n@@ -3130,7 +3128,8 @@ enqueue_ldpc_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op,\n \t\tdesc = acc_desc(q, total_enqueued_cbs);\n \t\tdesc->req.data_ptrs[0].address = q->ring_addr_iova + fcw_offset;\n \t\tdesc->req.data_ptrs[0].blen = ACC_FCW_LD_BLEN;\n-\t\trte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, ACC_FCW_LD_BLEN);\n+\t\tmemcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld,\n+\t\t ACC_FCW_LD_BLEN);\n \t\tret = acc100_dma_desc_ld_fill(op, &desc->req, &input,\n \t\t\t\th_output, &in_offset, &h_out_offset,\n \t\t\t\t&h_out_length,\n@@ -4430,7 +4429,7 @@ acc100_configure(const char *dev_name, struct rte_acc_conf *conf)\n \tstruct acc_device *d = bbdev->data->dev_private;\n \n \t/* Store configuration */\n-\trte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf));\n+\tmemcpy(&d->acc_conf, conf, sizeof(d->acc_conf));\n \n \tvalue = acc_reg_read(d, HwPfPcieGpexBridgeControl);\n \tbool firstCfg = (value != ACC100_CFG_PCI_BRIDGE);\ndiff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c\nindex 88b1104fab..3e5376a12e 100644\n--- a/drivers/baseband/acc/rte_vrb_pmd.c\n+++ b/drivers/baseband/acc/rte_vrb_pmd.c\n@@ -2450,15 +2450,13 @@ vrb_enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,\n \t\tuint8_t *prev_ptr = (uint8_t *) prev_desc;\n \t\tuint8_t *new_ptr = (uint8_t *) desc;\n \t\t/* Copy first 4 words and BDESCs. */\n-\t\trte_memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0);\n-\t\trte_memcpy(new_ptr + ACC_5GUL_OFFSET_0,\n-\t\t\t\tprev_ptr + ACC_5GUL_OFFSET_0,\n-\t\t\t\tACC_5GUL_SIZE_1);\n+\t\tmemcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0);\n+\t\tmemcpy(new_ptr + ACC_5GUL_OFFSET_0,\n+\t\t prev_ptr + ACC_5GUL_OFFSET_0, ACC_5GUL_SIZE_1);\n \t\tdesc->req.op_addr = prev_desc->req.op_addr;\n \t\t/* Copy FCW. */\n-\t\trte_memcpy(new_ptr + ACC_DESC_FCW_OFFSET,\n-\t\t\t\tprev_ptr + ACC_DESC_FCW_OFFSET,\n-\t\t\t\tACC_FCW_LD_BLEN);\n+\t\tmemcpy(new_ptr + ACC_DESC_FCW_OFFSET,\n+\t\t prev_ptr + ACC_DESC_FCW_OFFSET, ACC_FCW_LD_BLEN);\n \t\tvrb_dma_desc_ld_update(op, &desc->req, input, h_output,\n \t\t\t\t&in_offset, &h_out_offset,\n \t\t\t\t&h_out_length, harq_layout);\n@@ -2566,7 +2564,8 @@ vrb_enqueue_ldpc_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op *op,\n \t\tfcw_offset = (desc_idx << 8) + ACC_DESC_FCW_OFFSET;\n \t\tdesc->req.data_ptrs[0].address = q->ring_addr_iova + fcw_offset;\n \t\tdesc->req.data_ptrs[0].blen = ACC_FCW_LD_BLEN;\n-\t\trte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, ACC_FCW_LD_BLEN);\n+\t\tmemcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld,\n+\t\t ACC_FCW_LD_BLEN);\n \t\tdesc->req.fcw_ld.tb_trailer_size = (c - r - 1) * trail_len;\n \t\tret = vrb_dma_desc_ld_fill(op, &desc->req, &input,\n \t\t\t\th_output, &in_offset, &h_out_offset,\n@@ -3991,7 +3990,7 @@ enqueue_mldts_split_op(struct acc_queue *q, struct rte_bbdev_mldts_op *op,\n \t\tif (symb == 0)\n \t\t\tdesc->req.cbs_in_tb = num_syms;\n \t\telse\n-\t\t\trte_memcpy(&desc->req.fcw_mldts, fcw, ACC_FCW_MLDTS_BLEN);\n+\t\t\tmemcpy(&desc->req.fcw_mldts, fcw, ACC_FCW_MLDTS_BLEN);\n \t\tdesc->req.data_ptrs[1].address = rte_pktmbuf_iova_offset(input_q, in_offset);\n \t\tdesc->req.data_ptrs[1].blen = q_size;\n \t\tin_offset += q_size;\n@@ -4337,7 +4336,7 @@ vrb1_configure(const char *dev_name, struct rte_acc_conf *conf)\n \tstruct acc_device *d = bbdev->data->dev_private;\n \n \t/* Store configuration. */\n-\trte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf));\n+\tmemcpy(&d->acc_conf, conf, sizeof(d->acc_conf));\n \n \t/* Check we are already out of PG. */\n \tstatus = acc_reg_read(d, VRB1_PfHiSectionPowerGatingAck);\n@@ -4744,7 +4743,7 @@ vrb2_configure(const char *dev_name, struct rte_acc_conf *conf)\n \tstruct acc_device *d = bbdev->data->dev_private;\n \n \t/* Store configuration. */\n-\trte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf));\n+\tmemcpy(&d->acc_conf, conf, sizeof(d->acc_conf));\n \n \t/* Explicitly releasing AXI as this may be stopped after PF FLR/BME. */\n \taddress = VRB2_PfDmaAxiControl;\ndiff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c\nindex bb754a5395..23e2fdb811 100644\n--- a/drivers/baseband/la12xx/bbdev_la12xx.c\n+++ b/drivers/baseband/la12xx/bbdev_la12xx.c\n@@ -597,8 +597,8 @@ dequeue_single_op(struct bbdev_la12xx_q_priv *q_priv, void *dst)\n \n \top = q_priv->bbdev_op[ci];\n \n-\trte_memcpy(dst, q_priv->msg_ch_vaddr[ci],\n-\t\tsizeof(struct bbdev_ipc_enqueue_op));\n+\tmemcpy(dst, q_priv->msg_ch_vaddr[ci],\n+\t sizeof(struct bbdev_ipc_enqueue_op));\n \n \t/* Move Consumer Index forward */\n \tci++;\n", "prefixes": [ "v3", "17/30" ] }