Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139075/?format=api
{ "id": 139075, "url": "http://patchwork.dpdk.org/api/patches/139075/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240403101624.2771140-4-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240403101624.2771140-4-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240403101624.2771140-4-haijie1@huawei.com", "date": "2024-04-03T10:16:21", "name": "[3/5] net/hns3: fix double free for Rx/Tx queue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f3888a77f37827c8e42fe8e5bc3b3b9e1df77862", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240403101624.2771140-4-haijie1@huawei.com/mbox/", "series": [ { "id": 31665, "url": "http://patchwork.dpdk.org/api/series/31665/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31665", "date": "2024-04-03T10:16:19", "name": "net/hns3: add some bugfix", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31665/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139075/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139075/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 485F743DE7;\n\tWed, 3 Apr 2024 12:21:56 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3CFDE402EC;\n\tWed, 3 Apr 2024 12:21:48 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 28CA2402D1\n for <dev@dpdk.org>; Wed, 3 Apr 2024 12:21:45 +0200 (CEST)", "from mail.maildlp.com (unknown [172.19.163.174])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4V8ghY5TT6ztRcD;\n Wed, 3 Apr 2024 18:19:09 +0800 (CST)", "from kwepemd100004.china.huawei.com (unknown [7.221.188.31])\n by mail.maildlp.com (Postfix) with ESMTPS id 1892B140FB0;\n Wed, 3 Apr 2024 18:21:44 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 3 Apr 2024 18:21:43 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Yisen Zhuang <yisen.zhuang@huawei.com>, Hao Chen\n <chenh@yusur.tech>, \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>, \"Min Wang\n (Jushui)\" <wangmin3@huawei.com>, \"Min Hu (Connor)\" <humin29@huawei.com>,\n Huisong Li <lihuisong@huawei.com>", "CC": "<fengchengwen@huawei.com>, <liuyonglong@huawei.com>,\n <huangdengdui@huawei.com>, <haijie1@huawei.com>", "Subject": "[PATCH 3/5] net/hns3: fix double free for Rx/Tx queue", "Date": "Wed, 3 Apr 2024 18:16:21 +0800", "Message-ID": "<20240403101624.2771140-4-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20240403101624.2771140-1-haijie1@huawei.com>", "References": "<20240403101624.2771140-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Dengdui Huang <huangdengdui@huawei.com>\n\nThe Pointers to some resources on the Rx/Tx queue need to be set to NULL\nafter free inside the hns3_rx/tx_queue_release(), as this function is\ncalled from multiple threads (reset thread, device config thread, etc),\nleading to double memory free error.\n\nFixes: bba636698316 (\"net/hns3: support Rx/Tx and related operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx.c | 23 ++++++++++++++++++-----\n 1 file changed, 18 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex 54bf724a0e6c..fbc5ef3225c5 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -86,9 +86,14 @@ hns3_rx_queue_release(void *queue)\n \tstruct hns3_rx_queue *rxq = queue;\n \tif (rxq) {\n \t\thns3_rx_queue_release_mbufs(rxq);\n-\t\tif (rxq->mz)\n+\t\tif (rxq->mz) {\n \t\t\trte_memzone_free(rxq->mz);\n-\t\trte_free(rxq->sw_ring);\n+\t\t\trxq->mz = NULL;\n+\t\t}\n+\t\tif (rxq->sw_ring) {\n+\t\t\trte_free(rxq->sw_ring);\n+\t\t\trxq->sw_ring = NULL;\n+\t\t}\n \t\trte_free(rxq);\n \t}\n }\n@@ -99,10 +104,18 @@ hns3_tx_queue_release(void *queue)\n \tstruct hns3_tx_queue *txq = queue;\n \tif (txq) {\n \t\thns3_tx_queue_release_mbufs(txq);\n-\t\tif (txq->mz)\n+\t\tif (txq->mz) {\n \t\t\trte_memzone_free(txq->mz);\n-\t\trte_free(txq->sw_ring);\n-\t\trte_free(txq->free);\n+\t\t\ttxq->mz = NULL;\n+\t\t}\n+\t\tif (txq->sw_ring) {\n+\t\t\trte_free(txq->sw_ring);\n+\t\t\ttxq->sw_ring = NULL;\n+\t\t}\n+\t\tif (txq->free) {\n+\t\t\trte_free(txq->free);\n+\t\t\ttxq->free = NULL;\n+\t\t}\n \t\trte_free(txq);\n \t}\n }\n", "prefixes": [ "3/5" ] }