Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 139105,
    "url": "http://patchwork.dpdk.org/api/patches/139105/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1712250913-1977-4-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1712250913-1977-4-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1712250913-1977-4-git-send-email-roretzla@linux.microsoft.com",
    "date": "2024-04-04T17:15:12",
    "name": "[3/4] vhost: use alloca instead of vla sizeof",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "f188e866c8f3a8f7076b4f307c76ed0bf9d1162d",
    "submitter": {
        "id": 2077,
        "url": "http://patchwork.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1712250913-1977-4-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 31680,
            "url": "http://patchwork.dpdk.org/api/series/31680/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31680",
            "date": "2024-04-04T17:15:09",
            "name": "RFC samples converting VLA to alloca",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/31680/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/139105/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/139105/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A202B43DFB;\n\tThu,  4 Apr 2024 19:15:37 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B40CF40A6E;\n\tThu,  4 Apr 2024 19:15:20 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 105FB4064A\n for <dev@dpdk.org>; Thu,  4 Apr 2024 19:15:15 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id 63C3A20E97C1; Thu,  4 Apr 2024 10:15:14 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 63C3A20E97C1",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1712250914;\n bh=rD+L0VBEA4ijIJdqdd449HN9OEIpZijzzM7uh0U3AQI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=qrnREoKVqff0DtjBVN7ryRKKIj3Yj3IKzzmZmLHi1J/fhN9E50nqWjQHZXeexfm3C\n 1XVUskKQaMPawK8I688aQVpFBysb1rp5mv9tjftuVcJxnhyKMtWSP8U4fjF3hWtOJY\n Tw9KaNbCNxhTIH3rCvsILpUKmCXHeotaQCvaU6ME=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Thomas Monjalon <thomas@monjalon.net>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH 3/4] vhost: use alloca instead of vla sizeof",
        "Date": "Thu,  4 Apr 2024 10:15:12 -0700",
        "Message-Id": "<1712250913-1977-4-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1712250913-1977-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "\n <20231107193220.GA15232@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>\n <1712250913-1977-1-git-send-email-roretzla@linux.microsoft.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "RFC sample illustrating conversion of VLA to alloca() where\nsizeof(array) was in use.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/vhost/socket.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c\nindex 96b3ab5..cedcfb2 100644\n--- a/lib/vhost/socket.c\n+++ b/lib/vhost/socket.c\n@@ -110,7 +110,8 @@ struct vhost_user {\n {\n \tstruct iovec iov;\n \tstruct msghdr msgh;\n-\tchar control[CMSG_SPACE(max_fds * sizeof(int))];\n+\tconst size_t control_sz = sizeof(char) * CMSG_SPACE(max_fds * sizeof(int));\n+\tchar *control = alloca(control_sz);\n \tstruct cmsghdr *cmsg;\n \tint got_fds = 0;\n \tint ret;\n@@ -124,7 +125,7 @@ struct vhost_user {\n \tmsgh.msg_iov = &iov;\n \tmsgh.msg_iovlen = 1;\n \tmsgh.msg_control = control;\n-\tmsgh.msg_controllen = sizeof(control);\n+\tmsgh.msg_controllen = control_sz;\n \n \tret = recvmsg(sockfd, &msgh, 0);\n \tif (ret <= 0) {\n",
    "prefixes": [
        "3/4"
    ]
}