Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139185/?format=api
{ "id": 139185, "url": "http://patchwork.dpdk.org/api/patches/139185/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240408121525.1906-2-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240408121525.1906-2-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240408121525.1906-2-shaibran@amazon.com", "date": "2024-04-08T12:15:25", "name": "[v2,1/1] net/ena/base: fix metrics excessive memory consumption", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "513b25a8879a22e5d5c5c65bd5ee25fe48d44e5e", "submitter": { "id": 2930, "url": "http://patchwork.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240408121525.1906-2-shaibran@amazon.com/mbox/", "series": [ { "id": 31703, "url": "http://patchwork.dpdk.org/api/series/31703/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31703", "date": "2024-04-08T12:15:25", "name": "net/ena/base: bug fix for 23.11 stable only", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31703/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139185/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/139185/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0A9AA43DA3;\n\tMon, 8 Apr 2024 14:15:41 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8340340289;\n\tMon, 8 Apr 2024 14:15:40 +0200 (CEST)", "from smtp-fw-80009.amazon.com (smtp-fw-80009.amazon.com\n [99.78.197.220])\n by mails.dpdk.org (Postfix) with ESMTP id 57C4C40041;\n Mon, 8 Apr 2024 14:15:38 +0200 (CEST)", "from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO\n smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.25.36.210])\n by smtp-border-fw-80009.pdx80.corp.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 12:15:34 +0000", "from EX19MTAEUA001.ant.amazon.com [10.0.43.254:39368]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.32.21:2525]\n with esmtp (Farcaster)\n id 20fa19c0-335e-416e-a12f-a5ab9894c23d; Mon, 8 Apr 2024 12:15:32 +0000 (UTC)", "from EX19D007EUA002.ant.amazon.com (10.252.50.68) by\n EX19MTAEUA001.ant.amazon.com (10.252.50.223) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 8 Apr 2024 12:15:32 +0000", "from EX19MTAUEA001.ant.amazon.com (10.252.134.203) by\n EX19D007EUA002.ant.amazon.com (10.252.50.68) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Mon, 8 Apr 2024 12:15:32 +0000", "from HFA15-CG15235BS.amazon.com (10.1.212.52) by\n mail-relay.amazon.com (10.252.134.102) with Microsoft SMTP Server id\n 15.2.1258.28 via Frontend Transport; Mon, 8 Apr 2024 12:15:30 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1712578538; x=1744114538;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=CIkHVy0IwmuMGVR09lXEPNYyVLtnnQq/a5Fjbec3Zg8=;\n b=Oq9qHts2CP4Z1uoLDtQvQ057fY84Ywqnh2Lk6uwb0W3VB1aHMNBcJw4K\n LvKQyAkAkd2eKwvHs3kb9DO/TXC8Y/y8riGzRBLTxw0O0LaUSJJBffnBO\n EQna3u1D2L18cr4Fv3t9AM7y0PU69T5Lb5YtqrE24gJWxxuy0cnZjnc7M Y=;", "X-IronPort-AV": "E=Sophos;i=\"6.07,186,1708387200\"; d=\"scan'208\";a=\"79526608\"", "X-Farcaster-Flow-ID": "20fa19c0-335e-416e-a12f-a5ab9894c23d", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>, <bluca@debian.org>,\n <christian.ehrhardt@canonical.com>, <xuemingl@nvidia.com>,\n <ktraynor@redhat.com>", "CC": "<stable@dpdk.org>, <dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>", "Subject": "[PATCH v2 1/1] net/ena/base: fix metrics excessive memory consumption", "Date": "Mon, 8 Apr 2024 15:15:25 +0300", "Message-ID": "<20240408121525.1906-2-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240408121525.1906-1-shaibran@amazon.com>", "References": "<20240408121525.1906-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\n[ upstream commit c8a1898f82f8c04cbe1d3e2d0eec0705386c23f7 ]\n\nThe driver accidentally allocates a huge memory\nbuffer for the customer metrics because it uses\nan uninitialized variable for the buffer length.\nThis can lead to excessive memory footprint for\nthe driver which can even fail to initialize in\ncase of insufficient memory.\n\nBugzilla ID: 1400\nFixes: f73f53f7dc7a (\"net/ena: upgrade HAL\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/base/ena_com.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex 6953a1fa33..8ae7dcf48e 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -3134,16 +3134,18 @@ int ena_com_allocate_debug_area(struct ena_com_dev *ena_dev,\n int ena_com_allocate_customer_metrics_buffer(struct ena_com_dev *ena_dev)\n {\n \tstruct ena_customer_metrics *customer_metrics = &ena_dev->customer_metrics;\n+\tcustomer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;\n+\tcustomer_metrics->buffer_virt_addr = NULL;\n \n \tENA_MEM_ALLOC_COHERENT(ena_dev->dmadev,\n \t\t\t customer_metrics->buffer_len,\n \t\t\t customer_metrics->buffer_virt_addr,\n \t\t\t customer_metrics->buffer_dma_addr,\n \t\t\t customer_metrics->buffer_dma_handle);\n-\tif (unlikely(customer_metrics->buffer_virt_addr == NULL))\n+\tif (unlikely(customer_metrics->buffer_virt_addr == NULL)) {\n+\t\tcustomer_metrics->buffer_len = 0;\n \t\treturn ENA_COM_NO_MEM;\n-\n-\tcustomer_metrics->buffer_len = ENA_CUSTOMER_METRICS_BUFFER_SIZE;\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "v2", "1/1" ] }