Patch Comment Detail
get:
Show a patch comment.
patch:
Update a patch comment.
put:
Update a patch comment.
GET /api/patches/139476/comments/169568/?format=api
{ "id": 169568, "web_url": "http://patchwork.dpdk.org/comment/169568/", "msgid": "<ZiE6-Ci6nesPf_9v@bricha3-mobl1.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/ZiE6-Ci6nesPf_9v@bricha3-mobl1.ger.corp.intel.com", "date": "2024-04-18T15:23:36", "subject": "Re: [PATCH 16/16] build: enable vla warnings on Windows built code", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Thu, Apr 18, 2024 at 08:12:26AM -0700, Tyler Retzlaff wrote:\n> On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Brørup wrote:\n> > > MSVC does not support optional C11 VLAs. When building for Windows\n> > > enable -Wvla so that mingw and clang also fail if a VLA is used.\n> > \n> > Minor detail, doesn't affect my Ack for the series...\n> > \n> > Applications built for Windows with mingw and clang might use VLAs in\n> > the application itself.\n> > \n> > Perhaps we should let them continue doing that for now.\n> \n> i guess you mean our examples or if dpdk is configured as a sub-project?\n> \n> for examples i could explicitly suppress in examples with -Wno-vla but\n> that means any that use VLAs could not be built with MSVC.\n> \n> for sub-module and sub-project of dpdk i feel like these\n> add_project_arguments are not imparted on the application with\n> encapsulating project meson setup no?\n> \n> anyone know? Bruce? Stephen?\n> \nProject args are not used when building external applications - either\nthose using DPDK as a subproject or via pkg-config. So therefore, this\nchange should be safe. It will only impact built-in DPDK apps and examples.\n\n/Bruce", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E0CD043EA5;\n\tThu, 18 Apr 2024 17:23:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8512240E32;\n\tThu, 18 Apr 2024 17:23:53 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.19])\n by mails.dpdk.org (Postfix) with ESMTP id 9499840272\n for <dev@dpdk.org>; Thu, 18 Apr 2024 17:23:51 +0200 (CEST)", "from fmviesa010.fm.intel.com ([10.60.135.150])\n by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Apr 2024 08:23:50 -0700", "from fmsmsx603.amr.corp.intel.com ([10.18.126.83])\n by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384;\n 18 Apr 2024 08:23:50 -0700", "from fmsmsx610.amr.corp.intel.com (10.18.126.90) by\n fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35; Thu, 18 Apr 2024 08:23:49 -0700", "from FMSEDG603.ED.cps.intel.com (10.1.192.133) by\n fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35 via Frontend Transport; Thu, 18 Apr 2024 08:23:49 -0700", "from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by\n edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.1.2507.35; Thu, 18 Apr 2024 08:23:48 -0700", "from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17)\n by PH8PR11MB8038.namprd11.prod.outlook.com (2603:10b6:510:25e::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.38; Thu, 18 Apr\n 2024 15:23:45 +0000", "from DS0PR11MB7309.namprd11.prod.outlook.com\n ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com\n ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7519.010; Thu, 18 Apr 2024\n 15:23:45 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1713453831; x=1744989831;\n h=date:from:to:cc:subject:message-id:references:\n content-transfer-encoding:in-reply-to:mime-version;\n bh=r4fzwJVM+zSJVV96ubju15gnnRg1gT2hCRG/2+ylVIg=;\n b=lubJVwAhtPuu4wyTPmdnzDaL1VHHqYBNUnCwY/C1C9NLwPWvpfHzhYyr\n XxVf8Z4+AW0cwH/isCC4ZLvygys5SRTXqFmHVJPfmjZSeztgJvoX1zTLB\n O2u3wjvWbLk7T2u2PEUcLGNlG2tzG3MKSjyzTPGFMvZ7goKV2qH5r7kT3\n HHaWE10+Qk/rWetZv9fyyFaO3LPli34s65joAZqcPbVdfB8F0e3UMK+Ii\n wEyX9u7gZyMg8VDQHx8VuWleAn9Hq5GecLM+5CATV8pBb/crXr5elLPlg\n s3Iqpx+WvGRkvZPFtYCBARpbas6t/7vzraiq3tMvdTsd6Xx/M0kdIb6xP A==;", "X-CSE-ConnectionGUID": [ "FOg42GQGTKOiCiKzJQSuRg==", "YvLpCoYWRrO7FgPI95Cp2g==" ], "X-CSE-MsgGUID": [ "SdkbEtPuSkWiY57JDAuqRA==", "pbeSoBGhQeyb4zK6qCp5+g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11047\"; a=\"8883125\"", "E=Sophos;i=\"6.07,212,1708416000\";\n d=\"scan'208\";a=\"8883125\"", "E=Sophos;i=\"6.07,212,1708416000\"; d=\"scan'208\";a=\"23062794\"" ], "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=cpVfKjtmqwJmu8B0EczfH/tpiTvy0iNDeBABAaGgGBy/ZpDnIGybfpmQYfk2boBiDWCikMikSs5c31sfk1aAiCjl7ap/Gm78kiJTHz4isdfFXsM9CK0p0bSv5xv/jbRFVEb5cFT7T9o27sBCCh+/2uZkjvzWV8O9k2w4VeXekMC1GJA/z35KgQoTBN5B+LxSUxFDr898DRK3bqXRCGp8c69UNMP0RODEesT9aQJtoRM7Ll+4NDZcPZZow4i7BX6D06lE9WQEG3b5ng7EfHvzC886781Pxew7XTktwcLrn5C/G+HtloZxDizc7ptFYy3NKqMeZ1cuvDswN2DoZEdtJw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=x5rW7LcJHQmKkgehk4Bu3KDnlwJNpfXtJAdZSowXMaM=;\n b=DtE8vqZUxFfGmJjxTdJxu3/JC4ESV3ynPQUTL2T4SHryG6k9BPvKfkFi4I+E8CLOld3r4mnUFdwcZqDf3bdVQ8n2YUKauM386aGqijRS26B5aDQomVCF4tV/ywjEhdJlfeCStTV0M+l5PyWam63KABdhBMiUBTdln23qAvdt4vklAAW4t02P7Qh6n9/mmC/Fbe07jwUt26D/NX40MRFURAPduOPYW8No1eNtjROqAUJ38mXS5IWohwjaOWvidFknSLu6FzT5G6vtLtIA6Y+I9oSb4N7L/V9D3n9rPOCpYM7oZHdEB5bFf44lEx1B+YCXjoG1efaNWZUbbiGJubeoqQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;", "Date": "Thu, 18 Apr 2024 16:23:36 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "CC": "Morten =?iso-8859-1?q?Br=F8rup?= <mb@smartsharesystems.com>,\n <dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>,\n Aman Singh <aman.deep.singh@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n \"Sameh Gobriel\" <sameh.gobriel@intel.com>,\n Suanming Mou <suanmingm@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>", "Subject": "Re: [PATCH 16/16] build: enable vla warnings on Windows built code", "Message-ID": "<ZiE6-Ci6nesPf_9v@bricha3-mobl1.ger.corp.intel.com>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>\n <1713397319-26135-17-git-send-email-roretzla@linux.microsoft.com>\n <98CBD80474FA8B44BF855DF32C47DC35E9F3B6@smartserver.smartshare.dk>\n <20240418151226.GA31175@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "\n <20240418151226.GA31175@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>", "X-ClientProxiedBy": "DU2P251CA0012.EURP251.PROD.OUTLOOK.COM\n (2603:10a6:10:230::8) To DS0PR11MB7309.namprd11.prod.outlook.com\n (2603:10b6:8:13e::17)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DS0PR11MB7309:EE_|PH8PR11MB8038:EE_", "X-MS-Office365-Filtering-Correlation-Id": "8b2a932c-5ef2-4e3e-d7a5-08dc5fbb89a4", "X-LD-Processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 7XIkmOG9RKIUQeuRLneuSR7jYqoH0Av8zn8obh2IKX9AqmeNUjUBHZ3/pOGkArq2Iqta/EhtHC7dTre5UocgFWqoiCO7VlfAEhSXOVUwDKJ+um4qvItOQmr/VCanaFjt0ygbP2bh8Qq14HwksxxKWWiD+CtImGK6wybq22tQ0pEryWeYoMFGipfqpaprXfWuDuxhMvDiKHIXnV729Ied9Hvy+BzbJnCnmoNi+TVKqLt3l407LHPsZ0lUc60KfCYf2C+Fo5M9XfvxDKbx0TO3h3tELHivftzcOrecJZ0E1oe1LruX9sM9mTcR9V3VvacTZ3vZdc1iEmBHS1qvkehZ1Ays+TwLSYMiqfn0JvX9KljE7ZvlflasLfAak/ohiBPHeDGRMiINSfVnXm5oDmx1yOkhriCSTVY8dGIqxPmUwiSwJtLCLcB5HqVrEaPn5Yooh5jT8oFBvyRPbOMyHLVbblLGkDNxZfre6mlt2jS+ZZSiaGpu6cDJvpV1ylTpmcPgTfN/7sFdm6/NTyqnblM85BVaz6SDmMKlK77EYGnpUnuZpV+a0epkyRtM3g2pHiERNcC8vjbiqhTG6MlpHZyzLdVvP03whN5DVvkSDirUDX85fZL/YEYh8qpiqVm9ZZZfrvNJE8CRXExpIgkhzQgm89uFWRP/nopZe1V0dBF8NH4=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(1800799015)(376005)(7416005)(366007); DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?iso-8859-1?q?FrAZePIPT5SOU220/QKoHag?=\n\t=?iso-8859-1?q?haxmYXk33BMX16xtFFfZvpRPq492+yqwwWzCyInYNZk76tajZRV0M2euheCr?=\n\t=?iso-8859-1?q?4W389yLCzR9OLULpBRvnNu2+INGbjMOJ6t9WSzEoFjbGptJUn2AwP2a+8jmc?=\n\t=?iso-8859-1?q?UJMBb9Cyz2cuVm+Gj+V3uiIi1W/MRvfZjNU1x578/X6w6Ys+gszzZTy7eoTB?=\n\t=?iso-8859-1?q?n5+f0nK9tilijWxDXm4WamuqwY4vKNqDpCAZaI3bcuUxiyOqwJURsVYyU0Ec?=\n\t=?iso-8859-1?q?YlQQBpSSqFrdadHlTInXrNGkDGHd19vieWhdj/wSQFBCg+59Bj1p9KY1p/Qm?=\n\t=?iso-8859-1?q?mAjhay2Uxs29wPd/gmZ9H2uGClHkh6nfQhoQ5ouJHUuO6OGpShr/+7H9nqG+?=\n\t=?iso-8859-1?q?5RbLoCxCJ9SxQ92aA7n4lAOBu1x/WKH4iCizzieF42pz9FcP1mNtaBYDX8DV?=\n\t=?iso-8859-1?q?wIe+/6WrFrRTOehhBADEDL1UNm792SlcUtwQogf23FwLO939fYirn+rHrMPR?=\n\t=?iso-8859-1?q?vXBKYAxYFb7AbF8ePbeNv0BmqfZZOVPtDRYquxa8p+KO3eBYdInHgS5ht1AY?=\n\t=?iso-8859-1?q?C0KKT0gmjzwic8MwO8gWbfVSZTu0dMA27XN4Q3PCFyUybg1M+hpL7Rf3Tr9Y?=\n\t=?iso-8859-1?q?ZHqUxKrdUHwCQo+fK0dwlOI3yjA4hx5Fvf/1iSMAjdf1nD0OkCM98nW1dMhw?=\n\t=?iso-8859-1?q?KVitk40C69NFOKSYUsPNQBNkyef4J8RpCFJ51UFL5CKqAjWUJVWWKlzcb58/?=\n\t=?iso-8859-1?q?B6dxfMKPneNroE60yBgfY7Fk/uqAeNw3vpWrod5qUQPK4CeCkSqeKU0MRpr5?=\n\t=?iso-8859-1?q?gln8MZP2Yw1/yuyQzr7G/hW0y6mtjMyun21IvyO0mp7l6dmvJcWTfwIkCEps?=\n\t=?iso-8859-1?q?kJ2dmnPDvAThj9S5jft0r/cNlAoqOckw6+IyzAB2fEd8dS4/PbqcxwA+X2oc?=\n\t=?iso-8859-1?q?e0cbnPP3UeXBz3H33y148Tv66EuBEfQqmLM4Nd53FqRofQWQoR/aTPMgaVO4?=\n\t=?iso-8859-1?q?Cx1qotRxTZ9DnJobVT5vqDrV+R+704FBR8Iyk/vzjZ93TQvy7SV5hx/ag1Kl?=\n\t=?iso-8859-1?q?F7Mo8QQwWwY5ALIo3zfmSn/zrS6g0wS3CJ7pjjQVZ0YDTtpuMWjcdHyHnD3f?=\n\t=?iso-8859-1?q?e0yMf/VsJ3yau/K6ozNRxLTfb67MrWxmkadZz/ACB5/J74Lc2UToh0uE/A8S?=\n\t=?iso-8859-1?q?1oZTjS8Q7hLdJGH0OX2oeDv+twBApqXqT5al1b8WGO3M9joFGtcWpiFSxOSW?=\n\t=?iso-8859-1?q?XLaJEAkHtXGWb5VARO4mpCqHKR6a2leZm7VcEw2bk6bHcQZfSPJLKTdTwlF9?=\n\t=?iso-8859-1?q?lknZGKFdTPOZC1NHZ9zZW79BAL0z1PW19nAf21gOZB42iftN4vk+usWbj+zx?=\n\t=?iso-8859-1?q?rYjiSLICoYpj9TUIWeVOP0l+fhXZ11H6KCsAeUDX7ocUqbPWDUIYQ5ojv3xP?=\n\t=?iso-8859-1?q?3Mz/O4BsiFhtKphr77CGqCYz6/CLopR/kkgonNszdRF//1Rd97Rm+qO3sNKe?=\n\t=?iso-8859-1?q?eK6RImbO5n++rXM49i/Pb6q7R9T+hpqoh6XU+ypoWyAoL4xS282czAqKS4++?=\n\t=?iso-8859-1?q?TrOlLllpV65/e6WafJHDM03Lg1hMWOoZ7VX6Cw5TTHu3JPGQoUQ5p1/lF7M2?=\n\t=?iso-8859-1?q?tx3dJAD2wVfb6BlzVkRJ093hjAwfy96QyueyRYQ=3D=3D?=", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8b2a932c-5ef2-4e3e-d7a5-08dc5fbb89a4", "X-MS-Exchange-CrossTenant-AuthSource": "DS0PR11MB7309.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Apr 2024 15:23:45.5305 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n BTEWc5RkcuMhr0LlnugUThNINe5OhfvzqrxAR9yowTStcG9jRC7FgEctfCnOLJz3v2JNd9Jyo59jID7nONgKHbiqYp182vjEZmK+yBF66CA=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH8PR11MB8038", "X-OriginatorOrg": "intel.com", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null }