Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139478/?format=api
{ "id": 139478, "url": "http://patchwork.dpdk.org/api/patches/139478/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240418062025.26674-1-maoyingming@baidu.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240418062025.26674-1-maoyingming@baidu.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240418062025.26674-1-maoyingming@baidu.com", "date": "2024-04-18T06:20:25", "name": "doc: Fix some typos in mbuf_lib.rst and net/cnxk comments.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "862d4c569b553a5936c3d62ab324c12325b1d98f", "submitter": { "id": 2793, "url": "http://patchwork.dpdk.org/api/people/2793/?format=api", "name": "Mao YingMing", "email": "maoyingming@baidu.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240418062025.26674-1-maoyingming@baidu.com/mbox/", "series": [ { "id": 31777, "url": "http://patchwork.dpdk.org/api/series/31777/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31777", "date": "2024-04-18T06:20:25", "name": "doc: Fix some typos in mbuf_lib.rst and net/cnxk comments.", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31777/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139478/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139478/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D502343E9C;\n\tThu, 18 Apr 2024 08:21:47 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4DB48402CC;\n\tThu, 18 Apr 2024 08:21:47 +0200 (CEST)", "from bddwd-sys-mailin04.bddwd.baidu.com (mx411.baidu.com\n [124.64.200.154])\n by mails.dpdk.org (Postfix) with ESMTP id C7F864014F\n for <dev@dpdk.org>; Thu, 18 Apr 2024 08:20:27 +0200 (CEST)", "from virtual.domain.tld (bjhw-sys-rpm015653cc5.bjhw.baidu.com\n [10.227.53.39])\n by bddwd-sys-mailin04.bddwd.baidu.com (Postfix) with ESMTP id 08EAF13D80040;\n Thu, 18 Apr 2024 14:20:26 +0800 (CST)", "from localhost (localhost [127.0.0.1])\n by virtual.domain.tld (Postfix) with ESMTP id 01F28D9932;\n Thu, 18 Apr 2024 14:20:26 +0800 (CST)" ], "From": "Mao YingMing <maoyingming@baidu.com>", "To": "dev@dpdk.org", "Cc": "Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,\n Harman Kalra <hkalra@marvell.com>", "Subject": "[PATCH] doc: Fix some typos in mbuf_lib.rst and net/cnxk comments.", "Date": "Thu, 18 Apr 2024 14:20:25 +0800", "Message-Id": "<20240418062025.26674-1-maoyingming@baidu.com>", "X-Mailer": "git-send-email 2.9.4", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: maoyingming <maoyingming@baidu.com>\n\nFixes: 2542ad53d8 (doc: add description of the offload API)\nFixes: ae2c2cb606 (net/cnxk: avoid command copy from Tx queue)\n\nReviewed-by: lishuo02 <lishuo02@baidu.com>\nSigned-off-by: maoyingming <maoyingming@baidu.com>\n---\n doc/guides/prog_guide/mbuf_lib.rst | 8 ++++----\n drivers/net/cnxk/cn10k_tx.h | 2 +-\n drivers/net/cnxk/cn9k_tx.h | 2 +-\n 3 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/mbuf_lib.rst b/doc/guides/prog_guide/mbuf_lib.rst\nindex 049357c755..749f9c97a8 100644\n--- a/doc/guides/prog_guide/mbuf_lib.rst\n+++ b/doc/guides/prog_guide/mbuf_lib.rst\n@@ -134,7 +134,7 @@ a vxlan-encapsulated tcp packet:\n \n mb->l2_len = len(out_eth)\n mb->l3_len = len(out_ip)\n- mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM\n+ mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CKSUM\n set out_ip checksum to 0 in the packet\n \n This is supported on hardware advertising RTE_ETH_TX_OFFLOAD_IPV4_CKSUM.\n@@ -143,7 +143,7 @@ a vxlan-encapsulated tcp packet:\n \n mb->l2_len = len(out_eth)\n mb->l3_len = len(out_ip)\n- mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM | RTE_MBUF_F_TX_UDP_CKSUM\n+ mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CKSUM | RTE_MBUF_F_TX_UDP_CKSUM\n set out_ip checksum to 0 in the packet\n set out_udp checksum to pseudo header using rte_ipv4_phdr_cksum()\n \n@@ -154,7 +154,7 @@ a vxlan-encapsulated tcp packet:\n \n mb->l2_len = len(out_eth + out_ip + out_udp + vxlan + in_eth)\n mb->l3_len = len(in_ip)\n- mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM\n+ mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CKSUM\n set in_ip checksum to 0 in the packet\n \n This is similar to case 1), but l2_len is different. It is supported\n@@ -165,7 +165,7 @@ a vxlan-encapsulated tcp packet:\n \n mb->l2_len = len(out_eth + out_ip + out_udp + vxlan + in_eth)\n mb->l3_len = len(in_ip)\n- mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM | RTE_MBUF_F_TX_TCP_CKSUM\n+ mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CKSUM | RTE_MBUF_F_TX_TCP_CKSUM\n set in_ip checksum to 0 in the packet\n set in_tcp checksum to pseudo header using rte_ipv4_phdr_cksum()\n \ndiff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h\nindex 5c4b9e559e..f2230b5883 100644\n--- a/drivers/net/cnxk/cn10k_tx.h\n+++ b/drivers/net/cnxk/cn10k_tx.h\n@@ -1242,7 +1242,7 @@ cn10k_nix_xmit_prepare_tstamp(struct cn10k_eth_txq *txq, uintptr_t lmt_addr,\n \t\tstruct nix_send_mem_s *send_mem;\n \n \t\tsend_mem = (struct nix_send_mem_s *)(lmt + off);\n-\t\t/* Packets for which PKT_TX_IEEE1588_TMST is not set, tx tstamp\n+\t\t/* Packets for which RTE_MBUF_F_TX_IEEE1588_TMST is not set, tx tstamp\n \t\t * should not be recorded, hence changing the alg type to\n \t\t * NIX_SENDMEMALG_SUB and also changing send mem addr field to\n \t\t * next 8 bytes as it corrupts the actual Tx tstamp registered\ndiff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h\nindex 018fae2eb7..27c3318ceb 100644\n--- a/drivers/net/cnxk/cn9k_tx.h\n+++ b/drivers/net/cnxk/cn9k_tx.h\n@@ -559,7 +559,7 @@ cn9k_nix_xmit_prepare_tstamp(struct cn9k_eth_txq *txq, uint64_t *cmd,\n \n \t\tsend_mem = (struct nix_send_mem_s *)(cmd + off);\n \n-\t\t/* Packets for which PKT_TX_IEEE1588_TMST is not set, tx tstamp\n+\t\t/* Packets for which RTE_MBUF_F_TX_IEEE1588_TMST is not set, tx tstamp\n \t\t * should not be recorded, hence changing the alg type to\n \t\t * NIX_SENDMEMALG_SUB and also changing send mem addr field to\n \t\t * next 8 bytes as it corrupts the actual Tx tstamp registered\n", "prefixes": [] }