Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139617/?format=api
{ "id": 139617, "url": "http://patchwork.dpdk.org/api/patches/139617/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240422152336.147553-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240422152336.147553-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240422152336.147553-7-stephen@networkplumber.org", "date": "2024-04-22T15:21:36", "name": "[v5,6/9] latencystats: enforce that unused callback function is NULL", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9015efc5c9844b0e8130d74117d1344b7488721b", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240422152336.147553-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 31803, "url": "http://patchwork.dpdk.org/api/series/31803/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31803", "date": "2024-04-22T15:21:30", "name": "latencystats: improve algorithms and tests", "version": 5, "mbox": "http://patchwork.dpdk.org/series/31803/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139617/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139617/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 17A1C43EDB;\n\tMon, 22 Apr 2024 17:24:27 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 37A3240DCE;\n\tMon, 22 Apr 2024 17:24:04 +0200 (CEST)", "from mail-pf1-f178.google.com (mail-pf1-f178.google.com\n [209.85.210.178])\n by mails.dpdk.org (Postfix) with ESMTP id 0F48B406B8\n for <dev@dpdk.org>; Mon, 22 Apr 2024 17:23:52 +0200 (CEST)", "by mail-pf1-f178.google.com with SMTP id\n d2e1a72fcca58-6eff9dc1821so4481210b3a.3\n for <dev@dpdk.org>; Mon, 22 Apr 2024 08:23:51 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n cb17-20020a056a02071100b0060063c4be3bsm1402783pgb.14.2024.04.22.08.23.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Apr 2024 08:23:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713799431;\n x=1714404231; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Tbyh2BBDJylB3AYKzLsyjZ08dTesXypgKi0n1sS96uE=;\n b=ZAlamSzCyd37rEXw7BMa9g8WX7111M6ZNdaJ3MStE3ZZZk1EeVxSoXvwE4apsHEixs\n pJT+nAc5jipIdMRpe3Uup/k+g4TdQhkBetmG8pcPR6ikRMHgQOZJR8ANefhFM/4wOptJ\n q6zeC01wnhGiZPvnQ5UcKnOLANEmVdIuCSl3E2Sfj1qH/DYDPbia0xfBjV359qzOc4tW\n UpE+xdQ9V4r6ibiiL4CkWNJYLhPlzU4W5m/qIbOWvjMBsalxqJbIJxoY9OH0IOSZScWv\n KEqG1XlIJyMg4wmcjPo8DH36fqH2sP5y/bnO/PkPnuCQqZY6leJbbXo/NvvBWesuIiyq\n nFxA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713799431; x=1714404231;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Tbyh2BBDJylB3AYKzLsyjZ08dTesXypgKi0n1sS96uE=;\n b=vUXaNycENxVATQKe0nFoXGQ1g+iJqh0vVBEVbGFzZpWNs42dt0/YvP+Jnxb+7M87Lj\n nOpK+LokhcrCjZf8pCTrgN8+v6zMxtt9RttZp8TvivHjnPwFyHrX6hycAQYJyqyuWych\n 1O/KE5c2Y9qV4GSCDQNBmjyHnVwvjFj1iFFF4X8Uy5A++KCprit3pnqDvcmRsDgJQaZT\n lnibzlkOlMm1tLloqwv3gKo+7XbZ2Z123BeBh62NVgWSHdjRZGnSlSCYe4EEd5I+Ho5H\n jZ0T/5QvxYykkHhQHNw5A9E7QeVBCHNUqDiZr/bsp+BN8NuTb4RZCbp6kz0QpdW59rCR\n 6VKg==", "X-Gm-Message-State": "AOJu0YxR0MJlV1u3vnULfo1Vy/kRNSV2g3KNkOZySKrQNhUhRrKl/EfL\n 9uRbYRQ4JmIDmvw8U1oTsnfj5N05ECTqVNgndDcLHGv5S0b2IuSRpzt915aO4J9OlqGNSjki1D2\n G", "X-Google-Smtp-Source": "\n AGHT+IE2Q5ImzJzpzMNyB9WjKUzEYoK/mzJ2c3gWPb0CXJpu0CZ8hPkHIzArLQ59UPQq6vZSaPi+PQ==", "X-Received": "by 2002:a05:6a21:7884:b0:1a3:c515:202c with SMTP id\n bf4-20020a056a21788400b001a3c515202cmr11121669pzc.62.1713799431222;\n Mon, 22 Apr 2024 08:23:51 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v5 6/9] latencystats: enforce that unused callback function is\n NULL", "Date": "Mon, 22 Apr 2024 08:21:36 -0700", "Message-ID": "<20240422152336.147553-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240422152336.147553-1-stephen@networkplumber.org>", "References": "<20240408195036.182545-1-stephen@networkplumber.org>\n <20240422152336.147553-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "ISO C does not allow casting function pointer to void *.\nResolve by enforcing the reserved argument.\nThe user_cb argument for rte_latencystats_init() was not\nimplemented, and had to be NULL anyway.\n\nThe log type is local to this function and therefore\ncan be local to this file.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/latencystats/rte_latencystats.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex bd8fde2f0c..8311adb411 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -30,7 +30,7 @@\n \n static double cycles_per_ns;\n \n-RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO);\n+static RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO);\n #define RTE_LOGTYPE_LATENCY_STATS latencystat_logtype\n #define LATENCY_STATS_LOG(level, ...) \\\n \tRTE_LOG_LINE(level, LATENCY_STATS, \"\" __VA_ARGS__)\n@@ -246,6 +246,10 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \tif (rte_memzone_lookup(MZ_RTE_LATENCY_STATS))\n \t\treturn -EEXIST;\n \n+\t/** Reserved for possible future use */\n+\tif (user_cb != NULL)\n+\t\treturn -ENOTSUP;\n+\n \t/** Allocate stats in shared memory fo multi process support */\n \tmz = rte_memzone_reserve(MZ_RTE_LATENCY_STATS, sizeof(*glob_stats),\n \t\t\t\t\trte_socket_id(), flags);\n@@ -298,7 +302,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \t\tfor (qid = 0; qid < dev_info.nb_rx_queues; qid++) {\n \t\t\tcbs = &rx_cbs[pid][qid];\n \t\t\tcbs->cb = rte_eth_add_first_rx_callback(pid, qid,\n-\t\t\t\t\tadd_time_stamps, user_cb);\n+\t\t\t\t\tadd_time_stamps, NULL);\n \t\t\tif (!cbs->cb)\n \t\t\t\tLATENCY_STATS_LOG(NOTICE,\n \t\t\t\t\t\"Failed to register Rx callback for pid=%u, qid=%u\",\n@@ -307,7 +311,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tcbs->cb = rte_eth_add_tx_callback(pid, qid,\n-\t\t\t\t\tcalc_latency, user_cb);\n+\t\t\t\t\tcalc_latency, NULL);\n \t\t\tif (!cbs->cb)\n \t\t\t\tLATENCY_STATS_LOG(NOTICE,\n \t\t\t\t\t\"Failed to register Tx callback for pid=%u, qid=%u\",\n", "prefixes": [ "v5", "6/9" ] }