Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 139618,
    "url": "http://patchwork.dpdk.org/api/patches/139618/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240422152336.147553-8-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240422152336.147553-8-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240422152336.147553-8-stephen@networkplumber.org",
    "date": "2024-04-22T15:21:37",
    "name": "[v5,7/9] latencystats: add metric for number of samples",
    "commit_ref": null,
    "pull_url": null,
    "state": "new",
    "archived": false,
    "hash": "cdc5386a343303fe897e580859ca7a71b7a58ecd",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240422152336.147553-8-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 31803,
            "url": "http://patchwork.dpdk.org/api/series/31803/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31803",
            "date": "2024-04-22T15:21:30",
            "name": "latencystats: improve algorithms and tests",
            "version": 5,
            "mbox": "http://patchwork.dpdk.org/series/31803/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/139618/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/139618/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE5CA43EDB;\n\tMon, 22 Apr 2024 17:24:31 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 60D0A40DDD;\n\tMon, 22 Apr 2024 17:24:05 +0200 (CEST)",
            "from mail-pf1-f176.google.com (mail-pf1-f176.google.com\n [209.85.210.176])\n by mails.dpdk.org (Postfix) with ESMTP id CDDB740A72\n for <dev@dpdk.org>; Mon, 22 Apr 2024 17:23:52 +0200 (CEST)",
            "by mail-pf1-f176.google.com with SMTP id\n d2e1a72fcca58-6ee0642f718so3868380b3a.0\n for <dev@dpdk.org>; Mon, 22 Apr 2024 08:23:52 -0700 (PDT)",
            "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n cb17-20020a056a02071100b0060063c4be3bsm1402783pgb.14.2024.04.22.08.23.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Apr 2024 08:23:51 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713799432;\n x=1714404232; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uDckzPMoggt3O0PD6CzLT8GtY/9DAGBqZIMGwEjEdxs=;\n b=pGDKZg/6HkQOz9z73X3Yr7T2TL1zx/51RaJDunErswJNtQGpwDz7MODV0fosSMJXws\n z2gHeg3hZ0x8W10YzYGt/c6Mzpwj86q3Jx4WU1l2PfYVX6GgToF3L2ktJ2BQGTxwIwL5\n LA8WeTreoh2DQVRYONAR29uColzQAXdr/8/HGLAwx4dX3iQlqANvn7I88CDWDbY+At6/\n TYzkdtKC7g8xgrGvQlWPmqCrmSeiPaTpyGFoZE0M50QgtxjzCp4EygO085awUSR/+khZ\n wFkLjmQ0pp/Ppkc0aSJ96kAags5NXMreqIQlWBxKhe5++rn5+Ak6IsfpDJM57UYTJwqf\n s5lA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713799432; x=1714404232;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=uDckzPMoggt3O0PD6CzLT8GtY/9DAGBqZIMGwEjEdxs=;\n b=IrtCQ/asHJieltsztflvqQ5CUdxeaszbaJj7qLbiU7GxjQs6pOCBjrc/28zV+N7j1X\n E2Kfya3ZeCqB7p9DfmCyZFOiSEOKSJ0PicxHKWwTbkMKzPe4Bc2/z4NFg6jjU+8he5ZV\n IdK3L6MfbNF5tqQlBJH9ApjK0ofoA2f0g5mzJJ8c1ILxD1X9L1rWrBDnn7xihEmdcq7V\n h8QkLj3kz8q3BgUG/G/PPsrEdi1uFx2VvMdgfAGnrwk5UxUSVVHuj9q0POPuUyVh4PZc\n NCGezx3DPR2YMz8IGgqD5vCmPgoZDewM7B9OZrgIiLnUF3FbsyFmoQvPqjxYkc6FRxmY\n OOJw==",
        "X-Gm-Message-State": "AOJu0YzVQ2k6orQBFT1ykNeQNG7PVIZljSU/P+15AqotKoGle7KHh2rx\n vQX+FWqkMs59RVOx8u2dJGTK0nQuVj2HNuqUJFiCG+JEAj7sRWi5ftPTEvLqJDv6mVFAArBlKPL\n 2",
        "X-Google-Smtp-Source": "\n AGHT+IGzKj+IUuFC4n6R1TEB+eAtlHjyEWWGNe9lkWQY9gobcTgR9VkWh2SMqoyLhcJzULpVpgw3oA==",
        "X-Received": "by 2002:a05:6a21:2723:b0:1ad:4978:adf4 with SMTP id\n rm35-20020a056a21272300b001ad4978adf4mr828574pzb.1.1713799431992;\n Mon, 22 Apr 2024 08:23:51 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>",
        "Subject": "[PATCH v5 7/9] latencystats: add metric for number of samples",
        "Date": "Mon, 22 Apr 2024 08:21:37 -0700",
        "Message-ID": "<20240422152336.147553-8-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.43.0",
        "In-Reply-To": "<20240422152336.147553-1-stephen@networkplumber.org>",
        "References": "<20240408195036.182545-1-stephen@networkplumber.org>\n <20240422152336.147553-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Keeping track of the number of samples is useful when doing\ndebug and testing to make sure that samples are actually happening.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/latencystats/rte_latencystats.c | 20 ++++++++++++--------\n 1 file changed, 12 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex 8311adb411..e5a84fbd92 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -59,6 +59,7 @@ struct rte_latency_stats {\n \tuint64_t avg_latency; /**< Average latency */\n \tuint64_t max_latency; /**< Maximum latency */\n \tuint64_t jitter; /** Latency variation */\n+\tuint64_t samples;    /** Number of latency samples */\n \trte_spinlock_t lock; /** Latency calculation lock */\n };\n \n@@ -82,20 +83,26 @@ static const struct latency_stats_nameoff lat_stats_strings[] = {\n \t{\"avg_latency_ns\", offsetof(struct rte_latency_stats, avg_latency), LATENCY_AVG_SCALE},\n \t{\"max_latency_ns\", offsetof(struct rte_latency_stats, max_latency), 1},\n \t{\"jitter_ns\", offsetof(struct rte_latency_stats, jitter), LATENCY_JITTER_SCALE},\n+\t{\"samples\", offsetof(struct rte_latency_stats, samples), 0},\n };\n \n-#define NUM_LATENCY_STATS (sizeof(lat_stats_strings) / \\\n-\t\t\t\tsizeof(lat_stats_strings[0]))\n+#define NUM_LATENCY_STATS RTE_DIM(lat_stats_strings)\n \n static void\n latencystats_collect(uint64_t values[])\n {\n-\tunsigned int i;\n+\tunsigned int i, scale;\n \tconst uint64_t *stats;\n \n \tfor (i = 0; i < NUM_LATENCY_STATS; i++) {\n \t\tstats = RTE_PTR_ADD(glob_stats, lat_stats_strings[i].offset);\n-\t\tvalues[i] = floor(*stats / (cycles_per_ns * lat_stats_strings[i].scale));\n+\t\tscale = lat_stats_strings[i].scale;\n+\n+\t\t/* used to mark samples which are not a time interval */\n+\t\tif (scale == 0)\n+\t\t\tvalues[i] = *stats;\n+\t\telse\n+\t\t\tvalues[i] = floor(*stats / (cycles_per_ns * scale));\n \t}\n }\n \n@@ -173,7 +180,6 @@ calc_latency(uint16_t pid __rte_unused,\n \tunsigned int i;\n \tuint64_t now, latency;\n \tstatic uint64_t prev_latency;\n-\tstatic bool first_sample = true;\n \n \tnow = rte_rdtsc();\n \n@@ -184,9 +190,7 @@ calc_latency(uint16_t pid __rte_unused,\n \n \t\tlatency = now - *timestamp_dynfield(pkts[i]);\n \n-\t\tif (unlikely(first_sample)) {\n-\t\t\tfirst_sample = false;\n-\n+\t\tif (glob_stats->samples++ == 0) {\n \t\t\tglob_stats->min_latency = latency;\n \t\t\tglob_stats->max_latency = latency;\n \t\t\tglob_stats->avg_latency = latency * 4;\n",
    "prefixes": [
        "v5",
        "7/9"
    ]
}