Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139619/?format=api
{ "id": 139619, "url": "http://patchwork.dpdk.org/api/patches/139619/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240422152336.147553-9-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240422152336.147553-9-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240422152336.147553-9-stephen@networkplumber.org", "date": "2024-04-22T15:21:38", "name": "[v5,8/9] test: use initialization in latencystats test", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "00fb3ce860be749f91feb49a4a84f79b68c08f22", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240422152336.147553-9-stephen@networkplumber.org/mbox/", "series": [ { "id": 31803, "url": "http://patchwork.dpdk.org/api/series/31803/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31803", "date": "2024-04-22T15:21:30", "name": "latencystats: improve algorithms and tests", "version": 5, "mbox": "http://patchwork.dpdk.org/series/31803/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139619/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139619/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A3D143EDB;\n\tMon, 22 Apr 2024 17:24:38 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DDBF140DFB;\n\tMon, 22 Apr 2024 17:24:06 +0200 (CEST)", "from mail-pf1-f176.google.com (mail-pf1-f176.google.com\n [209.85.210.176])\n by mails.dpdk.org (Postfix) with ESMTP id 974D440A72\n for <dev@dpdk.org>; Mon, 22 Apr 2024 17:23:53 +0200 (CEST)", "by mail-pf1-f176.google.com with SMTP id\n d2e1a72fcca58-6ed691fb83eso3558147b3a.1\n for <dev@dpdk.org>; Mon, 22 Apr 2024 08:23:53 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n cb17-20020a056a02071100b0060063c4be3bsm1402783pgb.14.2024.04.22.08.23.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 22 Apr 2024 08:23:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713799433;\n x=1714404233; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MPx8Tq4z+i1E7ZA5J+6800hQ4t64aBB2SM01FOQj28E=;\n b=j2MvXtpR15DNbeyaM4/UXzI2PajJGFECqHEVs/+ZQE9DntHfRDySVLR8sJ4vQ4QHPW\n mqNTL9pM1nuIX5CAYxvgynlpdc96LhJNuNllVz8/J4aKIGUQDy//VLbXNkJxb8sYX4J9\n mXmRRjeOQhi2u9HHaXyokgQUXgWMTm7mlpsrsIo81CQ+GJKOG2YIejkoQs0X+5MjLY+1\n M5t//B1pU/lDrbQ62BKufzT4YkUqqI7rVGTi38emcqR2xxJUt+SXFdjvx0iLsWkARVWg\n IiULQWiUcvg5iH8ew+TYEki6+lL90LUgWBzaVotoXcXiyKN6BKBHPoa5BsO1tOcDnjO3\n MLew==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713799433; x=1714404233;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=MPx8Tq4z+i1E7ZA5J+6800hQ4t64aBB2SM01FOQj28E=;\n b=nyKV0wPNf0Wl7tjK703fZMGUMGnDxV73ixg95j+/NIDODuGB+3BvPrLdWORMltFx21\n kX1o51tZZZwn6OCdsEfm2wLYMVfd3Jj4gqbF/Favdf46H6627++Do8EqiPs8UEqKiV7w\n PclIYYss82r+ee02KUV0/ohUq97fYdfl+6htnkCvg9UZe2QpCuvvCUY17oNZ/HqHEwy6\n 87cPy+dG8tWIsfc1GvTeJl6FLx0uInpy7+DOU0SrMb7yFqIp+JcNfZSW8H5kVg6nc53F\n +fpyWOvqI3SeuJT2SRe+JKL0wcshhUEWB/A3Mff+QnogOHjlLBGlq+HG3WEsSeSWbFJV\n FWlg==", "X-Gm-Message-State": "AOJu0YwVUIo0yIK4/0gaf+bvhC6SYHkUC7ZJb80goeHSQyfxtnvCFEBW\n jRwF6uQsv1PAH6oB2hMXRIu6EmGBauQX34zVPIdn0cbg51gJL4Z5Q5l0MaeDxzDcvE4FvtkUjU2\n T", "X-Google-Smtp-Source": "\n AGHT+IEX3ZIUBbEs6BW2dRvkXhaWRvJHUQFSj5GAMPawlaY4t+EPK9MF50ejiBYJ0QKIITfPD8ARbg==", "X-Received": "by 2002:a05:6a21:2d09:b0:1a9:8b4a:b84 with SMTP id\n tw9-20020a056a212d0900b001a98b4a0b84mr12417019pzb.18.1713799432775;\n Mon, 22 Apr 2024 08:23:52 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v5 8/9] test: use initialization in latencystats test", "Date": "Mon, 22 Apr 2024 08:21:38 -0700", "Message-ID": "<20240422152336.147553-9-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240422152336.147553-1-stephen@networkplumber.org>", "References": "<20240408195036.182545-1-stephen@networkplumber.org>\n <20240422152336.147553-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "No need for loop and memset() here. Just use structure\ninitialization. Remove unnecessary initializations.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_latencystats.c | 22 +++++++---------------\n 1 file changed, 7 insertions(+), 15 deletions(-)", "diff": "diff --git a/app/test/test_latencystats.c b/app/test/test_latencystats.c\nindex c309ab194f..3369c8bb90 100644\n--- a/app/test/test_latencystats.c\n+++ b/app/test/test_latencystats.c\n@@ -21,7 +21,7 @@\n static uint16_t portid;\n static struct rte_ring *ring;\n \n-static struct rte_metric_name lat_stats_strings[] = {\n+static struct rte_metric_name lat_stats_strings[NUM_STATS] = {\n \t{\"min_latency_ns\"},\n \t{\"avg_latency_ns\"},\n \t{\"max_latency_ns\"},\n@@ -70,13 +70,9 @@ static int test_latency_uninit(void)\n /* Test case to get names of latency stats */\n static int test_latencystats_get_names(void)\n {\n-\tint ret = 0, i = 0;\n-\tint size = 0;\n-\tstruct rte_metric_name names[NUM_STATS];\n-\n-\tsize_t m_size = sizeof(struct rte_metric_name);\n-\tfor (i = 0; i < NUM_STATS; i++)\n-\t\tmemset(&names[i], 0, m_size);\n+\tint ret, i;\n+\tuint16_t size;\n+\tstruct rte_metric_name names[NUM_STATS] = { };\n \n \t/* Success Test: Valid names and size */\n \tsize = NUM_STATS;\n@@ -106,13 +102,9 @@ static int test_latencystats_get_names(void)\n /* Test case to get latency stats values */\n static int test_latencystats_get(void)\n {\n-\tint ret = 0, i = 0;\n-\tint size = 0;\n-\tstruct rte_metric_value values[NUM_STATS];\n-\n-\tsize_t v_size = sizeof(struct rte_metric_value);\n-\tfor (i = 0; i < NUM_STATS; i++)\n-\t\tmemset(&values[i], 0, v_size);\n+\tint ret;\n+\tuint16_t size;\n+\tstruct rte_metric_value values[NUM_STATS] = { };\n \n \t/* Success Test: Valid values and valid size */\n \tsize = NUM_STATS;\n", "prefixes": [ "v5", "8/9" ] }