Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139623/?format=api
{ "id": 139623, "url": "http://patchwork.dpdk.org/api/patches/139623/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240422154008.119800-5-hernan.vargas@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240422154008.119800-5-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240422154008.119800-5-hernan.vargas@intel.com", "date": "2024-04-22T15:40:07", "name": "[v1,4/5] baseband/acc: improve error description", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3a407003fb27539970bb3a7e2033e42e4ad10686", "submitter": { "id": 2659, "url": "http://patchwork.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240422154008.119800-5-hernan.vargas@intel.com/mbox/", "series": [ { "id": 31804, "url": "http://patchwork.dpdk.org/api/series/31804/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31804", "date": "2024-04-22T15:40:03", "name": "ACC100 improvements and clean up", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31804/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139623/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139623/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 83E2843EDB;\n\tMon, 22 Apr 2024 17:44:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BE06C402F1;\n\tMon, 22 Apr 2024 17:44:04 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by mails.dpdk.org (Postfix) with ESMTP id ACF13402F2\n for <dev@dpdk.org>; Mon, 22 Apr 2024 17:44:00 +0200 (CEST)", "from fmviesa003.fm.intel.com ([10.60.135.143])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2024 08:43:41 -0700", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by fmviesa003.fm.intel.com with ESMTP; 22 Apr 2024 08:43:40 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1713800641; x=1745336641;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=gEGlJrgFtgPpiwC2F/zpxpMBcoUQL3bsvUdNPq9HaZE=;\n b=JSSrUfy3eCkGqZR/mz1EyvFJbJzL9fZ3vwjWT83aDRdCC611ln7PM6PL\n 2rqZ6o+IEnoMPJX65Lapr8l3MRcconoRFYn18KqkxXwcfAEi22ASvhFes\n xk0WXHQKY1aDslJy/3oGUxdcFyrFK9li2Q8vjA+sfSzxPNCV2y8liyIuu\n YVlv+axBwzq2S4tShKcAOn33mjoalu3dtQwG/eLdFXM7IaQLdSuOqQ9nM\n LMW2dbfkpUIR6Bu7zL+UdFFIEJVNpg4YYMXU1vhzdbmyuvt6hqRybDjfY\n Pq8V9uV2sOgmoHDK9nY4vvXhaNMUyUDbpgGOUbpxWQp7uetIpiyqCdbpO A==;", "X-CSE-ConnectionGUID": [ "0uLsGGZBTEWSEoByYSBdJQ==", "BQHaJ0TzT9KvXw1AtmHvNQ==" ], "X-CSE-MsgGUID": [ "VeFTkzQnR82I7esj/eNbPA==", "OM89UAt3QdKFk0VaufOLmw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11052\"; a=\"20492710\"", "E=Sophos;i=\"6.07,220,1708416000\"; d=\"scan'208\";a=\"20492710\"", "E=Sophos;i=\"6.07,220,1708416000\"; d=\"scan'208\";a=\"28567540\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>", "Subject": "[PATCH v1 4/5] baseband/acc: improve error description", "Date": "Mon, 22 Apr 2024 08:40:07 -0700", "Message-Id": "<20240422154008.119800-5-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20240422154008.119800-1-hernan.vargas@intel.com>", "References": "<20240422154008.119800-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove dead code for error and update description of one error print.\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\n---\n drivers/baseband/acc/rte_acc100_pmd.c | 19 +------------------\n 1 file changed, 1 insertion(+), 18 deletions(-)", "diff": "diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c\nindex f37722879c20..8ec521675f34 100644\n--- a/drivers/baseband/acc/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc/rte_acc100_pmd.c\n@@ -1152,7 +1152,6 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,\n \tuint16_t harq_out_length, harq_in_length, ncb_p, k0_p, parity_offset;\n \tuint32_t harq_index;\n \tuint32_t l;\n-\tuint32_t max_hc_in;\n \n \tfcw->qm = op->ldpc_dec.q_m;\n \tfcw->nfiller = op->ldpc_dec.n_filler;\n@@ -1222,21 +1221,6 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,\n \t\tfcw->hcin_size1 = 0;\n \t}\n \n-\t/* Enforce additional check on FCW validity */\n-\tmax_hc_in = RTE_ALIGN_CEIL(fcw->ncb - fcw->nfiller, ACC_HARQ_ALIGN_64B);\n-\tif ((fcw->hcin_size0 > max_hc_in) ||\n-\t\t\t(fcw->hcin_size1 + fcw->hcin_offset > max_hc_in) ||\n-\t\t\t((fcw->hcin_size0 > fcw->hcin_offset) &&\n-\t\t\t(fcw->hcin_size1 != 0))) {\n-\t\trte_bbdev_log(ERR, \" Invalid FCW : HCIn %d %d %d, Ncb %d F %d\",\n-\t\t\t\tfcw->hcin_size0, fcw->hcin_size1,\n-\t\t\t\tfcw->hcin_offset,\n-\t\t\t\tfcw->ncb, fcw->nfiller);\n-\t\t/* Disable HARQ input in that case to carry forward */\n-\t\top->ldpc_dec.op_flags ^= RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE;\n-\t\tfcw->hcin_en = 0;\n-\t}\n-\n \tfcw->itmax = op->ldpc_dec.iter_max;\n \tfcw->itstop = check_bit(op->ldpc_dec.op_flags,\n \t\t\tRTE_BBDEV_LDPC_ITERATION_STOP_ENABLE);\n@@ -1286,8 +1270,7 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw,\n \t\tfcw->hcout_offset = 0;\n \n \t\tif (fcw->hcout_size0 == 0) {\n-\t\t\trte_bbdev_log(ERR, \" Invalid FCW : HCout %d\",\n-\t\t\t\tfcw->hcout_size0);\n+\t\t\trte_bbdev_log(ERR, \" Disabling HARQ output as size is zero\");\n \t\t\top->ldpc_dec.op_flags ^= RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE;\n \t\t\tfcw->hcout_en = 0;\n \t\t}\n", "prefixes": [ "v1", "4/5" ] }