Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139635/?format=api
{ "id": 139635, "url": "http://patchwork.dpdk.org/api/patches/139635/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240422190800.123027-9-hernan.vargas@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240422190800.123027-9-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240422190800.123027-9-hernan.vargas@intel.com", "date": "2024-04-22T19:07:59", "name": "[v1,8/9] test/bbdev: update fft measurement output", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b735fc24e279c1c0ae7b41490340c9256a3817f2", "submitter": { "id": 2659, "url": "http://patchwork.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240422190800.123027-9-hernan.vargas@intel.com/mbox/", "series": [ { "id": 31807, "url": "http://patchwork.dpdk.org/api/series/31807/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31807", "date": "2024-04-22T19:07:51", "name": "test-bbdev fixes and improvements for 24.07", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31807/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139635/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/139635/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3F59743EDD;\n\tMon, 22 Apr 2024 21:12:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A1AD840A8B;\n\tMon, 22 Apr 2024 21:11:46 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.11])\n by mails.dpdk.org (Postfix) with ESMTP id EC2B9402C5\n for <dev@dpdk.org>; Mon, 22 Apr 2024 21:11:35 +0200 (CEST)", "from orviesa006.jf.intel.com ([10.64.159.146])\n by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Apr 2024 12:11:36 -0700", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:35 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1713813096; x=1745349096;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=WjFTOCV68sgZ48p+4zvrvWZyj370txY2WUuzEH0S6Lo=;\n b=dnP6KlRzZjP4Yg0az1gaiFttf63fbCD5Mx9eFtQDUqDYdhvL2lP1+syS\n 8fwtmt360Qn6i3HB2TccxA4DWeVwN8cmlvCEI6gKcI6ETcIqeOlZa0bbg\n MIctD6prenFq1dWqJH+ffZJX0w7EyFPx6H5IvQ/aErs0JzvCBzDZGX2H+\n AH0kyWIyN5/AFqd/RiSU7CUfAWcN5tQFKQDX38NvaZe25Qcj7PtpK6B+8\n 2Ck/9Agna/33A2J3B4wFVLQ8qvwWR4WrurNcu830S/fmudFOAHehwz9R3\n QaNC74f6o6LpLRJl4hMv+0MsEb2N/uG+EZhLqat5X+BI5p0v8NMbtljdz g==;", "X-CSE-ConnectionGUID": [ "hl1+AkGwST62st0t9UBvQQ==", "QhmHSAgtRROUHIfkTEL0TA==" ], "X-CSE-MsgGUID": [ "SyNlTq25ToS0agjlz7x/Qw==", "hlf8MB70QQeIewBn0FbrOg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11052\"; a=\"19922822\"", "E=Sophos;i=\"6.07,221,1708416000\"; d=\"scan'208\";a=\"19922822\"", "E=Sophos;i=\"6.07,221,1708416000\"; d=\"scan'208\";a=\"24555975\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>", "Subject": "[PATCH v1 8/9] test/bbdev: update fft measurement output", "Date": "Mon, 22 Apr 2024 12:07:59 -0700", "Message-Id": "<20240422190800.123027-9-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20240422190800.123027-1-hernan.vargas@intel.com>", "References": "<20240422190800.123027-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Update check for FFT measurement output to better account for tolerance.\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\n---\n app/test-bbdev/test_bbdev_perf.c | 52 +++++++++++++++++++++++++++++++-\n 1 file changed, 51 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c\nindex 57b21730cab2..639e67a937b2 100644\n--- a/app/test-bbdev/test_bbdev_perf.c\n+++ b/app/test-bbdev/test_bbdev_perf.c\n@@ -2637,6 +2637,56 @@ validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig\n \treturn TEST_SUCCESS;\n }\n \n+static inline int\n+validate_op_fft_meas_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig_op,\n+\t\tbool skip_validate_output)\n+{\n+\tstruct rte_mbuf *m = op->data;\n+\tuint8_t i, nb_dst_segments = orig_op->nb_segments;\n+\tdouble thres_hold = 1.0;\n+\tuint32_t j, data_len_iq, error_num;\n+\tint32_t *ref_out, *op_out;\n+\tdouble estSNR, refSNR, delt, abs_delt;\n+\n+\tTEST_ASSERT(nb_dst_segments == m->nb_segs,\n+\t\t\t\"Number of segments differ in original (%u) and filled (%u) op fft\",\n+\t\t\tnb_dst_segments, m->nb_segs);\n+\n+\t/* Due to size limitation of mbuf, FFT doesn't use real mbuf. */\n+\tfor (i = 0; i < nb_dst_segments; ++i) {\n+\t\tuint16_t offset = (i == 0) ? op->offset : 0;\n+\t\tuint32_t data_len = op->length;\n+\n+\t\tTEST_ASSERT(orig_op->segments[i].length == data_len,\n+\t\t\t\t\"Length of segment differ in original (%u) and filled (%u) op fft\",\n+\t\t\t\torig_op->segments[i].length, data_len);\n+\n+\t\t/* Divided by 4 to get the number of 32 bits data. */\n+\t\tdata_len_iq = data_len >> 2;\n+\t\tref_out = (int32_t *)(orig_op->segments[i].addr);\n+\t\top_out = rte_pktmbuf_mtod_offset(m, int32_t *, offset);\n+\t\terror_num = 0;\n+\t\tfor (j = 0; j < data_len_iq; j++) {\n+\t\t\testSNR = 10*log10(op_out[j]);\n+\t\t\trefSNR = 10*log10(ref_out[j]);\n+\t\t\tdelt = refSNR - estSNR;\n+\t\t\tabs_delt = delt > 0 ? delt : -delt;\n+\t\t\terror_num += (abs_delt > thres_hold ? 1 : 0);\n+\t\t}\n+\t\tif ((error_num > 0) && !skip_validate_output) {\n+\t\t\trte_memdump(stdout, \"Buffer A\", ref_out, data_len);\n+\t\t\trte_memdump(stdout, \"Buffer B\", op_out, data_len);\n+\t\t\tTEST_ASSERT(error_num == 0,\n+\t\t\t\t\"FFT Output are not matched total (%u) errors (%u)\",\n+\t\t\t\tdata_len_iq, error_num);\n+\t\t}\n+\n+\t\tm = m->next;\n+\t}\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n static inline int\n validate_op_mldts_chain(struct rte_bbdev_op_data *op,\n \t\tstruct op_data_entries *orig_op)\n@@ -2712,7 +2762,7 @@ validate_fft_op(struct rte_bbdev_fft_op **ops, const uint16_t n,\n \t\t\t\t&ops[i]->fft.base_output, fft_data_orig, skip_validate_output),\n \t\t\t\t\"FFT Output buffers (op=%u) are not matched\", i);\n \t\tif (check_bit(ops[i]->fft.op_flags, RTE_BBDEV_FFT_POWER_MEAS))\n-\t\t\tTEST_ASSERT_SUCCESS(validate_op_fft_chain(\n+\t\t\tTEST_ASSERT_SUCCESS(validate_op_fft_meas_chain(\n \t\t\t\t&ops[i]->fft.power_meas_output, fft_pwr_orig, skip_validate_output),\n \t\t\t\t\"FFT Power Output buffers (op=%u) are not matched\", i);\n \t}\n", "prefixes": [ "v1", "8/9" ] }