Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139645/?format=api
{ "id": 139645, "url": "http://patchwork.dpdk.org/api/patches/139645/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240424034541.134335-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240424034541.134335-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240424034541.134335-1-stephen@networkplumber.org", "date": "2024-04-24T03:45:40", "name": "event: fix warning from useless snprintf", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "405ae164e43c16281014b8563f753e591509b41e", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240424034541.134335-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 31813, "url": "http://patchwork.dpdk.org/api/series/31813/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31813", "date": "2024-04-24T03:45:40", "name": "event: fix warning from useless snprintf", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31813/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139645/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/139645/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 97BF943EF1;\n\tWed, 24 Apr 2024 05:45:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1F24A402AB;\n\tWed, 24 Apr 2024 05:45:55 +0200 (CEST)", "from mail-oi1-f174.google.com (mail-oi1-f174.google.com\n [209.85.167.174])\n by mails.dpdk.org (Postfix) with ESMTP id 4A0F4400D7\n for <dev@dpdk.org>; Wed, 24 Apr 2024 05:45:53 +0200 (CEST)", "by mail-oi1-f174.google.com with SMTP id\n 5614622812f47-3c74b27179dso2568367b6e.1\n for <dev@dpdk.org>; Tue, 23 Apr 2024 20:45:53 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n ei16-20020a056a0080d000b006ed06c4074bsm10410761pfb.85.2024.04.23.20.45.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 23 Apr 2024 20:45:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1713930352;\n x=1714535152; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=it+rKWoNtAjd0sTFydnvrCchR6lUtN+tVKLFi3+XC6o=;\n b=jigXKhNVilfPPgPnde2vZJoOH6tWBgjXN0xVNLBIg8sldg8Zuo0shn/S1FDDmX4TwB\n UtJYDDBeG/a+DdxzdSD8oQUR6rrrcCKcys/BmaRzam//wtjp2PQuUDXxLmr5hbpsaQj3\n SDEChwHtMcTp2JgYH1+NEbkxVdp3lDlVL5lcLqiHJ6xGr/zeObtx+8Wy8N0yK3iQfhs2\n NxAGVnvgHy6pcJ9j4AcygXU63ZluYJk/VzGGI1N73F8wW/TIyIB0fxlTfZn3i4U0seB7\n YK6+ucMvBf/kAc2ZZIo3fzzjLw3erzm6KDa7c7/54oxY9peBOczsiBYbnODEDuQH8ej3\n aq1Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1713930352; x=1714535152;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=it+rKWoNtAjd0sTFydnvrCchR6lUtN+tVKLFi3+XC6o=;\n b=khr7x2zR4mjixAgbevTTi9w1C1j8o6L6OoeifPJzhFsyQsEyMRjIQe9rSAG7W1t546\n l0kBXFVzmf2mh+gQSNeLim1frxK4amoHEPxx+KZigEPNQkSl8znp+7hVCIFfX3LCXvcw\n s8XqUrFY16TxJt5YPUh97s9Fn2L5gdujOR0WKMAG6CraqBWgaaAqh7H6GmNxgLlz66u9\n Z8EcCrljTRg6LaPF3HnA4BdEThvcHkVVZ01NMWT6kQiMG+zrYCB6VlFNb12/huxWXZOW\n f1g3V3MQzAKUICmzo10wRxAsWIaqflsESM8QW6TmnFq+hslqX7zyIXDVgD5INM8mlQm1\n 9E3g==", "X-Gm-Message-State": "AOJu0Yx8xsFxOk7A+yS30V4RspTT/EN+PX80wOIsZmj8ORHS9ruRfp1+\n /nXWMZAHK2BWUEjWYh5ZCCQIRpn8Nklb334okVPVN6a5Fvq9uX074oUR0639UlKtiN1Zv0yccQu\n I", "X-Google-Smtp-Source": "\n AGHT+IHq8CgeiCg6hi+0g0jZytzIIk+RJhwy3l2Iac1ZSBNh4iNt14SHtzmQb4GkTXzqrrLcO8gxxA==", "X-Received": "by 2002:a05:6808:1526:b0:3c6:faf3:5ca4 with SMTP id\n u38-20020a056808152600b003c6faf35ca4mr1443002oiw.15.1713930352222;\n Tue, 23 Apr 2024 20:45:52 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com,\n Stephen Hemminger <stephen@networkplumber.org>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Jerin Jacob <jerin.jacob@caviumnetworks.com>", "Subject": "[PATCH] event: fix warning from useless snprintf", "Date": "Tue, 23 Apr 2024 20:45:40 -0700", "Message-ID": "<20240424034541.134335-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "With Gcc-14, this warning is generated:\n../drivers/event/sw/sw_evdev.c:263:3: warning: 'snprintf' will always be truncated;\n specified size is 12, but format string expands to at least 13 [-Wformat-truncation]\n 263 | snprintf(buf, sizeof(buf), \"sw%d_iq_%d_rob\", dev_id, i);\n | ^\n\nYet the whole printf to the buf is unnecessary. The type string argument\nhas never been implemented, and should just be NULL. Removing the\nunnecessary snprintf, then means IQ_ROB_NAMESIZE can be removed.\n\nFixes: 5ffb2f142d95 (\"event/sw: support event queues\")\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/event/sw/iq_chunk.h | 2 --\n drivers/event/sw/sw_evdev.c | 5 +----\n 2 files changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/drivers/event/sw/iq_chunk.h b/drivers/event/sw/iq_chunk.h\nindex 7a7a8782e6..e638142dbc 100644\n--- a/drivers/event/sw/iq_chunk.h\n+++ b/drivers/event/sw/iq_chunk.h\n@@ -9,8 +9,6 @@\n #include <stdbool.h>\n #include <rte_eventdev.h>\n \n-#define IQ_ROB_NAMESIZE 12\n-\n struct __rte_cache_aligned sw_queue_chunk {\n \tstruct rte_event events[SW_EVS_PER_Q_CHUNK];\n \tstruct sw_queue_chunk *next;\ndiff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c\nindex 1c01b069fe..19a52afc7d 100644\n--- a/drivers/event/sw/sw_evdev.c\n+++ b/drivers/event/sw/sw_evdev.c\n@@ -228,9 +228,7 @@ qid_init(struct sw_evdev *sw, unsigned int idx, int type,\n \t\tconst struct rte_event_queue_conf *queue_conf)\n {\n \tunsigned int i;\n-\tint dev_id = sw->data->dev_id;\n \tint socket_id = sw->data->socket_id;\n-\tchar buf[IQ_ROB_NAMESIZE];\n \tstruct sw_qid *qid = &sw->qids[idx];\n \n \t/* Initialize the FID structures to no pinning (-1), and zero packets */\n@@ -260,8 +258,7 @@ qid_init(struct sw_evdev *sw, unsigned int idx, int type,\n \t\t\tgoto cleanup;\n \t\t}\n \n-\t\tsnprintf(buf, sizeof(buf), \"sw%d_iq_%d_rob\", dev_id, i);\n-\t\tqid->reorder_buffer = rte_zmalloc_socket(buf,\n+\t\tqid->reorder_buffer = rte_zmalloc_socket(NULL,\n \t\t\t\twindow_size * sizeof(qid->reorder_buffer[0]),\n \t\t\t\t0, socket_id);\n \t\tif (!qid->reorder_buffer) {\n", "prefixes": [] }